tabby-rdp 0.4.0 → 0.5.0

package/CHANGELOG.md

@@ -1,5 +1,123 @@
 # Changelog
 
+## 0.5.0
+
+Shared folders, desktops behind an RD Gateway, Hyper-V VMs' consoles, more of what an .rdp file says, text sent as
+typed; more care with addresses that come from someone else; and fixes from a review of the code.
+
+**New**
+- **Shared folders** ([#26](https://github.com/meanaverage/tabby-rdp/issues/26)): folders from this computer appear as
+  drives on the remote desktop, under `\\tsclient` in Explorer, like mstsc's drive redirection. Settings › Remote
+  Desktop › Settings › Shared folders: **Share a folder…**, each one read-write or read-only. Every desktop you connect
+  to sees them; applies on the next connection. Windows mounts them (xrdp can, with FUSE); GNOME Remote Desktop
+  doesn't serve drives. Files move at the drive's pace through the RDP connection, so this is for working with files
+  in place rather than copying gigabytes; the clipboard still carries files either way. The remote gets the folder
+  and nothing else: `..` and symbolic links that lead out of it don't resolve, and only files and folders are served.
+  File operations run in the background (Node's thread pool), one request at a time, so a slow disk or network
+  folder slows the drive, not Tabby's window.
+- **Hyper-V VMs** ([#28](https://github.com/meanaverage/tabby-rdp/issues/28)): on a Windows SSH host that runs
+  Hyper-V, its VMs are listed among the host's desktops (`Get-VM`, with PowerShell over the SSH connection), and one
+  that is off is started when opened. What opens is the VM's console, through the host (port 2179), as Hyper-V
+  Manager's Connect does: no network or Remote Desktop needed in the VM. A Windows guest that is up gets an enhanced
+  session; otherwise it is the basic console. The sign-in is the host's, asked once per host; an account the host
+  signs in but doesn't let open the console (it ends the connection at once) brings the form back, saying so.
+- **RD Gateway** ([#29](https://github.com/meanaverage/tabby-rdp/issues/29)): a remote desktop profile, or a desktop
+  behind an SSH host, can name a Remote Desktop Gateway (**RD Gateway**: `rdgw.example.com`, or `host:port`). The
+  connection then goes to the gateway over HTTPS (its WebSocket transport, Windows Server 2012 R2 and later), signs in
+  there with a user name and password, and is connected on to the desktop, whose address is as the gateway sees it.
+  The desktop's sign-in is the gateway's too unless the profile picks a saved account for the gateway. A sign-in the
+  gateway refuses brings the form back saying it was the gateway, before anything goes to the desktop; a desktop its
+  policy doesn't allow, or that it can't reach, is an error saying which. The gateway's certificate is accepted when
+  valid for its name and otherwise remembered on first use; a changed one stops the connection until it is trusted.
+  The sign-in (NTLMv2) is bound to the gateway's TLS certificate, which gateways require by default. Smart cards,
+  sign-in pages and one-time codes at the gateway aren't supported.
+- **.rdp files** ([#27](https://github.com/meanaverage/tabby-rdp/issues/27)): an import applies the file's display
+  scale (`desktopscalefactor` 150 or more becomes the desktop's Retina sharpness) and its RD Gateway
+  (`gatewayhostname`, unless the file turns it off), and says which of its other settings the plugin doesn't apply
+  (sound left on the remote or off, a fixed window size, its own drives (shared folders are a setting here), printer,
+  smart card or USB redirection, several monitors, RemoteApp, an account of its own or a smart card at the gateway),
+  instead of ignoring them silently.
+- **Send text as typed** ([#31](https://github.com/meanaverage/tabby-rdp/issues/31)), a setting: the characters the
+  keyboard produces go to the desktop rather than key positions, so dead keys and a layout the remote doesn't have
+  come out right; keys with Ctrl, Alt or ⌘ still go by position, so shortcuts keep working. Off by default. Windows
+  types any character; a GNOME desktop only those its own layout has. Input methods (Chinese, Japanese, Korean) need
+  more than this and stay open in #31.
+- IronRDP's web client gains drive redirection (MS-RDPEFS) through a JavaScript file system (patch 15), and its
+  static channels send multi-chunk messages Windows accepts (patch 16): a response over 1600 bytes was flagged for the
+  receiver to keep the channel header, which Windows' drive redirector didn't expect and dropped the channel on.
+
+**Safer with addresses that come from someone else**
+- **Importing an .rdp file asks first**, naming the address, the gateway and the account the file leads to, with
+  **Add and connect**, **Add only** and **Cancel**. It used to add the profile and connect at once. Nothing in a file
+  runs on this computer (and a program it names for the remote isn't asked for), but a file decides where your
+  sign-in goes.
+- **A Windows desktop whose server doesn't use Network Level Authentication stops before the password is sent.**
+  Without it the password goes to the server as it is (encrypted on the way, readable to whatever answered), which a
+  server posing as a Windows machine can ask for; the first certificate being trusted on sight, nothing stood in the
+  way. The connection now stops when the server's answer says so, before TLS, and asks: **Send the password anyway**
+  (remembered for that desktop, shown and forgotten with its certificate under Settings › Remote Desktop ›
+  Certificates) or **Cancel**. xrdp signs in this way by design: desktops of the xrdp kind aren't asked about.
+
+**Fixed**
+- **Save to Downloads** couldn't be led elsewhere by the remote's file names alone, but could by a link already in
+  Downloads with a name the remote chose (a folder name, say). Folders are now made one at a time and must stay inside
+  the folder once links are followed, and each file is created new: an existing name, link or not, gets a number.
+- **Large files copied from the remote** were held in memory, twice over while being saved. They now arrive in a
+  private temporary file and are moved into place.
+- **The plugin's local proxy** (loopback, one per desktop) kept whatever a local program sent before showing the
+  session's token, with no limit or deadline, and an error on such a connection wasn't handled. The first message is
+  now capped at a request's size and has ten seconds to arrive, at most four clients connect at once, and messages
+  are capped at 32 MB. Reaching the server has a deadline too.
+- **A connection given up while the server was being reached** (the tab closed, Cancel) left that connection open
+  until it finished; closing a desktop could leave an idle proxy connection behind. Both end at once now.
+- **Data waiting for a slow side** was buffered without limit. The proxy now pauses the side it reads from while the
+  other has more than 8 MB waiting, and a desktop reached through SSH whose data isn't being read at all is closed at
+  64 MB rather than growing.
+- **Dropping files on a desktop after a reconnect** (a wrong password first, a certificate question) offered them
+  once per connection attempt, through handlers the earlier attempts left behind.
+- **Shortcut modifiers could stay held on the remote:** turning on view only, or turning off typing into all
+  desktops, by a shortcut sent the modifiers' key-down to the remote but not their release. Keys held at that moment
+  are released first.
+- **H.264: small changes far apart** (a clock in one corner, a cursor in another) read back everything between them:
+  33 MB for a 4K picture to get a few pixels. Regions far apart are read one by one (IronRDP patch 17).
+- **A desktop whose server went away could stay on screen, frozen.** Through an SSH host, a server that closes the
+  connection (a machine shut down, a VM stopped) is reported as the end of what it sends, and not always as closed;
+  the plugin waited for "closed", so the desktop sometimes stayed up, still marked connected, with no reconnect. The
+  end of the server's side now ends the desktop, and reconnecting takes over as for any drop.
+- **Linux without an unlocked keyring: Tabby could stop opening connections.** A keychain call there never returns
+  and keeps one of Node's four worker threads waiting. The plugin gave the keychain up after the first such call, but
+  calls started together (the settings page asking whether each saved account has a password, a desktop signing in
+  meanwhile) each kept a thread first, and with all four taken, Tabby's file access and name lookups waited forever:
+  a new SSH tab stayed at "Connecting". Keychain calls now go one at a time, so at most one thread is ever kept.
+
+## 0.4.1
+
+Fixes from a review of 0.4.0.
+
+**Fixed**
+- **Two desktops saving a password at the same moment** could lose one of them: Tabby's Vault rewrites its whole
+  contents per change. The plugin's Vault changes now go one after another.
+- **A saved account took the desktop's old domain:** an account with a plain user name and no domain was signed in with
+  the domain the desktop had been given before, a field the form hides once an account is chosen. The account's domain
+  (also none) is what is used.
+- **A profile group's account didn't reach profiles reached through an SSH profile** in that host's tab menu; it does
+  now, as it did when opening the profile itself.
+- **"Ask for the account" on a new profile from the settings page** could be overridden by the "Remote desktops"
+  group's default, since the group was assigned after the editor closed. The profile is in the group before the editor
+  opens.
+- **Removing an account** also clears a profile group default that named it, and says so when the password itself
+  couldn't be removed. A desktop whose account is gone asks for one, rather than signing in with a login of its own
+  saved earlier. A sign-in prompt left open while its account was removed or renamed no longer saves under it.
+- **Editing an account's user name** keeps the old name when the old password couldn't be removed, so the two never
+  disagree; a password kept for an account's earlier user name isn't used for the new one. A new account whose password
+  couldn't be saved isn't added.
+- **Hotkey collisions** are found among all of Tabby's bindings, per-profile and per-group hotkeys included, and named
+  by the profile or group; the note says only one of the two would act.
+- The settings page checks the accounts' passwords one after another, and not at all once the keychain has stopped
+  answering, so a Linux keyring that doesn't answer can't hold every keychain worker.
+- Cancelling or finishing **New account…** brings the user name fields back; the Vault lists a saved account's
+  password by the account's name, as intended.
+
 ## 0.4.0
 
 **New**

package/README.md

@@ -1,6 +1,6 @@
 <div align="center">
 
-<img src="docs/images/logo.svg" width="96" height="96" alt="">
+<img src="docs/images/logo.png" width="150" height="150" alt="tabby-rdp: a Tabby window with a GNOME desktop, a Windows desktop and two terminals side by side">
 
 # tabby-rdp
 
@@ -54,6 +54,7 @@ Making it work with GNOME took fixes in IronRDP, which we contribute upstream ([
 - [Windows and other desktops behind a host](#windows-and-other-desktops-behind-a-host)
 - [Remote desktop profiles](#remote-desktop-profiles)
 - [Saved accounts](#saved-accounts)
+- [Shared folders](#shared-folders)
 - [Several desktops in one tab](#several-desktops-in-one-tab)
 - [VMs on a host](#vms-on-a-host)
 - [desk: the console on the desktop](#desk-the-console-on-the-desktop)
@@ -62,6 +63,7 @@ Making it work with GNOME took fixes in IronRDP, which we contribute upstream ([
 - [Built on IronRDP](#built-on-ironrdp)
 - [Development](#development)
 - [Limitations](#limitations)
+- [Questions and problems](#questions-and-problems)
 - [License](#license)
 
 ## Install
@@ -109,7 +111,9 @@ connecting again.
 |---|---|
 | **Clipboard** | Copy and paste text and images in both directions. |
 | **Files** | Copy files or folders in Finder and press ⌘V on the desktop, or drop them onto it, or use **Remote Desktop › Send files…** in the pane's menu; they paste in Files or Explorer. Files copied on the remote offer **Save to Downloads**. |
+| **Shared folders** | Folders from this computer as drives on the remote desktop (`\\tsclient\<name>` in Explorer), read-write or read-only, for working with files in place: [below](#shared-folders). Windows (and xrdp with FUSE). |
 | **Several desktops in one tab** | Paste to all of them, type into all of them, and see which is which: [below](#several-desktops-in-one-tab). |
+| **RD Gateway** | Desktops behind a Remote Desktop Gateway: the profile names the gateway, and the connection goes through it over HTTPS: [below](#through-an-rd-gateway). |
 | **VMs on a host** | The host's VMs with a desktop, ready to open: [below](#vms-on-a-host). |
 | **Sound** | The remote desktop's sound plays locally. |
 | **Microphone** | Optional (off by default): an app on the remote desktop that records, such as a call, gets your microphone. It is only captured while the app records, with an indicator in the corner of the desktop. |
@@ -124,6 +128,7 @@ connecting again.
 | **Sign-in** | GNOME desktops need none: the plugin manages their credentials. Windows and xrdp desktops ask for the account once and can remember it, in Tabby's Vault when that is on and in the system keychain otherwise; **Sign in again…** in the menu replaces it. Desktops that share an account can use a [saved account](#saved-accounts), whose password is kept once. |
 | **Shortcuts** | Switching between the desktop and the console, view only, a screenshot, Ctrl+Alt+Del, typing into or pasting to all desktops of a tab, the connection status and Disconnect each have a hotkey, set on the settings page or in Tabby's Hotkeys. They work while the desktop has the keyboard; a key another hotkey has is refused. |
 | **Certificates** | GNOME desktops accept only the certificate the plugin made for them. Windows and xrdp desktops remember theirs on first use and ask before accepting a different one. |
+| **Passwords stay with servers that know them** | Windows signs in with Network Level Authentication: a proof both ways, where the password only reaches a server that knows it already. A Windows desktop whose server doesn't use it would get the password as it is, so the connection stops and asks first, before anything is sent. xrdp signs in that way by design, so desktops of the xrdp kind aren't asked about. |
 
 <p align="center"><img src="docs/images/files.png" width="760" alt="A file copied on the remote desktop, offered for saving"></p>
 
@@ -193,8 +198,13 @@ also type `user@host:port` and pick **Quick connect (REMOTE DESKTOP (RDP))**.
 
 **Import an .rdp file…** (in the menu's **Settings**, or **Remote desktop: import an .rdp file…** in Tabby's
 command palette) makes such a profile from a file saved by Remote Desktop Connection or handed out by an admin: its
-address, port, user name and domain, named after the file. Other settings in the file (screen size, drives, gateway)
-are ignored.
+address, port, user name and domain, named after the file, and its [RD Gateway](#through-an-rd-gateway) when it
+connects through one; a `desktopscalefactor` of 150 or more sets that desktop's sharpness to Retina. Settings the
+plugin doesn't apply (sound left on the remote, a fixed window size, drive or printer redirection, several monitors)
+are named in a note on import, so the desktop's behaviour isn't a surprise. Nothing in a file runs here, and a
+program it names to start on the remote isn't asked for. What a file does decide is where you connect, so importing
+asks first, naming the address, the gateway and the account it leads to: what you sign in with goes there, and once
+signed in that desktop gets the clipboard and the folders you share. **Add only** adds the profile without connecting.
 
 Its **Connect** setting can name an SSH profile instead of connecting directly. The address is then as that host sees
 it, and opening the profile opens that SSH tab and shows the desktop over it once SSH is connected. Such a desktop is
@@ -213,12 +223,40 @@ profiles:
       kind: windows             # or xrdp, or gnome
       username: alice           # optional
       via: ''                   # or the id of an SSH profile to go through
+      gateway: ''               # or an RD Gateway to go through: rdgw.example.com, or host:port
+      gatewayAccount: ''        # or a saved account's id, for a gateway that takes another account
 ```
 
 A direct connection is a plain TCP connection from this computer, encrypted with TLS like any RDP client's. The
 server's certificate is remembered on the first connection and checked on every later one, as for desktops behind a
 host (above).
 
+### Through an RD Gateway
+
+Where desktops sit behind a Remote Desktop Gateway (the HTTPS front door many companies put before their Windows
+machines), give the profile the gateway's address in **RD Gateway**: `rdgw.example.com`, or `host:port` when it
+isn't on 443. The profile's address is then the desktop as the gateway sees it (`pc17.corp.example`). The connection
+goes to the gateway over HTTPS, signs in there, and the gateway connects it on; the desktop then asks for its own
+sign-in as usual, inside that tunnel.
+
+- **One sign-in by default.** The account you enter for the desktop also signs in to the gateway, as with Remote
+  Desktop Connection's "use my RD Gateway credentials for the remote computer". A gateway that takes another account:
+  pick a [saved account](#saved-accounts) under **Gateway account**; its password is asked for once and kept with the
+  account.
+- **A refused sign-in says who refused it.** When it was the gateway (a wrong password, or its policy doesn't let the
+  account in), the form comes back saying so, and nothing has gone to the desktop. A desktop the gateway's policy
+  doesn't let the account reach, or that the gateway can't reach, is an error with that reason.
+- **The gateway's certificate** is accepted when it is valid for the gateway's name (issued by an authority this
+  computer trusts), and otherwise remembered on first use like a desktop's; either way a later change to one that
+  isn't valid stops the connection, before the sign-in goes out, until you trust the new one. Remembered ones are
+  listed under Settings › Remote Desktop › Certificates.
+- **Behind an SSH host too.** A desktop added behind an SSH host takes a gateway the same way (the **RD Gateway**
+  field of its form): the gateway is then reached from that host.
+
+It speaks the gateway's WebSocket transport (Windows Server 2012 R2 and later) and signs in with a user name and
+password (NTLM, bound to the gateway's TLS certificate as gateways require by default). Smart cards, sign-in pages
+and one-time codes at the gateway are not supported.
+
 ## Saved accounts
 
 Several desktops often share one account: a domain admin, a lab user. A saved account keeps that user name (and
@@ -238,6 +276,27 @@ The accounts' names and user names are in Tabby's config (`remoteDesktop.account
 Vault when it is enabled (encrypted, and carried by Tabby's config sync), else in the system keychain. Removing an
 account removes its password and sets its desktops back to asking.
 
+## Shared folders
+
+A folder on this computer can appear as a drive on the remote desktop, as mstsc's drive redirection does: in
+**Settings › Remote Desktop › Settings › Shared folders**, **Share a folder…** picks one. On the remote it is
+`\\tsclient\<name>` ("<name> on <this computer>" under This PC in Explorer), named after the folder; **Read-only**
+keeps the remote from changing, adding or removing anything in it. Every remote desktop you connect to sees the shared
+folders, so share only what each of them may have, and remove a folder to stop sharing it. Changes apply on the next
+connection.
+
+<p align="center"><img src="docs/images/shared-folders.png" width="548" alt="Shared folders in Settings › Remote Desktop: two folders, one read-only, and Share a folder…"></p>
+
+Files are served through the RDP connection as the remote reads and writes them, which suits opening and saving
+documents in place; for moving large files, copying through the clipboard is just as quick. They are read and written
+in the background, so a slow disk or network folder slows the drive down, not Tabby.
+
+The remote gets the shared folder and nothing else: a symbolic link works when it points inside the folder, and one
+that leads out of it isn't shown, read or written through. Only files and folders are served (no devices or pipes).
+
+Windows mounts shared folders (tested); xrdp can when built with FUSE (under `~/thinclient_drives`); GNOME Remote
+Desktop doesn't serve drives, so there the clipboard is the way.
+
 ## Several desktops in one tab
 
 Split a tab (Tabby's **Split** in the tab's menu, or drag one tab onto another) and each pane can show a desktop: one
@@ -258,7 +317,7 @@ preview. Desktops are named after their SSH profile's name.
 ## VMs on a host
 
 When you right-click an SSH host, the plugin looks at the host's libvirt VMs (`virsh`, as your SSH user; read-only, at
-most once a minute) and lists the ones with a desktop under **Desktops**, with nothing to set up:
+most once a minute; on a Windows host, [Hyper-V's](#hyper-v)) and lists the ones with a desktop under **Desktops**, with nothing to set up:
 
 - a running VM whose RDP port answers: Windows, or Linux with xrdp;
 - a Windows VM that's shut off: **Start and open**, which starts it (`virsh start`) and connects as soon as it answers.
@@ -275,6 +334,23 @@ host, it asks the VM to shut down (`virsh shutdown`, with a key press first, sin
 screen sleeps), then ends. VMs that were already running are never touched, and neither are machines woken over the
 network.
 
+### Hyper-V
+
+A Windows SSH host that runs Hyper-V gets the same: its VMs (`Get-VM`, with PowerShell over the SSH connection) are
+listed under **Desktops**, and one that is off is started when opened (`Start-VM`). What opens is the VM's console, as
+Hyper-V Manager's **Connect** shows it: reached through the host (its port 2179), so the VM needs no network, no
+Remote Desktop turned on, not even an operating system. A Windows guest that is up is asked for an enhanced session
+(its own sign-in screen, the clipboard, sound, shared folders, resizing); before that, and for other guests, it is the
+basic console: the picture, keyboard and mouse. The basic console is what has been tested so far; enhanced sessions
+take the same path but haven't been tried against a running Windows guest yet.
+
+The sign-in is the **host's**, not the guest's: an account that may open the VM's console there, which the plugin
+asks for once per host (the SSH user is filled in). That is an administrator, a member of the host's Hyper-V
+Administrators group, or an account given access with `Grant-VMConnectAccess`. A local administrator other than the
+built-in one can list VMs over SSH and still be refused the console, since Windows gives it a reduced token over the
+network; Hyper-V refuses by ending the connection at once, and the plugin then asks again, saying so. Listing VMs
+takes an account Hyper-V lets do that (an administrator of the host, in practice).
+
 ## desk: the console on the desktop
 
 Type `desk` in an SSH console, and the tab switches to that machine's desktop with a terminal attached to the very same
@@ -304,10 +380,12 @@ They are stored in Tabby's config under `remoteDesktop`:
 | Sound (`sound`) | On | Applies on the next connection. |
 | Video decoding (`h264`) | On | H.264 decoded by Tabby's browser engine (hardware-accelerated where available), for what the remote sends as video; applies on the next connection. |
 | Microphone (`microphone`) | Off | Send your microphone while an app on the remote desktop records. Applies on the next connection. |
+| Shared folders (`sharedFolders`) | None | `[{ path, name, readOnly }]`: folders shared as drives with every remote desktop ([Shared folders](#shared-folders)). Applies on the next connection. |
 | Show connection status (`connectionStatus`) | Off | The indicator in the desktop's corner; fades when the pointer comes near. |
 | Mac shortcuts (`macShortcuts`) | On | macOS. Off: ⌘ is the Windows key. |
+| Send text as typed (`unicodeKeys`) | Off | Sends the characters the keyboard produces rather than key positions, so dead keys and a layout the remote doesn't have come out right; keys with Ctrl, Alt or ⌘ still go by position. Windows types any character; GNOME only those its own layout has (mutter has no keycode for the others). Input methods (CJK) are not supported yet. |
 | Shortcuts (`hotkeys.remote-desktop-*`) | ⌘⇧G / Ctrl+Shift+G for the switch; the rest unbound | Tabby's hotkeys: the switch between desktop and console, view only, screenshot, Ctrl+Alt+Del, type into all, paste to all, connection status, disconnect. Changed on the settings page (Getting started › Shortcuts) or in Settings › Hotkeys. |
-| Saved accounts (`accounts`) | None | `[{ id, name, username, domain }]`; see [Saved accounts](#saved-accounts). The passwords are not in the config. |
+| Saved accounts (`accounts`) | None | `[{ id, name, username, domain }]`; see [Saved accounts](#saved-accounts). The passwords are in the Vault (encrypted, part of the config) or the keychain, never in plaintext in the config. |
 | Bring the console along with `desk` (`desk`) | Off | Installs `desk` and a login line on each machine you open a desktop on; applies on the next connection there. |
 | Session backend (`sessionBackend`) | `native` | For `desk`: `native` (trd-pty) or `tmux`. Config file only. |
 | Find virtual machines on SSH hosts (`discoverVMs`) | On | Lists a host's libvirt VMs with a desktop in its menu ([VMs on a host](#vms-on-a-host)). |
@@ -357,6 +435,8 @@ tabby-rdp ships IronRDP with a short series of patches ([ironrdp/](ironrdp)). Th
 | Microphone in the web client | Not submitted yet: waits for #2020 |
 | Keep clipboard sync working for the other desktops when one closes | Not submitted yet |
 | Sync the clipboard only for the desktop that has the focus | Not submitted yet |
+| Drive redirection in the web client, through a JavaScript file system | Not submitted yet |
+| Send chunked static-channel messages without CHANNEL_FLAG_SHOW_PROTOCOL, as Windows' drive redirector expects | Not submitted yet |
 
 The aim is to make IronRDP's browser client work well with both Linux and Windows desktops, for everyone who embeds
 it, not just this plugin.
@@ -407,9 +487,18 @@ npm run build:ironrdp        # rebuild vendor/ from IronRDP and ironrdp/patches:
   far as that xrdp version supports them), sound through the PipeWire or PulseAudio module. Live resize needs xrdp
   0.10 or newer; with 0.9 (Ubuntu 24.04), the desktop keeps its size, scaled to fit, or choose **Reconnect at the new
   size**. xrdp's standard RDP security without TLS (`security_layer=rdp`) isn't supported. `desk` needs GNOME.
+- **RD Gateways** are signed in to with a user name and password; ones that ask for a smart card, a sign-in page or
+  a one-time code, or that only take Kerberos, can't be used. Gateways before Windows Server 2012 R2 (no WebSocket
+  transport) can't either. A desktop behind a gateway isn't started when it is off.
 - **Waking a desktop** over the network (Wake-on-LAN) starts it but never shuts it down again; for VMs, see
   [Shut down VMs it started](#vms-on-a-host).
 
+## Questions and problems
+
+Questions ("how do I…", "is this expected?") go to [Discussions › Q&A](https://github.com/meanaverage/tabby-rdp/discussions/categories/q-a);
+bugs and feature requests to the [issues](https://github.com/meanaverage/tabby-rdp/issues). A bug report is most useful
+with the connection log: **Settings › Remote Desktop › Troubleshooting › Open desktops › Copy log**.
+
 ## License
 
 [MIT](LICENSE). The bundled IronRDP build is MIT or Apache-2.0 ([vendor/IRONRDP-LICENSE](vendor/IRONRDP-LICENSE)).

package/dist/accountForm.js

@@ -59,6 +59,8 @@ function newAccountOption(select, label, save, onChange) {
         field('cancel').addEventListener('click', () => {
             close();
             select.value = last;
+            // As a choice made by hand: the form around it follows (its user name fields show again).
+            select.dispatchEvent(new Event('change'));
         });
         form.addEventListener('submit', async (event) => {
             event.preventDefault();
@@ -73,10 +75,9 @@ function newAccountOption(select, label, save, onChange) {
                 const account = await save({ name: field('name').value.trim(), username, domain: field('domain').value.trim(), password: field('password').value });
                 const option = new Option(label(account), account.id);
                 select.insertBefore(option, select.querySelector(`option[value="${exports.NEW_ACCOUNT}"]`));
-                select.value = account.id;
-                last = account.id;
                 close();
-                onChange(account.id);
+                select.value = account.id;
+                select.dispatchEvent(new Event('change'));
             }
             catch (e) {
                 error.textContent = `Couldn't save it: ${e?.message ?? e}`;

package/dist/accountForm.js.map

@@ -1 +1 @@
-{"version":3,"file":"accountForm.js","sourceRoot":"","sources":["../src/accountForm.ts"],"names":[],"mappings":";;;AAyBA,4CA0EC;AAhGY,QAAA,WAAW,GAAG,SAAS,CAAA;AAEvB,QAAA,KAAK,GAAG;;;;;;CAMpB,CAAA;AASD;;;;GAIG;AACH,SAAgB,gBAAgB,CAC5B,MAAyB,EACzB,KAAkC,EAClC,IAAuD,EACvD,QAA8B;IAE9B,MAAM,CAAC,MAAM,CAAC,IAAI,MAAM,CAAC,cAAc,EAAE,mBAAW,CAAC,CAAC,CAAA;IACtD,IAAI,IAAI,GAAG,MAAM,CAAC,KAAK,CAAA;IACvB,IAAI,IAAI,GAA2B,IAAI,CAAA;IACvC,MAAM,KAAK,GAAG,GAAG,EAAE;QACf,IAAI,EAAE,MAAM,EAAE,CAAA;QACd,IAAI,GAAG,IAAI,CAAA;IACf,CAAC,CAAA;IACD,MAAM,CAAC,gBAAgB,CAAC,QAAQ,EAAE,GAAG,EAAE;QACnC,IAAI,MAAM,CAAC,KAAK,KAAK,mBAAW,EAAE,CAAC;YAC/B,KAAK,EAAE,CAAA;YACP,IAAI,GAAG,MAAM,CAAC,KAAK,CAAA;YACnB,QAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;YACtB,OAAM;QACV,CAAC;QACD,IAAI,IAAI,EAAE,CAAC;YACP,OAAM;QACV,CAAC;QACD,IAAI,GAAG,QAAQ,CAAC,aAAa,CAAC,MAAM,CAAC,CAAA;QACrC,IAAI,CAAC,SAAS,GAAG,iBAAiB,CAAA;QAClC,IAAI,CAAC,YAAY,GAAG,KAAK,CAAA;QACzB,IAAI,CAAC,SAAS,GAAG;;;;;;;;;mBASN,CAAA;QACX,MAAM,KAAK,GAAG,CAAC,IAAY,EAAE,EAAE,CAAC,IAAK,CAAC,aAAa,CAAC,UAAU,IAAI,IAAI,CAAqB,CAAA;QAC3F,MAAM,KAAK,GAAG,IAAI,CAAC,aAAa,CAAC,wBAAwB,CAAE,CAAA;QAC3D,8EAA8E;QAC9E,IAAI,CAAC,gBAAgB,CAAC,SAAS,EAAE,KAAK,CAAC,EAAE;YACrC,KAAK,CAAC,eAAe,EAAE,CAAA;YACvB,IAAI,KAAK,CAAC,GAAG,KAAK,QAAQ,EAAE,CAAC;gBACzB,KAAK,CAAC,cAAc,EAAE,CAAA;gBACtB,KAAK,CAAC,QAAQ,CAAC,CAAC,KAAK,EAAE,CAAA;YAC3B,CAAC;QACL,CAAC,CAAC,CAAA;QACF,KAAK,CAAC,QAAQ,CAAC,CAAC,gBAAgB,CAAC,OAAO,EAAE,GAAG,EAAE;YAC3C,KAAK,EAAE,CAAA;YACP,MAAM,CAAC,KAAK,GAAG,IAAI,CAAA;QACvB,CAAC,CAAC,CAAA;QACF,IAAI,CAAC,gBAAgB,CAAC,QAAQ,EAAE,KAAK,EAAC,KAAK,EAAC,EAAE;YAC1C,KAAK,CAAC,cAAc,EAAE,CAAA;YACtB,KAAK,CAAC,eAAe,EAAE,CAAA;YACvB,MAAM,QAAQ,GAAG,KAAK,CAAC,UAAU,CAAC,CAAC,KAAK,CAAC,IAAI,EAAE,CAAA;YAC/C,IAAI,CAAC,QAAQ,EAAE,CAAC;gBACZ,KAAK,CAAC,WAAW,GAAG,sBAAsB,CAAA;gBAC1C,KAAK,CAAC,UAAU,CAAC,CAAC,KAAK,EAAE,CAAA;gBACzB,OAAM;YACV,CAAC;YACD,IAAI,CAAC;gBACD,MAAM,OAAO,GAAG,MAAM,IAAI,CAAC,EAAE,IAAI,EAAE,KAAK,CAAC,MAAM,CAAC,CAAC,KAAK,CAAC,IAAI,EAAE,EAAE,QAAQ,EAAE,MAAM,EAAE,KAAK,CAAC,QAAQ,CAAC,CAAC,KAAK,CAAC,IAAI,EAAE,EAAE,QAAQ,EAAE,KAAK,CAAC,UAAU,CAAC,CAAC,KAAK,EAAE,CAAC,CAAA;gBACnJ,MAAM,MAAM,GAAG,IAAI,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,EAAE,OAAO,CAAC,EAAE,CAAC,CAAA;gBACrD,MAAM,CAAC,YAAY,CAAC,MAAM,EAAE,MAAM,CAAC,aAAa,CAAC,iBAAiB,mBAAW,IAAI,CAAC,CAAC,CAAA;gBACnF,MAAM,CAAC,KAAK,GAAG,OAAO,CAAC,EAAE,CAAA;gBACzB,IAAI,GAAG,OAAO,CAAC,EAAE,CAAA;gBACjB,KAAK,EAAE,CAAA;gBACP,QAAQ,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;YACxB,CAAC;YAAC,OAAO,CAAM,EAAE,CAAC;gBACd,KAAK,CAAC,WAAW,GAAG,qBAAqB,CAAC,EAAE,OAAO,IAAI,CAAC,EAAE,CAAA;YAC9D,CAAC;QACL,CAAC,CAAC,CAAA;QACF,MAAM,CAAC,qBAAqB,CAAC,UAAU,EAAE,IAAI,CAAC,CAAA;QAC9C,KAAK,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,CAAA;IACzB,CAAC,CAAC,CAAA;AACN,CAAC"}
+{"version":3,"file":"accountForm.js","sourceRoot":"","sources":["../src/accountForm.ts"],"names":[],"mappings":";;;AAyBA,4CA2EC;AAjGY,QAAA,WAAW,GAAG,SAAS,CAAA;AAEvB,QAAA,KAAK,GAAG;;;;;;CAMpB,CAAA;AASD;;;;GAIG;AACH,SAAgB,gBAAgB,CAC5B,MAAyB,EACzB,KAAkC,EAClC,IAAuD,EACvD,QAA8B;IAE9B,MAAM,CAAC,MAAM,CAAC,IAAI,MAAM,CAAC,cAAc,EAAE,mBAAW,CAAC,CAAC,CAAA;IACtD,IAAI,IAAI,GAAG,MAAM,CAAC,KAAK,CAAA;IACvB,IAAI,IAAI,GAA2B,IAAI,CAAA;IACvC,MAAM,KAAK,GAAG,GAAG,EAAE;QACf,IAAI,EAAE,MAAM,EAAE,CAAA;QACd,IAAI,GAAG,IAAI,CAAA;IACf,CAAC,CAAA;IACD,MAAM,CAAC,gBAAgB,CAAC,QAAQ,EAAE,GAAG,EAAE;QACnC,IAAI,MAAM,CAAC,KAAK,KAAK,mBAAW,EAAE,CAAC;YAC/B,KAAK,EAAE,CAAA;YACP,IAAI,GAAG,MAAM,CAAC,KAAK,CAAA;YACnB,QAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;YACtB,OAAM;QACV,CAAC;QACD,IAAI,IAAI,EAAE,CAAC;YACP,OAAM;QACV,CAAC;QACD,IAAI,GAAG,QAAQ,CAAC,aAAa,CAAC,MAAM,CAAC,CAAA;QACrC,IAAI,CAAC,SAAS,GAAG,iBAAiB,CAAA;QAClC,IAAI,CAAC,YAAY,GAAG,KAAK,CAAA;QACzB,IAAI,CAAC,SAAS,GAAG;;;;;;;;;mBASN,CAAA;QACX,MAAM,KAAK,GAAG,CAAC,IAAY,EAAE,EAAE,CAAC,IAAK,CAAC,aAAa,CAAC,UAAU,IAAI,IAAI,CAAqB,CAAA;QAC3F,MAAM,KAAK,GAAG,IAAI,CAAC,aAAa,CAAC,wBAAwB,CAAE,CAAA;QAC3D,8EAA8E;QAC9E,IAAI,CAAC,gBAAgB,CAAC,SAAS,EAAE,KAAK,CAAC,EAAE;YACrC,KAAK,CAAC,eAAe,EAAE,CAAA;YACvB,IAAI,KAAK,CAAC,GAAG,KAAK,QAAQ,EAAE,CAAC;gBACzB,KAAK,CAAC,cAAc,EAAE,CAAA;gBACtB,KAAK,CAAC,QAAQ,CAAC,CAAC,KAAK,EAAE,CAAA;YAC3B,CAAC;QACL,CAAC,CAAC,CAAA;QACF,KAAK,CAAC,QAAQ,CAAC,CAAC,gBAAgB,CAAC,OAAO,EAAE,GAAG,EAAE;YAC3C,KAAK,EAAE,CAAA;YACP,MAAM,CAAC,KAAK,GAAG,IAAI,CAAA;YACnB,0FAA0F;YAC1F,MAAM,CAAC,aAAa,CAAC,IAAI,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAA;QAC7C,CAAC,CAAC,CAAA;QACF,IAAI,CAAC,gBAAgB,CAAC,QAAQ,EAAE,KAAK,EAAC,KAAK,EAAC,EAAE;YAC1C,KAAK,CAAC,cAAc,EAAE,CAAA;YACtB,KAAK,CAAC,eAAe,EAAE,CAAA;YACvB,MAAM,QAAQ,GAAG,KAAK,CAAC,UAAU,CAAC,CAAC,KAAK,CAAC,IAAI,EAAE,CAAA;YAC/C,IAAI,CAAC,QAAQ,EAAE,CAAC;gBACZ,KAAK,CAAC,WAAW,GAAG,sBAAsB,CAAA;gBAC1C,KAAK,CAAC,UAAU,CAAC,CAAC,KAAK,EAAE,CAAA;gBACzB,OAAM;YACV,CAAC;YACD,IAAI,CAAC;gBACD,MAAM,OAAO,GAAG,MAAM,IAAI,CAAC,EAAE,IAAI,EAAE,KAAK,CAAC,MAAM,CAAC,CAAC,KAAK,CAAC,IAAI,EAAE,EAAE,QAAQ,EAAE,MAAM,EAAE,KAAK,CAAC,QAAQ,CAAC,CAAC,KAAK,CAAC,IAAI,EAAE,EAAE,QAAQ,EAAE,KAAK,CAAC,UAAU,CAAC,CAAC,KAAK,EAAE,CAAC,CAAA;gBACnJ,MAAM,MAAM,GAAG,IAAI,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,EAAE,OAAO,CAAC,EAAE,CAAC,CAAA;gBACrD,MAAM,CAAC,YAAY,CAAC,MAAM,EAAE,MAAM,CAAC,aAAa,CAAC,iBAAiB,mBAAW,IAAI,CAAC,CAAC,CAAA;gBACnF,KAAK,EAAE,CAAA;gBACP,MAAM,CAAC,KAAK,GAAG,OAAO,CAAC,EAAE,CAAA;gBACzB,MAAM,CAAC,aAAa,CAAC,IAAI,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAA;YAC7C,CAAC;YAAC,OAAO,CAAM,EAAE,CAAC;gBACd,KAAK,CAAC,WAAW,GAAG,qBAAqB,CAAC,EAAE,OAAO,IAAI,CAAC,EAAE,CAAA;YAC9D,CAAC;QACL,CAAC,CAAC,CAAA;QACF,MAAM,CAAC,qBAAqB,CAAC,UAAU,EAAE,IAAI,CAAC,CAAA;QAC9C,KAAK,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,CAAA;IACzB,CAAC,CAAC,CAAA;AACN,CAAC"}