tabby-mcp-server 1.1.2 → 1.1.3

package/README.md

@@ -184,7 +184,7 @@ For clients that don't support SSE, use the STDIO bridge:
 ```json
 {
   "mcpServers": {
-    "tabby-mcp": {
+    "tabby-mcp-server": {
       "command": "node",
       "args": ["/path/to/Tabby-MCP/scripts/stdio-bridge.js"]
     }
@@ -198,7 +198,7 @@ For clients that don't support SSE, use the STDIO bridge:
 {
   "mcp": {
     "servers": {
-      "tabby-mcp": {
+      "tabby-mcp-server": {
         "type": "stdio",
         "command": "node",
         "args": ["scripts/stdio-bridge.js"],
@@ -354,6 +354,20 @@ This project builds upon the work of [tabby-mcp-server](https://github.com/thuan
 
 ## 📝 Changelog
 
+### v1.1.3 (2026-01-22)
+
+**Bug Fixes:**
+- 🔧 Fixed `open_profile` sessionId inconsistency - now returns same sessionId as `get_session_list`
+- Fixed SSH connection state detection - `ready` now correctly reflects overall connection status
+
+**Improvements:**
+- Clearer state fields in `open_profile` response:
+  - `tabReady`: Tab/frontend initialized
+  - `sshConnected`: SSH connection established (SSH profiles only)
+  - `ready`: Overall ready state (for SSH: tabReady AND sshConnected)
+- Marked all peerDependencies as optional to prevent unnecessary package downloads
+- Added `tabby-ssh` to devDependencies for developer build stability
+
 ### v1.1.2 (2026-01-22)
 
 **Optimization:**

package/dist/index.js

@@ -17454,7 +17454,7 @@ const tabby_core_1 = __webpack_require__(1368);
 const mcpService_1 = __webpack_require__(7554);
 const mcpLogger_service_1 = __webpack_require__(9924);
 // Version from package.json - update on each release
-const PLUGIN_VERSION = '1.1.2';
+const PLUGIN_VERSION = '1.1.3';
 /**
  * MCP Settings Tab Component
  */
@@ -24837,6 +24837,7 @@ let TerminalToolCategory = class TerminalToolCategory extends base_tool_category
     }
     /**
      * Get or create a stable session ID for a tab
+     * Made public for cross-category access (e.g., from TabManagementToolCategory)
      */
     getOrCreateSessionId(tab) {
         let sessionId = this.tabToSessionId.get(tab);
@@ -28589,6 +28590,9 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
 var __metadata = (this && this.__metadata) || function (k, v) {
     if (typeof Reflect === "object" && typeof Reflect.metadata === "function") return Reflect.metadata(k, v);
 };
+var __param = (this && this.__param) || function (paramIndex, decorator) {
+    return function (target, key) { decorator(target, key, paramIndex); }
+};
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.TabManagementToolCategory = void 0;
 const core_1 = __webpack_require__(9430);
@@ -28597,15 +28601,17 @@ const tabby_terminal_1 = __webpack_require__(4319);
 const zod_1 = __webpack_require__(7552);
 const base_tool_category_1 = __webpack_require__(2099);
 const mcpLogger_service_1 = __webpack_require__(9924);
+const terminal_1 = __webpack_require__(2966);
 /**
  * Tab Management Tools Category - Comprehensive tab and profile management
  */
 let TabManagementToolCategory = class TabManagementToolCategory extends base_tool_category_1.BaseToolCategory {
-    constructor(app, logger, config, profilesService) {
+    constructor(app, logger, config, profilesService, terminalTools) {
         super(logger);
         this.app = app;
         this.config = config;
         this.profilesService = profilesService;
+        this.terminalTools = terminalTools;
         this.name = 'tab_management';
         // Tab ID registry for stable IDs
         // Use both WeakMap (for tab -> id) and Map (for id -> tab) to support bidirectional lookup
@@ -29021,6 +29027,12 @@ Parameters:
 - timeout: Timeout in ms when waiting (default: 30000)
 
 Returns sessionId for immediate use with exec_command, SFTP tools, etc.
+
+Response state fields:
+- tabReady: Tab/frontend initialized
+- sshConnected: SSH connection established (SSH profiles only)
+- ready: OVERALL ready state (for SSH: tabReady AND sshConnected)
+
 For SSH profiles, waits until sshSession.open=true (real connection established).
 
 NOTE: This opens a NEW tab. For existing connections, use get_session_list + exec_command.`,
@@ -29075,13 +29087,24 @@ NOTE: This opens a NEW tab. For existing connections, use get_session_list + exe
                         const isSSH = profile.type === 'ssh' || profile.type?.includes('ssh');
                         // Determine default waitForReady based on profile type
                         const waitForReady = params?.waitForReady ?? isSSH;
-                        // Generate sessionId for the new tab
-                        // Use same UUID generation as TerminalToolCategory
-                        let sessionId = 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, (c) => {
-                            const r = Math.random() * 16 | 0;
-                            const v = c === 'x' ? r : (r & 0x3 | 0x8);
-                            return v.toString(16);
-                        });
+                        // Get sessionId from TerminalToolCategory's registry
+                        // CRITICAL: Call getOrCreateSessionId DIRECTLY on the tab object
+                        // DO NOT use findTerminalSessions() as the tab may not yet be in app.tabs
+                        let sessionId;
+                        if (tab instanceof tabby_terminal_1.BaseTerminalTabComponent) {
+                            // Direct call to getOrCreateSessionId ensures the same ID is registered
+                            sessionId = this.terminalTools.getOrCreateSessionId(tab);
+                            this.logger.debug(`[open_profile] SessionId assigned: ${sessionId}`);
+                        }
+                        // Fallback: generate UUID if not a terminal tab (shouldn't happen)
+                        if (!sessionId) {
+                            sessionId = 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, (c) => {
+                                const r = Math.random() * 16 | 0;
+                                const v = c === 'x' ? r : (r & 0x3 | 0x8);
+                                return v.toString(16);
+                            });
+                            this.logger.warn(`[open_profile] Tab is not BaseTerminalTabComponent, generated fallback sessionId: ${sessionId}`);
+                        }
                         if (waitForReady) {
                             // Wait for the terminal session to be fully connected
                             const timing = this.config.store.mcp?.timing || {};
@@ -29148,7 +29171,11 @@ NOTE: This opens a NEW tab. For existing connections, use get_session_list + exe
                                 await new Promise(resolve => setTimeout(resolve, sessionPollInterval));
                             }
                             const elapsed = Date.now() - startTime;
-                            this.logger.info(`[open_profile] Profile opened: ${profile.name} (tabReady=${tabReady}, sshConnected=${sshConnected}, elapsed=${elapsed}ms)`);
+                            // Determine final ready state:
+                            // - For SSH: ready = tabReady AND sshConnected
+                            // - For non-SSH: ready = tabReady
+                            const ready = isSSH ? (tabReady && sshConnected) : tabReady;
+                            this.logger.info(`[open_profile] Profile opened: ${profile.name} (tabReady=${tabReady}, sshConnected=${sshConnected}, ready=${ready}, elapsed=${elapsed}ms)`);
                             return {
                                 content: [{
                                         type: 'text', text: JSON.stringify({
@@ -29159,13 +29186,19 @@ NOTE: This opens a NEW tab. For existing connections, use get_session_list + exe
                                             tabTitle: tab.title,
                                             profileName: profile.name,
                                             profileType: profile.type,
-                                            ready: tabReady,
-                                            sshConnected: isSSH ? sshConnected : undefined,
+                                            // State fields with clear semantics:
+                                            tabReady, // Tab/frontend initialized
+                                            sshConnected: isSSH ? sshConnected : undefined, // SSH connection established (SSH only)
+                                            ready, // OVERALL ready state: can start using this session
                                             elapsed: `${elapsed}ms`,
-                                            message: tabReady
+                                            message: ready
                                                 ? `Profile ready: ${profile.name}`
-                                                : `Profile opened but may not be fully connected: ${profile.name}`,
-                                            hint: 'Use sessionId with exec_command, SFTP tools, etc.'
+                                                : tabReady && !sshConnected
+                                                    ? `Tab opened but SSH not connected: ${profile.name}`
+                                                    : `Profile opened but not fully ready: ${profile.name}`,
+                                            hint: ready
+                                                ? 'Use sessionId with exec_command, SFTP tools, etc.'
+                                                : 'Session may not be fully connected. Check sshConnected status.'
                                         })
                                     }]
                             };
@@ -29182,9 +29215,12 @@ NOTE: This opens a NEW tab. For existing connections, use get_session_list + exe
                                         tabTitle: tab.title,
                                         profileName: profile.name,
                                         profileType: profile.type,
-                                        ready: false,
+                                        // State fields (unknown since we didn't wait)
+                                        tabReady: undefined, // Unknown - didn't wait
+                                        sshConnected: undefined, // Unknown - didn't wait
+                                        ready: false, // Not verified as ready
                                         message: `Opened profile: ${profile.name}`,
-                                        note: 'Profile opened. SSH connections may take a moment to establish.',
+                                        note: 'Profile opened without waiting. Use get_session_list to check status.',
                                         hint: 'Use sessionId with exec_command, SFTP tools, etc.'
                                     })
                                 }]
@@ -29447,10 +29483,12 @@ The active tab must be inside a SplitTabComponent, or be a terminal that can be
 exports.TabManagementToolCategory = TabManagementToolCategory;
 exports.TabManagementToolCategory = TabManagementToolCategory = __decorate([
     (0, core_1.Injectable)({ providedIn: 'root' }),
+    __param(4, (0, core_1.Inject)((0, core_1.forwardRef)(() => terminal_1.TerminalToolCategory))),
     __metadata("design:paramtypes", [tabby_core_1.AppService,
         mcpLogger_service_1.McpLoggerService,
         tabby_core_1.ConfigService,
-        tabby_core_1.ProfilesService])
+        tabby_core_1.ProfilesService,
+        terminal_1.TerminalToolCategory])
 ], TabManagementToolCategory);
 
 
@@ -52531,7 +52569,7 @@ let McpService = class McpService {
         // Initialize MCP Server
         this.server = new mcp_js_1.McpServer({
             name: 'Tabby MCP',
-            version: '1.1.2'
+            version: '1.1.3'
         });
         // Configure Express
         this.configureExpress();
@@ -52576,7 +52614,7 @@ let McpService = class McpService {
             res.status(200).json({
                 status: 'ok',
                 server: 'Tabby MCP',
-                version: '1.1.2',
+                version: '1.1.3',
                 transport: 'StreamableHTTP + SSE',
                 uptime: process.uptime()
             });
@@ -52585,7 +52623,7 @@ let McpService = class McpService {
         this.app.get('/info', (_, res) => {
             res.status(200).json({
                 name: 'Tabby MCP',
-                version: '1.1.2',
+                version: '1.1.3',
                 protocolVersion: '2025-03-26',
                 transports: ['streamable-http', 'sse'],
                 endpoints: {