tabby-bianbu-mcp 0.8.0 → 0.8.2

package/CHANGELOG.md

@@ -2,6 +2,21 @@
 
 All notable changes to `tabby-bianbu-mcp` will be documented in this file.
 
+## [0.8.2] - 2026-03-23
+
+### Fixed
+- **PTY helper SIGCHLD race condition**: replaced `SIGCHLD` signal handler with non-blocking `waitpid(WNOHANG)` poll — `.bashrc` subprocesses (e.g. `dircolors`, `lesspipe`) were triggering SIGCHLD, setting `running=False`, and killing the PTY before bash was ready
+- **PTY helper stdin EOF exit**: stdin EOF no longer terminates the helper; instead it stops watching stdin and lets master_fd drain until bash actually exits
+- **PTY stderr visibility**: Python helper stderr is now forwarded to the terminal output as red diagnostic text instead of being silently discarded
+- **select() timeout tuned**: changed from 50ms to 500ms to reduce CPU usage during idle PTY sessions
+
+## [0.8.1] - 2026-03-23
+
+### Fixed
+- **PTY shell tab closing immediately**: removed `closed.next()` from poll loop on process exit — prevents Tabby from auto-closing the tab when the PTY process ends
+- **PTY startup fallback**: if `open_pty_session` fails (e.g. python3 unavailable), automatically falls back to `BianbuShellSession` instead of leaving a dead tab
+- **Server-side early crash detection**: `open_pty_session` now waits 200ms and checks if the PTY child is still alive before returning, giving a clear error instead of a silently dead session
+
 ## [0.8.0] - 2026-03-23
 
 ### Added (Remote MCP Server v1.4.0)

package/assets/bianbu_agent_proxy.meta.json

@@ -3,7 +3,7 @@
   "sourceFile": "bianbu_agent_proxy.sh",
   "scriptVersion": "1.4.0",
   "serverVersion": "1.4.0",
-  "sha256": "14e858536af489a30d7c7f5d3a078659015ac315d66b5486949ae1f998d33df8",
-  "bytes": 85475,
-  "generatedAt": "2026-03-23T09:16:09.632Z"
+  "sha256": "273cfef8c453138dffd0a66e9e35ade821314e02c5247167f23a798f4d8c645d",
+  "bytes": 87190,
+  "generatedAt": "2026-03-23T09:53:28.729Z"
 }

package/assets/bianbu_agent_proxy.sh

@@ -791,78 +791,94 @@ else:
     stdin_fd = sys.stdin.fileno()
     old_stdin_flags = fcntl.fcntl(stdin_fd, fcntl.F_GETFL)
     fcntl.fcntl(stdin_fd, fcntl.F_SETFL, old_stdin_flags | os.O_NONBLOCK)
-    running = True
-    def on_sigchld(signum, frame):
-        nonlocal running
-        running = False
-    signal.signal(signal.SIGCHLD, on_sigchld)
+    # Ignore SIGCHLD to prevent select() interruption from .bashrc subprocesses etc.
+    signal.signal(signal.SIGCHLD, signal.SIG_DFL)
+    child_exited = False
     stdin_buf = b''
-    while running:
+    while True:
+        fds_to_watch = [master_fd]
+        if not child_exited:
+            fds_to_watch.append(stdin_fd)
         try:
-            readable, _, _ = select.select([master_fd, stdin_fd], [], [], 0.05)
+            readable, _, _ = select.select(fds_to_watch, [], [], 0.5)
         except (select.error, InterruptedError, ValueError):
-            if not running:
-                break
-            continue
-        if master_fd in readable:
-            try:
-                data = os.read(master_fd, 65536)
-                if not data:
-                    break
-                send_msg({'type': 'output', 'data': base64.b64encode(data).decode('ascii')})
-            except OSError:
-                break
-        if stdin_fd in readable:
-            try:
-                chunk = os.read(stdin_fd, 65536)
-                if not chunk:
+            pass
+        else:
+            if master_fd in readable:
+                try:
+                    data = os.read(master_fd, 65536)
+                    if data:
+                        send_msg({'type': 'output', 'data': base64.b64encode(data).decode('ascii')})
+                    else:
+                        break
+                except OSError:
                     break
-                stdin_buf += chunk
-                while b'\n' in stdin_buf:
-                    line, stdin_buf = stdin_buf.split(b'\n', 1)
-                    line = line.strip()
-                    if not line:
-                        continue
-                    try:
-                        cmd = json.loads(line.decode('utf-8'))
-                        if cmd['type'] == 'input':
-                            raw = base64.b64decode(cmd['data'])
-                            os.write(master_fd, raw)
-                        elif cmd['type'] == 'resize':
-                            set_winsize(master_fd, cmd['rows'], cmd['cols'])
+            if stdin_fd in readable:
+                try:
+                    chunk = os.read(stdin_fd, 65536)
+                    if chunk:
+                        stdin_buf += chunk
+                        while b'\n' in stdin_buf:
+                            line, stdin_buf = stdin_buf.split(b'\n', 1)
+                            line = line.strip()
+                            if not line:
+                                continue
                             try:
-                                os.kill(pid, signal.SIGWINCH)
-                            except OSError:
+                                cmd = json.loads(line.decode('utf-8'))
+                                if cmd['type'] == 'input':
+                                    raw = base64.b64decode(cmd['data'])
+                                    os.write(master_fd, raw)
+                                elif cmd['type'] == 'resize':
+                                    set_winsize(master_fd, cmd['rows'], cmd['cols'])
+                                    try:
+                                        os.kill(pid, signal.SIGWINCH)
+                                    except OSError:
+                                        pass
+                                elif cmd['type'] == 'close':
+                                    child_exited = True
+                                    break
+                            except (json.JSONDecodeError, KeyError, OSError):
                                 pass
-                        elif cmd['type'] == 'close':
-                            running = False
-                            break
-                    except (json.JSONDecodeError, KeyError, OSError):
-                        pass
-            except OSError:
-                break
-    try:
-        os.kill(pid, signal.SIGTERM)
-    except OSError:
-        pass
-    exit_code = -1
-    try:
-        for _ in range(50):
-            rpid, status = os.waitpid(pid, os.WNOHANG)
-            if rpid != 0:
-                exit_code = os.WEXITSTATUS(status) if os.WIFEXITED(status) else -1
-                break
-            import time; time.sleep(0.1)
-        else:
+                except OSError:
+                    pass
+        # Check if child process has exited (non-blocking)
+        if not child_exited:
             try:
-                os.kill(pid, signal.SIGKILL)
-                os.waitpid(pid, 0)
+                rpid, status = os.waitpid(pid, os.WNOHANG)
+                if rpid != 0:
+                    child_exited = True
+            except ChildProcessError:
+                child_exited = True
+        # If child exited, drain remaining master_fd output then break
+        if child_exited:
+            import time
+            time.sleep(0.1)
+            try:
+                while True:
+                    leftover = os.read(master_fd, 65536)
+                    if not leftover:
+                        break
+                    send_msg({'type': 'output', 'data': base64.b64encode(leftover).decode('ascii')})
             except OSError:
                 pass
+            break
+    exit_code = -1
+    if not child_exited:
+        try:
+            os.kill(pid, signal.SIGTERM)
+        except OSError:
+            pass
+    try:
+        rpid, status = os.waitpid(pid, os.WNOHANG if child_exited else 0)
+        if rpid != 0:
+            exit_code = os.WEXITSTATUS(status) if os.WIFEXITED(status) else -1
     except ChildProcessError:
         pass
     send_msg({'type': 'exit', 'code': exit_code})
-    os.close(master_fd)
+    try:
+        os.close(master_fd)
+    except OSError:
+        pass
 `;
 }
 
@@ -934,7 +950,20 @@ function createPtySession(id, cwd, asRoot, cols, rows) {
       } catch {}
     }
   });
-  child.stderr.on('data', () => {});
+  child.stderr.on('data', (chunk) => {
+    const msg = chunk.toString().trim();
+    if (msg) {
+      // Inject stderr as a synthetic output line so the client can see errors
+      const buf = Buffer.from(`\r\n\x1b[31m[pty-helper stderr] ${msg}\x1b[0m\r\n`);
+      session.outputBuffer.push(buf);
+      session.outputBufferSize += buf.length;
+      session.updatedAt = Date.now();
+      for (const waiter of session.waiters) {
+        waiter();
+      }
+      session.waiters = [];
+    }
+  });
   child.on('exit', () => {
     session.alive = false;
     session.updatedAt = Date.now();
@@ -1570,7 +1599,13 @@ function makeServer() {
       }
       await ensurePtyHelper();
       const session_id = newSessionId('pty');
-      createPtySession(session_id, workingDirectory, as_root, cols, rows);
+      const session = createPtySession(session_id, workingDirectory, as_root, cols, rows);
+      // Wait briefly to detect immediate crash
+      await new Promise(r => setTimeout(r, 200));
+      if (!session.alive) {
+        ptySessions.delete(session_id);
+        throw new Error('PTY session exited immediately — check that python3 is available and the working directory is accessible');
+      }
       const payload = { session_id, cwd: workingDirectory, as_root, cols, rows };
       return textResult(JSON.stringify(payload, null, 2), payload);
     },