systeminformation 5.25.6 → 5.25.8

package/lib/cpu.js

@@ -780,16 +780,13 @@ function getCpu() {
             result.governor = util.getValue(lines, 'governor') || '';
 
             // Test Raspberry
-            if (result.vendor === 'ARM') {
-              const linesRpi = fs.readFileSync('/proc/cpuinfo').toString().split('\n');
-              const rPIRevision = util.decodePiCpuinfo(linesRpi);
-              if (rPIRevision.model.toLowerCase().indexOf('raspberry') >= 0) {
-                result.family = result.manufacturer;
-                result.manufacturer = rPIRevision.manufacturer;
-                result.brand = rPIRevision.processor;
-                result.revision = rPIRevision.revisionCode;
-                result.socket = 'SOC';
-              }
+            if (result.vendor === 'ARM' && util.isRaspberry()) {
+              const rPIRevision = util.decodePiCpuinfo();
+              result.family = result.manufacturer;
+              result.manufacturer = rPIRevision.manufacturer;
+              result.brand = rPIRevision.processor;
+              result.revision = rPIRevision.revisionCode;
+              result.socket = 'SOC';
             }
 
             // Test RISC-V

package/lib/graphics.js

@@ -733,8 +733,8 @@ function graphics(callback) {
       }
       if (_linux) {
         // Raspberry: https://elinux.org/RPI_vcgencmd_usage
-        if (util.isRaspberry() && util.isRaspbian()) {
-          let cmd = 'fbset -s | grep \'mode "\'; vcgencmd get_mem gpu; tvservice -s; tvservice -n;';
+        if (util.isRaspberry()) {
+          let cmd = 'fbset -s 2> /dev/null | grep \'mode "\' ; vcgencmd get_mem gpu 2> /dev/null; tvservice -s 2> /dev/null; tvservice -n 2> /dev/null;';
           exec(cmd, function (error, stdout) {
             let lines = stdout.toString().split('\n');
             if (lines.length > 3 && lines[0].indexOf('mode "') >= -1 && lines[2].indexOf('0x12000a') > -1) {
@@ -759,7 +759,7 @@ function graphics(callback) {
                 });
               }
             }
-            if (lines.length > 1 && stdout.toString().indexOf('gpu=') >= -1) {
+            if (lines.length >= 1 && stdout.toString().indexOf('gpu=') >= -1) {
               result.controllers.push({
                 vendor: 'Broadcom',
                 model: util.getRpiGpu(),

package/lib/memory.js

@@ -401,10 +401,9 @@ function memLayout(callback) {
             try {
               let stdout = execSync('cat /proc/cpuinfo 2>/dev/null', util.execOptsLinux);
               let lines = stdout.toString().split('\n');
-              let model = util.getValue(lines, 'hardware', ':', true).toUpperCase();
               let version = util.getValue(lines, 'revision', ':', true).toLowerCase();
 
-              if (model === 'BCM2835' || model === 'BCM2708' || model === 'BCM2709' || model === 'BCM2835' || model === 'BCM2837') {
+              if (util.isRaspberry(lines)) {
 
                 const clockSpeed = {
                   '0': 400,

package/lib/system.js

@@ -189,7 +189,7 @@ function system(callback) {
                 const model = util.getValue(lines, 'model:', ':', true);
                 // reference values: https://elinux.org/RPi_HardwareHistory
                 // https://www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md
-                if ((result.model === 'BCM2835' || result.model === 'BCM2708' || result.model === 'BCM2709' || result.model === 'BCM2710' || result.model === 'BCM2711' || result.model === 'BCM2836' || result.model === 'BCM2837' || result.model === '') && model.toLowerCase().indexOf('raspberry') >= 0) {
+                if (util.isRaspberry(lines)) {
                   const rPIRevision = util.decodePiCpuinfo(lines);
                   result.model = rPIRevision.model;
                   result.version = rPIRevision.revisionCode;
@@ -504,23 +504,14 @@ function baseboard(callback) {
           result.memSlots = util.toInt(util.getValue(lines, 'Number Of Devices')) || null;
 
           // raspberry
-          let linesRpi = '';
-          try {
-            linesRpi = fs.readFileSync('/proc/cpuinfo').toString().split('\n');
-          } catch (e) {
-            util.noop();
-          }
-          if (linesRpi) {
-            const hardware = util.getValue(linesRpi, 'hardware');
-            if (hardware.startsWith('BCM')) {
-              const rpi = util.decodePiCpuinfo(linesRpi);
-              result.manufacturer = rpi.manufacturer;
-              result.model = 'Raspberry Pi';
-              result.serial = rpi.serial;
-              result.version = rpi.type + ' - ' + rpi.revision;
-              result.memMax = os.totalmem();
-              result.memSlots = 0;
-            }
+          if (util.isRaspberry()) {
+            const rpi = util.decodePiCpuinfo();
+            result.manufacturer = rpi.manufacturer;
+            result.model = 'Raspberry Pi';
+            result.serial = rpi.serial;
+            result.version = rpi.type + ' - ' + rpi.revision;
+            result.memMax = os.totalmem();
+            result.memSlots = 0;
           }
 
           if (callback) { callback(result); }

package/lib/util.js

@@ -635,7 +635,7 @@ function smartMonToolsInstalled() {
   return _smartMonToolsInstalled;
 }
 
-function isRaspberry() {
+function isRaspberry(cpuinfo) {
   const PI_MODEL_NO = [
     'BCM2708',
     'BCM2709',
@@ -647,11 +647,9 @@ function isRaspberry() {
     'BCM2837',
     'BCM2837B0'
   ];
-  let cpuinfo = [];
-
   if (_rpi_cpuinfo !== null) {
     cpuinfo = _rpi_cpuinfo;
-  } else {
+  } else if (cpuinfo === undefined) {
     try {
       cpuinfo = fs.readFileSync('/proc/cpuinfo', { encoding: 'utf8' }).toString().split('\n');
       _rpi_cpuinfo = cpuinfo;
@@ -884,6 +882,8 @@ function decodePiCpuinfo(lines) {
 
   if (_rpi_cpuinfo === null) {
     _rpi_cpuinfo = lines;
+  } else if (lines === undefined) {
+    lines = _rpi_cpuinfo;
   }
 
   // https://www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "systeminformation",
-  "version": "5.25.6",
+  "version": "5.25.8",
   "description": "Advanced, lightweight system and OS information library",
   "license": "MIT",
   "author": "Sebastian Hildebrandt <hildebrandt@plus-innovations.com> (https://plus-innovations.com)",