systeminformation 5.21.4 → 5.21.6

package/README.md

@@ -29,11 +29,11 @@
   [![MIT license][license-img]][license-url]
 
 ## The Systeminformation Project
-This is amazing. Started as a small project just for myself, it now has > 15,000 lines of code, > 600 versions published, up to 6 mio downloads per month, > 150 mio downloads overall. #1 NPM ranking for backend packages. Thank you to all who contributed to this project!
+This is amazing. Started as a small project just for myself, it now has > 15,000 lines of code, > 600 versions published, up to 8 mio downloads per month, > 200 mio downloads overall. #1 NPM ranking for backend packages. Thank you to all who contributed to this project!
 
 ## Please support this project ... ☕️
 
-Over the past few years I spent **over 2.000 hours** working on this project and invested in hardware to be able to test on different platforms. Currently I am working very hard on the next **new version 6.0** completely rewritten in TypeScript and with a lot of new features. Any support is highly appreciated - [Buy me a coffee](https://www.buymeacoffee.com/systeminfo).
+Over the past few years I spent **more than 2.000 hours** working on this project and invested in hardware to be able to test on different platforms. Currently I am working very hard on the next **new version 6.0** completely rewritten in TypeScript and with a lot of new features. Any support is highly appreciated - [Buy me a coffee](https://www.buymeacoffee.com/systeminfo).
 
 **Your contribution** make it possible for me to keep working on this project, add new features and support more platforms. Thank you in advance!
 

package/lib/system.js

@@ -317,6 +317,13 @@ function system(callback) {
 
 exports.system = system;
 
+function cleanDefaults(s) {
+  const cmpStr = s.toLowerCase();
+  if (cmpStr.indexOf('o.e.m.') === -1 && cmpStr.indexOf('default string') === -1 && cmpStr !== 'default') {
+    return s || '';
+  }
+  return '';
+}
 function bios(callback) {
 
   return new Promise((resolve) => {
@@ -418,7 +425,7 @@ function bios(callback) {
               }
               result.releaseDate = util.getValue(lines, 'releasedate', ':');
               result.revision = util.getValue(lines, 'buildnumber', ':');
-              result.serial = util.getValue(lines, 'serialnumber', ':');
+              result.serial = cleanDefaults(util.getValue(lines, 'serialnumber', ':'));
             }
 
             if (callback) { callback(result); }
@@ -562,16 +569,16 @@ function baseboard(callback) {
           ).then((data) => {
             let lines = data.results[0] ? data.results[0].toString().split('\r\n') : [''];
 
-            result.manufacturer = util.getValue(lines, 'manufacturer', ':');
-            result.model = util.getValue(lines, 'model', ':');
+            result.manufacturer = cleanDefaults(util.getValue(lines, 'manufacturer', ':'));
+            result.model = cleanDefaults(util.getValue(lines, 'model', ':'));
             if (!result.model) {
-              result.model = util.getValue(lines, 'product', ':');
+              result.model = cleanDefaults(util.getValue(lines, 'product', ':'));
             }
-            result.version = util.getValue(lines, 'version', ':');
-            result.serial = util.getValue(lines, 'serialnumber', ':');
-            result.assetTag = util.getValue(lines, 'partnumber', ':');
+            result.version = cleanDefaults(util.getValue(lines, 'version', ':'));
+            result.serial = cleanDefaults(util.getValue(lines, 'serialnumber', ':'));
+            result.assetTag = cleanDefaults(util.getValue(lines, 'partnumber', ':'));
             if (!result.assetTag) {
-              result.assetTag = util.getValue(lines, 'sku', ':');
+              result.assetTag = cleanDefaults(util.getValue(lines, 'sku', ':'));
             }
 
             // memphysical
@@ -688,22 +695,21 @@ function chassis(callback) {
       }
       if (_windows) {
         try {
-          util.powerShell('Get-CimInstance Win32_SystemEnclosure | select Model,Manufacturer,ChassisTypes,Version,SerialNumber,PartNumber,SKU | fl').then((stdout, error) => {
+          util.powerShell('Get-CimInstance Win32_SystemEnclosure | select Model,Manufacturer,ChassisTypes,Version,SerialNumber,PartNumber,SKU,SMBIOSAssetTag | fl').then((stdout, error) => {
             if (!error) {
               let lines = stdout.toString().split('\r\n');
 
-              result.manufacturer = util.getValue(lines, 'manufacturer', ':');
-              result.model = util.getValue(lines, 'model', ':');
+              result.manufacturer = cleanDefaults(util.getValue(lines, 'manufacturer', ':'));
+              result.model = cleanDefaults(util.getValue(lines, 'model', ':'));
               const ctype = parseInt(util.getValue(lines, 'ChassisTypes', ':').replace(/\D/g, ''));
               result.type = (ctype && !isNaN(ctype) && ctype < chassisTypes.length) ? chassisTypes[ctype - 1] : '';
-              result.version = util.getValue(lines, 'version', ':');
-              result.serial = util.getValue(lines, 'serialnumber', ':');
-              result.assetTag = util.getValue(lines, 'partnumber', ':');
-              result.sku = util.getValue(lines, 'sku', ':');
-              if (result.manufacturer.toLowerCase().indexOf('o.e.m.') !== -1) { result.manufacturer = '-'; }
-              if (result.version.toLowerCase().indexOf('o.e.m.') !== -1) { result.version = '-'; }
-              if (result.serial.toLowerCase().indexOf('o.e.m.') !== -1) { result.serial = '-'; }
-              if (result.assetTag.toLowerCase().indexOf('o.e.m.') !== -1) { result.assetTag = '-'; }
+              result.version = cleanDefaults(util.getValue(lines, 'version', ':'));
+              result.serial = cleanDefaults(util.getValue(lines, 'serialnumber', ':'));
+              result.assetTag = cleanDefaults(util.getValue(lines, 'partnumber', ':'));
+              if (!result.assetTag) {
+                result.assetTag = cleanDefaults(util.getValue(lines, 'SMBIOSAssetTag', ':'));
+              }
+              result.sku = cleanDefaults(util.getValue(lines, 'sku', ':'));
             }
 
             if (callback) { callback(result); }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "systeminformation",
-  "version": "5.21.4",
+  "version": "5.21.6",
   "description": "Advanced, lightweight system and OS information library",
   "license": "MIT",
   "author": "Sebastian Hildebrandt <hildebrandt@plus-innovations.com> (https://plus-innovations.com)",