systeminformation 4.34.19 → 4.34.23

package/CHANGELOG.md

@@ -30,6 +30,10 @@ For major (breaking) changes - version 3 and 2 see end of page.
 
 | Version        | Date           | Comment  |
 | -------------- | -------------- | -------- |
+| 4.34.23        | 2021-05-05     | `networkInterfaces()` fixed Windows XP bug (WMIC NetEnabled) |
+| 4.34.22        | 2021-05-05     | restored Node 4.x compatibility |
+| 4.34.21        | 2021-05-04     | `dockerContainerInspect()`, `dockerContainerProcesses()` parameter validation fix |
+| 4.34.20        | 2021-04-08     | `versions()` parameter validation |
 | 4.34.19        | 2021-03-16     | `inetLatency()` `ineChecksite()` schema validation |
 | 4.34.18        | 2021-03-16     | code refactoring |
 | 4.34.17        | 2021-03-15     | `sanitizeShellString()` and other security improvements |

package/README.md

@@ -811,7 +811,7 @@ Sebastian Hildebrandt, [+innovations](http://www.plus-innovations.com)
 
 Written by Sebastian Hildebrandt [sebhildebrandt](https://github.com/sebhildebrandt)
 
-#### Contributers
+#### Contributors
 
 - Guillaume Legrain [glegrain](https://github.com/glegrain)
 - Riccardo Novaglia [richy24](https://github.com/richy24)

package/lib/docker.js

@@ -192,7 +192,7 @@ function dockerContainerInspect(containerID, payload) {
     process.nextTick(() => {
       containerID = containerID || '';
       if (typeof containerID !== 'string') {
-        resolve();
+        return resolve();
       }
       const containerIdSanitized = (util.isPrototypePolluted() ? '' : util.sanitizeShellString(containerID, true)).trim();
       if (containerIdSanitized) {
@@ -497,7 +497,7 @@ function dockerContainerProcesses(containerID, callback) {
     process.nextTick(() => {
       containerID = containerID || '';
       if (typeof containerID !== 'string') {
-        resolve(result);
+        return resolve(result);
       }
       const containerIdSanitized = (util.isPrototypePolluted() ? '' : util.sanitizeShellString(containerID, true)).trim();
 

package/lib/graphics.js

@@ -721,7 +721,7 @@ function graphics(callback) {
               const nvidiaData = nvidiaDevices();
               // needs to be rewritten ... using no spread operators
               result.controllers = result.controllers.map((controller) => { // match by busAddress
-                return mergeControllerNvidia(controller, nvidiaData.find(({ pciBus }) => pciBus.endsWith(controller.busAddress)) || {});
+                return mergeControllerNvidia(controller, nvidiaData.find((contr) => contr.pciBus.toLowerCase().endsWith(controller.busAddress.toLowerCase())) || {});
               })
             }
             let cmd = "clinfo --raw";

package/lib/network.js

@@ -239,7 +239,7 @@ function parseLinesWindowsNics(sections, nconfigsections) {
 }
 
 function getWindowsNics() {
-  const cmd = util.getWmic() + ' nic get MACAddress, name, NetEnabled, Speed, NetConnectionStatus, AdapterTypeId /value';
+  const cmd = util.getWmic() + ' nic get /value';
   const cmdnicconfig = util.getWmic() + ' nicconfig get dhcpEnabled /value';
   try {
     const nsections = execSync(cmd, util.execOptsWin).split(/\n\s*\n/);
@@ -677,12 +677,15 @@ function testVirtualNic(iface, ifaceName, mac) {
   } else return false;
 }
 
-function networkInterfaces(callback, rescan = true) {
+function networkInterfaces(callback, rescan) {
 
   if (typeof callback === 'boolean') {
     rescan = callback;
     callback = null;
   }
+  if (typeof rescan === 'undefined') {
+    rescan = true;
+  }
   return new Promise((resolve) => {
     process.nextTick(() => {
       let result = [];

package/lib/osinfo.js

@@ -457,6 +457,10 @@ function versions(apps, callback) {
         apps = '*';
       } else {
         apps = apps || '*';
+        if (typeof apps !== 'string') {
+          if (callback) { callback({}); }
+          return resolve({});
+        }
       }
       const appsObj = checkVersionParam(apps);
       let totalFunctions = appsObj.counter;

package/lib/util.js

@@ -536,7 +536,8 @@ function countLines(lines, startingWith) {
   return uniqueLines.length;
 }
 
-function sanitizeShellString(str, strict = false) {
+function sanitizeShellString(str, strict) {
+  if (typeof strict === 'undefined') { strict = false; }
   const s = str || '';
   let result = '';
   for (let i = 0; i <= mathMin(s.length, 2000); i++) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "systeminformation",
-  "version": "4.34.19",
+  "version": "4.34.23",
   "description": "Simple system and OS information library",
   "license": "MIT",
   "author": "Sebastian Hildebrandt <hildebrandt@plus-innovations.com> (https://plus-innovations.com)",