syntaur 0.47.0 → 0.48.0

package/dist/dashboard/server.js

@@ -3046,6 +3046,53 @@ function factFieldNames(decl) {
   ].map((k) => k.toLowerCase()) : [exportNames.fact.toLowerCase()];
   return { storageKey: name, exports: exportNames, registryKeys };
 }
+function validateFactDeclarations(raw2) {
+  const problems = [];
+  const owners = /* @__PURE__ */ new Map();
+  for (const key of Object.keys(DERIVE_FIELDS)) owners.set(key, "built-in");
+  for (const key of Object.keys(ASSIGNMENT_FIELDS)) owners.set(key, "built-in");
+  for (const row of raw2 ?? []) {
+    const name = (row?.name ?? "").trim();
+    if (!/^[a-z][a-zA-Z0-9]*$/.test(name)) {
+      problems.push(
+        `fact "${row?.name ?? ""}": invalid name \u2014 must match /^[a-z][a-zA-Z0-9]*$/`
+      );
+      continue;
+    }
+    const type = (row.type ?? "").trim();
+    if (type !== "bool" && type !== "number" && type !== "attestation") {
+      problems.push(
+        `fact "${name}": invalid type "${row.type ?? ""}" \u2014 expected bool, number, or attestation`
+      );
+      continue;
+    }
+    if (type === "attestation") {
+      const binds = (row.binds ?? "none").toString().trim() || "none";
+      if (binds !== "plan" && binds !== "commit" && binds !== "none") {
+        problems.push(
+          `fact "${name}": invalid binds "${row.binds}" \u2014 expected plan, commit, or none`
+        );
+        continue;
+      }
+    }
+    const decl = type === "attestation" ? { name, type, binds: "none" } : { name, type };
+    const keys = factFieldNames(decl).registryKeys;
+    const collidingKey = keys.find((k) => owners.has(k));
+    if (collidingKey !== void 0) {
+      const owner = owners.get(collidingKey);
+      if (owner === "built-in") {
+        problems.push(`fact "${name}": exported field "${collidingKey}" collides with a built-in field`);
+      } else if (owner === name) {
+        problems.push(`fact "${name}": duplicate declaration (a fact named "${name}" is already declared)`);
+      } else {
+        problems.push(`fact "${name}": exported field "${collidingKey}" collides with fact "${owner}"`);
+      }
+      continue;
+    }
+    for (const key of keys) owners.set(key, name);
+  }
+  return problems;
+}
 function acceptFactDeclarations(declarations) {
   const taken = /* @__PURE__ */ new Set([
     ...Object.keys(DERIVE_FIELDS),
@@ -3571,7 +3618,6 @@ function parseStatusConfig(content) {
       continue;
     }
   }
-  if (statuses.length === 0) return null;
   const derive = phaseLadder.length > 0 || disposition.length > 0 || Object.keys(headline).length > 0 ? {
     phaseLadder: phaseLadder.length > 0 ? phaseLadder : DEFAULT_DERIVE_CONFIG.phaseLadder,
     disposition: disposition.length > 0 ? disposition : DEFAULT_DERIVE_CONFIG.disposition,
@@ -3582,6 +3628,7 @@ function parseStatusConfig(content) {
       active: "phase"
     }
   } : null;
+  if (statuses.length === 0 && facts.length === 0 && derive === null) return null;
   return {
     statuses,
     order: order.length > 0 ? order : statuses.map((s) => s.id),
@@ -3707,53 +3754,6 @@ function validateDeriveConfig(derive, statusConfig, validateWhen = () => null) {
   }
   return problems;
 }
-function validateFactDeclarations(raw2) {
-  const problems = [];
-  const owners = /* @__PURE__ */ new Map();
-  for (const key of Object.keys(DERIVE_FIELDS)) owners.set(key, "built-in");
-  for (const key of Object.keys(ASSIGNMENT_FIELDS)) owners.set(key, "built-in");
-  for (const row of raw2 ?? []) {
-    const name = (row?.name ?? "").trim();
-    if (!/^[a-z][a-zA-Z0-9]*$/.test(name)) {
-      problems.push(
-        `fact "${row?.name ?? ""}": invalid name \u2014 must match /^[a-z][a-zA-Z0-9]*$/`
-      );
-      continue;
-    }
-    const type = (row.type ?? "").trim();
-    if (type !== "bool" && type !== "number" && type !== "attestation") {
-      problems.push(
-        `fact "${name}": invalid type "${row.type ?? ""}" \u2014 expected bool, number, or attestation`
-      );
-      continue;
-    }
-    if (type === "attestation") {
-      const binds = (row.binds ?? "none").toString().trim() || "none";
-      if (binds !== "plan" && binds !== "commit" && binds !== "none") {
-        problems.push(
-          `fact "${name}": invalid binds "${row.binds}" \u2014 expected plan, commit, or none`
-        );
-        continue;
-      }
-    }
-    const decl = type === "attestation" ? { name, type, binds: "none" } : { name, type };
-    const keys = factFieldNames(decl).registryKeys;
-    const collidingKey = keys.find((k) => owners.has(k));
-    if (collidingKey !== void 0) {
-      const owner = owners.get(collidingKey);
-      if (owner === "built-in") {
-        problems.push(`fact "${name}": exported field "${collidingKey}" collides with a built-in field`);
-      } else if (owner === name) {
-        problems.push(`fact "${name}": duplicate declaration (a fact named "${name}" is already declared)`);
-      } else {
-        problems.push(`fact "${name}": exported field "${collidingKey}" collides with fact "${owner}"`);
-      }
-      continue;
-    }
-    for (const key of keys) owners.set(key, name);
-  }
-  return problems;
-}
 function serializeIntegrationConfig(integrations) {
   const lines = [];
   if (integrations.claudePluginDir) {
@@ -4833,7 +4833,6 @@ var init_config2 = __esm({
     init_agents_schema();
     init_slug();
     init_fact_registry();
-    init_query();
     init_terminal_schema();
     init_workspace_visibility_schema();
     DEFAULT_DERIVE_CONFIG = {
@@ -7453,24 +7452,28 @@ async function getStatusConfig() {
   if (_cachedConfig) return _cachedConfig;
   const config = await readConfig();
   if (config.statuses) {
+    const sc = config.statuses;
+    const defaults = sc.statuses.length === 0 ? buildDefaultStatusConfig() : null;
+    const effectiveStatuses = defaults ? defaults.statuses : sc.statuses;
+    const effectiveOrder = defaults ? defaults.order : sc.order;
     const terminalSet = new Set(
-      config.statuses.statuses.filter((s) => s.terminal).map((s) => s.id)
+      effectiveStatuses.filter((s) => s.terminal).map((s) => s.id)
     );
-    const hasCustomTransitions = config.statuses.transitions.length > 0;
-    const effectiveTransitions = hasCustomTransitions ? config.statuses.transitions : Array.from(DEFAULT_TRANSITION_TABLE.entries()).map(([key, to]) => {
+    const hasCustomTransitions = sc.transitions.length > 0;
+    const effectiveTransitions = hasCustomTransitions ? sc.transitions : Array.from(DEFAULT_TRANSITION_TABLE.entries()).map(([key, to]) => {
       const [from, command] = key.split(":");
       return { from, command, to };
     });
-    const accepted = acceptFactDeclarations(normalizeFactDeclarations(config.statuses.facts ?? null));
+    const accepted = acceptFactDeclarations(normalizeFactDeclarations(sc.facts ?? null));
     _cachedConfig = {
       custom: true,
-      statuses: config.statuses.statuses,
-      order: config.statuses.order,
+      statuses: effectiveStatuses,
+      order: effectiveOrder,
       transitions: effectiveTransitions,
       transitionTable: buildTransitionTable(effectiveTransitions),
       terminalStatuses: terminalSet.size > 0 ? terminalSet : /* @__PURE__ */ new Set(["completed", "failed"]),
-      derive: config.statuses.derive ?? null,
-      facts: config.statuses.facts ?? null,
+      derive: sc.derive ?? null,
+      facts: sc.facts ?? null,
       factDeclarations: accepted,
       deriveRegistry: buildDeriveRegistry(accepted),
       queryRegistry: buildQueryRegistry(accepted)
@@ -8634,7 +8637,7 @@ async function buildDerivedDetail(assignment, assignmentDir, projectDir) {
   try {
     const { computeFactsDetailed: computeFactsDetailed2 } = await Promise.resolve().then(() => (init_facts(), facts_exports));
     const { deriveDimensions: deriveDimensions2 } = await Promise.resolve().then(() => (init_derive(), derive_exports));
-    const { DEFAULT_DERIVE_CONFIG: DEFAULT_DERIVE_CONFIG2 } = await Promise.resolve().then(() => (init_config2(), config_exports));
+    const { DEFAULT_DERIVE_CONFIG: DEFAULT_DERIVE_CONFIG3 } = await Promise.resolve().then(() => (init_config2(), config_exports));
     const { facts, attestations } = await computeFactsDetailed2({
       assignmentDir,
       frontmatter: {
@@ -8649,7 +8652,7 @@ async function buildDerivedDetail(assignment, assignmentDir, projectDir) {
     });
     const dims = deriveDimensions2({
       facts,
-      derive: config.derive ?? DEFAULT_DERIVE_CONFIG2,
+      derive: config.derive ?? DEFAULT_DERIVE_CONFIG3,
       currentStatus: assignment.status,
       terminalStatuses: config.terminalStatuses,
       knownStatusIds: new Set(config.statuses.map((s) => s.id)),
@@ -16713,7 +16716,9 @@ function createWorkspaceVisibilityConfigRouter() {
 
 // src/dashboard/api-status-config.ts
 init_config2();
+init_fact_registry();
 init_api();
+init_derive();
 import { Router as Router9 } from "express";
 
 // src/utils/status-config-resolution.ts
@@ -17090,7 +17095,8 @@ function createStatusConfigRouter(projectsDir, assignmentsDir2) {
         order: config.order,
         transitions: config.transitions,
         custom: config.custom,
-        factDeclarations: config.factDeclarations
+        factDeclarations: config.factDeclarations,
+        rawFacts: config.facts ?? []
       });
     } catch (error) {
       console.error("Error getting status config:", error);
@@ -17114,8 +17120,27 @@ function createStatusConfigRouter(projectsDir, assignmentsDir2) {
   });
   router.post("/", async (req, res) => {
     try {
-      const { statuses, order, transitions, resolutions: rawResolutions } = req.body ?? {};
-      if (!Array.isArray(statuses) || !Array.isArray(order) || !Array.isArray(transitions)) {
+      const {
+        statuses,
+        order,
+        transitions,
+        facts: bodyFacts,
+        factRemovalAcks,
+        resolutions: rawResolutions
+      } = req.body ?? {};
+      const currentConfig = await getStatusConfig();
+      const hasFacts = bodyFacts !== void 0;
+      const hasStatuses = statuses !== void 0;
+      const hasOrder = order !== void 0;
+      const hasTransitions = transitions !== void 0;
+      let effectiveStatuses = statuses;
+      let effectiveOrder = order;
+      let effectiveTransitions = transitions;
+      if (hasFacts && !hasStatuses && !hasOrder && !hasTransitions) {
+        effectiveStatuses = currentConfig.statuses;
+        effectiveOrder = currentConfig.order;
+        effectiveTransitions = currentConfig.transitions;
+      } else if (!Array.isArray(effectiveStatuses) || !Array.isArray(effectiveOrder) || !Array.isArray(effectiveTransitions)) {
         res.status(400).json({ error: "malformed-statuses", message: "Request body must include statuses, order, and transitions arrays" });
         return;
       }
@@ -17129,10 +17154,9 @@ function createStatusConfigRouter(projectsDir, assignmentsDir2) {
         return;
       }
       const resolutions = parsed.resolutions;
-      const currentConfig = await getStatusConfig();
       const oldIds = new Set(currentConfig.statuses.map((s) => s.id));
       const newIds = /* @__PURE__ */ new Set();
-      for (const s of statuses) {
+      for (const s of effectiveStatuses) {
         if (s && typeof s === "object" && isString(s.id)) {
           newIds.add(s.id);
         }
@@ -17213,13 +17237,83 @@ function createStatusConfigRouter(projectsDir, assignmentsDir2) {
         }
         throw err;
       }
+      let factsToWrite = currentConfig.facts ?? null;
+      if (hasFacts) {
+        const shapedFacts = [];
+        if (!Array.isArray(bodyFacts)) {
+          res.status(400).json({ error: "malformed-facts", message: "facts must be an array" });
+          return;
+        }
+        for (let i = 0; i < bodyFacts.length; i++) {
+          const row = bodyFacts[i];
+          if (!row || typeof row !== "object") {
+            res.status(400).json({ error: "malformed-facts", message: `facts[${i}] must be an object` });
+            return;
+          }
+          const name = row.name;
+          const type = row.type;
+          if (typeof name !== "string" || typeof type !== "string") {
+            res.status(400).json({ error: "malformed-facts", message: `facts[${i}] must have name and type strings` });
+            return;
+          }
+          const binds = row.binds;
+          const normalizedBinds = binds === void 0 ? null : binds === null ? null : typeof binds === "string" ? binds : null;
+          shapedFacts.push({ name, type, binds: normalizedBinds });
+        }
+        const problems = validateFactDeclarations(shapedFacts);
+        if (problems.length > 0) {
+          res.status(400).json({ error: "invalid-facts", problems });
+          return;
+        }
+        const currentNames = new Set((currentConfig.facts ?? []).map((f) => f.name));
+        const incomingNames = new Set(shapedFacts.map((f) => f.name));
+        const removedNames = [];
+        for (const name of currentNames) {
+          if (!incomingNames.has(name)) removedNames.push(name);
+        }
+        const acks = new Set(Array.isArray(factRemovalAcks) ? factRemovalAcks.map((x) => String(x)) : []);
+        const unresolvedRefs = [];
+        const deriveConfig = currentConfig.derive ?? null;
+        if (deriveConfig !== null && removedNames.length > 0) {
+          const acceptedAll = acceptFactDeclarations(normalizeFactDeclarations(currentConfig.facts));
+          const fullRegistry = buildDeriveRegistry(acceptedAll);
+          for (const removedName of removedNames) {
+            if (acks.has(removedName)) continue;
+            const acceptedWithout = acceptedAll.filter((d) => d.name !== removedName);
+            const withoutRegistry = buildDeriveRegistry(acceptedWithout);
+            for (let i = 0; i < deriveConfig.phaseLadder.length; i++) {
+              const rung = deriveConfig.phaseLadder[i];
+              if (rung.when === "*") continue;
+              const before = validateDeriveCondition(rung.when, fullRegistry);
+              const after = validateDeriveCondition(rung.when, withoutRegistry);
+              if (before === null && after !== null) {
+                unresolvedRefs.push({ factName: removedName, location: `phaseLadder[${i}]`, when: rung.when });
+              }
+            }
+            for (let i = 0; i < deriveConfig.disposition.length; i++) {
+              const rule = deriveConfig.disposition[i];
+              if (rule.when === null) continue;
+              const before = validateDeriveCondition(rule.when, fullRegistry);
+              const after = validateDeriveCondition(rule.when, withoutRegistry);
+              if (before === null && after !== null) {
+                unresolvedRefs.push({ factName: removedName, location: `disposition[${i}]`, when: rule.when });
+              }
+            }
+          }
+        }
+        if (unresolvedRefs.length > 0) {
+          res.status(409).json({ error: "unresolved-fact-references", references: unresolvedRefs });
+          return;
+        }
+        factsToWrite = shapedFacts;
+      }
       try {
         await writeStatusConfig({
-          statuses,
-          order,
-          transitions,
+          statuses: effectiveStatuses,
+          order: effectiveOrder,
+          transitions: effectiveTransitions,
           derive: currentConfig.derive ?? null,
-          facts: currentConfig.facts ?? null
+          facts: factsToWrite
         });
       } catch (err) {
         console.error("Error saving status config after applying resolutions:", err);