synapse-hub 2.2.2 → 2.2.3

package/tools/verify_all.py

@@ -237,43 +237,42 @@ def gate_2_path_portability(repo_root, mode="AUTO"):
 
 
 def gate_3_clean_pom(repo_root, mode="AUTO"):
-    print("\n[GATE 3] Checking Clean POM & Flat Architecture in Scripts/......")
-    scripts_dir = os.path.join(repo_root, "Scripts")
-
-    has_groovy = False
-    if os.path.isdir(scripts_dir):
-        groovy_files = [f for f in glob.glob(os.path.join(scripts_dir, "**", "*.groovy"), recursive=True)]
-        has_groovy = len(groovy_files) > 0
-
-    if not has_groovy:
-        if mode == "HUB":
-            print("[SKIP] Hub Mode: Repository contains QA Hub assets; no target Groovy scripts in Scripts/ to verify.")
-            return True
-        else:
-            print("[SKIP] No Groovy test scripts present in Scripts/ directory.")
-            return True
+    print("\n[GATE 3] Checking Clean POM & Flat Architecture in Test Scripts...")
+    effective_mode = detect_repo_mode(repo_root) if mode == "AUTO" else mode
+    if effective_mode == "HUB":
+        print("[PASS] Hub Mode: Repository contains QA Hub assets; Clean POM applies to target test suites.")
+        return True
+
+    test_dirs = ["Scripts", "tests", "test", "e2e", "specs", "cypress"]
+    test_files = []
+    for td in test_dirs:
+        d = os.path.join(repo_root, td)
+        if os.path.isdir(d):
+            for ext in ("*.groovy", "*.ts", "*.js", "*.py", "*.java"):
+                test_files.extend(glob.glob(os.path.join(d, "**", ext), recursive=True))
+
+    if not test_files:
+        print("[SKIP] No test scripts present in candidate directories (Scripts/, tests/, e2e/).")
+        return True
 
     violations = []
-    for root, dirs, files in os.walk(scripts_dir):
-        for f in files:
-            if f.endswith(".groovy"):
-                full_path = os.path.join(root, f)
-                rel_path = os.path.relpath(full_path, repo_root)
-                try:
-                    with open(full_path, "r", encoding="utf-8", errors="ignore") as fp:
-                        for line_no, line in enumerate(fp, 1):
-                            stripped = line.strip()
-                            if stripped.startswith("//") or stripped.startswith("/*"):
-                                continue
-                            if "findTestObject" in line:
-                                violations.append((rel_path, line_no, "Raw findTestObject"))
-                            if "//" in line and ("//table" in line or "//input" in line or "//button" in line):
-                                violations.append((rel_path, line_no, "Raw XPath"))
-                except Exception:
-                    pass
+    for full_path in sorted(set(test_files)):
+        rel_path = os.path.relpath(full_path, repo_root)
+        try:
+            with open(full_path, "r", encoding="utf-8", errors="ignore") as fp:
+                for line_no, line in enumerate(fp, 1):
+                    stripped = line.strip()
+                    if stripped.startswith("//") or stripped.startswith("/*") or stripped.startswith("#"):
+                        continue
+                    if "findTestObject" in line:
+                        violations.append((rel_path, line_no, "Raw findTestObject"))
+                    if "//" in line and ("//table" in line or "//input" in line or "//button" in line):
+                        violations.append((rel_path, line_no, "Raw XPath"))
+        except Exception:
+            pass
 
     if violations:
-        print(f"[FAIL] {len(violations)} Clean POM violations in Scripts/:")
+        print(f"[FAIL] {len(violations)} Clean POM violations in test scripts:")
         for rel_path, line_no, reason in violations:
             print(f"   - {rel_path}:{line_no} ({reason})")
         return False
@@ -404,26 +403,35 @@ def gate_6_credential_security(repo_root, mode="AUTO"):
 
 def gate_7_infer_linter(repo_root, mode="AUTO"):
     print("\n[GATE 7] Running Meta Infer-Style Static Defect & Fake-Pass Sentinel...")
-    scripts_dir = os.path.join(repo_root, "Scripts")
-    has_groovy = False
-    if os.path.isdir(scripts_dir):
-        groovy_files = [f for f in glob.glob(os.path.join(scripts_dir, "**", "*.groovy"), recursive=True)]
-        has_groovy = len(groovy_files) > 0
-
-    if not has_groovy:
-        if mode == "HUB":
-            print("[SKIP] Hub Mode: No Groovy test scripts in Scripts/ to scan (Static Defect Sentinel active for target projects).")
-            return True
-        else:
-            print("[SKIP] No Groovy test scripts present in Scripts/ directory.")
-            return True
+    effective_mode = detect_repo_mode(repo_root) if mode == "AUTO" else mode
+    if effective_mode == "HUB":
+        print("[PASS] Hub Mode: Static Defect Sentinel active for target projects.")
+        return True
+
+    test_dirs = ["Scripts", "tests", "test", "e2e", "specs", "cypress"]
+    has_tests = False
+    target_scan_dir = None
+    for td in test_dirs:
+        d = os.path.join(repo_root, td)
+        if os.path.isdir(d):
+            for ext in ("*.groovy", "*.ts", "*.js", "*.py", "*.java"):
+                if glob.glob(os.path.join(d, "**", ext), recursive=True):
+                    has_tests = True
+                    target_scan_dir = d
+                    break
+        if has_tests:
+            break
+
+    if not has_tests:
+        print("[SKIP] No test scripts (Groovy/TS/JS/Py) present in candidate test directories.")
+        return True
 
     infer_script = os.path.join(SCRIPT_DIR, "infer_linter.py")
     if not os.path.exists(infer_script):
         infer_script = os.path.join(repo_root, "tools", "infer_linter.py")
 
     if os.path.exists(infer_script):
-        res = subprocess.run([sys.executable, infer_script, "--dir", scripts_dir], stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True)
+        res = subprocess.run([sys.executable, infer_script, "--dir", target_scan_dir], stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True)
         if res.returncode != 0:
             print("[FAIL] Static Defect Sentinel detected critical issues in test scripts:")
             print(res.stdout)