synapse-hub 0.0.0-stage → 2.0.0

package/.agents/skills/clean-pom-crafter/references/pom_patterns.groovy

@@ -0,0 +1,138 @@
+package com.enterprise.pages
+
+import org.openqa.selenium.By
+import org.openqa.selenium.JavascriptExecutor
+import org.openqa.selenium.Keys
+import org.openqa.selenium.WebDriver
+import org.openqa.selenium.WebElement
+import com.kms.katalon.core.webui.driver.DriverFactory
+
+/**
+ * Enterprise Clean POM common methods reusable across Page Classes.
+ * Kế thừa trực tiếp từ BasePage.
+ */
+class PomPatterns extends BasePage {
+
+    /**
+     * Hành vi tìm kiếm 2 pha: Bấm Search -> Điền từ khóa -> Enter -> Chờ bảng cập nhật
+     */
+    public static void searchRecord(String keyword) {
+        WebDriver driver = DriverFactory.getWebDriver()
+        List<WebElement> inputs = driver.findElements(By.cssSelector("input.p-inputtext[placeholder*='Tìm kiếm'], input[placeholder*='tên'], input[placeholder*='mã']"))
+        if (inputs.isEmpty() || !inputs.get(0).isDisplayed()) {
+            WebElement searchToggle = findElement(By.cssSelector("button.p-button-icon-only[icon*='search'], button[title*='Tìm kiếm']"))
+            searchToggle.click()
+            waitForElementVisible(By.cssSelector("input.p-inputtext[placeholder*='Tìm kiếm'], input[placeholder*='tên'], input[placeholder*='mã']"), 5)
+        }
+        WebElement input = findElement(By.cssSelector("input.p-inputtext[placeholder*='Tìm kiếm'], input[placeholder*='tên'], input[placeholder*='mã']"))
+        jsSetInput(input, keyword)
+        input.sendKeys(Keys.ENTER)
+        waitForAngular(5)
+        waitForElementVisible(By.cssSelector("p-table table tbody tr"), 5)
+    }
+
+    /**
+     * Chỉnh sửa bản ghi tại dòng đầu tiên và xác thực theo tên mới
+     */
+    public static void editRecord(String oldKeyword, String newName) {
+        searchRecord(oldKeyword)
+        WebElement editBtn = findElement(By.cssSelector("p-table tbody tr:first-child button[icon*='pencil'], p-table tbody tr:first-child button[icon*='edit']"))
+        clickElement(editBtn)
+        waitForElementVisible(By.cssSelector("input[formcontrolname='name'], input[name='name']"), 5)
+
+        WebElement nameInput = findElement(By.cssSelector("input[formcontrolname='name'], input[name='name']"))
+        jsSetInput(nameInput, newName)
+
+        WebElement saveBtn = findElement(By.xpath("//button[@title='Xác nhận' or contains(.,'Lưu') or contains(.,'Xác nhận')]"))
+        clickElement(saveBtn)
+        waitForAngular(5)
+
+        searchRecord(newName)
+        WebElement firstRow = findElement(By.cssSelector("p-table tbody tr:first-child"))
+        assert firstRow.getText().contains(newName) : "Lỗi: Bản ghi chưa cập nhật tên mới!"
+    }
+
+    /**
+     * Xóa bản ghi tại dòng đầu tiên và xác nhận p-confirmdialog
+     */
+    public static void deleteRecord(String keyword) {
+        WebDriver driver = DriverFactory.getWebDriver()
+        searchRecord(keyword)
+        WebElement deleteBtn = findElement(By.cssSelector("p-table tbody tr:first-child button.p-button-danger, p-table tbody tr:first-child button[icon*='trash']"))
+        clickElement(deleteBtn)
+        waitForElementVisible(By.xpath("//div[contains(@class,'p-dialog-footer') or contains(@class,'p-confirm-dialog')]//button[contains(@class,'p-confirm-dialog-accept') or contains(.,'Xóa') or contains(.,'Đồng ý') or contains(.,'Xác nhận')]"), 5)
+
+        WebElement confirmBtn = findElement(By.xpath("//div[contains(@class,'p-dialog-footer') or contains(@class,'p-confirm-dialog')]//button[contains(@class,'p-confirm-dialog-accept') or contains(.,'Xóa') or contains(.,'Đồng ý') or contains(.,'Xác nhận')]"))
+        clickElement(confirmBtn)
+        waitForAngular(5)
+
+        verifyRecordNotExists(keyword)
+    }
+
+    /**
+     * Điền ngày vào p-calendar an toàn với Angular
+     */
+    public static void setCalendarDate(WebElement element, String dateStr) {
+        WebDriver driver = DriverFactory.getWebDriver()
+        JavascriptExecutor js = (JavascriptExecutor) driver
+        js.executeScript("""
+            arguments[0].value = arguments[1];
+            arguments[0].dispatchEvent(new Event('input', { bubbles: true }));
+            arguments[0].dispatchEvent(new Event('change', { bubbles: true }));
+            arguments[0].dispatchEvent(new Event('blur', { bubbles: true }));
+        """, element, dateStr)
+    }
+
+    /**
+     * Chọn nhiều lựa chọn trong p-multiselect
+     */
+    public static void selectMultiOptions(WebElement multiSelectEl, List<String> optionTexts) {
+        clickElement(multiSelectEl)
+        waitForElementVisible(By.cssSelector(".p-multiselect-panel"), 5)
+        WebDriver driver = DriverFactory.getWebDriver()
+        for (String opt : optionTexts) {
+            WebElement item = driver.findElement(By.xpath("//li[contains(@class, 'p-multiselect-item') and contains(., '" + opt + "')]"))
+            clickElement(item)
+        }
+        WebElement closeBtn = driver.findElement(By.cssSelector(".p-multiselect-close"))
+        if (closeBtn != null && closeBtn.isDisplayed()) {
+            closeBtn.click()
+        }
+    }
+
+    /**
+     * Kiểm tra bản ghi tồn tại trong bảng p-table
+     */
+    public static void verifyRecordExists(String keyword) {
+        WebDriver driver = DriverFactory.getWebDriver()
+        List<WebElement> rows = driver.findElements(By.cssSelector("p-table table tbody tr"))
+        assert !rows.isEmpty() : "Lỗi: Bảng không có dữ liệu nào!"
+        String firstRowText = rows.get(0).getText()
+        assert firstRowText.contains(keyword) : "Lỗi: Không tìm thấy từ khóa '${keyword}' trong hàng đầu tiên!"
+    }
+
+    /**
+     * Kiểm tra bản ghi đã bị xóa hoàn toàn khỏi bảng
+     */
+    public static void verifyRecordNotExists(String keyword) {
+        WebDriver driver = DriverFactory.getWebDriver()
+        searchRecord(keyword)
+        List<WebElement> rows = driver.findElements(By.cssSelector("p-table table tbody tr"))
+        if (rows.isEmpty()) return
+        String firstRowText = rows.get(0).getText()
+        assert !firstRowText.contains(keyword) || firstRowText.contains("Không có dữ liệu") : "Lỗi: Bản ghi '${keyword}' vẫn còn tồn tại trong bảng!"
+    }
+
+    /**
+     * Gán giá trị an toàn kích hoạt Angular Change Detection
+     */
+    public static void jsSetInput(WebElement element, String value) {
+        WebDriver driver = DriverFactory.getWebDriver()
+        JavascriptExecutor js = (JavascriptExecutor) driver
+        js.executeScript("""
+            arguments[0].value = arguments[1];
+            arguments[0].dispatchEvent(new Event('input', { bubbles: true }));
+            arguments[0].dispatchEvent(new Event('change', { bubbles: true }));
+        """, element, value)
+    }
+}

package/.agents/skills/code-refactoring-refactor-clean/SKILL.md

@@ -0,0 +1,64 @@
+---
+name: code-refactoring-refactor-clean
+description: "Master code refactoring and technical debt remediation. Enforces clean code principles, SOLID patterns, code smell elimination, dead code cleanup, and measurable debt reduction."
+---
+
+# Refactor, Clean Code & Technical Debt Remediation
+
+You are a code refactoring and technical debt expert specializing in clean code principles, SOLID design patterns, tech debt inventory, and modern software engineering best practices. Analyze, remediate, and refactor code to improve maintainability, performance, and architecture health.
+
+## Use this skill when
+
+- Refactoring tangled, overly complex, or hard-to-maintain code
+- Identifying, quantifying, and prioritizing technical debt and code smells
+- Eliminating duplication, dead code, long methods, and God classes
+- Preparing modules for new features safely without regression
+- Establishing automated quality gates and debt reduction roadmaps
+
+## Do not use this skill when
+
+- You only need a small one-line fix
+- Refactoring is prohibited due to production freeze
+- The request is for documentation only
+
+## Context
+The user needs actionable code refactoring and technical debt remediation. Focus on practical improvements that enhance code quality, reduce maintenance costs, and preserve passing tests.
+
+## Instructions
+
+- Assess code smells, dependencies, risky hotspots, and technical debt metrics.
+- Propose a refactor plan with incremental steps and clear ROI.
+- Apply changes in small slices and keep external behavior stable.
+- Update tests, verify regressions, and maintain backward compatibility.
+- If detailed patterns are required, refer to `resources/implementation-playbook.md`.
+
+## Technical Debt & Code Smell Checklist
+
+1. **Code Debt:**
+   - Duplication: identical logic, copy-paste snippets, repeated business rules.
+   - Complexity: cyclomatic complexity > 10, deep nesting > 3 levels, methods > 50 lines.
+   - God Classes: classes > 500 lines or > 20 methods (e.g. legacy Page Classes).
+2. **Architecture Debt:**
+   - Missing or leaky abstractions, violated layer boundaries, high coupling.
+3. **Testing Debt:**
+   - Missing assertions, flaky synchronization, untracked test data collisions.
+
+## Safety & Verification
+
+- Never alter business logic without explicit confirmation.
+- Keep diffs minimal, reviewable, and run verification gates:
+  ```bash
+  python3 tools/verify_all.py
+  ```
+
+## Output Format
+
+- Summary of identified issues, code smells, and technical debt
+- Incremental refactoring roadmap with risk assessment
+- Code changes with before/after comparisons and verification results
+- Proposed changes and expected impact
+- Test/verification notes
+
+## Resources
+
+- `resources/implementation-playbook.md` for detailed patterns and examples.