synabun 2026.4.26-beta.11 → 2026.4.26-beta.13

package/neural-interface/public/shared/ui-update.js

@@ -201,10 +201,9 @@ function openUpdateModal() {
       ? 'Installing from npm.'
       : (installPlan.manualHint || 'Open the SynaBun repository for the correct update path.');
     const autoRestartControl = canAutoUpdate ? `
-      <label class="update-skip-label" style="margin:14px 0 8px;display:flex;align-items:center;gap:8px;cursor:pointer">
-        <input type="checkbox" id="update-auto-restart" checked>
-        <span>Relaunch SynaBun after update</span>
-      </label>` : '';
+      <p style="font-size:11px;color:var(--t-muted);opacity:.75;margin:10px 0 0">
+        SynaBun will relaunch automatically after the update finishes.
+      </p>` : '';
     const manualButton = canAutoUpdate ? `
         <button class="action-btn action-btn--ghost" id="update-manual" title="Run the command yourself in your own terminal">Manual</button>` : '';
     const updateNowButton = canAutoUpdate ? `
@@ -293,8 +292,6 @@ function openUpdateModal() {
       overlay.querySelector('#update-manual-note').style.display = '';
       const runNow = overlay.querySelector('#update-run-now');
       if (runNow) runNow.style.display = 'none';
-      const autoRestartLabel = overlay.querySelector('#update-auto-restart')?.closest('label');
-      if (autoRestartLabel) autoRestartLabel.style.display = 'none';
     });
 
     // Skip checkbox
@@ -313,8 +310,8 @@ function openUpdateModal() {
     const canAutoUpdate = installPlan.canAutoUpdate === true;
     const repoUrl = installPlan.openUrl || SYNABUN_GITHUB_URL;
 
-    const autoRestartCb = overlay.querySelector('#update-auto-restart');
-    const autoRestart = !!autoRestartCb?.checked;
+    // Auto-restart is always on; server forces it true regardless of payload.
+    const autoRestart = true;
 
     const runBtn = overlay.querySelector('#update-run-now');
     const backBtn = overlay.querySelector('#update-back');
@@ -361,7 +358,7 @@ function openUpdateModal() {
       icon.className = 'update-backup-icon';
       icon.textContent = '✓';
       icon.style.color = '#34c759';
-      text.innerHTML = `<strong>Updater terminal launched</strong><span class="update-run-detail">SynaBun is shutting down so npm can replace the package. Watch the terminal for install progress${autoRestart ? '; SynaBun will relaunch when it finishes.' : '; run <code>synabun</code> when it finishes.'}</span><span class="update-run-hint">If no terminal window appears, run <code>${esc(installPlan.displayCommand || 'npm i -g synabun@latest')}</code> manually.</span>`;
+      text.innerHTML = `<strong>Updater terminal launched</strong><span class="update-run-detail">SynaBun is shutting down so npm can replace the package. Watch the terminal for install progress; SynaBun will relaunch automatically when it finishes.</span><span class="update-run-hint">If no terminal window appears, run <code>${esc(installPlan.displayCommand || 'npm i -g synabun@latest')}</code> manually.</span>`;
       runBtn.innerHTML = 'Updater running…';
 
       // Server is shutting down. Optionally redirect to a friendly offline

package/neural-interface/server.js

@@ -1552,7 +1552,7 @@ app.put('/api/settings', (req, res) => {
 // leaving spawned children orphaned (opencode sidecar, agents, _sidecarProcess
 // CLI links, pty terminals, cloudflare tunnel). On Windows those orphans
 // kept file handles inside neural-interface/ open, causing EBUSY errors when
-// `npm i -g synabun@latest` tried to rename the package directory.
+// `npm i -g synabun@latest` tried to rename the package directory.
 //
 // gracefulShutdown() centralizes shutdown so /api/server/restart,
 // /api/server/shutdown, and the new /api/system/run-update all release
@@ -1598,7 +1598,11 @@ async function gracefulShutdown(reason = 'shutdown') {
   // Synabun spawns CLI links, pty terminals, cloudflare tunnel etc. that may
   // not be reachable through the registries above. The taskkill /T flag walks
   // the process tree and terminates every descendant.
-  if (process.platform === 'win32') {
+  //
+  // Do not run this for click-to-update. The updater terminal is deliberately
+  // launched before this server exits; taskkill /T would kill that brand-new
+  // terminal too, which looks like a brief blink and no update on Windows.
+  if (process.platform === 'win32' && reason !== 'run-update') {
     try {
       // Use spawn(detached) so taskkill survives our own exit and finishes
       // killing children even if we exit before it completes.
@@ -1639,6 +1643,42 @@ function shellSingleQuote(s) {
   return `'${String(s).replace(/'/g, `'\\''`)}'`;
 }
 
+function collectWindowsDescendantPids(rootPid) {
+  if (process.platform !== 'win32' || !rootPid) return [];
+  try {
+    const script = [
+      `$root=${Number(rootPid)}`,
+      '$procs=Get-CimInstance Win32_Process | Select-Object ProcessId,ParentProcessId',
+      '$seen=@{}',
+      '$front=@($root)',
+      '$out=@()',
+      'while ($front.Count -gt 0) {',
+      '  $next=@()',
+      '  foreach ($p in $procs) {',
+      '    if ($front -contains $p.ParentProcessId -and -not $seen.ContainsKey($p.ProcessId)) {',
+      '      $seen[$p.ProcessId]=$true',
+      '      $out += $p.ProcessId',
+      '      $next += $p.ProcessId',
+      '    }',
+      '  }',
+      '  $front=$next',
+      '}',
+      '$out -join ","',
+    ].join('; ');
+    const result = spawnSync('powershell.exe', ['-NoProfile', '-NonInteractive', '-Command', script], {
+      encoding: 'utf8',
+      windowsHide: true,
+      timeout: 5000,
+    });
+    const out = result.status === 0 ? String(result.stdout || '').trim() : '';
+    return out
+      ? out.split(',').map(v => Number(v)).filter(pid => Number.isFinite(pid) && pid > 0 && pid !== rootPid)
+      : [];
+  } catch {
+    return [];
+  }
+}
+
 function cleanupOldUpdaterStages(baseDir) {
   try {
     if (!existsSync(baseDir)) return;
@@ -1653,7 +1693,7 @@ function cleanupOldUpdaterStages(baseDir) {
   } catch {}
 }
 
-function stageSynabunUpdater({ installPlan, serverPid, autoRestart }) {
+function stageSynabunUpdater({ installPlan, serverPid, autoRestart, cleanupPids = [] }) {
   const sourceUpdater = resolve(PACKAGE_ROOT, 'updater.mjs');
   if (!existsSync(sourceUpdater)) {
     throw new Error(`updater.mjs not found at ${sourceUpdater}. SynaBun install may be corrupt - reinstall manually: ${installPlan.displayCommand}`);
@@ -1680,18 +1720,25 @@ function stageSynabunUpdater({ installPlan, serverPid, autoRestart }) {
     current: installPlan.current,
     target: installPlan.target,
     channel: installPlan.channel,
+    cleanupPids,
   };
   writeFileSync(payloadPath, JSON.stringify(payload, null, 2) + '\n', 'utf8');
 
   if (process.platform === 'win32') {
+    const nodeBin = String(process.execPath || 'node').replace(/"/g, '');
     writeFileSync(runnerPath, [
       '@echo off',
       'setlocal enableextensions',
+      'chcp 65001 >nul 2>&1',
       'title SynaBun Updater',
       'cd /d "%~dp0"',
       'set "EXIT_CODE=0"',
-      'set "NODE_BIN=node"',
+      `set "NODE_BIN=${nodeBin}"`,
       'if defined SYNABUN_NODE_BIN set "NODE_BIN=%SYNABUN_NODE_BIN%"',
+      'echo SynaBun Updater starting...',
+      'echo Node:    %NODE_BIN%',
+      'echo Stage:   %~dp0',
+      'echo.',
       '"%NODE_BIN%" "%~dp0updater.mjs" --payload "%~dp0payload.json" --no-hold',
       'set "EXIT_CODE=%ERRORLEVEL%"',
       'echo.',
@@ -1739,51 +1786,60 @@ function stageSynabunUpdater({ installPlan, serverPid, autoRestart }) {
 // can lock the directory npm is trying to replace.
 app.post('/api/system/run-update', async (req, res) => {
   try {
-    const autoRestart = !!req.body?.autoRestart;
+    // Auto-restart is always on — running the click-to-update flow implies the
+    // user wants the new version live without a manual relaunch step.
+    const autoRestart = true;
 
     if (!_synabunUpdateCache.checkedAt) {
       try { await checkSynabunUpdate(); } catch {}
-    }
-    const installPlan = _synabunUpdateCache.installPlan;
-    if (!_synabunUpdateCache.updateAvailable || !installPlan) {
-      return res.status(409).json({ error: 'No SynaBun update is currently available.' });
-    }
-    if (installPlan.canAutoUpdate === false) {
-      return res.status(409).json({
-        error: installPlan.manualHint || `This installation cannot be auto-updated. Open ${installPlan.openUrl || SYNABUN_GITHUB_REPO_URL}`,
-        installPlan,
-        openUrl: installPlan.openUrl || SYNABUN_GITHUB_REPO_URL,
-      });
-    }
-    if (!installPlan.installSpec) {
-      return res.status(500).json({ error: 'SynaBun update plan is missing an npm install target.' });
-    }
-
-    const plat = process.platform;
+    }
+    const installPlan = _synabunUpdateCache.installPlan;
+    if (!_synabunUpdateCache.updateAvailable || !installPlan) {
+      return res.status(409).json({ error: 'No SynaBun update is currently available.' });
+    }
+    if (installPlan.canAutoUpdate === false) {
+      return res.status(409).json({
+        error: installPlan.manualHint || `This installation cannot be auto-updated. Open ${installPlan.openUrl || SYNABUN_GITHUB_REPO_URL}`,
+        installPlan,
+        openUrl: installPlan.openUrl || SYNABUN_GITHUB_REPO_URL,
+      });
+    }
+    if (!installPlan.installSpec) {
+      return res.status(500).json({ error: 'SynaBun update plan is missing an npm install target.' });
+    }
+
+    const plat = process.platform;
     const serverPid = process.pid;
-    const staged = stageSynabunUpdater({ installPlan, serverPid, autoRestart });
+    const cleanupPids = collectWindowsDescendantPids(serverPid);
+    const staged = stageSynabunUpdater({ installPlan, serverPid, autoRestart, cleanupPids });
 
     let spawned = null;
     let launchError = null;
 
-    if (plat === 'win32') {
-      try {
-        spawned = spawn('powershell.exe', [
-          '-NoProfile',
-          '-ExecutionPolicy', 'Bypass',
-          '-Command',
-          '$p=$env:SYNABUN_UPDATER_RUNNER; $w=$env:SYNABUN_UPDATER_CWD; $cmd=$env:ComSpec; if (-not $cmd) { $cmd="cmd.exe" }; Start-Process -FilePath $cmd -ArgumentList @("/k", "`"$p`"") -WorkingDirectory $w -WindowStyle Normal',
-        ], {
+    if (plat === 'win32') {
+      // Use cmd's `start` builtin to spawn a fresh visible console.
+      // Prior implementation used PowerShell + Start-Process -ArgumentList,
+      // which re-quoted the runner path and produced `cmd /k """C:\path\..."""`
+      // — cmd's quote-stripping then mangled it and the new window died before
+      // running anything (visible to users as a brief blink). `cmd /c start ""
+      // /D <dir> <runner>` is the canonical, reliable way to launch a fresh
+      // console window on Windows.
+      try {
+        const comSpec = process.env.ComSpec || 'cmd.exe';
+        spawned = spawn(comSpec, [
+          '/c', 'start',
+          '""',                        // empty title — required when next token is quoted path
+          '/D', staged.stageDir,       // working dir for new console
+          staged.runnerPath,           // batch file to run in new window
+        ], {
           cwd: staged.stageDir,
           shell: false,
           detached: true,
           stdio: 'ignore',
-          windowsHide: true,
+          windowsHide: true,           // hides only the wrapper cmd.exe; new console stays visible
           env: {
             ...process.env,
             SYNABUN_NODE_BIN: process.execPath,
-            SYNABUN_UPDATER_RUNNER: staged.runnerPath,
-            SYNABUN_UPDATER_CWD: staged.stageDir,
           },
         });
       } catch (err) { launchError = err; }
@@ -4594,7 +4650,7 @@ function stopOpencodeServer() {
   // On Windows `process.kill(pid, 'SIGTERM')` is unreliable for non-Node
   // children (cmd.exe shells, opencode native binaries). Use taskkill /T /F
   // to walk the process tree and force-terminate every descendant.
-  // This is the recurring source of EBUSY errors during `npm i -g
+  // This is the recurring source of EBUSY errors during `npm i -g
   // synabun@latest` — opencode-ai's `serve` process survives parent SynaBun
   // exit and keeps file handles inside neural-interface/ open.
   const winKill = (pid) => {
@@ -10434,7 +10490,7 @@ app.post('/api/search/memories', async (req, res) => {
 // when EITHER source is newer than the installed version (catches one-sided
 // publishes — e.g. release tagged on GitHub before npm publish completes).
 
-let _synabunUpdateCache = {
+let _synabunUpdateCache = {
   current: null,
   installedChannel: 'stable',    // 'stable' | 'prerelease'
   npmLatestStable: null,         // dist-tags.latest
@@ -10448,97 +10504,97 @@ let _synabunUpdateCache = {
   gitUpdateAvailable: false,
   updateAvailable: false,        // npmUpdateAvailable || gitUpdateAvailable
   source: null,                  // 'npm' | 'github' | 'both' | null
-  installPlan: null,             // server-owned npm/GitHub action target for click-to-update
+  installPlan: null,             // server-owned npm/GitHub action target for click-to-update
   checkedAt: null,
   npmError: null,
-  gitError: null,
-};
-
-const SYNABUN_GITHUB_REPO_URL = 'https://github.com/danilokhury/Synabun';
-
-function isSynabunGitHubRemote(remoteText) {
-  return /github\.com[:/]danilokhury\/Synabun(?:\.git)?(?:[\s)]|$)/i.test(String(remoteText || ''));
-}
-
-function detectSynabunInstallSource() {
-  const normalizedRoot = PACKAGE_ROOT.replace(/\\/g, '/');
-  if (/\/node_modules\/synabun$/i.test(normalizedRoot)) {
-    return { kind: 'npm-global' };
-  }
-
-  try {
-    const inside = execSync('git rev-parse --is-inside-work-tree', {
-      cwd: PACKAGE_ROOT,
-      encoding: 'utf8',
-      stdio: ['ignore', 'pipe', 'ignore'],
-      timeout: 2000,
-    }).trim();
-    if (inside === 'true') {
-      let remote = '';
-      let remotes = '';
-      try {
-        remote = execSync('git remote get-url origin', {
-          cwd: PACKAGE_ROOT,
-          encoding: 'utf8',
-          stdio: ['ignore', 'pipe', 'ignore'],
-          timeout: 2000,
-        }).trim();
-      } catch {}
-      try {
-        remotes = execSync('git remote -v', {
-          cwd: PACKAGE_ROOT,
-          encoding: 'utf8',
-          stdio: ['ignore', 'pipe', 'ignore'],
-          timeout: 2000,
-        }).trim();
-      } catch {}
-      if (isSynabunGitHubRemote(`${remote}\n${remotes}`)) {
-        const firstRemote = remote || remotes.split(/\s+/).find(part => isSynabunGitHubRemote(part)) || null;
-        return { kind: 'github-clone', remote: firstRemote };
-      }
-      return { kind: 'git-clone', remote: remote || null };
-    }
-  } catch {}
-
-  return { kind: 'local' };
-}
-
-function buildSynabunInstallPlan({ current, installedChannel, latest, updateAvailable }) {
-  if (!updateAvailable) return null;
-
-  const installSource = detectSynabunInstallSource();
-  if (installSource.kind !== 'npm-global') {
-    const clonedHint = installSource.kind === 'github-clone'
-      ? 'This SynaBun install is a GitHub checkout. Open the repository to pull or reinstall from the correct source.'
-      : 'This SynaBun install was not detected as npm. Open the repository for the correct update path.';
-    return {
-      source: 'github',
-      installSource: installSource.kind,
-      canAutoUpdate: false,
-      current,
-      target: latest,
-      channel: installedChannel,
-      displayCommand: SYNABUN_GITHUB_REPO_URL,
-      openUrl: SYNABUN_GITHUB_REPO_URL,
-      manualCommand: installSource.kind === 'github-clone' ? 'git pull --ff-only' : null,
-      manualHint: clonedHint,
-      remote: installSource.remote,
-    };
-  }
-
-  const installSpec = 'synabun@latest';
-  return {
-    source: 'npm',
-    installSource: installSource.kind,
-    canAutoUpdate: true,
-    current,
-    target: latest,
-    channel: installedChannel,
-    installSpec,
-    displayCommand: 'npm i -g synabun@latest',
-    npmTag: 'latest',
-  };
-}
+  gitError: null,
+};
+
+const SYNABUN_GITHUB_REPO_URL = 'https://github.com/danilokhury/Synabun';
+
+function isSynabunGitHubRemote(remoteText) {
+  return /github\.com[:/]danilokhury\/Synabun(?:\.git)?(?:[\s)]|$)/i.test(String(remoteText || ''));
+}
+
+function detectSynabunInstallSource() {
+  const normalizedRoot = PACKAGE_ROOT.replace(/\\/g, '/');
+  if (/\/node_modules\/synabun$/i.test(normalizedRoot)) {
+    return { kind: 'npm-global' };
+  }
+
+  try {
+    const inside = execSync('git rev-parse --is-inside-work-tree', {
+      cwd: PACKAGE_ROOT,
+      encoding: 'utf8',
+      stdio: ['ignore', 'pipe', 'ignore'],
+      timeout: 2000,
+    }).trim();
+    if (inside === 'true') {
+      let remote = '';
+      let remotes = '';
+      try {
+        remote = execSync('git remote get-url origin', {
+          cwd: PACKAGE_ROOT,
+          encoding: 'utf8',
+          stdio: ['ignore', 'pipe', 'ignore'],
+          timeout: 2000,
+        }).trim();
+      } catch {}
+      try {
+        remotes = execSync('git remote -v', {
+          cwd: PACKAGE_ROOT,
+          encoding: 'utf8',
+          stdio: ['ignore', 'pipe', 'ignore'],
+          timeout: 2000,
+        }).trim();
+      } catch {}
+      if (isSynabunGitHubRemote(`${remote}\n${remotes}`)) {
+        const firstRemote = remote || remotes.split(/\s+/).find(part => isSynabunGitHubRemote(part)) || null;
+        return { kind: 'github-clone', remote: firstRemote };
+      }
+      return { kind: 'git-clone', remote: remote || null };
+    }
+  } catch {}
+
+  return { kind: 'local' };
+}
+
+function buildSynabunInstallPlan({ current, installedChannel, latest, updateAvailable }) {
+  if (!updateAvailable) return null;
+
+  const installSource = detectSynabunInstallSource();
+  if (installSource.kind !== 'npm-global') {
+    const clonedHint = installSource.kind === 'github-clone'
+      ? 'This SynaBun install is a GitHub checkout. Open the repository to pull or reinstall from the correct source.'
+      : 'This SynaBun install was not detected as npm. Open the repository for the correct update path.';
+    return {
+      source: 'github',
+      installSource: installSource.kind,
+      canAutoUpdate: false,
+      current,
+      target: latest,
+      channel: installedChannel,
+      displayCommand: SYNABUN_GITHUB_REPO_URL,
+      openUrl: SYNABUN_GITHUB_REPO_URL,
+      manualCommand: installSource.kind === 'github-clone' ? 'git pull --ff-only' : null,
+      manualHint: clonedHint,
+      remote: installSource.remote,
+    };
+  }
+
+  const installSpec = 'synabun@latest';
+  return {
+    source: 'npm',
+    installSource: installSource.kind,
+    canAutoUpdate: true,
+    current,
+    target: latest,
+    channel: installedChannel,
+    installSpec,
+    displayCommand: 'npm i -g synabun@latest',
+    npmTag: 'latest',
+  };
+}
 
 async function checkSynabunUpdate() {
   let current = _synabunUpdateCache.current;
@@ -10667,12 +10723,12 @@ async function checkSynabunUpdate() {
   else if (npmUpdateAvailable)                   source = 'npm';
   else if (gitUpdateAvailable)                   source = 'github';
 
-  const installPlan = buildSynabunInstallPlan({
-    current,
-    installedChannel,
-    latest,
-    updateAvailable,
-  });
+  const installPlan = buildSynabunInstallPlan({
+    current,
+    installedChannel,
+    latest,
+    updateAvailable,
+  });
 
   _synabunUpdateCache = {
     current,
@@ -23809,7 +23865,7 @@ setInterval(saveSessionSnapshot, SESSION_SNAPSHOT_INTERVAL_MS);
 // Manual termination paths (Ctrl+C, kill, parent shell exit) all flow through
 // gracefulShutdown — same teardown the in-app restart/shutdown/update paths
 // use. Without this, hand-killed servers still leave orphaned opencode +
-// agent children holding file handles, which blocks `npm i -g synabun`.
+// agent children holding file handles, which blocks `npm i -g synabun`.
 process.on('SIGINT', async () => {
   console.log('\n[server] SIGINT received.');
   await gracefulShutdown('sigint');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "synabun",
-  "version": "2026.4.26-beta.11",
+  "version": "2026.4.26-beta.13",
   "description": "Persistent vector memory for AI assistants",
   "license": "Apache-2.0",
   "author": "The SynaBun Authors",

package/updater.mjs

@@ -20,6 +20,7 @@ const legacyTag = sanitizeTag(args.tag || 'latest');
 const installSpec = sanitizeInstallSpec(payload.installSpec || args['install-spec'] || `synabun@${legacyTag}`);
 const displayCommand = payload.displayCommand || `npm i -g ${installSpec}`;
 const serverPid = toPid(payload.serverPid ?? args.pid);
+const cleanupPids = sanitizePidList(payload.cleanupPids).filter(pid => pid !== serverPid && pid !== process.pid);
 const autoRestart = payload.autoRestart != null ? !!payload.autoRestart : !!args.restart;
 const safeCwd = payload.cwd || process.cwd();
 const noHold = !!args['no-hold'];
@@ -46,8 +47,8 @@ try {
     if (exited) {
       console.log('  Server exited.\n');
     } else {
-      console.warn('  Server still alive after 30s - forcing kill.\n');
-      forceKillTree(serverPid);
+      console.warn('  Server still alive after 30s - forcing server process kill.\n');
+      forceKillPid(serverPid);
       await sleep(1500);
     }
   } else {
@@ -55,7 +56,15 @@ try {
   }
 
   await sleep(1500);
-  if (isWin && serverPid) forceKillTree(serverPid);
+  if (cleanupPids.length) {
+    console.log(`Cleaning up ${cleanupPids.length} pre-existing child process${cleanupPids.length === 1 ? '' : 'es'}...`);
+    for (const pid of cleanupPids) {
+      if (!isPidAlive(pid)) continue;
+      forceKillTree(pid);
+    }
+    await sleep(1000);
+    console.log('  Cleanup complete.\n');
+  }
 
   console.log(`Running: ${displayCommand}\n`);
   console.log(HR);
@@ -143,6 +152,19 @@ function toPid(raw) {
   return Number.isFinite(pid) && pid > 0 ? pid : null;
 }
 
+function sanitizePidList(raw) {
+  if (!Array.isArray(raw)) return [];
+  const out = [];
+  const seen = new Set();
+  for (const item of raw) {
+    const pid = toPid(item);
+    if (!pid || seen.has(pid)) continue;
+    seen.add(pid);
+    out.push(pid);
+  }
+  return out;
+}
+
 async function waitForExit(pid, timeoutMs) {
   const deadline = Date.now() + timeoutMs;
   while (Date.now() < deadline) {
@@ -176,6 +198,20 @@ function forceKillTree(pid) {
   } catch {}
 }
 
+function forceKillPid(pid) {
+  try {
+    if (isWin) {
+      spawnSync('taskkill', ['/pid', String(pid), '/F'], {
+        shell: true,
+        windowsHide: true,
+        stdio: 'ignore',
+      });
+    } else {
+      try { process.kill(pid, 'SIGKILL'); } catch {}
+    }
+  } catch {}
+}
+
 function printFixTips(command) {
   console.error('Common fixes:');
   if (isWin) {