synabun 2026.4.26-beta.11 → 2026.4.26-beta.12

package/neural-interface/server.js

@@ -1594,11 +1594,15 @@ async function gracefulShutdown(reason = 'shutdown') {
 
   try { closeDb(); } catch {}
 
-  // 5. Belt-and-suspenders: tree-kill THIS process's descendants on Windows.
-  // Synabun spawns CLI links, pty terminals, cloudflare tunnel etc. that may
-  // not be reachable through the registries above. The taskkill /T flag walks
-  // the process tree and terminates every descendant.
-  if (process.platform === 'win32') {
+  // 5. Belt-and-suspenders: tree-kill THIS process's descendants on Windows.
+  // Synabun spawns CLI links, pty terminals, cloudflare tunnel etc. that may
+  // not be reachable through the registries above. The taskkill /T flag walks
+  // the process tree and terminates every descendant.
+  //
+  // Do not run this for click-to-update. The updater terminal is deliberately
+  // launched before this server exits; taskkill /T would kill that brand-new
+  // terminal too, which looks like a brief blink and no update on Windows.
+  if (process.platform === 'win32' && reason !== 'run-update') {
     try {
       // Use spawn(detached) so taskkill survives our own exit and finishes
       // killing children even if we exit before it completes.
@@ -1635,9 +1639,45 @@ app.post('/api/server/shutdown', async (req, res) => {
   }, 200);
 });
 
-function shellSingleQuote(s) {
-  return `'${String(s).replace(/'/g, `'\\''`)}'`;
-}
+function shellSingleQuote(s) {
+  return `'${String(s).replace(/'/g, `'\\''`)}'`;
+}
+
+function collectWindowsDescendantPids(rootPid) {
+  if (process.platform !== 'win32' || !rootPid) return [];
+  try {
+    const script = [
+      `$root=${Number(rootPid)}`,
+      '$procs=Get-CimInstance Win32_Process | Select-Object ProcessId,ParentProcessId',
+      '$seen=@{}',
+      '$front=@($root)',
+      '$out=@()',
+      'while ($front.Count -gt 0) {',
+      '  $next=@()',
+      '  foreach ($p in $procs) {',
+      '    if ($front -contains $p.ParentProcessId -and -not $seen.ContainsKey($p.ProcessId)) {',
+      '      $seen[$p.ProcessId]=$true',
+      '      $out += $p.ProcessId',
+      '      $next += $p.ProcessId',
+      '    }',
+      '  }',
+      '  $front=$next',
+      '}',
+      '$out -join ","',
+    ].join('; ');
+    const result = spawnSync('powershell.exe', ['-NoProfile', '-NonInteractive', '-Command', script], {
+      encoding: 'utf8',
+      windowsHide: true,
+      timeout: 5000,
+    });
+    const out = result.status === 0 ? String(result.stdout || '').trim() : '';
+    return out
+      ? out.split(',').map(v => Number(v)).filter(pid => Number.isFinite(pid) && pid > 0 && pid !== rootPid)
+      : [];
+  } catch {
+    return [];
+  }
+}
 
 function cleanupOldUpdaterStages(baseDir) {
   try {
@@ -1653,7 +1693,7 @@ function cleanupOldUpdaterStages(baseDir) {
   } catch {}
 }
 
-function stageSynabunUpdater({ installPlan, serverPid, autoRestart }) {
+function stageSynabunUpdater({ installPlan, serverPid, autoRestart, cleanupPids = [] }) {
   const sourceUpdater = resolve(PACKAGE_ROOT, 'updater.mjs');
   if (!existsSync(sourceUpdater)) {
     throw new Error(`updater.mjs not found at ${sourceUpdater}. SynaBun install may be corrupt - reinstall manually: ${installPlan.displayCommand}`);
@@ -1678,20 +1718,22 @@ function stageSynabunUpdater({ installPlan, serverPid, autoRestart }) {
     displayCommand: installPlan.displayCommand,
     source: installPlan.source,
     current: installPlan.current,
-    target: installPlan.target,
-    channel: installPlan.channel,
-  };
+    target: installPlan.target,
+    channel: installPlan.channel,
+    cleanupPids,
+  };
   writeFileSync(payloadPath, JSON.stringify(payload, null, 2) + '\n', 'utf8');
 
-  if (process.platform === 'win32') {
-    writeFileSync(runnerPath, [
-      '@echo off',
-      'setlocal enableextensions',
-      'title SynaBun Updater',
-      'cd /d "%~dp0"',
-      'set "EXIT_CODE=0"',
-      'set "NODE_BIN=node"',
-      'if defined SYNABUN_NODE_BIN set "NODE_BIN=%SYNABUN_NODE_BIN%"',
+  if (process.platform === 'win32') {
+    const nodeBin = String(process.execPath || 'node').replace(/"/g, '');
+    writeFileSync(runnerPath, [
+      '@echo off',
+      'setlocal enableextensions',
+      'title SynaBun Updater',
+      'cd /d "%~dp0"',
+      'set "EXIT_CODE=0"',
+      `set "NODE_BIN=${nodeBin}"`,
+      'if defined SYNABUN_NODE_BIN set "NODE_BIN=%SYNABUN_NODE_BIN%"',
       '"%NODE_BIN%" "%~dp0updater.mjs" --payload "%~dp0payload.json" --no-hold',
       'set "EXIT_CODE=%ERRORLEVEL%"',
       'echo.',
@@ -1761,7 +1803,8 @@ app.post('/api/system/run-update', async (req, res) => {
 
     const plat = process.platform;
     const serverPid = process.pid;
-    const staged = stageSynabunUpdater({ installPlan, serverPid, autoRestart });
+    const cleanupPids = collectWindowsDescendantPids(serverPid);
+    const staged = stageSynabunUpdater({ installPlan, serverPid, autoRestart, cleanupPids });
 
     let spawned = null;
     let launchError = null;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "synabun",
-  "version": "2026.4.26-beta.11",
+  "version": "2026.4.26-beta.12",
   "description": "Persistent vector memory for AI assistants",
   "license": "Apache-2.0",
   "author": "The SynaBun Authors",

package/updater.mjs

@@ -20,6 +20,7 @@ const legacyTag = sanitizeTag(args.tag || 'latest');
 const installSpec = sanitizeInstallSpec(payload.installSpec || args['install-spec'] || `synabun@${legacyTag}`);
 const displayCommand = payload.displayCommand || `npm i -g ${installSpec}`;
 const serverPid = toPid(payload.serverPid ?? args.pid);
+const cleanupPids = sanitizePidList(payload.cleanupPids).filter(pid => pid !== serverPid && pid !== process.pid);
 const autoRestart = payload.autoRestart != null ? !!payload.autoRestart : !!args.restart;
 const safeCwd = payload.cwd || process.cwd();
 const noHold = !!args['no-hold'];
@@ -46,8 +47,8 @@ try {
     if (exited) {
       console.log('  Server exited.\n');
     } else {
-      console.warn('  Server still alive after 30s - forcing kill.\n');
-      forceKillTree(serverPid);
+      console.warn('  Server still alive after 30s - forcing server process kill.\n');
+      forceKillPid(serverPid);
       await sleep(1500);
     }
   } else {
@@ -55,7 +56,15 @@ try {
   }
 
   await sleep(1500);
-  if (isWin && serverPid) forceKillTree(serverPid);
+  if (cleanupPids.length) {
+    console.log(`Cleaning up ${cleanupPids.length} pre-existing child process${cleanupPids.length === 1 ? '' : 'es'}...`);
+    for (const pid of cleanupPids) {
+      if (!isPidAlive(pid)) continue;
+      forceKillTree(pid);
+    }
+    await sleep(1000);
+    console.log('  Cleanup complete.\n');
+  }
 
   console.log(`Running: ${displayCommand}\n`);
   console.log(HR);
@@ -143,6 +152,19 @@ function toPid(raw) {
   return Number.isFinite(pid) && pid > 0 ? pid : null;
 }
 
+function sanitizePidList(raw) {
+  if (!Array.isArray(raw)) return [];
+  const out = [];
+  const seen = new Set();
+  for (const item of raw) {
+    const pid = toPid(item);
+    if (!pid || seen.has(pid)) continue;
+    seen.add(pid);
+    out.push(pid);
+  }
+  return out;
+}
+
 async function waitForExit(pid, timeoutMs) {
   const deadline = Date.now() + timeoutMs;
   while (Date.now() < deadline) {
@@ -176,6 +198,20 @@ function forceKillTree(pid) {
   } catch {}
 }
 
+function forceKillPid(pid) {
+  try {
+    if (isWin) {
+      spawnSync('taskkill', ['/pid', String(pid), '/F'], {
+        shell: true,
+        windowsHide: true,
+        stdio: 'ignore',
+      });
+    } else {
+      try { process.kill(pid, 'SIGKILL'); } catch {}
+    }
+  } catch {}
+}
+
 function printFixTips(command) {
   console.error('Common fixes:');
   if (isWin) {