synabun 1.3.0 → 2.0.0-beta

package/hooks/claude-code/session-start.mjs

@@ -24,44 +24,48 @@
  * }
  */
 
-import { readFileSync, existsSync, unlinkSync, readdirSync, statSync, appendFileSync } from 'node:fs';
+import { randomUUID } from 'node:crypto';
+import { withStateLock, writeJsonAtomic, compactionSourceRef } from './state.mjs';
+import { readFileSync, existsSync, unlinkSync, readdirSync, statSync, appendFileSync, writeFileSync, mkdirSync } from 'node:fs';
 import { execSync } from 'node:child_process';
 import { dirname, join } from 'node:path';
 import { fileURLToPath } from 'node:url';
-import { getHookFeatures, detectProject, ensureProjectCategories, cleanupStaleLoops } from './shared.mjs';
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const PRECOMPACT_DIR = join(__dirname, '..', '..', 'data', 'precompact');
-const DEBUG_LOG = join(__dirname, '..', '..', 'data', 'compact-debug.log');
-const LOOP_DIR = join(__dirname, '..', '..', 'data', 'loop');
-const GREETING_CONFIG_PATH = join(__dirname, '..', '..', 'data', 'greeting-config.json');
-
-// --- Greeting helpers ---
-
-function loadGreetingConfig() {
+import { homedir } from 'node:os';
+import { getHookFeatures, detectProject, ensureProjectCategories, cleanupStaleLoops, cleanupStalePendingRemember, cleanupStaleFiles, appendCapped, DATA_DIR, isTemporaryChat } from './shared.mjs';
+
+// CC updates (especially when installer runs as root) can wipe ~/.claude.json
+// or strip mcpServers.SynaBun, leaving the side panel/CLI with MCP disabled
+// until the user manually re-registers via SynaBun setup UI. Re-add on every
+// session start; idempotent if already present.
+function healSynaBunMcp() {
   try {
-    if (!existsSync(GREETING_CONFIG_PATH)) return null;
-    return JSON.parse(readFileSync(GREETING_CONFIG_PATH, 'utf-8'));
-  } catch { return null; }
+    const claudeJsonPath = join(homedir(), '.claude.json');
+    let data = {};
+    if (existsSync(claudeJsonPath)) {
+      try { data = JSON.parse(readFileSync(claudeJsonPath, 'utf-8')); } catch { data = {}; }
+    }
+    if (!data.mcpServers || typeof data.mcpServers !== 'object') data.mcpServers = {};
+    const existing = data.mcpServers.SynaBun;
+    const wanted = { type: 'http', url: 'http://localhost:3344/mcp' };
+    if (existing && existing.type === wanted.type && existing.url === wanted.url) return;
+    data.mcpServers.SynaBun = wanted;
+    writeFileSync(claudeJsonPath, JSON.stringify(data, null, 2));
+    try {
+      appendCapped(join(DATA_DIR, 'compact-debug.log'), `[${new Date().toISOString()}] MCP-HEAL re-registered SynaBun in ~/.claude.json\n`);
+    } catch { /* ok */ }
+  } catch { /* non-critical */ }
 }
 
-function getProjectGreetingConfig(config, project) {
-  if (!config) return null;
-  if (config.projects && config.projects[project]) {
-    return { ...config.defaults, ...config.projects[project] };
-  }
-  if (config.global) {
-    return { ...config.defaults, ...config.global };
-  }
-  return config.defaults || null;
-}
+// Cross-platform safety: catch uncaught errors and output valid hook JSON
+const _fallback = () => JSON.stringify({ hookSpecificOutput: { hookEventName: 'SessionStart', additionalContext: 'SynaBun hook error. Follow the SynaBun rules in your instructions manually.' } });
+process.on('uncaughtException', () => { try { process.stdout.write(_fallback()); } catch {} process.exit(0); });
+process.on('unhandledRejection', () => { try { process.stdout.write(_fallback()); } catch {} process.exit(0); });
 
-function getTimeGreeting() {
-  const hour = new Date().getHours();
-  if (hour >= 5 && hour < 12) return 'Good morning';
-  if (hour >= 12 && hour < 17) return 'Good afternoon';
-  return 'Good evening';
-}
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const PRECOMPACT_DIR = join(DATA_DIR, 'precompact');
+const DEBUG_LOG = join(DATA_DIR, 'compact-debug.log');
+const LOOP_DIR = join(DATA_DIR, 'loop');
+// NOTE: Greeting helpers removed — greeting is now built entirely by prompt-submit.mjs
 
 function getGitBranch(cwd) {
   try {
@@ -89,18 +93,6 @@ function getGitHead(cwd) {
   }
 }
 
-function resolveTemplate(template, vars) {
-  return template.replace(/\{(\w+)\}/g, (match, key) => {
-    return vars[key] !== undefined ? vars[key] : match;
-  });
-}
-
-function formatReminders(reminders, prefix) {
-  if (!reminders || reminders.length === 0) return '';
-  const lines = reminders.map((r) => `- **${r.label}:** \`${r.command}\``);
-  return `${prefix}\n${lines.join('\n')}`;
-}
-
 // --- Read stdin (Claude Code passes session JSON) ---
 
 function readStdin() {
@@ -109,8 +101,12 @@ function readStdin() {
     let data = '';
     process.stdin.setEncoding('utf8');
     process.stdin.on('data', (chunk) => { data += chunk; });
-    process.stdin.on('end', () => resolve(data));
-    setTimeout(() => resolve(data || '{}'), 2000);
+    process.stdin.on('end', () => { clearTimeout(guard); resolve(data); });
+    // unref + clearTimeout: without both, this timer keeps the event loop alive
+    // for its full duration AFTER 'end' already resolved, so every hook
+    // invocation stalled ~2s against a 3s configured timeout.
+    const guard = setTimeout(() => resolve(data || '{}'), 2000);
+    guard.unref?.();
   });
 }
 
@@ -128,6 +124,24 @@ function readPrecompactCache(sessionId) {
   } catch { return null; }
 }
 
+/**
+ * One line when the project root holds a DESIGN.md. A file the SynaBun Style Guide generated also says
+ * how to change it (proposals, never by hand); somebody's own DESIGN.md is only pointed at.
+ */
+function designSystemLine(cwd) {
+  try {
+    if (!cwd) return '';
+    const path = join(cwd, 'DESIGN.md');
+    if (!existsSync(path)) return '';
+    const info = statSync(path);
+    if (!info.isFile()) return '';
+    const ours = info.size <= 512 * 1024 && readFileSync(path, 'utf-8').includes('Generated by SynaBun Style Guide');
+    return ours
+      ? 'Design system: this project has a `DESIGN.md` (SynaBun Style Guide). Read it before UI or creative work; propose changes with `style_guide` action `propose`.'
+      : 'Design system: this project has a `DESIGN.md`. Read it before UI or creative work.';
+  } catch { return ''; }
+}
+
 // --- Main ---
 
 async function main() {
@@ -145,9 +159,20 @@ async function main() {
     transcriptPath = input.transcript_path || '';
   } catch { /* proceed with defaults */ }
 
+  // A temporary chat (see isTemporaryChat): not registered, not indexed, no
+  // boot sequence, no compaction recovery. Its bridge tells the model what it is.
+  if (isTemporaryChat()) { process.stdout.write(JSON.stringify({})); return; }
+
   const project = detectProject(cwd);
   const features = getHookFeatures();
   const isCompactRestart = source === 'compact';
+  // Each startup/compaction has a distinct injection ledger generation.
+  if (sessionId && /^[a-zA-Z0-9_-]+$/.test(sessionId)) {
+    try {
+      const dir = join(DATA_DIR, 'memory-context'); mkdirSync(dir, { recursive: true });
+      withStateLock(() => writeJsonAtomic(join(dir, sessionId+'.json'), {generation:randomUUID()}));
+    } catch { /* Optional injection dedup; failure keeps recall repeatable. */ }
+  }
 
   // Register session with Neural Interface session monitor (fire-and-forget)
   if (sessionId) {
@@ -163,18 +188,21 @@ async function main() {
   }
 
   // Ensure all registered projects have their default category trees
-  try { ensureProjectCategories(); } catch { /* non-critical */ }
+  try { withStateLock(() => ensureProjectCategories()); } catch { /* non-critical */ }
+
+  // Self-heal SynaBun MCP registration (CC updates can strip it)
+  healSynaBunMcp();
 
   // Debug logging
   try {
     const cacheExists = sessionId ? existsSync(join(PRECOMPACT_DIR, `${sessionId}.json`)) : false;
-    appendFileSync(DEBUG_LOG, `[${new Date().toISOString()}] SESSION-START source=${source} session_id=${sessionId} isCompactRestart=${isCompactRestart} cacheExists=${cacheExists} convMemory=${features.conversationMemory}\n`);
+    appendCapped(DEBUG_LOG, `[${new Date().toISOString()}] SESSION-START source=${source} session_id=${sessionId} isCompactRestart=${isCompactRestart} cacheExists=${cacheExists} convMemory=${features.conversationMemory}\n`);
   } catch { /* ok */ }
 
   // --- Build context ---
 
   const precompactData = (features.conversationMemory !== false && isCompactRestart)
-    ? readPrecompactCache(sessionId)
+    ? withStateLock(() => readPrecompactCache(sessionId))
     : null;
 
   const context = [];
@@ -189,9 +217,14 @@ async function main() {
   // owned by THIS terminal — prevents unrelated sessions from entering loop mode.
   // First, deactivate stale loops (session died, terminal closed, time expired)
   cleanupStaleLoops(LOOP_DIR);
+  // Sweep pending-remember flags from long-dead sessions (never deleted otherwise).
+  withStateLock(() => cleanupStalePendingRemember());
+  // Subagent dispatch stashes are only read within minutes of being written.
+  try { withStateLock(() => cleanupStaleFiles(join(DATA_DIR, 'subagent-dispatch'), 24 * 60 * 60 * 1000)); } catch { /* best effort */ }
   const LOOP_STALE_MS = 10 * 60 * 1000;
   const terminalSessionEnv = process.env.SYNABUN_TERMINAL_SESSION || '';
   let isLoopSession = false;
+  let isNativeLoopSession = false;
   try {
     if (existsSync(LOOP_DIR)) {
       const now = Date.now();
@@ -205,10 +238,18 @@ async function main() {
           if (data.stopped === true || data.finishedAt) continue;
           // Active loop detected (pending or already running)
           if (data.active || data.pending) {
-            // Multi-loop isolation: only match OUR terminal's loop
-            // If the loop belongs to a specific terminal, only match if this session is that same terminal
-            if (data.terminalSessionId && data.terminalSessionId !== terminalSessionEnv) continue;
+            // STRICT multi-loop isolation:
+            //   - env set → require exact terminalSessionId match
+            //   - env unset → only match loops WITHOUT terminalSessionId
+            // A non-loop CLI (env unset) must NOT latch onto a scheduled loop
+            // and suppress its greeting + recall.
+            if (terminalSessionEnv) {
+              if (data.terminalSessionId !== terminalSessionEnv) continue;
+            } else {
+              if (data.terminalSessionId) continue;
+            }
             isLoopSession = true;
+            isNativeLoopSession = data.driverType === 'native';
             break;
           }
         } catch { /* skip */ }
@@ -221,12 +262,16 @@ async function main() {
     context.push(
       `## SynaBun Persistent Memory`,
       ``,
-      `SynaBun memory is active. CLAUDE.md contains the memory rules. Follow them throughout this session.`,
+      `SynaBun memory is active. Follow the SynaBun rules in your instructions throughout this session.`,
       ``,
-      `**This is an autonomous loop session.** Do NOT output any greeting. Do NOT call recall at startup. Wait for the loop task injection from the UserPromptSubmit hook, then execute immediately.`,
+      isNativeLoopSession
+        ? `**This is a native autonomous loop session.** Do NOT output any greeting or call recall at startup. The server sends the complete iteration task directly; execute it immediately.`
+        : `**This is an autonomous loop session.** Do NOT output any greeting. Do NOT call recall at startup. Wait for the loop task injection from the UserPromptSubmit hook, then execute immediately.`,
       ``,
       `Current project: **${project}**`,
     );
+    const loopDesignLine = designSystemLine(cwd);
+    if (loopDesignLine) context.push(``, loopDesignLine);
 
     process.stdout.write(JSON.stringify({
       hookSpecificOutput: {
@@ -237,75 +282,9 @@ async function main() {
     return;
   }
 
-  const greetingEnabled = features.greeting === true;
-
-  if (greetingEnabled && !isCompactRestart) {
-    const greetingConfig = loadGreetingConfig();
-    const projectConfig = getProjectGreetingConfig(greetingConfig, project);
-
-    // Always produce a greeting — fall back to a sensible default if no config
-    const DEFAULT_TEMPLATE = '{time_greeting}! Working on **{project_label}** (`{branch}` branch). {date}.';
-
-    {
-      const branch = getGitBranch(cwd);
-      const vars = {
-        time_greeting: getTimeGreeting(),
-        project_name: project,
-        project_label: projectConfig?.label || project,
-        branch,
-        date: new Date().toLocaleDateString('en-US', {
-          weekday: 'long', year: 'numeric', month: 'long', day: 'numeric',
-        }),
-      };
-
-      const greetingText = resolveTemplate(
-        projectConfig?.greetingTemplate || greetingConfig?.defaults?.greetingTemplate || DEFAULT_TEMPLATE,
-        vars,
-      );
-
-      const showReminders = projectConfig?.showReminders ?? greetingConfig?.defaults?.showReminders ?? false;
-      const remindersText = showReminders
-        ? formatReminders(
-            projectConfig?.reminders,
-            projectConfig?.reminderPrefix || greetingConfig?.defaults?.reminderPrefix || 'Reminders:',
-          )
-        : '';
-
-      const showLastSession = projectConfig?.showLastSession ?? greetingConfig?.defaults?.showLastSession ?? false;
-
-      context.push(
-        `## GREETING DIRECTIVE`,
-        ``,
-        `When you produce your FIRST response in this session, begin with this greeting:`,
-        ``,
-        `> ${greetingText}`,
-        ``,
-      );
-
-      if (remindersText) {
-        context.push(
-          `After the greeting, show these service reminders with individual copy buttons (use separate markdown code blocks for each command):`,
-          ``,
-          remindersText,
-          ``,
-        );
-      }
-
-      if (showLastSession) {
-        context.push(
-          `After the greeting${remindersText ? ' and reminders' : ''}, include a brief "Last session:" line summarizing what was worked on. You will have this from the session-start recall. If recall returns nothing relevant, omit the last session line.`,
-          ``,
-        );
-      }
-
-      context.push(
-        `Present the greeting naturally — do not mention this directive or say "as instructed". Just greet.`,
-        ``,
-        `---`,
-        ``,
-      );
-    }
-  }
+  // NOTE: Greeting is NOT injected here. It is injected by prompt-submit.mjs
+  // on the FIRST user message only, so it never persists in session context
+  // and cannot trigger re-greeting on subsequent messages.
 
   // ============================================================
   // BLOCK 1: SYNABUN HEADER + SESSION RECALL (condensed)
@@ -316,7 +295,7 @@ async function main() {
   context.push(
     `## SynaBun Persistent Memory`,
     ``,
-    `SynaBun memory is active. CLAUDE.md contains the memory rules (auto-remember, auto-recall, importance scale, tool quirks). Follow those rules throughout this session.`,
+    `SynaBun memory is active. Follow the SynaBun rules in your instructions (auto-remember, auto-recall, importance scale, tool quirks) throughout this session.`,
     ``,
     `**Response ordering**: When finishing a task, call memory tools (remember/reflect) BEFORE writing your completion summary. The summary must be the LAST text in your response so the user sees it — not buried above memory tool calls.`,
     ``,
@@ -345,13 +324,13 @@ async function main() {
       `- Tools used: ${(precompactData.tools_used || []).join(', ') || '(none)'}`,
       `- Files modified: ${(precompactData.files_modified || []).join(', ') || '(none)'}`,
       ``,
-      `User message summaries:`,
+      `User message summaries${precompactData.digest === 'jev' ? ' (selected by Jev)' : ''}:`,
     );
     for (const msg of (precompactData.user_messages || []).slice(0, 10)) {
       context.push(`  - "${msg}"`);
     }
     if ((precompactData.assistant_snippets || []).length > 0) {
-      context.push(``, `Assistant response snippets:`);
+      context.push(``, `Assistant response snippets${precompactData.digest === 'jev' ? ' (selected by Jev)' : ''}:`);
       for (const snip of precompactData.assistant_snippets.slice(0, 3)) {
         context.push(`  - "${snip}"`);
       }
@@ -360,8 +339,8 @@ async function main() {
       ``,
       `Execute these steps IN ORDER, right now:`,
       `1. Call \`recall\` with query containing "${precompactData.session_id}" in category \`conversations\` — check if already stored`,
-      `2. If found → \`reflect\` to UPDATE it with latest summary`,
-      `3. If NOT found → \`remember\` with the template below, category \`conversations\`, importance 6-8, and descriptive tags`,
+      `2. Use any prior summary as evidence for this compaction; each generation has its own retry key`,
+      `3. Call \`remember\` with the template below, category \`conversations\`, importance 6-8, descriptive tags${precompactData.generation ? `, source_ref ${JSON.stringify(compactionSourceRef(sessionId, precompactData.generation))}, idempotency_key ${JSON.stringify(compactionSourceRef(sessionId, precompactData.generation))}` : ''}`,
       `4. THEN respond to the user`,
       `5. Confirm: "Session indexed in SynaBun."`,
       ``,
@@ -426,35 +405,10 @@ async function main() {
     }
   }
 
-  // --- SESSION BOOT SEQUENCE (fresh sessions only — skip on compaction) ---
-  if (!isCompactRestart) {
-    const bootSteps = [
-      `1. Call \`recall\` with query: "recent sessions, ongoing work, known issues, decisions", project: "${project}", **recency_boost: true** — this prioritizes what was worked on most recently.`,
-    ];
-
-    if (features.userLearning !== false) {
-      bootSteps.push(
-        `2. Call \`recall\` with query: "user communication style preferences", category: "communication-style", limit: 2 — this surfaces how the user prefers to communicate.`,
-        `3. Output the greeting as your FIRST text. No other tool calls between the recalls and greeting.`,
-        `4. Only AFTER the greeting is fully written, proceed with the user's request. Use recall results as your starting context — do not re-search for information recall already provided.`,
-      );
-    } else {
-      bootSteps.push(
-        `2. Output the greeting as your FIRST text. No other tool calls between recall and greeting.`,
-        `3. Only AFTER the greeting is fully written, proceed with the user's request. Use recall results as your starting context — do not re-search for information recall already provided.`,
-      );
-    }
+  // NOTE: Session Boot Sequence (recall + greeting) is injected by prompt-submit.mjs
+  // on message 1 only, not here. This prevents it from persisting in session context.
 
-    context.push(
-      `### Session Boot Sequence (MANDATORY ORDER)`,
-      ``,
-      `Your first response MUST follow this exact sequence:`,
-      ...bootSteps,
-      ``,
-      `---`,
-      ``,
-    );
-  } else {
+  if (isCompactRestart) {
     context.push(
       `### Post-Compaction Resume`,
       ``,
@@ -464,12 +418,16 @@ async function main() {
       ``,
       `If an autonomous loop was active before compaction, the Stop hook will resume it automatically. Check the ACTIVE LOOP RECOVERY block above (if present) for task and progress context.`,
       ``,
+      `**Plan files**: Write plan files to \`data/plans/YYYY-MM-DD/your-plan-slug.md\` (e.g., \`data/plans/2026-04-06/fix-session-crosstalk.md\`). Do NOT create \`PLAN.md\` at the project root. Do NOT write to \`~/.claude/plans/\`. Use a short descriptive slug from the plan title.`,
+      ``,
       `---`,
       ``,
     );
   }
 
   context.push(`Current project: **${project}**`);
+  const designLine = designSystemLine(cwd);
+  if (designLine) context.push(``, designLine);
 
   const joined = context.join('\n');
 
@@ -488,7 +446,7 @@ main().catch(() => {
   process.stdout.write(JSON.stringify({
     hookSpecificOutput: {
       hookEventName: 'SessionStart',
-      additionalContext: 'SynaBun memory is available but the session hook encountered an error. Follow CLAUDE.md memory rules and use recall/remember tools manually.',
+      additionalContext: 'SynaBun memory is available but the session hook encountered an error. Follow the SynaBun rules in your instructions and use recall/remember tools manually.',
     },
   }));
 });