sygnal 7.0.0 → 7.1.0

package/dist/diagnostics.esm.js

@@ -117,6 +117,8 @@ const CODE_TITLES = {
     SYG111: 'Controlled input has no input listener',
     SYG115: 'Unknown DOM event shorthand',
     SYG116: 'EVENTS value has no string type',
+    // PLAN-13 N-1: dev entry (checks/next.ts onNext) and sygnal-check
+    SYG117: 'next() names an action with no model entry',
     SYG124: 'Component used as a control or selector',
     SYG125: 'Control given .intent, .model or .initialState',
     SYG126: 'Control rendered but never listened to',
@@ -152,6 +154,8 @@ const CODE_TITLES = {
     // PLAN-5 V-1: VirtualCollection (checks/virtual.ts)
     SYG430: 'VirtualCollection has no bounded height',
     SYG431: 'VirtualCollection items without ids',
+    // PLAN-13 F-3: dev entry (checks/next.ts onRender) and sygnal-check
+    SYG429: 'Switchable state map names no page',
     SYG432: 'VirtualCollection item does not render one element',
     SYG433: 'VirtualCollection scroll target not in the list',
     SYG434: 'Invalid VirtualCollection estimateSize or overscan',
@@ -167,6 +171,8 @@ const CODE_TITLES = {
     SYG202: 'STATE reducer returned undefined',
     // SYG3xx streams & intent construction (1A)
     SYG301: 'RxJS operator used on an xstream stream',
+    // PLAN-13 X-1: static only (sygnal-check)
+    SYG302: "Default import from 'xstream'",
     // SYG4xx collections / switchable / sub-components / context (1A)
     SYG401: "Collection 'from' field is missing or not an array",
     // SYG5xx strict mode / canonical forms (2A; dev-plans/PLAN-1-canonical-forms.md)
@@ -395,6 +401,7 @@ const DEV_CODE_SEVERITY = {
     SYG112: 'error',
     SYG115: 'warn',
     SYG116: 'error',
+    SYG117: 'warn',
     // PLAN-4 1-D: controls, static (sygnal-check)
     SYG124: 'error',
     SYG125: 'error',
@@ -406,6 +413,10 @@ const DEV_CODE_SEVERITY = {
     SYG129: 'warn',
     // PLAN-10 X-1: static only (sygnal-check)
     SYG170: 'warn',
+    // PLAN-13 X-1: static only (sygnal-check)
+    SYG302: 'info',
+    // PLAN-13 F-3 (checks/next.ts)
+    SYG429: 'warn',
     SYG171: 'warn',
     SYG221: 'error',
     // PLAN-4 GS-4 (state.ts)
@@ -1127,7 +1138,9 @@ const propsCheck = {
                 data: { prop: key },
             });
         }
-        if ('state' in props) {
+        // PLAN-13 F-3 follow-up: a Switchable page gets the Switchable's props, whose `state` is the
+        // host's binding (a per-page map too), consumed by the host: not a prop meant for the page
+        if ('state' in props && component.__next?.kind !== 'page') {
             const value = props.state;
             const isLens = typeof value === 'string' || (value && typeof value === 'object' && typeof value.get === 'function');
             if (!isLens && value !== undefined && once(`SYG106:${name}:state`)) {
@@ -3855,7 +3868,8 @@ const audited = (f, type, sink, h) => (s, d, nx, p, ...r) => {
  *   page after a patch, G-460: on rendered elements), SYG612 (D173: a form
  *   6.0 removed, met at runtime; once per form and component, with a link to the migration
  *   guide), SYG453 (PLAN-9, D470: two children with one identity share one instance), SYG426
- *   (PLAN-9, D471: a lowercase <collection> / <switchable> tag, deprecated in 6.3.0).
+ *   (PLAN-9, D471: a lowercase <collection> / <switchable> tag, deprecated in 6.3.0), SYG117
+ *   (PLAN-13 N-1: next() to an action the component has no model entry for).
  *
  * Only while diagnostics are on (the checks' own rule); production builds never load this.
  */
@@ -4051,6 +4065,36 @@ function lowercaseTags(iv) {
     };
     walk(raw.tmpl, 0);
 }
+/**
+ * PLAN-13 F-3 SYG429: a Switchable's per-page `state={{ page: … }}` with a key that names no page
+ * (read from the owner's template, as SYG426; 0 production bytes). Once per component and key
+ */
+function switchableMaps(iv) {
+    const raw = iv.i;
+    if (!raw?.kids?.size || !raw.tmpl)
+        return;
+    const walk = (n, d) => {
+        if (!n || typeof n != 'object' || n.$p || d > 300)
+            return;
+        const p = n.sel == 'switchable' && n.data?.props, st = p?.state;
+        if (st && isPlainObject(st) && typeof st.get != 'function' && isPlainObject(p.of)) {
+            const pages = Object.keys(p.of);
+            for (const k of Object.keys(st))
+                if (!(k in p.of) && once(`SYG429:${iv.name}:${k}`))
+                    devReport('SYG429', {
+                        component: iv.name,
+                        message: `${iv.name}'s Switchable state map binds '${k}', which is not one of its pages (${pages.join(', ')}), so that binding is never used${didYouMean(k, pages)}`,
+                        fix: 'Use the page name from of={{ … }} as the key, or remove the entry',
+                        data: { key: k, pages },
+                    });
+        }
+        const kids = n.children;
+        if (Array.isArray(kids))
+            for (const c of kids)
+                walk(c, d + 1);
+    };
+    walk(raw.tmpl, 0);
+}
 /** the instance fields the checks read from today's Component instances */
 class Facade {
     constructor(__next) {
@@ -4327,6 +4371,7 @@ function nextHooks(_api) {
             removedTags(f, vnode);
             try {
                 lowercaseTags(iv);
+                switchableMaps(iv);
             }
             catch (_) { /* a check never breaks the app */ }
             // SYG453: only a view with children can render one twice
@@ -4369,6 +4414,26 @@ function nextHooks(_api) {
             }
             catch (_) { /* a check never breaks the app */ }
         },
+        // SYG117 (PLAN-13 N-1): next('X') goes to the component's own model only; with no entry
+        // for X it does nothing (an ancestor's entry of that name never runs)
+        onNext(iv, type) {
+            if (!on() || iv.def.handlers.has(type))
+                return;
+            const name = iv.name;
+            if (!once(`SYG117:${name}:${type}`))
+                return;
+            let up = live.get(iv.parentId);
+            while (up && !up.def.handlers.has(type))
+                up = live.get(up.parentId);
+            devReport('SYG117', {
+                component: name,
+                message: `${name} calls next('${type}'), but ${name} has no model entry '${type}', so the action does nothing${up ? `: next() never reaches ${up.name}, which handles '${type}'` : ''}${didYouMean(type, iv.def.handlers.keys())}`,
+                fix: up
+                    ? `next() stays in its own component. Send it up instead: give the entry that calls it a PARENT sink (PARENT: (state) => ({ … })) and add ${type}: CHILD.select(${name}) to ${up.name}.intent, or emit EVENTS: event('${type}', …) and select it there`
+                    : `Add the entry to ${name}.model (${type}: (state, data) => …), or fix the name to match an existing one`,
+                data: { action: type, ...(up ? { handledBy: up.name } : {}) },
+            });
+        },
         onElementCommand(iv, cmd) {
             if (!on())
                 return;