sygnal 6.3.0 → 6.4.0

package/dist/diagnostics.cjs.js

@@ -269,6 +269,9 @@ const CODE_TITLES = {
     SYG425: 'isolatedState slice lacks initialState keys',
     // PLAN-9 (D471): checks/next.ts; dev entry and sygnal-check
     SYG426: 'Deprecated lowercase marker tag',
+    // checks/next.ts and sygnal-check: a component reference that is not a function (an import of
+    // a name the module doesn't export is undefined under Vitest)
+    SYG427: 'CHILD.select() of something that is not a component',
     // PLAN-9 (D470): checks/next.ts; dev entry
     SYG453: 'Two children with the same identity share one instance',
     SYG601: "Retired in 6.0: Missing or invalid sources",
@@ -475,6 +478,8 @@ const DEV_CODE_SEVERITY = {
     SYG425: 'warn',
     // PLAN-9 (checks/next.ts): D471 a lowercase <collection> / <switchable> tag (deprecated in 6.3.0)
     SYG426: 'warn',
+    // checks/next.ts: CHILD.select(undefined), usually a missing export
+    SYG427: 'error',
     // PLAN-9 (checks/next.ts): D470 key identity, two children with one identity
     SYG453: 'warn',
     SYG612: 'error',
@@ -791,11 +796,20 @@ const underTest = (c) => {
     const dom = c?.sources?.[c.DOMSourceName || 'DOM'];
     return !!dom && typeof dom == 'object' && '_hub' in dom;
 };
-// G-620: an LLM / chat sink gets the chat driver's fix, not makeFetchDriver's
-const driverFix = (sink) => `Pass a driver named ${sink} to run(): ` + (/^(LLM|CHAT|AI|ASSISTANT)$/.test(sink)
-    ? `run(App, { ${sink}: makeChatDriver({ transport: openResponses({ baseURL: 'http://localhost:11434/v1', model: 'llama3.2' }) }) }) (from 'sygnal/ai'; uiMessageStream('/api/chat') for an AI SDK server)`
-    : `run(App, { ${sink}: makeFetchDriver() }) for HTTP, or driverFromAsync(fn) / your own driver`) +
-    `. Check the spelling against the drivers you pass`;
+// G-620: the usual driver for a known sink name (an LLM / chat sink gets the chat driver's fix,
+// SW the service worker's), the generic text for any other name
+const DRIVER_FOR = [
+    [/^(LLM|CHAT|AI|ASSISTANT)$/, (s) => `run(App, { ${s}: makeChatDriver({ transport: openResponses({ baseURL: 'http://localhost:11434/v1', model: 'llama3.2' }) }) }) (from 'sygnal/ai'; uiMessageStream('/api/chat') for an AI SDK server)`],
+    [/^(SW|SERVICE_WORKER)$/, (s) => `run(App, { ${s}: makeServiceWorkerDriver('/sw.js', { enabled: import.meta.env.PROD }) }) (enabled: false keeps the driver, with no service worker, on a dev server)`],
+    [/^(HTTP|API|FETCH)$/, (s) => `run(App, { ${s}: makeFetchDriver() })`],
+    [/^(WS|SOCKET)$/, (s) => `run(App, { ${s}: makeSocketDriver() })`],
+];
+const driverFix = (sink) => {
+    const known = DRIVER_FOR.find(([re]) => re.test(sink));
+    return `Pass a driver named ${sink} to run(): ` +
+        (known ? known[1](sink) : `run(App, { ${sink}: makeFetchDriver() }) for HTTP, or driverFromAsync(fn) / your own driver`) +
+        `. Check the spelling against the drivers you pass`;
+};
 const wiringCheck = {
     id: 'wiring',
     onIntent(component, actionNames) {
@@ -1344,6 +1358,10 @@ onReset(() => {
 });
 const unref = (t) => { if (t && typeof t.unref === 'function')
     t.unref(); return t; };
+/**
+ * The view's source, plus the words sygnal/vite registered for the component (its module's and
+ * its relative imports' string literals: markup a view helper draws), when it did
+ */
 function viewSource(component) {
     const view = component && component.view;
     if (typeof view !== 'function')
@@ -1356,6 +1374,9 @@ function viewSource(component) {
         catch (_) {
             src = '';
         }
+        const registered = globalThis.__SYGNAL_VIEW_TOKENS__?.get?.(view);
+        if (typeof registered == 'string')
+            src += '\n' + registered;
         viewTokens.set(view, src);
     }
     return src;
@@ -3000,7 +3021,8 @@ const persistCheck = {
         const o = p.options, init = view.initialState;
         if (!o || !init || typeof init != 'object')
             return;
-        const keys = Object.keys(init);
+        // a behavior's slice (`uses = { chat: chat() }`) is a state key too
+        const keys = [...Object.keys(init), ...Object.keys(view.uses || {})];
         for (const opt of ['pick', 'omit']) {
             for (const k of Array.isArray(o[opt]) ? o[opt] : []) {
                 if (keys.includes(k) || !once(`SYG223:${name}:${opt}:${k}`))
@@ -3714,6 +3736,18 @@ function removed(component, name, anchor, detail) {
         data: { form: anchor, guide: `${MIGRATE}#${anchor}`, ...(detail ? { detail } : {}) },
     });
 }
+/** SYG427: CHILD.select(x) with no component (an import of a name the module doesn't export) */
+function notComponent(f, x) {
+    if (!once(`SYG427:${f.name}`))
+        return;
+    const got = x === null ? 'null' : typeof x == 'object' ? 'an object' : String(x);
+    devReport('SYG427', {
+        component: f.name,
+        message: `${f.name}'s intent calls CHILD.select(${got}): that is not a component, so it never emits`,
+        fix: "Pass the child component itself, and check its import: a name its module doesn't export is undefined (Vitest runs on; the browser fails to link the module). Export it: export function Child() { … }",
+        data: { got },
+    });
+}
 /** the removed forms a definition shows (statics, view arity, model keys), once per function */
 let seenDefs = new WeakSet();
 // G-332: resetChecks() forgets them (as the once() dedupe)
@@ -4097,8 +4131,13 @@ function nextHooks(_api) {
                     const v = t[k];
                     if (k !== 'CHILD' || !v || typeof v.select != 'function')
                         return v;
-                    return { ...v, select: (x, ...r) => { if (typeof x == 'string')
-                            removed(f, f.name, 'child-select-name', `CHILD.select('${x}')`); return v.select(x, ...r); } };
+                    return { ...v, select: (x, ...r) => {
+                            if (typeof x == 'string')
+                                removed(f, f.name, 'child-select-name', `CHILD.select('${x}')`);
+                            else if (typeof x != 'function')
+                                notComponent(f, x);
+                            return v.select(x, ...r);
+                        } };
                 },
             });
         },