switchroom 0.7.15 → 0.10.0

package/telegram-plugin/tests/first-paint.test.ts

@@ -1,257 +0,0 @@
-/**
- * First-paint seam tests — Phase 2 of #545.
- *
- * Drives `firstPaintTurn` directly with fake bot api, fake progress driver,
- * and a stub `controllerFactory`. Measures wall-clock deltas against the
- * spec-doc deadlines (waiting-ux-spec.md):
- *
- *   F2 ("instant draft / status reaction"):
- *      bot.api.setMessageReaction(... '👀' ...) within 800ms of seam entry.
- *   F3 ("progress card start"):
- *      progressDriver.startTurn within 800ms of seam entry. (The spec only
- *      pins 800ms on the status reaction; we mirror that bound here because
- *      progress-card start is a synchronous side effect of the same seam
- *      and shares the "first visible signal" contract.)
- *
- * The seam is a pure async fn, so 'within Xms' really means 'before any
- * fake-timer advance' — we assert with the wall clock pinned, then verify
- * elapsed-fake-time stays <800ms.
- *
- * RED-or-GREEN: Phase 2 is allowed to surface real seam bugs. Do NOT alter
- * production code to force these green; if a deadline is missed, that's a
- * bug to file.
- */
-
-import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
-import {
-  firstPaintTurn,
-  type FirstPaintCtx,
-  type FirstPaintDeps,
-} from '../first-paint.js'
-import type { StatusReactionController } from '../status-reactions.js'
-import type { DraftStreamHandle } from '../draft-stream.js'
-
-const CHAT = '8248703757'
-const INBOUND_MSG = 100
-const STATUS_REACTION_DEADLINE_MS = 800
-const PROGRESS_CARD_DEADLINE_MS = 800
-
-type ReactionCall = {
-  chatId: string | number
-  messageId: number
-  emoji: string
-  /** Wall-clock at invocation (Date.now under fake timers). */
-  ts: number
-}
-
-type StartTurnCall = {
-  chatId: string
-  threadId?: string
-  userText: string
-  replyToMessageId?: number
-  ts: number
-}
-
-interface Harness {
-  deps: FirstPaintDeps
-  ctx: FirstPaintCtx
-  reactionCalls: ReactionCall[]
-  startTurnCalls: StartTurnCall[]
-  controllerCalls: { setQueued: number; cancel: number }
-  errors: string[]
-}
-
-function makeHarness(overrides: { ctx?: Partial<FirstPaintCtx> } = {}): Harness {
-  const reactionCalls: ReactionCall[] = []
-  const startTurnCalls: StartTurnCall[] = []
-  const controllerCalls = { setQueued: 0, cancel: 0 }
-  const errors: string[] = []
-
-  const fakeController = {
-    setQueued: () => {
-      controllerCalls.setQueued += 1
-    },
-    cancel: () => {
-      controllerCalls.cancel += 1
-    },
-    // Surface enough of the public API to satisfy callers; unused here.
-    setThinking: () => {},
-    setTool: () => {},
-    setCompacting: () => {},
-    setDone: () => {},
-    setSilent: () => {},
-    setError: () => {},
-  } as unknown as StatusReactionController
-
-  const deps: FirstPaintDeps = {
-    bot: {
-      api: {
-        setMessageReaction: async (chatId, messageId, reactions) => {
-          for (const r of reactions) {
-            reactionCalls.push({
-              chatId,
-              messageId,
-              emoji: r.emoji as string,
-              ts: Date.now(),
-            })
-          }
-        },
-      },
-    },
-    progressDriver: {
-      startTurn: (args) => {
-        startTurnCalls.push({ ...args, ts: Date.now() })
-      },
-    },
-    activeStatusReactions: new Map(),
-    activeReactionMsgIds: new Map(),
-    activeTurnStartedAt: new Map(),
-    progressUpdateTurnCount: new Map(),
-    activeDraftStreams: new Map<string, DraftStreamHandle>(),
-    activeDraftParseModes: new Map(),
-    suppressPtyPreview: new Set(),
-    statusKey: (chatId, threadId) => `${chatId}:${threadId ?? '_'}`,
-    streamKey: (chatId, threadId) => `${chatId}:${threadId ?? '_'}`,
-    purgeReactionTracking: () => {},
-    signalTracker: {
-      noteSignal: () => {},
-      reset: () => {},
-    },
-    resolveAgentDirFromEnv: () => null,
-    addActiveReaction: () => {},
-    logStreamingEvent: () => {},
-    controllerFactory: () => fakeController,
-    logError: (m) => {
-      errors.push(m)
-    },
-  }
-
-  const ctx: FirstPaintCtx = {
-    chatId: CHAT,
-    messageId: INBOUND_MSG,
-    messageThreadId: undefined,
-    isSteerPrefix: false,
-    effectiveText: 'hi',
-    inboundReceivedAt: Date.now(),
-    access: { statusReactions: true },
-    ...overrides.ctx,
-  }
-
-  return { deps, ctx, reactionCalls, startTurnCalls, controllerCalls, errors }
-}
-
-beforeEach(() => {
-  vi.useFakeTimers()
-})
-
-afterEach(() => {
-  vi.useRealTimers()
-})
-
-describe('firstPaintTurn — first-paint seam', () => {
-  it('happy path: fresh turn fires status reaction (👀 via setQueued path) and startTurn in order', async () => {
-    const h = makeHarness()
-    const t0 = Date.now()
-
-    await firstPaintTurn(h.deps, h.ctx)
-
-    // Fresh turn: controllerFactory was used, setQueued called once.
-    expect(h.controllerCalls.setQueued).toBe(1)
-    expect(h.controllerCalls.cancel).toBe(0)
-
-    // The fake controller is a stub, so the bot.api.setMessageReaction
-    // path here is exercised only via the steer/queued branches — for a
-    // fresh turn the seam delegates the actual emoji emission to the
-    // controller (which our stub records as `setQueued`). Either way the
-    // FIRST visible signal happens within the seam call. Assert startTurn
-    // fired and the controller was queued before any timer advance.
-    expect(h.startTurnCalls).toHaveLength(1)
-    expect(h.startTurnCalls[0].chatId).toBe(CHAT)
-    expect(h.startTurnCalls[0].userText).toBe('hi')
-    expect(h.startTurnCalls[0].replyToMessageId).toBe(INBOUND_MSG)
-
-    // No fake-time advance happened; both side effects fired synchronously.
-    expect(Date.now() - t0).toBe(0)
-    expect(h.errors).toHaveLength(0)
-  })
-
-  it('F2 — instant draft: status reaction fires within 800ms of seam entry (fresh turn)', async () => {
-    const h = makeHarness()
-    const t0 = Date.now()
-
-    await firstPaintTurn(h.deps, h.ctx)
-
-    // The "first visible signal" for a fresh turn is the controller's
-    // queued state. Production wires this through the controller's emit
-    // callback (which calls bot.api.setMessageReaction with 👀). Our
-    // controllerFactory stub records `setQueued` instead — so we assert
-    // setQueued landed within the deadline.
-    expect(h.controllerCalls.setQueued).toBe(1)
-    const elapsed = Date.now() - t0
-    expect(elapsed).toBeLessThan(STATUS_REACTION_DEADLINE_MS)
-  })
-
-  it('F2 — instant draft (queued mid-turn branch): 👀 reaction fires synchronously within 800ms', async () => {
-    const h = makeHarness()
-    // Simulate prior turn in flight by seeding activeStatusReactions.
-    const key = `${CHAT}:_`
-    const placeholderCtrl = {
-      cancel: () => {},
-      setQueued: () => {},
-    } as unknown as StatusReactionController
-    h.deps.activeStatusReactions.set(key, placeholderCtrl)
-    h.deps.activeTurnStartedAt.set(key, Date.now() - 5_000)
-
-    const t0 = Date.now()
-    await firstPaintTurn(h.deps, h.ctx)
-
-    // Mid-turn queued branch posts 👀 directly via bot.api.
-    const eyes = h.reactionCalls.find((c) => c.emoji === '👀')
-    expect(eyes, 'expected a 👀 reaction call in mid-turn queued branch').toBeDefined()
-    expect((eyes!.ts) - t0).toBeLessThan(STATUS_REACTION_DEADLINE_MS)
-  })
-
-  it('F3 — progress card: startTurn fires within 800ms of seam entry on a fresh turn', async () => {
-    const h = makeHarness()
-    const t0 = Date.now()
-
-    await firstPaintTurn(h.deps, h.ctx)
-
-    expect(h.startTurnCalls).toHaveLength(1)
-    const elapsed = h.startTurnCalls[0].ts - t0
-    expect(elapsed).toBeLessThan(PROGRESS_CARD_DEADLINE_MS)
-  })
-
-  it('F3 — does NOT fire startTurn when a prior turn is in flight (steer branch)', async () => {
-    const h = makeHarness({ ctx: { isSteerPrefix: true } })
-    const key = `${CHAT}:_`
-    const placeholderCtrl = {
-      cancel: () => {},
-      setQueued: () => {},
-    } as unknown as StatusReactionController
-    h.deps.activeStatusReactions.set(key, placeholderCtrl)
-    h.deps.activeTurnStartedAt.set(key, Date.now() - 5_000)
-
-    const result = await firstPaintTurn(h.deps, h.ctx)
-
-    expect(result.isSteering).toBe(true)
-    expect(h.startTurnCalls).toHaveLength(0)
-    // Steer branch posts 🤝, not a new card.
-    expect(h.reactionCalls.find((c) => c.emoji === '🤝')).toBeDefined()
-  })
-
-  it('logError dep captures progress-card startTurn failures (does not write to stderr)', async () => {
-    const h = makeHarness()
-    h.deps.progressDriver = {
-      startTurn: () => {
-        throw new Error('boom')
-      },
-    }
-
-    await firstPaintTurn(h.deps, h.ctx)
-
-    expect(h.errors).toHaveLength(1)
-    expect(h.errors[0]).toContain('progress-card startTurn failed')
-    expect(h.errors[0]).toContain('boom')
-  })
-})

package/telegram-plugin/tests/foreman-create-flow.test.ts

@@ -1,359 +0,0 @@
-/**
- * Tests for the create-agent flow state machine (foreman-create-flow.ts).
- *
- * Pure function tests — no grammY, no SQLite, no network.
- *
- * Covers:
- *   - startCreateFlow: valid/invalid name, inline name, no name
- *   - handleFlowText: step transitions (asked-name → asked-profile → asked-bot-token → ...)
- *   - Error paths: invalid name, unknown profile, bad token shape, short code
- *   - makeInitialState / advanceState / stepLabel helpers
- */
-
-import { describe, it, expect } from 'vitest'
-import {
-  startCreateFlow,
-  handleFlowText,
-  makeInitialState,
-  advanceState,
-  stepLabel,
-  isValidAgentName,
-} from '../foreman/foreman-create-flow.js'
-import type { CreateFlowState } from '../foreman/state.js'
-
-const PROFILES = ['default', 'health-coach', 'coding-assistant']
-
-// ─── isValidAgentName ─────────────────────────────────────────────────────
-
-describe('foreman-create-flow: isValidAgentName', () => {
-  it('accepts lowercase simple name', () => expect(isValidAgentName('gymbro')).toBe(true))
-  it('accepts name with hyphens', () => expect(isValidAgentName('my-agent')).toBe(true))
-  it('accepts name with underscores', () => expect(isValidAgentName('my_agent')).toBe(true))
-  it('accepts name starting with digit', () => expect(isValidAgentName('1agent')).toBe(true))
-  it('rejects uppercase', () => expect(isValidAgentName('Gymbro')).toBe(false))
-  it('rejects empty string', () => expect(isValidAgentName('')).toBe(false))
-  it('rejects spaces', () => expect(isValidAgentName('my agent')).toBe(false))
-  it('rejects semicolon', () => expect(isValidAgentName('agent; evil')).toBe(false))
-  it('accepts 51-char name', () => expect(isValidAgentName('a'.repeat(51))).toBe(true))
-  it('rejects 52-char name', () => expect(isValidAgentName('a'.repeat(52))).toBe(false))
-})
-
-// ─── startCreateFlow ──────────────────────────────────────────────────────
-
-describe('foreman-create-flow: startCreateFlow', () => {
-  it('asks for name when no inline name given', () => {
-    const action = startCreateFlow(null, PROFILES)
-    expect(action.kind).toBe('ask-name')
-  })
-
-  it('asks for profile when valid inline name given', () => {
-    const action = startCreateFlow('gymbro', PROFILES)
-    expect(action.kind).toBe('ask-profile')
-    if (action.kind === 'ask-profile') {
-      expect(action.profiles).toEqual(PROFILES)
-    }
-  })
-
-  it('returns error when inline name is invalid', () => {
-    const action = startCreateFlow('Bad Name!', PROFILES)
-    expect(action.kind).toBe('error')
-    if (action.kind === 'error') {
-      expect(action.message).toContain('Bad Name!')
-      expect(action.stayInStep).toBe(false)
-    }
-  })
-
-  it('returns error for uppercase inline name', () => {
-    const action = startCreateFlow('MyAgent', PROFILES)
-    expect(action.kind).toBe('error')
-  })
-})
-
-// ─── handleFlowText — null state ─────────────────────────────────────────
-
-describe('foreman-create-flow: handleFlowText with null state', () => {
-  it('cancels when no active flow', () => {
-    const action = handleFlowText({ state: null, text: 'hello', profiles: PROFILES })
-    expect(action.kind).toBe('cancel')
-  })
-})
-
-// ─── handleFlowText — asked-name step ────────────────────────────────────
-
-describe('foreman-create-flow: handleFlowText step=asked-name', () => {
-  function makeState(): CreateFlowState {
-    return makeInitialState('chat-1', null) // step = 'asked-name'
-  }
-
-  it('transitions to ask-profile on valid name', () => {
-    const action = handleFlowText({ state: makeState(), text: 'gymbro', profiles: PROFILES })
-    expect(action.kind).toBe('ask-profile')
-    if (action.kind === 'ask-profile') {
-      expect(action.profiles).toEqual(PROFILES)
-    }
-  })
-
-  it('returns error on invalid name, stayInStep=true', () => {
-    const action = handleFlowText({ state: makeState(), text: 'Bad Name!', profiles: PROFILES })
-    expect(action.kind).toBe('error')
-    if (action.kind === 'error') {
-      expect(action.stayInStep).toBe(true)
-    }
-  })
-
-  it('error message mentions the bad input', () => {
-    const action = handleFlowText({ state: makeState(), text: 'MyBotIsGreat', profiles: PROFILES })
-    if (action.kind === 'error') {
-      expect(action.message).toContain('MyBotIsGreat')
-    }
-  })
-
-  it('accepts name with hyphens', () => {
-    const action = handleFlowText({ state: makeState(), text: 'my-agent', profiles: PROFILES })
-    expect(action.kind).toBe('ask-profile')
-  })
-})
-
-// ─── handleFlowText — asked-profile step ──────────────────────────────────
-
-describe('foreman-create-flow: handleFlowText step=asked-profile', () => {
-  function makeState(name = 'gymbro'): CreateFlowState {
-    return {
-      chatId: 'chat-1',
-      step: 'asked-profile',
-      name,
-      profile: null,
-      botToken: null,
-      authSessionName: null,
-      loginUrl: null,
-      startedAt: Date.now(),
-      updatedAt: Date.now(),
-    }
-  }
-
-  it('transitions to ask-bot-token on valid profile', () => {
-    const action = handleFlowText({ state: makeState(), text: 'health-coach', profiles: PROFILES })
-    expect(action.kind).toBe('ask-bot-token')
-    if (action.kind === 'ask-bot-token') {
-      expect(action.profile).toBe('health-coach')
-      expect(action.name).toBe('gymbro')
-    }
-  })
-
-  it('returns error on unknown profile, stayInStep=true', () => {
-    const action = handleFlowText({ state: makeState(), text: 'nonexistent-profile', profiles: PROFILES })
-    expect(action.kind).toBe('error')
-    if (action.kind === 'error') {
-      expect(action.stayInStep).toBe(true)
-      expect(action.message).toContain('nonexistent-profile')
-    }
-  })
-
-  it('lists valid profiles in error message', () => {
-    const action = handleFlowText({ state: makeState(), text: 'bad', profiles: PROFILES })
-    if (action.kind === 'error') {
-      for (const p of PROFILES) {
-        expect(action.message).toContain(p)
-      }
-    }
-  })
-
-  it('cancels with missing-name when state.name is unset (#28 item 1)', () => {
-    // Pre-#28 fix this fell back to using the profile name as the agent
-    // name. Now we cancel cleanly so the user gets a clear restart
-    // signal instead of an agent named "default".
-    const stateNoName = {
-      chatId: 'chat-1',
-      step: 'asked-profile' as const,
-      name: null,
-      profile: null,
-      botToken: null,
-      authSessionName: null,
-      loginUrl: null,
-      startedAt: Date.now(),
-      updatedAt: Date.now(),
-    }
-    const action = handleFlowText({ state: stateNoName, text: 'default', profiles: PROFILES })
-    expect(action.kind).toBe('cancel')
-    if (action.kind === 'cancel') {
-      expect(action.reason).toBe('missing-name')
-    }
-  })
-})
-
-// ─── handleFlowText — asked-bot-token step ───────────────────────────────
-
-describe('foreman-create-flow: handleFlowText step=asked-bot-token', () => {
-  function makeState(): CreateFlowState {
-    return {
-      chatId: 'chat-1',
-      step: 'asked-bot-token',
-      name: 'gymbro',
-      profile: 'health-coach',
-      botToken: null,
-      authSessionName: null,
-      loginUrl: null,
-      startedAt: Date.now(),
-      updatedAt: Date.now(),
-    }
-  }
-
-  it('transitions to call-create-agent on token-shaped input', () => {
-    const token = '1234567890:AAHaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
-    const action = handleFlowText({ state: makeState(), text: token, profiles: PROFILES })
-    expect(action.kind).toBe('call-create-agent')
-    if (action.kind === 'call-create-agent') {
-      expect(action.botToken).toBe(token)
-      expect(action.name).toBe('gymbro')
-      expect(action.profile).toBe('health-coach')
-    }
-  })
-
-  it('returns error on token with no colon, stayInStep=true', () => {
-    const action = handleFlowText({ state: makeState(), text: 'notavalidtoken', profiles: PROFILES })
-    expect(action.kind).toBe('error')
-    if (action.kind === 'error') {
-      expect(action.stayInStep).toBe(true)
-    }
-  })
-
-  it('returns error on token too short', () => {
-    const action = handleFlowText({ state: makeState(), text: 'a:b', profiles: PROFILES })
-    expect(action.kind).toBe('error')
-    if (action.kind === 'error') {
-      expect(action.stayInStep).toBe(true)
-    }
-  })
-
-  it('cancels if name or profile missing in state', () => {
-    const state: CreateFlowState = {
-      ...makeState(),
-      name: null,
-    }
-    const action = handleFlowText({ state, text: '1234567890:AAHsomething', profiles: PROFILES })
-    expect(action.kind).toBe('cancel')
-  })
-})
-
-// ─── handleFlowText — asked-oauth-code step ──────────────────────────────
-
-describe('foreman-create-flow: handleFlowText step=asked-oauth-code', () => {
-  function makeState(): CreateFlowState {
-    return {
-      chatId: 'chat-1',
-      step: 'asked-oauth-code',
-      name: 'gymbro',
-      profile: 'health-coach',
-      botToken: '1234567890:AAHsomething',
-      authSessionName: 'gymbro-auth-123',
-      loginUrl: 'https://claude.ai/oauth/authorize?...',
-      startedAt: Date.now(),
-      updatedAt: Date.now(),
-    }
-  }
-
-  it('transitions to call-complete-creation on plausible code', () => {
-    const action = handleFlowText({ state: makeState(), text: 'abc12345', profiles: PROFILES })
-    expect(action.kind).toBe('call-complete-creation')
-    if (action.kind === 'call-complete-creation') {
-      expect(action.name).toBe('gymbro')
-      expect(action.code).toBe('abc12345')
-    }
-  })
-
-  it('returns error on code that is too short, stayInStep=true', () => {
-    const action = handleFlowText({ state: makeState(), text: 'ab', profiles: PROFILES })
-    expect(action.kind).toBe('error')
-    if (action.kind === 'error') {
-      expect(action.stayInStep).toBe(true)
-    }
-  })
-
-  it('cancels if name missing in state', () => {
-    const state: CreateFlowState = { ...makeState(), name: null }
-    const action = handleFlowText({ state, text: 'abc12345', profiles: PROFILES })
-    expect(action.kind).toBe('cancel')
-  })
-})
-
-// ─── handleFlowText — done step ──────────────────────────────────────────
-
-describe('foreman-create-flow: handleFlowText step=done', () => {
-  it('returns cancel when flow is already done', () => {
-    const state: CreateFlowState = {
-      chatId: 'chat-1',
-      step: 'done',
-      name: 'gymbro',
-      profile: 'health-coach',
-      botToken: null,
-      authSessionName: null,
-      loginUrl: null,
-      startedAt: Date.now(),
-      updatedAt: Date.now(),
-    }
-    const action = handleFlowText({ state, text: 'hello', profiles: PROFILES })
-    expect(action.kind).toBe('cancel')
-  })
-})
-
-// ─── makeInitialState ─────────────────────────────────────────────────────
-
-describe('foreman-create-flow: makeInitialState', () => {
-  it('sets step to asked-name when name is null', () => {
-    const state = makeInitialState('chat-1', null)
-    expect(state.step).toBe('asked-name')
-    expect(state.name).toBeNull()
-  })
-
-  it('sets step to asked-profile when name provided', () => {
-    const state = makeInitialState('chat-1', 'gymbro')
-    expect(state.step).toBe('asked-profile')
-    expect(state.name).toBe('gymbro')
-  })
-
-  it('sets startedAt and updatedAt', () => {
-    const before = Date.now()
-    const state = makeInitialState('chat-1', null)
-    const after = Date.now()
-    expect(state.startedAt).toBeGreaterThanOrEqual(before)
-    expect(state.startedAt).toBeLessThanOrEqual(after)
-    expect(state.updatedAt).toBe(state.startedAt)
-  })
-})
-
-// ─── advanceState ─────────────────────────────────────────────────────────
-
-describe('foreman-create-flow: advanceState', () => {
-  it('merges updates into state', () => {
-    const state = makeInitialState('chat-1', 'gymbro')
-    const next = advanceState(state, { step: 'asked-bot-token', profile: 'health-coach' })
-    expect(next.step).toBe('asked-bot-token')
-    expect(next.profile).toBe('health-coach')
-    expect(next.name).toBe('gymbro')
-    expect(next.chatId).toBe('chat-1')
-  })
-
-  it('updates updatedAt', () => {
-    const state = makeInitialState('chat-1', null)
-    const before = Date.now()
-    const next = advanceState(state, { step: 'asked-profile', name: 'gymbro' })
-    expect(next.updatedAt).toBeGreaterThanOrEqual(before)
-  })
-
-  it('preserves startedAt', () => {
-    const state = makeInitialState('chat-1', null)
-    const next = advanceState(state, { step: 'asked-profile' })
-    expect(next.startedAt).toBe(state.startedAt)
-  })
-})
-
-// ─── stepLabel ────────────────────────────────────────────────────────────
-
-describe('foreman-create-flow: stepLabel', () => {
-  it('returns a non-empty string for each step', () => {
-    const steps = ['asked-name', 'asked-profile', 'asked-bot-token', 'asked-oauth-code', 'done'] as const
-    for (const step of steps) {
-      expect(stepLabel(step).length).toBeGreaterThan(0)
-    }
-  })
-})