switchroom 0.18.9 → 0.18.11

package/telegram-plugin/tests/worker-visibility-prose-silent-harness.test.ts

@@ -158,6 +158,7 @@ function makeHarness() {
     stallThresholdMs: 60_000, // tight active-loop threshold
     silentSynthesisStallThresholdMs: 300_000, // widened window (also long-runner window)
     silentStallTerminalMs: 300_000, // post-stall terminal-synthesis window (unchanged)
+    inflightTerminalCapMs: 900_000, // died-mid-tool cap (15 min, compressed from the 45-min default)
     rescanMs: 500,
     now: () => currentTime,
     setInterval: sharedSetInterval,
@@ -278,10 +279,23 @@ describe('prose-silent background worker — end-to-end visibility harness (PR 2
     expect(h.stallCalls[0].agentId).toBe(h.agentId)
     expect(h.stallTerminalCalls).toHaveLength(0)
 
-    // (d) TERMINAL GATE RELEASE: 300s past the stall, the silent-stall terminal
-    // synthesis fires — onStallTerminal + onFinish — and the feed finalizes.
-    // This is the untouched, load-bearing completion path.
-    h.advance(310_000)
+    // (d) IN-FLIGHT DEFERRAL: 300s past the stall the OLD contract
+    // (#2777/#2782) synthesised terminal here. But this worker's transcript
+    // ends in a Bash tool_use with NO tool_result — it may still be inside
+    // the tool call (incident 2026-07-10: exactly this shape finalised a
+    // LIVE worker's card mid-Bash). Synthesis is now deferred while the
+    // tool call is in flight...
+    h.advance(310_000) // total idle ~672s — past silentStallTerminalMs, under the 900s cap
+    await h.flush()
+    expect(h.stallTerminalCalls).toHaveLength(0)
+    expect(h.finishCalls).toHaveLength(0)
+
+    // (e) TERMINAL GATE RELEASE AT THE CAP: ...but not forever. A worker
+    // that died mid-tool (JSONL frozen, tool_result never coming) must not
+    // wedge — past inflightTerminalCapMs of total idle the synthesis
+    // proceeds and the completion gate releases. The load-bearing release
+    // from #2777/#2782 survives, bounded instead of at the raw synth window.
+    h.advance(300_000) // total idle ~972s ≥ 900s cap
     await h.flush()
     expect(h.stallTerminalCalls).toHaveLength(1)
     expect(h.finishCalls).toHaveLength(1)

package/telegram-plugin/welcome-text.ts

@@ -279,9 +279,9 @@ export function statusUnpairedText(): string {
  */
 export const switchroomHelpCommandNames = [
   // Session & approvals
-  "new", "compact", "clear", "approve", "deny", "pending", "interrupt",
+  "new", "compact", "clear", "approve", "deny", "pending", "interrupt", "stop",
   // Agents
-  "agents", "agentstart", "stop", "restart", "logs", "memory",
+  "agents", "agentstart", "agentstop", "restart", "logs", "memory",
   // Auth & config — consolidated onto the `/auth` dashboard.
   "auth", "model",
   "topics", "update", "version", "whoami",
@@ -380,11 +380,12 @@ export function switchroomHelpText(agentName: string): string {
     `\`/deny [id]\` — deny pending tool permission`,
     `\`/pending\` — list pending permission prompts`,
     `\`/interrupt [name]\` — interrupt an agent turn`,
+    `\`/stop\` — cancel my in-flight turn (bare "stop" works too)`,
     ``,
     `**Agents**`,
     `\`/agents\` — list all agents`,
     `\`/agentstart [name]\` — start an agent`,
-    `\`/stop [name]\` — stop an agent`,
+    `\`/agentstop [name]\` — stop an agent's container`,
     `\`/logs [name] [lines]\` — show agent logs`,
     `\`/memory <query>\` — search agent memory`,
     ``,

package/telegram-plugin/worker-activity-feed.ts

@@ -342,6 +342,16 @@ export interface WorkerActivityFeed {
   finish(agentId: string, view: WorkerActivityView): Promise<void>
   /** Forget a worker's state without editing (e.g. error path). */
   drop(agentId: string): void
+  /**
+   * Issue #3023 (card resurrection). Undo a finalization: clear the durable
+   * `finalized` gate (and any lingering per-handle `finished` latch) so a
+   * worker whose card was FALSELY finalized can be painted/edited again. The
+   * watcher calls this (via the gateway's `onResurrect` wiring) when a
+   * falsely-finalized worker's JSONL resumes growing. A fresh `running` cue
+   * after this repaints a live card — the operator invariant that active work
+   * stays visible. Idempotent; a no-op if the worker was never finalized.
+   */
+  resurrect(agentId: string): void
   /** Clear the heartbeat interval (gateway shutdown). Idempotent. */
   stop(): void
   /** Manually fire one heartbeat tick (test hook). */
@@ -777,6 +787,23 @@ export function createWorkerActivityFeed(opts: WorkerActivityFeedOpts): WorkerAc
       markFinalized(agentId)
       handles.delete(agentId)
     },
+    resurrect(agentId) {
+      // Issue #3023: the worker's card was falsely finalized and its JSONL has
+      // resumed. Re-open the paint path: drop the durable finalized gate so a
+      // fresh `running` cue creates a new handle and first-paints a live card
+      // again, and un-latch any surviving handle (finish deleted it in the
+      // common case, but a staged pendingFinish could keep it alive). The next
+      // `update` tick from the watcher's replayed progress does the repaint.
+      const wasFinalized = finalized.delete(agentId)
+      const h = handles.get(agentId)
+      if (h != null) {
+        h.finished = false
+        h.pendingFinish = null
+      }
+      if (wasFinalized || h != null) {
+        log(`worker-feed: resurrect agent=${agentId} — cleared finalized gate; card will repaint on next running cue`)
+      }
+    },
     heartbeatTick,
     stop() {
       if (heartbeatTimer != null) {