switchroom 0.18.15 → 0.18.17

package/telegram-plugin/tests/session-model-file.test.ts

@@ -1,10 +1,12 @@
 /**
- * Durable session-model file helpers (session-model-file.ts) — the gateway
- * side of the stickiness contract (reference/rfcs/session-model-stickiness.md).
+ * Session-model file helpers (session-model-file.ts) — the gateway side of the
+ * session-scoped /model contract (reference/rfcs/session-model-stickiness.md
+ * §0.1, rev 4 — consume-once). The `.relaunch-model-intent` subsystem and the
+ * crashloop counter were retired with rev 4; their tests are gone.
  */
 
 import { describe, it, expect, beforeEach, afterEach } from 'vitest'
-import { mkdtempSync, rmSync, readFileSync, writeFileSync, existsSync } from 'node:fs'
+import { mkdtempSync, rmSync, writeFileSync, existsSync } from 'node:fs'
 import { join } from 'node:path'
 import { tmpdir } from 'node:os'
 import {
@@ -15,17 +17,8 @@ import {
   readSessionModelFileRaw,
   restoreSessionModelFileRaw,
   clearSessionModelFile,
-  clearSessionModelBootAttempts,
-  SESSION_MODEL_BOOT_ATTEMPTS_FILE,
-  writeRelaunchModelIntent,
-  clearRelaunchModelIntent,
   readConfiguredDefaultModel,
-  intentForRestartReason,
-  readRelaunchModelIntent,
-  clearStaleGatewayShutdownIntent,
-  GATEWAY_SHUTDOWN_INTENT_REASON_PREFIX,
   SESSION_MODEL_FILE,
-  RELAUNCH_MODEL_INTENT_FILE,
   CONFIGURED_DEFAULT_MODEL_FILE,
   parseSessionEffort,
   writeSessionEffortFile,
@@ -87,86 +80,6 @@ describe('rollback snapshot (scheduleModelRelaunch dispatch failure)', () => {
   })
 })
 
-describe('relaunch intent', () => {
-  it('writes one-line JSON with intent, reason, and embedded ts (the freshness clock)', () => {
-    writeRelaunchModelIntent(dir, 'keep', 'user: /new from chat')
-    const raw = readFileSync(join(dir, RELAUNCH_MODEL_INTENT_FILE), 'utf8')
-    const parsed = JSON.parse(raw)
-    expect(parsed.intent).toBe('keep')
-    expect(parsed.reason).toBe('user: /new from chat')
-    expect(Math.abs(Date.now() - parsed.ts)).toBeLessThan(5000)
-  })
-
-  it('last-writer-wins and clearable', () => {
-    writeRelaunchModelIntent(dir, 'keep', 'a')
-    writeRelaunchModelIntent(dir, 'revert', 'b')
-    expect(JSON.parse(readFileSync(join(dir, RELAUNCH_MODEL_INTENT_FILE), 'utf8')).intent).toBe('revert')
-    clearRelaunchModelIntent(dir)
-    expect(existsSync(join(dir, RELAUNCH_MODEL_INTENT_FILE))).toBe(false)
-  })
-})
-
-describe('intentForRestartReason — the triggerSelfRestart per-reason table (RFC §3)', () => {
-  it.each([
-    'schedule-restart-immediate',
-    'restart-drain-cap-forced',
-    'turn-complete-pending-restart',
-    'fleet-fallback-resume',
-    'sr-to-claude-model-switch',
-  ])('switchroom-managed relaunch %s → keep', (reason) => {
-    expect(intentForRestartReason(reason)).toBe('keep')
-  })
-
-  it('inline-button-restart → keep (#3039: a restart is not "clear my model")', () => {
-    expect(intentForRestartReason('inline-button-restart')).toBe('keep')
-  })
-
-  it('unknown gateway reasons default to keep (only gateway code calls triggerSelfRestart; crashes never do)', () => {
-    expect(intentForRestartReason('some-future-recovery-path')).toBe('keep')
-  })
-})
-
-describe('readRelaunchModelIntent', () => {
-  it('round-trips a stamped intent; null when absent / corrupt / malformed', () => {
-    expect(readRelaunchModelIntent(dir)).toBeNull()
-    writeRelaunchModelIntent(dir, 'keep', 'watchdog recovery')
-    const rec = readRelaunchModelIntent(dir)!
-    expect(rec.intent).toBe('keep')
-    expect(rec.reason).toBe('watchdog recovery')
-    expect(Math.abs(Date.now() - rec.ts)).toBeLessThan(5000)
-    writeFileSync(join(dir, RELAUNCH_MODEL_INTENT_FILE), '{broken')
-    expect(readRelaunchModelIntent(dir)).toBeNull()
-    writeFileSync(join(dir, RELAUNCH_MODEL_INTENT_FILE), '{"intent":"maybe","reason":"x","ts":1}\n')
-    expect(readRelaunchModelIntent(dir)).toBeNull()
-  })
-})
-
-describe('clearStaleGatewayShutdownIntent (#3018 finding 4 — a gateway-only bounce must not leave a keep stamp)', () => {
-  it('clears ONLY a gateway-shutdown-stamped intent and reports it', () => {
-    writeRelaunchModelIntent(
-      dir,
-      'keep',
-      `${GATEWAY_SHUTDOWN_INTENT_REASON_PREFIX} graceful SIGTERM shutdown (deploy/rolling restart) — preserving user-chosen session model`,
-    )
-    expect(clearStaleGatewayShutdownIntent(dir)).toBe(true)
-    expect(existsSync(join(dir, RELAUNCH_MODEL_INTENT_FILE))).toBe(false)
-    // Idempotent: a second call finds nothing.
-    expect(clearStaleGatewayShutdownIntent(dir)).toBe(false)
-  })
-
-  it('never touches a triggerSelfRestart / user-slash stamp (un-prefixed reason)', () => {
-    writeRelaunchModelIntent(dir, 'keep', 'sr-to-claude-model-switch')
-    expect(clearStaleGatewayShutdownIntent(dir)).toBe(false)
-    expect(readRelaunchModelIntent(dir)!.reason).toBe('sr-to-claude-model-switch')
-  })
-
-  it('is a safe no-op on an absent or corrupt intent file', () => {
-    expect(clearStaleGatewayShutdownIntent(dir)).toBe(false)
-    writeFileSync(join(dir, RELAUNCH_MODEL_INTENT_FILE), 'not json')
-    expect(clearStaleGatewayShutdownIntent(dir)).toBe(false)
-  })
-})
-
 describe('readConfiguredDefaultModel', () => {
   it('reads the trimmed value; null when absent or empty', () => {
     expect(readConfiguredDefaultModel(dir)).toBeNull()
@@ -181,9 +94,9 @@ describe('readConfiguredDefaultModel', () => {
   })
 })
 
-// ─── #3039: durable session-effort carrier ───────────────────────────────────
+// ─── #3186: consume-once session-effort carrier (queued-command boot apply) ──
 
-describe('session-effort file helpers (#3039)', () => {
+describe('session-effort file helpers (#3186)', () => {
   let dir: string
   beforeEach(() => {
     dir = mkdtempSync(join(tmpdir(), 'sr-session-effort-'))
@@ -218,64 +131,3 @@ describe('session-effort file helpers (#3039)', () => {
     expect(readSessionEffortFile(dir)).toBeNull()
   })
 })
-
-describe('intentForRestartReason is keep-for-everything (#3039)', () => {
-  it('every reason keeps — restarts never clear a user model choice', () => {
-    for (const reason of [
-      'inline-button-restart',
-      'user: /restart from chat',
-      'schedule-restart-immediate',
-      'anything-else',
-    ]) {
-      expect(intentForRestartReason(reason)).toBe('keep')
-    }
-  })
-})
-
-describe('clearSessionModelBootAttempts (#3043 item 2: bridge-register clears the crashloop counter)', () => {
-  const bootAttemptsPath = () => join(dir, SESSION_MODEL_BOOT_ATTEMPTS_FILE)
-
-  // Faithful model of start.sh.hbs "Override crashloop self-heal": each boot
-  // within 150s of the previous stamp bumps the count; a stale stamp resets to
-  // 1. Reproduced here so the accumulate-vs-reset OUTCOME is asserted, not just
-  // the delete call.
-  function simulateBootStamp(nowSec: number): number {
-    let count = 0
-    let prev = 0
-    if (existsSync(bootAttemptsPath())) {
-      const [c, p] = readFileSync(bootAttemptsPath(), 'utf8').trim().split(/\s+/)
-      count = Number(c) || 0
-      prev = Number(p) || 0
-    }
-    count = nowSec - prev < 150 ? count + 1 : 1
-    writeFileSync(bootAttemptsPath(), `${count} ${nowSec}\n`)
-    return count
-  }
-
-  it('WITHOUT a bridge register, three fast boots accumulate toward the 3-strike clear', () => {
-    // Three operator hand-bounces, each <150s apart, with no register between.
-    expect(simulateBootStamp(1000)).toBe(1)
-    expect(simulateBootStamp(1010)).toBe(2)
-    expect(simulateBootStamp(1020)).toBe(3) // start.sh would now clear a HEALTHY override — the false positive
-  })
-
-  it('a bridge register between boots resets the counter, so a healthy agent never reaches 3', () => {
-    expect(simulateBootStamp(1000)).toBe(1)
-    // Boot 1 came all the way up and the bridge registered → gateway clears it.
-    clearSessionModelBootAttempts(dir)
-    expect(existsSync(bootAttemptsPath())).toBe(false)
-
-    // Next fast boot starts fresh at 1 (no accumulation), and register clears again.
-    expect(simulateBootStamp(1010)).toBe(1)
-    clearSessionModelBootAttempts(dir)
-    expect(simulateBootStamp(1020)).toBe(1)
-    // The healthy agent's counter never climbs to the 3-strike clear.
-    const [count] = readFileSync(bootAttemptsPath(), 'utf8').trim().split(/\s+/)
-    expect(Number(count)).toBeLessThan(3)
-  })
-
-  it('is best-effort — no throw when the counter file is absent', () => {
-    expect(existsSync(bootAttemptsPath())).toBe(false)
-    expect(() => clearSessionModelBootAttempts(dir)).not.toThrow()
-  })
-})