switchroom 0.14.47 → 0.14.49

package/telegram-plugin/tests/boot-card-msgid.test.ts

@@ -0,0 +1,88 @@
+/**
+ * Unit tests for the cross-reboot boot-card message-id store
+ * (gateway/boot-card-msgid.ts) — the persistence that lets a routine reboot
+ * EDIT the prior boot card in place (zero notification) instead of sending a
+ * new one.
+ *
+ * All I/O is to an isolated mkdtemp dir — NEVER ~/.switchroom (test discipline).
+ */
+
+import { describe, it, expect, beforeEach, afterEach } from 'vitest'
+import { mkdtempSync, rmSync, writeFileSync, existsSync } from 'node:fs'
+import { tmpdir } from 'node:os'
+import { join } from 'node:path'
+import {
+  bootCardChatKey,
+  loadBootCardMsgId,
+  saveBootCardMsgId,
+} from '../gateway/boot-card-msgid.js'
+
+let dir: string
+let path: string
+
+beforeEach(() => {
+  dir = mkdtempSync(join(tmpdir(), 'boot-card-msgid-'))
+  path = join(dir, '.boot-card-msgid.json')
+})
+afterEach(() => {
+  rmSync(dir, { recursive: true, force: true })
+})
+
+describe('bootCardChatKey', () => {
+  it('keys a DM (no topic) distinctly from a supergroup topic', () => {
+    expect(bootCardChatKey('12345', undefined)).toBe('12345:')
+    expect(bootCardChatKey('-1001234567890', 4)).toBe('-1001234567890:4')
+    // Different topics in the same supergroup are distinct cards.
+    expect(bootCardChatKey('-100', 3)).not.toBe(bootCardChatKey('-100', 4))
+  })
+})
+
+describe('loadBootCardMsgId / saveBootCardMsgId', () => {
+  it('returns null when the file does not exist (first boot)', () => {
+    expect(loadBootCardMsgId(path, 'dm:')).toBeNull()
+  })
+
+  it('round-trips a saved id', () => {
+    saveBootCardMsgId(path, 'dm:', 353)
+    expect(loadBootCardMsgId(path, 'dm:')).toBe(353)
+  })
+
+  it('keeps ids for different chats independent', () => {
+    saveBootCardMsgId(path, 'dm:', 100)
+    saveBootCardMsgId(path, '-100:4', 200)
+    expect(loadBootCardMsgId(path, 'dm:')).toBe(100)
+    expect(loadBootCardMsgId(path, '-100:4')).toBe(200)
+    // Updating one leaves the other intact.
+    saveBootCardMsgId(path, 'dm:', 101)
+    expect(loadBootCardMsgId(path, 'dm:')).toBe(101)
+    expect(loadBootCardMsgId(path, '-100:4')).toBe(200)
+  })
+
+  it('returns null for an unknown chat key', () => {
+    saveBootCardMsgId(path, 'dm:', 1)
+    expect(loadBootCardMsgId(path, 'other:')).toBeNull()
+  })
+
+  it('rejects non-positive / non-finite ids on save and load', () => {
+    saveBootCardMsgId(path, 'dm:', 0)
+    saveBootCardMsgId(path, 'dm:', -5)
+    saveBootCardMsgId(path, 'dm:', Number.NaN)
+    expect(loadBootCardMsgId(path, 'dm:')).toBeNull()
+  })
+
+  it('treats a corrupt file as empty (falls back to fresh send)', () => {
+    writeFileSync(path, 'not json{', 'utf8')
+    expect(loadBootCardMsgId(path, 'dm:')).toBeNull()
+    // And a subsequent save still works (overwrites the garbage).
+    saveBootCardMsgId(path, 'dm:', 7)
+    expect(loadBootCardMsgId(path, 'dm:')).toBe(7)
+  })
+
+  it('does not rewrite the file when the id is unchanged (idempotent)', () => {
+    saveBootCardMsgId(path, 'dm:', 42)
+    expect(existsSync(path)).toBe(true)
+    // Saving the same value again is a no-op; the value is still readable.
+    saveBootCardMsgId(path, 'dm:', 42)
+    expect(loadBootCardMsgId(path, 'dm:')).toBe(42)
+  })
+})

package/telegram-plugin/tests/pending-inbound-buffer.test.ts

@@ -220,6 +220,33 @@ describe('redeliverBufferedInbound — wedge-clear self-heal (fleet-update incid
     expect(calls).toBe(0)
   })
 
+  // onDelivered: the deliver-until-acked enrol hook (clerk lost-message
+  // incident 2026-06-03). A socket-write "success" is not proof claude
+  // consumed it; the caller uses onDelivered to enrol the redelivered inbound
+  // in the deliver-until-acked queue so the sweep re-delivers until `enqueue`.
+  it('calls onDelivered for each CONFIRMED-delivered group (per merged identity)', () => {
+    const buf = createPendingInboundBuffer({ log: () => {} })
+    buf.push('klanker', inbound('user', 1))
+    buf.push('klanker', inbound('cron', 2)) // source-tagged → its own group
+    const delivered: number[] = []
+    const r = redeliverBufferedInbound(buf, 'klanker', () => true, undefined, (merged) => {
+      delivered.push(merged.messageId as number)
+    })
+    expect(r.redelivered).toBe(2)
+    expect(delivered).toEqual([1, 2]) // fired once per group, carrying the merged identity
+  })
+
+  it('does NOT call onDelivered for a group that failed to send (re-buffered, not enrolled)', () => {
+    const buf = createPendingInboundBuffer({ log: () => {} })
+    buf.push('klanker', inbound('user', 1))
+    const delivered: number[] = []
+    const r = redeliverBufferedInbound(buf, 'klanker', () => false, undefined, (m) =>
+      delivered.push(m.messageId as number),
+    )
+    expect(r.rebuffered).toBe(1)
+    expect(delivered).toEqual([]) // never enrolled — buffer/spool still own it
+  })
+
   it('only touches the named agent', () => {
     const buf = createPendingInboundBuffer({ log: () => {} })
     buf.push('klanker', inbound('user', 1))

package/telegram-plugin/tests/resume-inbound-builder.test.ts

@@ -179,4 +179,23 @@ describe('selectResumeBuilder', () => {
       expect(selectResumeBuilder(endedVia)).toBe(expected)
     })
   }
+
+  // 3h staleness failsafe (operator spec, 2026-06-03).
+  const MAX = 10_800_000 // 3h
+  it('downgrades a fresh resume to report when older than maxAgeMs (no auto-resume of stale work)', () => {
+    expect(selectResumeBuilder('restart', { ageMs: MAX + 1, maxAgeMs: MAX })).toBe('report')
+    expect(selectResumeBuilder(null, { ageMs: MAX + 60_000, maxAgeMs: MAX })).toBe('report')
+  })
+  it('keeps resume when within maxAgeMs', () => {
+    expect(selectResumeBuilder('restart', { ageMs: MAX - 1, maxAgeMs: MAX })).toBe('resume')
+    expect(selectResumeBuilder('sigterm', { ageMs: 1000, maxAgeMs: MAX })).toBe('resume')
+  })
+  it('age cap never UPGRADES — report/null stay as-is regardless of age', () => {
+    expect(selectResumeBuilder('timeout', { ageMs: MAX + 1, maxAgeMs: MAX })).toBe('report')
+    expect(selectResumeBuilder('stop', { ageMs: MAX + 1, maxAgeMs: MAX })).toBe(null)
+  })
+  it('legacy behaviour preserved when age/maxAge omitted (blanket resume)', () => {
+    expect(selectResumeBuilder('restart')).toBe('resume')
+    expect(selectResumeBuilder('restart', { ageMs: MAX + 1 })).toBe('resume') // needs BOTH to cap
+  })
 })