swift-code-reviewer-skill 1.3.0 → 1.4.0

package/bin/install.js

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+'use strict';
 
 const fs = require('fs');
 const path = require('path');
@@ -6,7 +7,6 @@ const os = require('os');
 
 const SKILL_NAME = 'swift-code-reviewer-skill';
 
-// Colors for terminal output
 const colors = {
   reset: '\x1b[0m',
   bright: '\x1b[1m',
@@ -14,7 +14,7 @@ const colors = {
   yellow: '\x1b[33m',
   blue: '\x1b[34m',
   red: '\x1b[31m',
-  cyan: '\x1b[36m'
+  cyan: '\x1b[36m',
 };
 
 function log(message, color = colors.reset) {
@@ -23,14 +23,9 @@ function log(message, color = colors.reset) {
 
 function copyRecursive(src, dest) {
   const stats = fs.statSync(src);
-
   if (stats.isDirectory()) {
-    if (!fs.existsSync(dest)) {
-      fs.mkdirSync(dest, { recursive: true });
-    }
-
-    const entries = fs.readdirSync(src);
-    for (const entry of entries) {
+    if (!fs.existsSync(dest)) fs.mkdirSync(dest, { recursive: true });
+    for (const entry of fs.readdirSync(src)) {
       copyRecursive(path.join(src, entry), path.join(dest, entry));
     }
   } else {
@@ -39,18 +34,20 @@ function copyRecursive(src, dest) {
 }
 
 function findPackageRoot() {
-  let packageRoot = __dirname;
-  while (!fs.existsSync(path.join(packageRoot, 'SKILL.md'))) {
-    const parent = path.dirname(packageRoot);
-    if (parent === packageRoot) {
+  let dir = __dirname;
+  while (!fs.existsSync(path.join(dir, 'SKILL.md'))) {
+    const parent = path.dirname(dir);
+    if (parent === dir) {
       log('  Error: Could not find SKILL.md in package', colors.red);
       process.exit(1);
     }
-    packageRoot = parent;
+    dir = parent;
   }
-  return packageRoot;
+  return dir;
 }
 
+// ---------- global install (default command) ----------
+
 function install() {
   log('\n  Swift Code Reviewer Skill Installer', colors.cyan + colors.bright);
   log('  ====================================\n', colors.cyan);
@@ -76,113 +73,70 @@ function install() {
 
   fs.mkdirSync(targetDir, { recursive: true });
 
-  const filesToCopy = [
-    'SKILL.md',
-    'README.md',
-    'LICENSE',
-    'CONTRIBUTING.md',
-    'CHANGELOG.md'
-  ];
-
-  const dirsToCopy = ['references', 'skills', 'templates'];
+  const filesToCopy = ['SKILL.md', 'README.md', 'LICENSE', 'CONTRIBUTING.md', 'CHANGELOG.md'];
+  const dirsToCopy = ['core', 'references', 'skills', 'templates'];
 
   for (const file of filesToCopy) {
     const src = path.join(packageRoot, file);
-    const dest = path.join(targetDir, file);
-
     if (fs.existsSync(src)) {
-      fs.copyFileSync(src, dest);
+      fs.copyFileSync(src, path.join(targetDir, file));
       log(`  Copied: ${file}`, colors.green);
     }
   }
 
   for (const dir of dirsToCopy) {
     const src = path.join(packageRoot, dir);
-    const dest = path.join(targetDir, dir);
-
     if (fs.existsSync(src)) {
-      copyRecursive(src, dest);
+      copyRecursive(src, path.join(targetDir, dir));
       log(`  Copied: ${dir}/`, colors.green);
     }
   }
 
   log('\n  Installation complete!', colors.green + colors.bright);
   log('\n  The skill is now available in Claude Code.', colors.reset);
-  log('  To add the review agent and /review command to a project, run:', colors.reset);
+  log('  To scaffold the review agent into a project, run:', colors.reset);
   log('\n    npx swift-code-reviewer-skill init\n', colors.cyan);
-  log('  Or use it directly by asking Claude to:', colors.reset);
-  log('\n    - "Review this PR"', colors.cyan);
-  log('    - "Review LoginView.swift"', colors.cyan);
-  log('    - "Review my uncommitted changes"', colors.cyan);
-  log('    - "Check if this follows our coding standards"\n', colors.cyan);
-
   log(`  Skill location: ${targetDir}`, colors.blue);
   log('  Documentation: https://github.com/Viniciuscarvalho/swift-code-reviewer-skill\n', colors.blue);
 }
 
-function init() {
+// ---------- init (project scaffolding) ----------
+
+async function init(flags) {
   log('\n  Swift Code Reviewer — Project Setup', colors.cyan + colors.bright);
   log('  =====================================\n', colors.cyan);
 
   const packageRoot = findPackageRoot();
   const cwd = process.cwd();
 
-  // Verify we're in a git repo (likely a real project)
   if (!fs.existsSync(path.join(cwd, '.git'))) {
     log('  Warning: Not a git repository. Running anyway.\n', colors.yellow);
   }
 
-  const claudeDir = path.join(cwd, '.claude');
-  const agentsDir = path.join(claudeDir, 'agents');
-  const commandsDir = path.join(claudeDir, 'commands');
+  const { selectAgents } = require('./lib/prompt');
+  const { AGENT_INSTALLERS } = require('./lib/agents');
 
-  const templateAgentSrc = path.join(packageRoot, 'templates', 'agents', 'swift-code-reviewer.md');
-  const templateCommandSrc = path.join(packageRoot, 'templates', 'commands', 'review.md');
+  const agents = await selectAgents({
+    allFlag: flags.all,
+    agentFlag: flags.agent,
+    isTTY: Boolean(process.stdout.isTTY),
+  });
 
-  // Check templates exist
-  if (!fs.existsSync(templateAgentSrc)) {
-    log('  Error: Agent template not found. Reinstall the skill with:', colors.red);
-    log('    npx swift-code-reviewer-skill\n', colors.cyan);
-    process.exit(1);
+  if (agents.length === 0) {
+    log('  No agents selected. Nothing to do.\n', colors.yellow);
+    return;
   }
 
-  fs.mkdirSync(agentsDir, { recursive: true });
-  fs.mkdirSync(commandsDir, { recursive: true });
-
-  let created = 0;
-  let skipped = 0;
-
-  // Copy agent
-  const agentDest = path.join(agentsDir, 'swift-code-reviewer.md');
-  if (fs.existsSync(agentDest)) {
-    log('  Skipped: .claude/agents/swift-code-reviewer.md (already exists)', colors.yellow);
-    skipped++;
-  } else {
-    fs.copyFileSync(templateAgentSrc, agentDest);
-    log('  Created: .claude/agents/swift-code-reviewer.md', colors.green);
-    created++;
+  const opts = { dryRun: flags.dryRun, force: flags.force };
+  for (const agent of agents) {
+    AGENT_INSTALLERS[agent](packageRoot, cwd, opts);
   }
 
-  // Copy command
-  const commandDest = path.join(commandsDir, 'review.md');
-  if (fs.existsSync(commandDest)) {
-    log('  Skipped: .claude/commands/review.md (already exists)', colors.yellow);
-    skipped++;
-  } else {
-    fs.copyFileSync(templateCommandSrc, commandDest);
-    log('  Created: .claude/commands/review.md', colors.green);
-    created++;
-  }
-
-  log(`\n  Done! ${created} file(s) created, ${skipped} skipped.`, colors.green + colors.bright);
-
-  if (created > 0) {
-    log('\n  Usage:', colors.reset);
-    log('    /review          — run a full code review before pushing', colors.cyan);
-    log('    @swift-code-reviewer — invoke the agent directly\n', colors.cyan);
-  }
+  log('\n  Done!\n', colors.green + colors.bright);
 }
 
+// ---------- uninstall ----------
+
 function uninstall() {
   log('\n  Uninstalling Swift Code Reviewer Skill', colors.yellow + colors.bright);
   log('  ======================================\n', colors.yellow);
@@ -199,29 +153,56 @@ function uninstall() {
   }
 }
 
+// ---------- help ----------
+
 function showHelp() {
   log('\n  Swift Code Reviewer Skill', colors.cyan + colors.bright);
   log('  =========================\n', colors.cyan);
-  log('  Usage: npx swift-code-reviewer-skill [command]\n', colors.reset);
+  log('  Usage: npx swift-code-reviewer-skill [command] [options]\n', colors.reset);
   log('  Commands:', colors.bright);
   log('    (none)     Install the skill to ~/.claude/skills/', colors.reset);
-  log('    init       Scaffold agent + /review command into current project', colors.reset);
+  log('    init       Scaffold review agent into the current project', colors.reset);
   log('    uninstall  Remove the skill from ~/.claude/skills/', colors.reset);
   log('    help       Show this help message\n', colors.reset);
+  log('  Options for init:', colors.bright);
+  log('    --agent <name[,name]>   Target specific agent(s): claude, codex, gemini, kiro', colors.reset);
+  log('    --all                   Install for all supported agents', colors.reset);
+  log('    --force                 Overwrite existing files', colors.reset);
+  log('    --dry-run               Preview writes without touching the filesystem\n', colors.reset);
   log('  Examples:', colors.bright);
-  log('    npx swift-code-reviewer-skill              # install skill globally', colors.cyan);
-  log('    npx swift-code-reviewer-skill init          # add agent + command to project', colors.cyan);
-  log('    npx swift-code-reviewer-skill uninstall     # remove skill\n', colors.cyan);
+  log('    npx swift-code-reviewer-skill              # install skill globally (Claude)', colors.cyan);
+  log('    npx swift-code-reviewer-skill init          # interactive agent picker', colors.cyan);
+  log('    npx swift-code-reviewer-skill init --all    # all agents at once', colors.cyan);
+  log('    npx swift-code-reviewer-skill init --agent codex,gemini', colors.cyan);
+  log('    npx swift-code-reviewer-skill init --dry-run', colors.cyan);
+  log('    npx swift-code-reviewer-skill uninstall\n', colors.cyan);
 }
 
-// Parse command line arguments
+// ---------- arg parsing ----------
+
+function parseFlags(argv) {
+  const flags = { all: false, agent: null, dryRun: false, force: false };
+  for (let i = 0; i < argv.length; i++) {
+    const arg = argv[i];
+    if (arg === '--all') flags.all = true;
+    else if (arg === '--dry-run') flags.dryRun = true;
+    else if (arg === '--force') flags.force = true;
+    else if (arg === '--agent' && argv[i + 1]) { flags.agent = argv[++i]; }
+    else if (arg.startsWith('--agent=')) { flags.agent = arg.slice('--agent='.length); }
+  }
+  return flags;
+}
+
+// ---------- entry point ----------
+
 const args = process.argv.slice(2);
-const command = args[0];
+const command = args.find((a) => !a.startsWith('-')) || '';
+const flags = parseFlags(args.filter((a) => a.startsWith('-') || args.indexOf(a) > 0));
 
 switch (command) {
   case 'init':
   case 'setup':
-    init();
+    init(flags).catch((err) => { console.error(err); process.exit(1); });
     break;
   case 'uninstall':
   case 'remove':

package/bin/lib/agents.js

@@ -0,0 +1,134 @@
+'use strict';
+
+const fs = require('fs');
+const path = require('path');
+
+const colors = {
+  reset: '\x1b[0m',
+  bright: '\x1b[1m',
+  green: '\x1b[32m',
+  yellow: '\x1b[33m',
+  blue: '\x1b[34m',
+  cyan: '\x1b[36m',
+};
+
+function log(msg, color = colors.reset) {
+  console.log(`${color}${msg}${colors.reset}`);
+}
+
+function writeFile(dest, src, label, dryRun) {
+  const exists = fs.existsSync(dest);
+  if (dryRun) {
+    log(`  [dry-run] ${exists ? 'Update' : 'Create'}: ${label}`, colors.blue);
+    return;
+  }
+  if (exists) {
+    log(`  Updated: ${label}`, colors.yellow);
+  } else {
+    log(`  Created: ${label}`, colors.green);
+  }
+  fs.mkdirSync(path.dirname(dest), { recursive: true });
+  fs.copyFileSync(src, dest);
+}
+
+function skipFile(label, dryRun) {
+  if (dryRun) {
+    log(`  [dry-run] Skip (exists): ${label}`, colors.yellow);
+  } else {
+    log(`  Skipped: ${label} (already exists)`, colors.yellow);
+  }
+}
+
+function installClaude(packageRoot, cwd, { dryRun = false, force = false } = {}) {
+  log('\n  Installing for Claude Code…', colors.cyan);
+
+  const agentSrc = path.join(packageRoot, 'templates', 'agents', 'claude', 'swift-code-reviewer.md');
+  const cmdSrc = path.join(packageRoot, 'templates', 'commands', 'claude', 'review.md');
+
+  const agentDest = path.join(cwd, '.claude', 'agents', 'swift-code-reviewer.md');
+  const cmdDest = path.join(cwd, '.claude', 'commands', 'review.md');
+
+  if (!force && fs.existsSync(agentDest)) {
+    skipFile('.claude/agents/swift-code-reviewer.md', dryRun);
+  } else {
+    writeFile(agentDest, agentSrc, '.claude/agents/swift-code-reviewer.md', dryRun);
+  }
+
+  if (!force && fs.existsSync(cmdDest)) {
+    skipFile('.claude/commands/review.md', dryRun);
+  } else {
+    writeFile(cmdDest, cmdSrc, '.claude/commands/review.md', dryRun);
+  }
+
+  log('\n  Claude Code hints:', colors.reset);
+  log('    /review              — run a full Swift code review', colors.cyan);
+  log('    @swift-code-reviewer — invoke the agent directly\n', colors.cyan);
+}
+
+function installCodex(packageRoot, cwd, { dryRun = false, force = false } = {}) {
+  log('\n  Installing for OpenAI Codex CLI…', colors.cyan);
+
+  const agentSrc = path.join(packageRoot, 'templates', 'agents', 'codex', 'swift-code-reviewer.md');
+  const agentDest = path.join(cwd, 'swift-code-reviewer.md');
+
+  if (!force && fs.existsSync(agentDest)) {
+    skipFile('swift-code-reviewer.md', dryRun);
+  } else {
+    writeFile(agentDest, agentSrc, 'swift-code-reviewer.md', dryRun);
+  }
+
+  log('\n  Codex post-install — add this to your AGENTS.md:\n', colors.reset);
+  log('    ## Swift code review', colors.cyan);
+  log('    See swift-code-reviewer.md for the full review guide.\n', colors.cyan);
+  log('  Note: Codex concatenates AGENTS.md into the system prompt and does not', colors.yellow);
+  log('  auto-resolve @-path mentions. Paste the snippet above manually.\n', colors.yellow);
+}
+
+function installGemini(packageRoot, cwd, { dryRun = false, force = false } = {}) {
+  log('\n  Installing for Google Gemini CLI…', colors.cyan);
+
+  const agentSrc = path.join(packageRoot, 'templates', 'agents', 'gemini', 'swift-code-reviewer.md');
+  const cmdSrc = path.join(packageRoot, 'templates', 'commands', 'gemini', 'review.toml');
+
+  const agentDest = path.join(cwd, 'swift-code-reviewer.md');
+  const cmdDest = path.join(cwd, '.gemini', 'commands', 'review.toml');
+
+  if (!force && fs.existsSync(agentDest)) {
+    skipFile('swift-code-reviewer.md', dryRun);
+  } else {
+    writeFile(agentDest, agentSrc, 'swift-code-reviewer.md', dryRun);
+  }
+
+  if (!force && fs.existsSync(cmdDest)) {
+    skipFile('.gemini/commands/review.toml', dryRun);
+  } else {
+    writeFile(cmdDest, cmdSrc, '.gemini/commands/review.toml', dryRun);
+  }
+
+  log('\n  Gemini CLI hints:', colors.reset);
+  log('    /review              — run a full Swift code review (via review.toml)', colors.cyan);
+  log('    The command uses @./swift-code-reviewer.md to load the guide.\n', colors.cyan);
+}
+
+function installKiro(packageRoot, cwd, { dryRun = false, force = false } = {}) {
+  log('\n  Installing for Kiro…', colors.cyan);
+
+  const agentSrc = path.join(packageRoot, 'templates', 'agents', 'kiro', 'swift-code-reviewer.md');
+  const agentDest = path.join(cwd, '.kiro', 'steering', 'swift-code-reviewer.md');
+
+  if (!force && fs.existsSync(agentDest)) {
+    skipFile('.kiro/steering/swift-code-reviewer.md', dryRun);
+  } else {
+    writeFile(agentDest, agentSrc, '.kiro/steering/swift-code-reviewer.md', dryRun);
+  }
+
+  log('\n  Kiro hints:', colors.reset);
+  log('    Steering auto-activates for any *.swift file (fileMatch inclusion).', colors.cyan);
+  log('    Note: workspace-scoped steering only — global steering has a known', colors.yellow);
+  log('    bug (https://github.com/kirodotdev/Kiro/issues/6171).\n', colors.yellow);
+}
+
+const AGENT_INSTALLERS = { claude: installClaude, codex: installCodex, gemini: installGemini, kiro: installKiro };
+const VALID_AGENTS = Object.keys(AGENT_INSTALLERS);
+
+module.exports = { installClaude, installCodex, installGemini, installKiro, AGENT_INSTALLERS, VALID_AGENTS };

package/bin/lib/prompt.js

@@ -0,0 +1,58 @@
+'use strict';
+
+const { VALID_AGENTS } = require('./agents');
+
+/**
+ * Resolve which agents to install based on CLI flags and TTY state.
+ *
+ * Priority:
+ *   1. --all flag → all agents
+ *   2. --agent <name[,name]> flag → named agents
+ *   3. TTY available → interactive @inquirer/prompts checkbox
+ *   4. Non-TTY without flags → ['claude'] (CI-safe fallback)
+ */
+async function selectAgents({ allFlag, agentFlag, isTTY } = {}) {
+  if (allFlag) return [...VALID_AGENTS];
+
+  if (agentFlag) {
+    const requested = agentFlag.split(',').map((s) => s.trim().toLowerCase());
+    const invalid = requested.filter((a) => !VALID_AGENTS.includes(a));
+    if (invalid.length > 0) {
+      console.error(`  Unknown agent(s): ${invalid.join(', ')}`);
+      console.error(`  Valid options: ${VALID_AGENTS.join(', ')}`);
+      process.exit(1);
+    }
+    return requested;
+  }
+
+  if (!isTTY) {
+    return ['claude'];
+  }
+
+  const { checkbox } = require('@inquirer/prompts');
+  const choices = VALID_AGENTS.map((name) => ({
+    name: agentLabel(name),
+    value: name,
+    checked: name === 'claude',
+  }));
+
+  const selected = await checkbox({
+    message: 'Which agent(s) should the review guide be installed for?',
+    choices,
+    validate: (val) => val.length > 0 || 'Select at least one agent.',
+  });
+
+  return selected;
+}
+
+function agentLabel(name) {
+  const labels = {
+    claude: 'Claude Code  (.claude/agents/ + .claude/commands/)',
+    codex:  'OpenAI Codex CLI  (swift-code-reviewer.md at repo root)',
+    gemini: 'Google Gemini CLI  (swift-code-reviewer.md + .gemini/commands/review.toml)',
+    kiro:   'Kiro  (.kiro/steering/swift-code-reviewer.md, fileMatch: **/*.swift)',
+  };
+  return labels[name] || name;
+}
+
+module.exports = { selectAgents };