swift-code-reviewer-skill 1.1.1 → 1.2.1

package/skills/swiftui-ui-patterns/references/menu-bar.md

@@ -0,0 +1,101 @@
+# Menu Bar
+
+## Intent
+
+Use this when adding or customizing the macOS/iPadOS menu bar with SwiftUI commands.
+
+## Core patterns
+
+- Add commands at the `Scene` level with `.commands { ... }`.
+- Use `SidebarCommands()` when your UI includes a navigation sidebar.
+- Use `CommandMenu` for app-specific menus and group related actions.
+- Use `CommandGroup` to insert items before/after system groups or replace them.
+- Use `FocusedValue` for context-sensitive menu items that depend on the active scene.
+
+## Example: basic command menu
+
+```swift
+@main
+struct MyApp: App {
+  var body: some Scene {
+    WindowGroup {
+      ContentView()
+    }
+    .commands {
+      CommandMenu("Actions") {
+        Button("Run", action: run)
+          .keyboardShortcut("R")
+        Button("Stop", action: stop)
+          .keyboardShortcut(".")
+      }
+    }
+  }
+
+  private func run() {}
+  private func stop() {}
+}
+```
+
+## Example: insert and replace groups
+
+```swift
+WindowGroup {
+  ContentView()
+}
+.commands {
+  CommandGroup(before: .systemServices) {
+    Button("Check for Updates") { /* open updater */ }
+  }
+
+  CommandGroup(after: .newItem) {
+    Button("New from Clipboard") { /* create item */ }
+  }
+
+  CommandGroup(replacing: .help) {
+    Button("User Manual") { /* open docs */ }
+  }
+}
+```
+
+## Example: focused menu state
+
+```swift
+@Observable
+final class DataModel {
+  var items: [String] = []
+}
+
+struct ContentView: View {
+  @State private var model = DataModel()
+
+  var body: some View {
+    List(model.items, id: \.self) { item in
+      Text(item)
+    }
+    .focusedSceneValue(model)
+  }
+}
+
+struct ItemCommands: Commands {
+  @FocusedValue(DataModel.self) private var model: DataModel?
+
+  var body: some Commands {
+    CommandGroup(after: .newItem) {
+      Button("New Item") {
+        model?.items.append("Untitled")
+      }
+      .disabled(model == nil)
+    }
+  }
+}
+```
+
+## Menu bar and Settings
+
+- Defining a `Settings` scene adds the Settings menu item on macOS automatically.
+- If you need a custom entry point inside the app, use `OpenSettingsAction` or `SettingsLink`.
+
+## Pitfalls
+
+- Avoid registering the same keyboard shortcut in multiple command groups.
+- Don’t use menu items as the only discoverable entry point for critical features.

package/skills/swiftui-ui-patterns/references/navigationstack.md

@@ -0,0 +1,159 @@
+# NavigationStack
+
+## Intent
+
+Use this pattern for programmatic navigation and deep links, especially when each tab needs an independent navigation history. The key idea is one `NavigationStack` per tab, each with its own path binding and router object.
+
+## Core architecture
+
+- Define a route enum that is `Hashable` and represents all destinations.
+- Create a lightweight router (or use a library such as `https://github.com/Dimillian/AppRouter`) that owns the `path` and any sheet state.
+- Each tab owns its own router instance and binds `NavigationStack(path:)` to it.
+- Inject the router into the environment so child views can navigate programmatically.
+- Centralize destination mapping with a single `navigationDestination(for:)` block (or a `withAppRouter()` modifier).
+
+## Example: custom router with per-tab stack
+
+```swift
+@MainActor
+@Observable
+final class RouterPath {
+  var path: [Route] = []
+  var presentedSheet: SheetDestination?
+
+  func navigate(to route: Route) {
+    path.append(route)
+  }
+
+  func reset() {
+    path = []
+  }
+}
+
+enum Route: Hashable {
+  case account(id: String)
+  case status(id: String)
+}
+
+@MainActor
+struct TimelineTab: View {
+  @State private var routerPath = RouterPath()
+
+  var body: some View {
+    NavigationStack(path: $routerPath.path) {
+      TimelineView()
+        .navigationDestination(for: Route.self) { route in
+          switch route {
+          case .account(let id): AccountView(id: id)
+          case .status(let id): StatusView(id: id)
+          }
+        }
+    }
+    .environment(routerPath)
+  }
+}
+```
+
+## Example: centralized destination mapping
+
+Use a shared view modifier to avoid duplicating route switches across screens.
+
+```swift
+extension View {
+  func withAppRouter() -> some View {
+    navigationDestination(for: Route.self) { route in
+      switch route {
+      case .account(let id):
+        AccountView(id: id)
+      case .status(let id):
+        StatusView(id: id)
+      }
+    }
+  }
+}
+```
+
+Then apply it once per stack:
+
+```swift
+NavigationStack(path: $routerPath.path) {
+  TimelineView()
+    .withAppRouter()
+}
+```
+
+## Example: binding per tab (tabs with independent history)
+
+```swift
+@MainActor
+struct TabsView: View {
+  @State private var timelineRouter = RouterPath()
+  @State private var notificationsRouter = RouterPath()
+
+  var body: some View {
+    TabView {
+      TimelineTab(router: timelineRouter)
+      NotificationsTab(router: notificationsRouter)
+    }
+  }
+}
+```
+
+## Example: generic tabs with per-tab NavigationStack
+
+Use this when tabs are built from data and each needs its own path without hard-coded names.
+
+```swift
+@MainActor
+struct TabsView: View {
+  @State private var selectedTab: AppTab = .timeline
+  @State private var tabRouter = TabRouter()
+
+  var body: some View {
+    TabView(selection: $selectedTab) {
+      ForEach(AppTab.allCases) { tab in
+        NavigationStack(path: tabRouter.binding(for: tab)) {
+          tab.makeContentView()
+        }
+        .environment(tabRouter.router(for: tab))
+        .tabItem { tab.label }
+        .tag(tab)
+      }
+    }
+  }
+}
+```
+
+@MainActor
+@Observable
+final class TabRouter {
+  private var routers: [AppTab: RouterPath] = [:]
+
+  func router(for tab: AppTab) -> RouterPath {
+    if let router = routers[tab] { return router }
+    let router = RouterPath()
+    routers[tab] = router
+    return router
+  }
+
+  func binding(for tab: AppTab) -> Binding<[Route]> {
+    let router = router(for: tab)
+    return Binding(get: { router.path }, set: { router.path = $0 })
+  }
+}
+
+## Design choices to keep
+
+- One `NavigationStack` per tab to preserve independent history.
+- A single source of truth for navigation state (`RouterPath` or library router).
+- Use `navigationDestination(for:)` to map routes to views.
+- Reset the path when app context changes (account switch, logout, etc.).
+- Inject the router into the environment so child views can navigate and present sheets without prop-drilling.
+- Keep sheet presentation state on the router if you want a single place to manage modals.
+
+## Pitfalls
+
+- Do not share one path across all tabs unless you want global history.
+- Ensure route identifiers are stable and `Hashable`.
+- Avoid storing view instances in the path; store lightweight route data instead.
+- If using a router object, keep it outside other `@Observable` objects to avoid nested observation.

package/skills/swiftui-ui-patterns/references/overlay.md

@@ -0,0 +1,45 @@
+# Overlay and toasts
+
+## Intent
+
+Use overlays for transient UI (toasts, banners, loaders) without affecting layout.
+
+## Core patterns
+
+- Use `.overlay(alignment:)` to place global UI without changing the underlying layout.
+- Keep overlays lightweight and dismissible.
+- Use a dedicated `ToastCenter` (or similar) for global state if multiple features trigger toasts.
+
+## Example: toast overlay
+
+```swift
+struct AppRootView: View {
+  @State private var toast: Toast?
+
+  var body: some View {
+    content
+      .overlay(alignment: .top) {
+        if let toast {
+          ToastView(toast: toast)
+            .transition(.move(edge: .top).combined(with: .opacity))
+            .onAppear {
+              DispatchQueue.main.asyncAfter(deadline: .now() + 2) {
+                withAnimation { self.toast = nil }
+              }
+            }
+        }
+      }
+  }
+}
+```
+
+## Design choices to keep
+
+- Prefer overlays for transient UI rather than embedding in layout stacks.
+- Use transitions and short auto-dismiss timers.
+- Keep the overlay aligned to a clear edge (`.top` or `.bottom`).
+
+## Pitfalls
+
+- Avoid overlays that block all interaction unless explicitly needed.
+- Don’t stack many overlays; use a queue or replace the current toast.

package/skills/swiftui-ui-patterns/references/performance.md

@@ -0,0 +1,62 @@
+# Performance guardrails
+
+## Intent
+
+Use these rules when a SwiftUI screen is large, scroll-heavy, frequently updated, or at risk of unnecessary recomputation.
+
+## Core rules
+
+- Give `ForEach` and list content stable identity. Do not use unstable indices as identity when the collection can reorder or mutate.
+- Keep expensive filtering, sorting, and formatting out of `body`; precompute or move it into a model/helper when it is not trivial.
+- Narrow observation scope so only the views that read changing state need to update.
+- Prefer lazy containers for larger scrolling content and extract subviews when only part of a screen changes frequently.
+- Avoid swapping entire top-level view trees for small state changes; keep a stable root view and vary localized sections or modifiers.
+
+## Example: stable identity
+
+```swift
+ForEach(items) { item in
+  Row(item: item)
+}
+```
+
+Prefer that over index-based identity when the collection can change order:
+
+```swift
+ForEach(Array(items.enumerated()), id: \.offset) { _, item in
+  Row(item: item)
+}
+```
+
+## Example: move expensive work out of body
+
+```swift
+struct FeedView: View {
+  let items: [FeedItem]
+
+  private var sortedItems: [FeedItem] {
+    items.sorted(using: KeyPathComparator(\.createdAt, order: .reverse))
+  }
+
+  var body: some View {
+    List(sortedItems) { item in
+      FeedRow(item: item)
+    }
+  }
+}
+```
+
+If the work is more expensive than a small derived property, move it into a model, store, or helper that updates less often.
+
+## When to investigate further
+
+- Janky scrolling in long feeds or grids
+- Typing lag from search or form validation
+- Overly broad view updates when one small piece of state changes
+- Large screens with many conditionals or repeated formatting work
+
+## Pitfalls
+
+- Recomputing heavy transforms every render
+- Observing a large object from many descendants when only one field matters
+- Building custom scroll containers when `List`, `LazyVStack`, or `LazyHGrid` would already solve the problem

package/skills/swiftui-ui-patterns/references/previews.md

@@ -0,0 +1,48 @@
+# Previews
+
+## Intent
+
+Use previews to validate layout, state wiring, and injected dependencies without relying on a running app or live services.
+
+## Core rules
+
+- Add `#Preview` coverage for the primary state plus important secondary states such as loading, empty, and error.
+- Use deterministic fixtures, mocks, and sample data. Do not make previews depend on live network calls, real databases, or global singletons.
+- Install required environment dependencies directly in the preview so the view can render in isolation.
+- Keep preview setup close to the view until it becomes noisy; then extract lightweight preview helpers or fixtures.
+- If a preview crashes, fix the state initialization or dependency wiring before expanding the feature further.
+
+## Example: simple preview states
+
+```swift
+#Preview("Loaded") {
+  ProfileView(profile: .fixture)
+}
+
+#Preview("Empty") {
+  ProfileView(profile: nil)
+}
+```
+
+## Example: preview with injected dependencies
+
+```swift
+#Preview("Search results") {
+  SearchView()
+    .environment(SearchClient.preview(results: [.fixture, .fixture2]))
+    .environment(Theme.preview)
+}
+```
+
+## Preview checklist
+
+- Does the preview install every required environment dependency?
+- Does it cover at least one success path and one non-happy path?
+- Are fixtures stable and small enough to be read quickly?
+- Can the preview render without network, auth, or app-global initialization?
+
+## Pitfalls
+
+- Do not hide preview crashes by making dependencies optional if the production view requires them.
+- Avoid huge inline fixtures when a named sample is easier to read.
+- Do not couple previews to global shared singletons unless the project has no alternative.

package/skills/swiftui-ui-patterns/references/scroll-reveal.md

@@ -0,0 +1,133 @@
+# Scroll-reveal detail surfaces
+
+## Intent
+
+Use this pattern when a detail screen has a primary surface first and secondary content behind it, and you want the user to reveal that secondary layer by scrolling or swiping instead of tapping a separate button.
+
+Typical fits:
+
+- media detail screens that reveal actions or metadata
+- maps, cards, or canvases that transition into structured detail
+- full-screen viewers with a second "actions" or "insights" page
+
+## Core pattern
+
+Build the interaction as a paged vertical `ScrollView` with two sections:
+
+1. a primary section sized to the viewport
+2. a secondary section below it
+
+Derive a normalized `progress` value from the vertical content offset and drive all visual changes from that one value.
+
+Avoid treating the reveal as a separate gesture system unless scroll alone cannot express it.
+
+## Minimal structure
+
+```swift
+private enum DetailSection: Hashable {
+  case primary
+  case secondary
+}
+
+struct DetailSurface: View {
+  @State private var revealProgress: CGFloat = 0
+  @State private var secondaryHeight: CGFloat = 1
+
+  var body: some View {
+    GeometryReader { geometry in
+      ScrollViewReader { proxy in
+        ScrollView(.vertical, showsIndicators: false) {
+          VStack(spacing: 0) {
+            PrimaryContent(progress: revealProgress)
+              .frame(height: geometry.size.height)
+              .id(DetailSection.primary)
+
+            SecondaryContent(progress: revealProgress)
+              .id(DetailSection.secondary)
+              .onGeometryChange(for: CGFloat.self) { geo in
+                geo.size.height
+              } action: { newHeight in
+                secondaryHeight = max(newHeight, 1)
+              }
+          }
+          .scrollTargetLayout()
+        }
+        .scrollTargetBehavior(.paging)
+        .onScrollGeometryChange(for: CGFloat.self, of: { scroll in
+          scroll.contentOffset.y + scroll.contentInsets.top
+        }) { _, offset in
+          revealProgress = (offset / secondaryHeight).clamped(to: 0...1)
+        }
+        .safeAreaInset(edge: .bottom) {
+          ChevronAffordance(progress: revealProgress) {
+            withAnimation(.smooth) {
+              let target: DetailSection = revealProgress < 0.5 ? .secondary : .primary
+              proxy.scrollTo(target, anchor: .top)
+            }
+          }
+        }
+      }
+    }
+  }
+}
+```
+
+## Design choices to keep
+
+- Make the primary section exactly viewport-sized when the interaction should feel like paging between states.
+- Compute `progress` from real scroll offset, not from duplicated booleans like `isExpanded`, `isShowingSecondary`, and `isSnapped`.
+- Use `progress` to drive `offset`, `opacity`, `blur`, `scaleEffect`, and toolbar state so the whole surface stays synchronized.
+- Use `ScrollViewReader` for programmatic snapping from taps on the primary content or chevron affordances.
+- Use `onScrollTargetVisibilityChange` when you need a settled section state for haptics, tooltip dismissal, analytics, or accessibility announcements.
+
+## Morphing a shared control
+
+If a control appears to move from the primary surface into the secondary content, do not render two fully visible copies.
+
+Instead:
+
+- expose a source anchor in the primary area
+- expose a destination anchor in the secondary area
+- render one overlay that interpolates position and size using `progress`
+
+```swift
+Color.clear
+  .anchorPreference(key: ControlAnchorKey.self, value: .bounds) { anchor in
+    ["source": anchor]
+  }
+
+Color.clear
+  .anchorPreference(key: ControlAnchorKey.self, value: .bounds) { anchor in
+    ["destination": anchor]
+  }
+
+.overlayPreferenceValue(ControlAnchorKey.self) { anchors in
+  MorphingControlOverlay(anchors: anchors, progress: revealProgress)
+}
+```
+
+This keeps the motion coherent and avoids duplicate-hit-target bugs.
+
+## Haptics and affordances
+
+- Use light threshold haptics when the reveal begins and stronger haptics near the committed state.
+- Keep a visible affordance like a chevron or pill while `progress` is near zero.
+- Flip, fade, or blur the affordance as the secondary section becomes active.
+
+## Interaction guards
+
+- Disable vertical scrolling when a conflicting mode is active, such as pinch-to-zoom, crop, or full-screen media manipulation.
+- Disable hit testing on overlays that should disappear once the secondary content is revealed.
+- Avoid same-axis nested scroll views unless the inner view is effectively static or disabled during the reveal.
+
+## Pitfalls
+
+- Do not hard-code the progress divisor. Measure the secondary section height or another real reveal distance.
+- Do not mix multiple animation sources for the same property. If `progress` drives it, keep other animations off that property.
+- Do not store derived state like `isSecondaryVisible` unless another API requires it. Prefer deriving it from `progress` or visible scroll targets.
+- Beware of layout feedback loops when measuring heights. Clamp zero values and update only when the measured height actually changes.
+
+## Concrete example
+
+- Pool iOS tile detail reveal: `/Users/dimillian/Documents/Dev/Pool/pool-ios/Pool/Sources/Features/Tile/Detail/TileDetailView.swift`
+- Secondary content anchor example: `/Users/dimillian/Documents/Dev/Pool/pool-ios/Pool/Sources/Features/Tile/Detail/TileDetailIntentListView.swift`

package/skills/swiftui-ui-patterns/references/scrollview.md

@@ -0,0 +1,87 @@
+# ScrollView and Lazy stacks
+
+## Intent
+
+Use `ScrollView` with `LazyVStack`, `LazyHStack`, or `LazyVGrid` when you need custom layout, mixed content, or horizontal/ grid-based scrolling.
+
+## Core patterns
+
+- Prefer `ScrollView` + `LazyVStack` for chat-like or custom feed layouts.
+- Use `ScrollView(.horizontal)` + `LazyHStack` for chips, tags, avatars, and media strips.
+- Use `LazyVGrid` for icon/media grids; prefer adaptive columns when possible.
+- Use `ScrollViewReader` for scroll-to-top/bottom and anchor-based jumps.
+- Use `safeAreaInset(edge:)` for input bars that should stick above the keyboard.
+
+## Example: vertical custom feed
+
+```swift
+@MainActor
+struct ConversationView: View {
+  private enum Constants { static let bottomAnchor = "bottom" }
+  @State private var scrollProxy: ScrollViewProxy?
+
+  var body: some View {
+    ScrollViewReader { proxy in
+      ScrollView {
+        LazyVStack {
+          ForEach(messages) { message in
+            MessageRow(message: message)
+              .id(message.id)
+          }
+          Color.clear.frame(height: 1).id(Constants.bottomAnchor)
+        }
+        .padding(.horizontal, .layoutPadding)
+      }
+      .safeAreaInset(edge: .bottom) {
+        MessageInputBar()
+      }
+      .onAppear {
+        scrollProxy = proxy
+        withAnimation {
+          proxy.scrollTo(Constants.bottomAnchor, anchor: .bottom)
+        }
+      }
+    }
+  }
+}
+```
+
+## Example: horizontal chips
+
+```swift
+ScrollView(.horizontal, showsIndicators: false) {
+  LazyHStack(spacing: 8) {
+    ForEach(chips) { chip in
+      ChipView(chip: chip)
+    }
+  }
+}
+```
+
+## Example: adaptive grid
+
+```swift
+let columns = [GridItem(.adaptive(minimum: 120))]
+
+ScrollView {
+  LazyVGrid(columns: columns, spacing: 8) {
+    ForEach(items) { item in
+      GridItemView(item: item)
+    }
+  }
+  .padding(8)
+}
+```
+
+## Design choices to keep
+
+- Use `Lazy*` stacks when item counts are large or unknown.
+- Use non-lazy stacks for small, fixed-size content to avoid lazy overhead.
+- Keep IDs stable when using `ScrollViewReader`.
+- Prefer explicit animations (`withAnimation`) when scrolling to an ID.
+
+## Pitfalls
+
+- Avoid nesting scroll views of the same axis; it causes gesture conflicts.
+- Don’t combine `List` and `ScrollView` in the same hierarchy without a clear reason.
+- Overuse of `LazyVStack` for tiny content can add unnecessary complexity.

package/skills/swiftui-ui-patterns/references/searchable.md

@@ -0,0 +1,71 @@
+# Searchable
+
+## Intent
+
+Use `searchable` to add native search UI with optional scopes and async results.
+
+## Core patterns
+
+- Bind `searchable(text:)` to local state.
+- Use `.searchScopes` for multiple search modes.
+- Use `.task(id: searchQuery)` or debounced tasks to avoid overfetching.
+- Show placeholders or progress states while results load.
+
+## Example: searchable with scopes
+
+```swift
+@MainActor
+struct ExploreView: View {
+  @State private var searchQuery = ""
+  @State private var searchScope: SearchScope = .all
+  @State private var isSearching = false
+  @State private var results: [SearchResult] = []
+
+  var body: some View {
+    List {
+      if isSearching {
+        ProgressView()
+      } else {
+        ForEach(results) { result in
+          SearchRow(result: result)
+        }
+      }
+    }
+    .searchable(
+      text: $searchQuery,
+      placement: .navigationBarDrawer(displayMode: .always),
+      prompt: Text("Search")
+    )
+    .searchScopes($searchScope) {
+      ForEach(SearchScope.allCases, id: \.self) { scope in
+        Text(scope.title)
+      }
+    }
+    .task(id: searchQuery) {
+      await runSearch()
+    }
+  }
+
+  private func runSearch() async {
+    guard !searchQuery.isEmpty else {
+      results = []
+      return
+    }
+    isSearching = true
+    defer { isSearching = false }
+    try? await Task.sleep(for: .milliseconds(250))
+    results = await fetchResults(query: searchQuery, scope: searchScope)
+  }
+}
+```
+
+## Design choices to keep
+
+- Show a placeholder when search is empty or has no results.
+- Debounce input to avoid spamming the network.
+- Keep search state local to the view.
+
+## Pitfalls
+
+- Avoid running searches for empty strings.
+- Don’t block the main thread during fetch.