swift-code-reviewer-skill 1.0.0

package/CHANGELOG.md

@@ -0,0 +1,214 @@
+# Changelog
+
+All notable changes to the Swift Code Reviewer Agent Skill will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [1.0.0] - 2026-02-10
+
+### Added
+
+#### Core Functionality
+- **Four-phase review workflow**: Context Gathering → Analysis → Report Generation → Delivery
+- **Multi-layer analysis** across 6 core categories:
+  - Swift Best Practices (Swift 6+ concurrency, error handling, optionals)
+  - SwiftUI Quality (state management, modern APIs, view composition)
+  - Performance (view optimization, ForEach performance, resource management)
+  - Security & Safety (input validation, sensitive data, network security)
+  - Architecture (MVVM, Repository, DI patterns, testability)
+  - Project-Specific Standards (.claude/CLAUDE.md integration)
+
+#### Review Capabilities
+- **GitHub PR reviews** via `gh` CLI integration
+- **GitLab MR reviews** via `glab` CLI integration
+- **Git diff analysis** for uncommitted changes
+- **Single file reviews** with context awareness
+- **Directory reviews** for multiple files
+- **Project standards validation** via .claude/CLAUDE.md
+
+#### Feedback System
+- **Severity classification**: Critical, High, Medium, Low
+- **Positive feedback** for good practices
+- **Refactoring suggestions** for improvements
+- **File:line references** for precise issue location
+- **Code examples** showing current vs recommended code
+- **Prioritized action items** for structured follow-up
+
+#### Reference Documentation (7,700+ lines)
+- **review-workflow.md** (1,131 lines): Complete review process and git integration
+- **swift-quality-checklist.md** (928 lines): Swift 6+ patterns and best practices
+- **swiftui-review-checklist.md** (909 lines): SwiftUI state management and modern APIs
+- **performance-review.md** (914 lines): Performance anti-patterns and optimization
+- **security-checklist.md** (781 lines): Security vulnerabilities and safe practices
+- **architecture-patterns.md** (862 lines): MVVM, Repository, DI, Coordinator patterns
+- **feedback-templates.md** (666 lines): Review templates and severity guidelines
+- **custom-guidelines.md** (852 lines): Project standards integration guide
+
+#### Integration Features
+- **swift-best-practices skill** integration for Swift 6+ language patterns
+- **swiftui-expert-skill** integration for SwiftUI best practices
+- **swiftui-performance-audit** integration for performance analysis
+- **Independent operation** with comprehensive built-in checklists
+
+#### Platform Support
+- Swift 6.0+
+- iOS 17+, macOS 14+, watchOS 10+, tvOS 17+, visionOS 1+
+- GitHub and GitLab integration
+- Local git repository support
+
+### Documentation
+
+- **README.md**: Comprehensive overview with examples and usage patterns
+- **CONTRIBUTING.md**: Contribution guidelines and development setup
+- **LICENSE**: MIT License
+- **CHANGELOG.md**: Version history and change tracking
+- **.gitignore**: Standard macOS and editor ignores
+
+### Features in Detail
+
+#### Swift Quality Checks
+- Actor isolation and MainActor usage
+- Sendable conformance validation
+- Data race prevention
+- Typed throws (Swift 6+)
+- Force unwrap detection (!, as!, try!)
+- Optional handling patterns
+- Access control enforcement
+- Swift API Design Guidelines compliance
+
+#### SwiftUI Checks
+- @Observable pattern adoption (iOS 17+)
+- Property wrapper selection guide
+- NavigationStack vs NavigationView
+- .task vs .onAppear for async work
+- Modern .onChange syntax
+- State ownership rules
+- View composition guidelines
+- Accessibility compliance
+
+#### Performance Checks
+- View update optimization
+- Equatable conformance for ViewModels
+- ForEach identity stability
+- GeometryReader overuse detection
+- Layout thrash prevention
+- AsyncImage for remote images
+- Memory leak detection
+- Retain cycle prevention
+
+#### Security Checks
+- Keychain usage for credentials
+- Biometric authentication
+- HTTPS enforcement
+- Certificate pinning
+- API key protection
+- Input validation
+- SQL injection prevention
+- XSS prevention in WebViews
+- Sensitive data logging prevention
+
+#### Architecture Checks
+- MVVM pattern validation
+- Repository pattern implementation
+- Dependency injection verification
+- Use Case pattern detection
+- Coordinator pattern for navigation
+- Protocol-based abstractions
+- Testability assessment
+- Code organization (MARK comments, extensions)
+
+#### Project Standards
+- .claude/CLAUDE.md parsing and validation
+- Custom architecture pattern validation
+- Design system compliance (colors, fonts, spacing)
+- Error handling pattern conformance
+- Testing requirement verification
+- Navigation pattern compliance
+
+### Templates and Examples
+
+#### Positive Feedback Templates
+- Modern API adoption
+- Architecture excellence
+- Code quality
+- Performance optimization
+- Accessibility support
+- Security awareness
+
+#### Issue Report Templates
+- Critical issues (security, crashes, data races)
+- High priority (performance, anti-patterns)
+- Medium priority (code quality, documentation)
+- Low priority (style, suggestions)
+
+#### Refactoring Suggestions
+- Extract subview
+- Simplify complex logic
+- Extract reusable component
+- Performance optimization opportunities
+
+### Example Review Reports
+
+Provided complete examples for:
+- Reviewing uncommitted changes
+- Reviewing against project standards
+- Pull request reviews
+- File-specific reviews
+- Multi-file reviews
+
+## [Unreleased]
+
+### Planned Features
+
+- **Swift 6.1 support**: Add new language features
+- **iOS 18 patterns**: Add latest SwiftUI APIs
+- **Xcode 16 integration**: Better Xcode project analysis
+- **Custom rule engine**: User-defined review rules
+- **Machine learning**: Pattern learning from reviewed code
+- **Team metrics**: Aggregate review statistics
+- **CI/CD integration**: Automated PR review comments
+- **VSCode extension**: Direct editor integration
+
+### Potential Enhancements
+
+- **Video tutorials**: Screen recordings showing usage
+- **Interactive examples**: Live code review demonstrations
+- **Best practices database**: Searchable pattern library
+- **Quick fixes**: Automated code corrections
+- **Review presets**: Configurable review profiles
+- **Multi-language support**: Objective-C, C++, SwiftUI previews
+
+## Version History Summary
+
+- **1.0.0** (2026-02-10): Initial release with comprehensive review capabilities
+
+---
+
+## How to Read This Changelog
+
+- **Added**: New features
+- **Changed**: Changes in existing functionality
+- **Deprecated**: Soon-to-be removed features
+- **Removed**: Removed features
+- **Fixed**: Bug fixes
+- **Security**: Vulnerability fixes
+
+## Contributing
+
+See [CONTRIBUTING.md](CONTRIBUTING.md) for guidelines on proposing changes.
+
+## Release Process
+
+1. Update version in SKILL.md
+2. Update CHANGELOG.md with changes
+3. Create git tag: `git tag -a v1.0.0 -m "Release 1.0.0"`
+4. Push tag: `git push origin v1.0.0`
+5. Create GitHub release with notes from CHANGELOG
+
+---
+
+**Note**: This skill follows [Semantic Versioning](https://semver.org/):
+- **MAJOR**: Incompatible API changes
+- **MINOR**: Backward-compatible functionality additions
+- **PATCH**: Backward-compatible bug fixes

package/CONTRIBUTING.md

@@ -0,0 +1,271 @@
+# Contributing to Swift Code Reviewer Agent Skill
+
+Thank you for your interest in contributing! This document provides guidelines for contributing to the Swift Code Reviewer skill.
+
+## How to Contribute
+
+### Reporting Issues
+
+If you find a bug or have a suggestion:
+
+1. **Search existing issues** to avoid duplicates
+2. **Create a new issue** with:
+   - Clear, descriptive title
+   - Detailed description of the issue or suggestion
+   - Code examples (if applicable)
+   - Expected vs actual behavior
+   - Swift/SwiftUI version and platform
+
+### Suggesting Enhancements
+
+We welcome suggestions for:
+
+- New review patterns to detect
+- Additional best practices to check
+- Improved feedback templates
+- Better project standard integration
+- Performance optimizations
+- Documentation improvements
+
+### Contributing Code
+
+#### Setting Up Development Environment
+
+1. Fork the repository
+2. Clone your fork:
+   ```bash
+   git clone https://github.com/yourusername/swift-code-reviewer-skill.git
+   cd swift-code-reviewer-skill
+   ```
+
+3. Create a branch:
+   ```bash
+   git checkout -b feature/your-feature-name
+   ```
+
+#### Making Changes
+
+**Skill Logic (SKILL.md)**
+
+When modifying the main skill file:
+
+1. Maintain YAML frontmatter format
+2. Keep sections well-organized
+3. Update table of contents if adding sections
+4. Test with real Swift/SwiftUI code
+
+**Reference Files (references/*.md)**
+
+When updating reference documentation:
+
+1. **swift-quality-checklist.md**: Add Swift language patterns
+2. **swiftui-review-checklist.md**: Add SwiftUI patterns
+3. **performance-review.md**: Add performance anti-patterns
+4. **security-checklist.md**: Add security concerns
+5. **architecture-patterns.md**: Add architectural patterns
+6. **feedback-templates.md**: Add review templates
+7. **custom-guidelines.md**: Update guidelines parsing logic
+8. **review-workflow.md**: Update review process steps
+
+**Format Guidelines:**
+
+- Use clear, descriptive headings
+- Include code examples (bad ❌ and good ✅)
+- Add comments explaining why something is an issue
+- Reference official documentation when possible
+- Keep examples concise and focused
+
+#### Code Example Format
+
+Always use this format for examples:
+
+```markdown
+**Check for:**
+- [ ] Pattern or rule to check
+
+**Examples:**
+
+❌ **Bad: [Description]**
+```swift
+// Code showing the anti-pattern
+```
+
+✅ **Good: [Description]**
+```swift
+// Code showing the correct pattern
+```
+
+**Why This Matters**: [Explanation of impact]
+```
+
+#### Testing Your Changes
+
+1. **Test with real code**: Review actual Swift/SwiftUI files
+2. **Test different scenarios**:
+   - Single file review
+   - Git diff review
+   - PR/MR review
+   - Project standards validation
+
+3. **Verify output**:
+   - All severity levels work
+   - File:line references are correct
+   - Code examples are accurate
+   - Positive feedback is included
+
+4. **Check integration**:
+   - References to other skills work
+   - Project standards (.claude/CLAUDE.md) parsing works
+   - Git commands execute correctly
+
+#### Commit Guidelines
+
+Write clear, descriptive commit messages:
+
+```
+Add force unwrap detection in security checklist
+
+- Added pattern detection for !, as!, and try!
+- Included examples of safe alternatives
+- Updated security-checklist.md with new section
+```
+
+**Format:**
+- First line: Summary (50 chars or less)
+- Blank line
+- Detailed description (if needed)
+- List specific changes
+
+#### Pull Request Process
+
+1. **Update documentation** if you changed functionality
+2. **Add examples** demonstrating your changes
+3. **Test thoroughly** with various Swift/SwiftUI code
+4. **Create pull request** with:
+   - Clear title and description
+   - Reference related issues
+   - List of changes
+   - Examples of new functionality
+
+5. **Respond to feedback** from reviewers
+6. **Keep commits clean** (squash if needed)
+
+## What to Contribute
+
+### High Priority
+
+- **New Swift 6 patterns**: Add checks for latest Swift features
+- **iOS 18 patterns**: Add SwiftUI iOS 18+ patterns
+- **Performance patterns**: Add new performance anti-patterns
+- **Security checks**: Add security vulnerability detection
+- **Real-world examples**: Add examples from actual code reviews
+
+### Medium Priority
+
+- **Improved templates**: Better feedback templates
+- **Documentation**: Clearer explanations and examples
+- **Edge cases**: Handle unusual code patterns
+- **Integration**: Better integration with other skills
+
+### Low Priority
+
+- **Formatting**: Improve markdown formatting
+- **Typos**: Fix spelling and grammar
+- **Organization**: Reorganize sections for clarity
+
+## Style Guide
+
+### Markdown
+
+- Use `#` for main headings, `##` for sections, `###` for subsections
+- Use **bold** for emphasis
+- Use `code` for inline code
+- Use code blocks with language tags: ```swift
+- Use tables for structured data
+- Use lists for sequential items
+- Use checkboxes `- [ ]` for checklist items
+
+### Code Examples
+
+- Always show both bad ❌ and good ✅ examples
+- Include comments explaining key points
+- Keep examples minimal but complete
+- Use realistic variable/function names
+- Follow Swift naming conventions
+
+### Writing Style
+
+- **Clear and concise**: Avoid unnecessary words
+- **Active voice**: "Use @Observable" not "@ Observable should be used"
+- **Specific**: "View body exceeds 50 lines" not "View is too large"
+- **Educational**: Explain *why*, not just *what*
+- **Respectful**: Assume good intentions, be constructive
+
+## Review Criteria
+
+Pull requests are evaluated on:
+
+1. **Correctness**: Does it accurately identify issues?
+2. **Completeness**: Are examples clear and comprehensive?
+3. **Clarity**: Is documentation easy to understand?
+4. **Consistency**: Does it match existing style?
+5. **Value**: Does it improve the skill's effectiveness?
+
+## Recognition
+
+Contributors will be:
+- Listed in the README
+- Credited in release notes
+- Thanked in the community
+
+Significant contributions may result in becoming a maintainer.
+
+## Questions?
+
+- **General questions**: Open a discussion
+- **Bug reports**: Open an issue
+- **Feature ideas**: Open an issue with [Feature Request] tag
+- **Code questions**: Comment on relevant PR
+
+## Code of Conduct
+
+### Our Pledge
+
+We are committed to providing a welcoming and inclusive environment for all contributors, regardless of:
+- Experience level
+- Background
+- Identity
+- Location
+
+### Expected Behavior
+
+- Be respectful and considerate
+- Welcome newcomers and help them learn
+- Give and accept constructive feedback gracefully
+- Focus on what's best for the community
+- Show empathy towards others
+
+### Unacceptable Behavior
+
+- Harassment or discrimination
+- Trolling or insulting comments
+- Personal or political attacks
+- Publishing others' private information
+- Other unprofessional conduct
+
+### Enforcement
+
+Violations will result in:
+1. Warning
+2. Temporary ban
+3. Permanent ban (severe or repeated violations)
+
+Report violations to [maintainer email].
+
+## License
+
+By contributing, you agree that your contributions will be licensed under the MIT License.
+
+---
+
+Thank you for contributing to making Swift code reviews better! 🎉

package/LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2026 Swift Code Reviewer Contributors
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.