svf-tools 1.0.674 → 1.0.676

package/README.md

@@ -42,7 +42,7 @@
 
 <br />
 
-#### We are looking for self-motivated PhD students and we welcome industry collaboration/sponsorship to improve SVF (Please contact yulei.sui@uts.edu.au if you are interested)
+#### We are looking for self-motivated PhD students and we welcome industry collaboration/sponsorship to improve SVF (Please contact y.sui@unsw.edu.au if you are interested)
 
 <br />
 <p>We release SVF source code in the hope of benefiting others. You are kindly asked to acknowledge usage of the tool by citing some of our publications listed http://svf-tools.github.io/SVF, especially the following two: </p>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "svf-tools",
-  "version": "1.0.674",
+  "version": "1.0.676",
   "description": "* <b>[TypeClone](https://github.com/SVF-tools/SVF/wiki/TypeClone) published in our [ECOOP paper](https://yuleisui.github.io/publications/ecoop20.pdf) is now available in SVF </b> * <b>SVF now uses a single script for its build. Just type [`source ./build.sh`](https://github.com/SVF-tools/SVF/blob/master/build.sh) in your terminal, that's it!</b> * <b>SVF now supports LLVM-10.0.0! </b> * <b>We thank [bsauce](https://github.com/bsauce) for writing a user manual of SVF ([link1](https://www.jianshu.com/p/068a08ec749c) and [link2](https://www.jianshu.com/p/777c30d4240e)) in Chinese </b> * <b>SVF now supports LLVM-9.0.0 (Thank [Byoungyoung Lee](https://github.com/SVF-tools/SVF/issues/142) for his help!). </b> * <b>SVF now supports a set of [field-sensitive pointer analyses](https://yuleisui.github.io/publications/sas2019a.pdf). </b> * <b>[Use SVF as an external lib](https://github.com/SVF-tools/SVF/wiki/Using-SVF-as-a-lib-in-your-own-tool) for your own project (Contributed by [Hongxu Chen](https://github.com/HongxuChen)). </b> * <b>SVF now supports LLVM-7.0.0. </b> * <b>SVF now supports Docker. [Try SVF in Docker](https://github.com/SVF-tools/SVF/wiki/Try-SVF-in-Docker)! </b> * <b>SVF now supports [LLVM-6.0.0](https://github.com/svf-tools/SVF/pull/38) (Contributed by [Jack Anthony](https://github.com/jackanth)). </b> * <b>SVF now supports [LLVM-4.0.0](https://github.com/svf-tools/SVF/pull/23) (Contributed by Jared Carlson. Thank [Jared](https://github.com/jcarlson23) and [Will](https://github.com/dtzWill) for their in-depth [discussions](https://github.com/svf-tools/SVF/pull/18) about updating SVF!) </b> * <b>SVF now supports analysis for C++ programs.</b> <br />",
   "main": "index.js",
   "scripts": {

package/svf/include/Graphs/ConsGEdge.h

@@ -306,7 +306,7 @@ public:
     /// Get location set of the gep edge
     inline s32_t getConstantFieldIdx() const
     {
-        return ls.accumulateConstantFieldIdx();
+        return ls.getConstantFieldIdx();
     }
 
 };

package/svf/include/MemoryModel/LocationSet.h

@@ -92,7 +92,7 @@ public:
 
     /// Get methods
     //@{
-    inline s32_t accumulateConstantFieldIdx() const
+    inline s32_t getConstantFieldIdx() const
     {
         return fldIdx;
     }
@@ -107,7 +107,7 @@ public:
     //@}
 
     /// Return accumulated constant offset given OffsetVarVec
-    s32_t accumulateConstantOffset() const;
+    s32_t computeConstantOffset() const;
 
     /// Return element number of a type.
     u32_t getElementNum(const SVFType* type) const;
@@ -147,7 +147,7 @@ template <> struct std::hash<SVF::LocationSet>
     {
         SVF::Hash<std::pair<SVF::NodeID, SVF::NodeID>> h;
         std::hash<SVF::LocationSet::OffsetVarAndGepTypePairs> v;
-        return h(std::make_pair(ls.accumulateConstantFieldIdx(), v(ls.getOffsetVarAndGepTypePairVec())));
+        return h(std::make_pair(ls.getConstantFieldIdx(), v(ls.getOffsetVarAndGepTypePairVec())));
     }
 };
 

package/svf/include/SVFIR/SVFStatements.h

@@ -456,13 +456,13 @@ public:
     /// Return accumulated constant offset (when accessing array or struct) if this offset is a constant.
     inline s32_t accumulateConstantOffset() const
     {
-        return getLocationSet().accumulateConstantOffset();
+        return getLocationSet().computeConstantOffset();
     }
     /// Field index of the gep statement if it access the field of a struct
     inline s32_t getConstantFieldIdx() const
     {
         assert(isVariantFieldGep()==false && "Can't retrieve the LocationSet if using a variable field index (pointer arithmetic) for struct field access ");
-        return getLocationSet().accumulateConstantFieldIdx();
+        return getLocationSet().getConstantFieldIdx();
     }
     /// Gep statement with a variant field index (pointer arithmetic) for struct field access
     inline bool isVariantFieldGep() const

package/svf/include/SVFIR/SVFVariables.h

@@ -399,7 +399,7 @@ public:
     /// offset of the base value variable
     inline s32_t getConstantFieldIdx() const
     {
-        return ls.accumulateConstantFieldIdx();
+        return ls.getConstantFieldIdx();
     }
 
     /// Return name of a LLVM value
@@ -466,7 +466,7 @@ public:
     /// offset of the mem object
     inline s32_t getConstantFieldIdx() const
     {
-        return ls.accumulateConstantFieldIdx();
+        return ls.getConstantFieldIdx();
     }
 
     /// Set the base object from which this GEP node came from.
@@ -484,15 +484,15 @@ public:
     /// Return the type of this gep object
     inline virtual const SVFType* getType() const
     {
-        return SymbolTableInfo::SymbolInfo()->getFlatternedElemType(mem->getType(), ls.accumulateConstantFieldIdx());
+        return SymbolTableInfo::SymbolInfo()->getFlatternedElemType(mem->getType(), ls.getConstantFieldIdx());
     }
 
     /// Return name of a LLVM value
     inline const std::string getValueName() const
     {
         if (value)
-            return value->getName() + "_" + std::to_string(ls.accumulateConstantFieldIdx());
-        return "offset_" + std::to_string(ls.accumulateConstantFieldIdx());
+            return value->getName() + "_" + std::to_string(ls.getConstantFieldIdx());
+        return "offset_" + std::to_string(ls.getConstantFieldIdx());
     }
 
     virtual const std::string toString() const;

package/svf/lib/MemoryModel/LocationSet.cpp

@@ -102,26 +102,26 @@ u32_t LocationSet::getElementNum(const SVFType* type) const
 
 /// %5 = getelementptr inbounds %struct.Student, %struct.Student* %4, i64 1
 ///     value1: i64 1 type1: %struct.Student*
-///     accumulateConstantOffset = 32
+///     computeConstantOffset = 32
 /// %6 = getelementptr inbounds %struct.Student, %struct.Student* %5, i32 0, i32 1
 ///     value1: i32 0  type1: %struct.Student*
 ///     value2: i32 1  type2: %struct.Student = type { %struct.inner, [10 x [3 x i8]] }
-///     accumulateConstantOffset = 2
+///     computeConstantOffset = 2
 /// %7 = getelementptr inbounds [10 x [3 x i8]], [10 x [3 x i8]]* %6, i64 0, i64 3
 ///     value1: i64 0  type1: [10 x [3 x i8]]*
 ///     value2: i64 3  type2: [10 x [3 x i8]]
-///     accumulateConstantOffset = 9
+///     computeConstantOffset = 9
 /// %8 = getelementptr inbounds [3 x i8], [3 x i8]* %7, i64 0, i64 2
 ///     value1: i64 0  type1: [3 x i8]*
 ///     value2: i64 2  type2: [3 x i8]
-///     accumulateConstantOffset = 2
-s32_t LocationSet::accumulateConstantOffset() const
+///     computeConstantOffset = 2
+s32_t LocationSet::computeConstantOffset() const
 {
 
     assert(isConstantOffset() && "not a constant offset");
 
     if(offsetVarAndGepTypePairs.empty())
-        return accumulateConstantFieldIdx();
+        return getConstantFieldIdx();
 
     s32_t totalConstOffset = 0;
     for(int i = offsetVarAndGepTypePairs.size() - 1; i >= 0; i--)
@@ -153,14 +153,14 @@ s32_t LocationSet::accumulateConstantOffset() const
 NodeBS LocationSet::computeAllLocations() const
 {
     NodeBS result;
-    result.set(accumulateConstantFieldIdx());
+    result.set(getConstantFieldIdx());
     return result;
 }
 
 LocationSet LocationSet::operator+ (const LocationSet& rhs) const
 {
     LocationSet ls(rhs);
-    ls.fldIdx += accumulateConstantFieldIdx();
+    ls.fldIdx += getConstantFieldIdx();
     OffsetVarAndGepTypePairs::const_iterator it = getOffsetVarAndGepTypePairVec().begin();
     OffsetVarAndGepTypePairs::const_iterator eit = getOffsetVarAndGepTypePairVec().end();
     for (; it != eit; ++it)
@@ -221,7 +221,7 @@ std::string LocationSet::dump() const
     std::string str;
     std::stringstream rawstr(str);
 
-    rawstr << "LocationSet\tField_Index: " << accumulateConstantFieldIdx();
+    rawstr << "LocationSet\tField_Index: " << getConstantFieldIdx();
     rawstr << ",\tNum-Stride: {";
     const OffsetVarAndGepTypePairs& vec = getOffsetVarAndGepTypePairVec();
     OffsetVarAndGepTypePairs::const_iterator it = vec.begin();

package/svf/lib/SABER/SaberSVFGBuilder.cpp

@@ -261,27 +261,23 @@ void SaberSVFGBuilder::rmIncomingEdgeForSUStore(BVDataPTAImpl* pta)
 
         if(const StoreSVFGNode* stmtNode = SVFUtil::dyn_cast<StoreSVFGNode>(node))
         {
-            for(const SVFStmt* svfstmt : pta->getPAG()->getSVFStmtList(stmtNode->getICFGNode()))
+            if(SVFUtil::isa<StoreStmt>(stmtNode->getPAGEdge()))
             {
-                if(SVFUtil::isa<StoreStmt>(svfstmt))
+                NodeID singleton;
+                if(isStrongUpdate(node, singleton, pta))
                 {
-                    NodeID singleton;
-                    if(isStrongUpdate(node, singleton, pta))
+                    Set<SVFGEdge*> toRemove;
+                    for (SVFGNode::const_iterator it2 = node->InEdgeBegin(), eit2 = node->InEdgeEnd(); it2 != eit2; ++it2)
                     {
-                        Set<SVFGEdge*> toRemove;
-                        for (SVFGNode::const_iterator it2 = node->InEdgeBegin(), eit2 = node->InEdgeEnd(); it2 != eit2; ++it2)
+                        if ((*it2)->isIndirectVFGEdge())
                         {
-                            if ((*it2)->isIndirectVFGEdge())
-                            {
-                                toRemove.insert(*it2);
-                            }
-                        }
-                        for (SVFGEdge* edge: toRemove)
-                        {
-                            svfg->removeSVFGEdge(edge);
+                            toRemove.insert(*it2);
                         }
                     }
-
+                    for (SVFGEdge* edge: toRemove)
+                    {
+                        svfg->removeSVFGEdge(edge);
+                    }
                 }
             }
         }

package/svf/lib/SVFIR/SVFIR.cpp

@@ -430,7 +430,7 @@ NodeID SVFIR::getGepObjVar(const MemObj* obj, const LocationSet& ls)
     LocationSet newLS = pag->getSymbolInfo()->getModulusOffset(obj,ls);
 
     // Base and first field are the same memory location.
-    if (Options::FirstFieldEqBase() && newLS.accumulateConstantFieldIdx() == 0) return base;
+    if (Options::FirstFieldEqBase() && newLS.getConstantFieldIdx() == 0) return base;
 
     NodeLocationSetMap::iterator iter = GepObjVarMap.find(std::make_pair(base, newLS));
     if (iter == GepObjVarMap.end())
@@ -450,7 +450,7 @@ NodeID SVFIR::addGepObjNode(const MemObj* obj, const LocationSet& ls)
     assert(0==GepObjVarMap.count(std::make_pair(base, ls))
            && "this node should not be created before");
 
-    NodeID gepId = NodeIDAllocator::get()->allocateGepObjectId(base, ls.accumulateConstantFieldIdx(), Options::MaxFieldLimit());
+    NodeID gepId = NodeIDAllocator::get()->allocateGepObjectId(base, ls.getConstantFieldIdx(), Options::MaxFieldLimit());
     GepObjVarMap[std::make_pair(base, ls)] = gepId;
     GepObjVar *node = new GepObjVar(obj, gepId, ls);
     memToFieldsMap[base].set(gepId);

package/svf/lib/SVFIR/SVFVariables.cpp

@@ -145,7 +145,7 @@ const std::string GepObjVar::toString() const
 {
     std::string str;
     std::stringstream rawstr(str);
-    rawstr << "GepObjVar ID: " << getId() << " with offset_" + std::to_string(ls.accumulateConstantFieldIdx());
+    rawstr << "GepObjVar ID: " << getId() << " with offset_" + std::to_string(ls.getConstantFieldIdx());
     if (Options::ShowSVFIRValue())
     {
         rawstr << "\n";

package/svf/lib/SVFIR/SymbolTableInfo.cpp

@@ -98,7 +98,7 @@ LocationSet SymbolTableInfo::getModulusOffset(const MemObj* obj, const LocationS
     /// of current struct. Make the offset positive so we can still get a node within current
     /// struct to represent this obj.
 
-    s32_t offset = ls.accumulateConstantFieldIdx();
+    s32_t offset = ls.getConstantFieldIdx();
     if(offset < 0)
     {
         writeWrnMsg("try to create a gep node with negative offset.");
@@ -392,13 +392,13 @@ bool ObjTypeInfo::isNonPtrFieldObj(const LocationSet& ls)
         else
             sz = SymbolTableInfo::SymbolInfo()->getTypeInfo(ety)->getFlattenFieldTypes().size();
 
-        if(sz <= (u32_t)ls.accumulateConstantFieldIdx())
+        if(sz <= (u32_t) ls.getConstantFieldIdx())
         {
             writeWrnMsg("out of bound error when accessing the struct/array");
             return false;
         }
 
-        const SVFType* elemTy = SymbolTableInfo::SymbolInfo()->getFlatternedElemType(ety, ls.accumulateConstantFieldIdx());
+        const SVFType* elemTy = SymbolTableInfo::SymbolInfo()->getFlatternedElemType(ety, ls.getConstantFieldIdx());
         return (elemTy->isPointerTy() == false);
     }
     else

package/svf-llvm/lib/SVFIRBuilder.cpp

@@ -272,6 +272,8 @@ bool SVFIRBuilder::computeGepOffset(const User *V, LocationSet& ls)
         //s32_t bo = byteOffset.getSExtValue();
     }
 
+    bool isConst = true;
+
     for (bridge_gep_iterator gi = bridge_gep_begin(*V), ge = bridge_gep_end(*V);
             gi != ge; ++gi)
     {
@@ -293,7 +295,7 @@ bool SVFIRBuilder::computeGepOffset(const User *V, LocationSet& ls)
                 continue;
             s32_t idx = op->getSExtValue();
             u32_t offset = pag->getSymbolInfo()->getFlattenedElemIdx(LLVMModuleSet::getLLVMModuleSet()->getSVFType(arrTy), idx);
-            ls.setFldIdx(ls.accumulateConstantFieldIdx() + offset);
+            ls.setFldIdx(ls.getConstantFieldIdx() + offset);
         }
         else if (const StructType *ST = SVFUtil::dyn_cast<StructType>(gepTy))
         {
@@ -301,7 +303,7 @@ bool SVFIRBuilder::computeGepOffset(const User *V, LocationSet& ls)
             //The actual index
             s32_t idx = op->getSExtValue();
             u32_t offset = pag->getSymbolInfo()->getFlattenedElemIdx(LLVMModuleSet::getLLVMModuleSet()->getSVFType(ST), idx);
-            ls.setFldIdx(ls.accumulateConstantFieldIdx() + offset);
+            ls.setFldIdx(ls.getConstantFieldIdx() + offset);
         }
         else if (gepTy->isSingleValueType())
         {
@@ -309,17 +311,17 @@ bool SVFIRBuilder::computeGepOffset(const User *V, LocationSet& ls)
             // If its point-to target is struct or array, it's likely an array accessing (%result = gep %struct.A* %a, i32 %non-const-index)
             // If its point-to target is single value (pointer arithmetic), then it's a variant gep (%result = gep i8* %p, i32 %non-const-index)
             if(!op && gepTy->isPointerTy() && getPtrElementType(SVFUtil::dyn_cast<PointerType>(gepTy))->isSingleValueType())
-                return false;
+                isConst = false;
 
             // The actual index
             //s32_t idx = op->getSExtValue();
 
             // For pointer arithmetic we ignore the byte offset
             // consider using inferFieldIdxFromByteOffset(geopOp,dataLayout,ls,idx)?
-            // ls.setFldIdx(ls.accumulateConstantFieldIdx() + inferFieldIdxFromByteOffset(geopOp,idx));
+            // ls.setFldIdx(ls.getConstantFieldIdx() + inferFieldIdxFromByteOffset(geopOp,idx));
         }
     }
-    return true;
+    return isConst;
 }
 
 /*!
@@ -1178,8 +1180,10 @@ void SVFIRBuilder::addComplexConsForExt(const Value* D, const Value* S, const Va
     for (u32_t index = 0; index < sz; index++)
     {
         LLVMModuleSet* llvmmodule = LLVMModuleSet::getLLVMModuleSet();
-        const SVFType* dElementType = pag->getSymbolInfo()->getFlatternedElemType(llvmmodule->getSVFType(dtype), fields[index].accumulateConstantFieldIdx());
-        const SVFType* sElementType = pag->getSymbolInfo()->getFlatternedElemType(llvmmodule->getSVFType(stype), fields[index].accumulateConstantFieldIdx());
+        const SVFType* dElementType = pag->getSymbolInfo()->getFlatternedElemType(llvmmodule->getSVFType(dtype),
+                                      fields[index].getConstantFieldIdx());
+        const SVFType* sElementType = pag->getSymbolInfo()->getFlatternedElemType(llvmmodule->getSVFType(stype),
+                                      fields[index].getConstantFieldIdx());
         NodeID dField = getGepValVar(D,fields[index],dElementType);
         NodeID sField = getGepValVar(S,fields[index],sElementType);
         NodeID dummy = pag->addDummyValNode();
@@ -1387,7 +1391,8 @@ void SVFIRBuilder::handleExtCall(CallBase* cs, const Function *callee)
                         //For each field (i), add store edge *(arg0 + i) = arg1
                         for (u32_t index = 0; index < sz; index++)
                         {
-                            const SVFType* dElementType = pag->getSymbolInfo()->getFlatternedElemType(LLVMModuleSet::getLLVMModuleSet()->getSVFType(dtype), dstFields[index].accumulateConstantFieldIdx());
+                            const SVFType* dElementType = pag->getSymbolInfo()->getFlatternedElemType(LLVMModuleSet::getLLVMModuleSet()->getSVFType(dtype),
+                                                          dstFields[index].getConstantFieldIdx());
                             NodeID dField = getGepValVar(cs->getArgOperand(op.getOperands()[0]), dstFields[index], dElementType);
                             addStoreEdge(getValueNode(cs->getArgOperand(op.getOperands()[1])),dField);
                         }
@@ -1430,7 +1435,7 @@ void SVFIRBuilder::handleExtCall(CallBase* cs, const Function *callee)
                         // We have vArg3 points to the entry of _Rb_tree_node_base { color; parent; left; right; }.
                         // Now we calculate the offset from base to vArg3
                         NodeID vnArg3 = pag->getValueNode(LLVMModuleSet::getLLVMModuleSet()->getSVFValue(vArg3));
-                        s32_t offset = getLocationSetFromBaseNode(vnArg3).accumulateConstantFieldIdx();
+                        s32_t offset = getLocationSetFromBaseNode(vnArg3).getConstantFieldIdx();
 
                         // We get all flattened fields of base
                         vector<LocationSet> fields;
@@ -1442,7 +1447,8 @@ void SVFIRBuilder::handleExtCall(CallBase* cs, const Function *callee)
                         {
                             if((u32_t)i >= fields.size())
                                 break;
-                            const SVFType* elementType = pag->getSymbolInfo()->getFlatternedElemType(LLVMModuleSet::getLLVMModuleSet()->getSVFType(type), fields[i].accumulateConstantFieldIdx());
+                            const SVFType* elementType = pag->getSymbolInfo()->getFlatternedElemType(LLVMModuleSet::getLLVMModuleSet()->getSVFType(type),
+                                                         fields[i].getConstantFieldIdx());
                             NodeID vnD = getGepValVar(vArg3, fields[i], elementType);
                             NodeID vnS = getValueNode(vArg1);
                             if(vnD && vnS)