svf-lib 1.0.840 → 1.0.841

package/SVF-osx/include/Graphs/ICFG.h

@@ -128,7 +128,7 @@ protected:
     /// Add control-flow edges for top level pointers
     //@{
     ICFGEdge* addIntraEdge(ICFGNode* srcNode, ICFGNode* dstNode);
-    ICFGEdge* addConditionalIntraEdge(ICFGNode* srcNode, ICFGNode* dstNode, const Value* condition, NodeID branchID);
+    ICFGEdge* addConditionalIntraEdge(ICFGNode* srcNode, ICFGNode* dstNode, const Value* condition, s64_t branchCondVal);
     ICFGEdge* addCallEdge(ICFGNode* srcNode, ICFGNode* dstNode, const Instruction* cs);
     ICFGEdge* addRetEdge(ICFGNode* srcNode, ICFGNode* dstNode, const Instruction* cs);
     //@}

package/SVF-osx/include/Graphs/ICFGEdge.h

@@ -112,15 +112,8 @@ class IntraCFGEdge : public ICFGEdge
 {
 
 public:
-    /// the first element is a boolean (for if/else) or numeric condition value (for switch)
-    /// the second element is the value when this condition should hold to execute this CFGEdge.
-    /// e.g., Inst1: br %cmp label 0, label 1,  Inst2 is label 0 and Inst 3 is label 1;
-    /// for edge between Inst1 and Inst 2, the first element is %cmp and second element is 0
-
-    typedef std::pair<const Value*,NodeID> BranchCondition;
-
     /// Constructor
-    IntraCFGEdge(ICFGNode* s, ICFGNode* d): ICFGEdge(s,d,IntraCF)
+    IntraCFGEdge(ICFGNode* s, ICFGNode* d): ICFGEdge(s,d,IntraCF), conditionVar(nullptr), branchCondVal(0)
     {
     }
     /// Methods for support type inquiry through isa, cast, and dyn_cast:
@@ -139,19 +132,29 @@ public:
     }
     //@}
 
-    const BranchCondition& getBranchCondtion() const{
-        return brCondition;
+    const Value* getCondition() const{
+        return conditionVar;
     }
 
-    void setBranchCondtion(const Value* pNode, NodeID branchID){
-        brCondition = std::make_pair(pNode,branchID);
+    const s64_t getSuccessorCondValue() const{
+        assert(getCondition() && "this is not a conditional branch edge");
+        return branchCondVal;
+    }
+
+    void setBranchCondition(const Value* c, s64_t bVal){
+        conditionVar = c;
+        branchCondVal = bVal;
     }
 
     virtual const std::string toString() const;
 
 private:
-    BranchCondition brCondition;
-
+    /// conditionVar is a boolean (for if/else) or numeric condition variable (for switch)
+    /// branchCondVal is the value when this condition should hold to execute this CFGEdge.
+    /// e.g., Inst1: br %cmp label 0, label 1,  Inst2 is label 0 and Inst 3 is label 1;
+    /// for edge between Inst1 and Inst 2, the first element is %cmp and second element is 0
+    const Value* conditionVar;
+    s64_t branchCondVal;
 };
 
 

package/SVF-osx/include/MemoryModel/SVFStatements.h

@@ -639,15 +639,6 @@ public:
     {
         return SVFStmt::getDstNode();
     }
-    /// Return the position of this op
-    const u32_t getOpPos(const SVFVar* op) const{
-        for(u32_t i = 0; i < getOpVarNum(); i++){
-            if(getOpVar(i)==op)
-                return i;
-        }
-        assert(false && "this operand not found!");
-        abort();
-    }
 
     NodeID getOpVarID(u32_t pos) const;
     NodeID getResID() const;
@@ -718,8 +709,8 @@ public:
     }
 
     /// Return the corresponding ICFGNode of this operand
-    inline const ICFGNode* getOpICFGNode(const SVFVar* op) const{
-        return opICFGNodes.at(getOpPos(op));
+    inline const ICFGNode* getOpICFGNode(u32_t op_idx) const{
+        return opICFGNodes.at(op_idx);
     }
 
     /// Return true if this is a phi at the function exit 

package/SVF-osx/include/SVF-FE/SVFIRBuilder.h

@@ -309,7 +309,9 @@ public:
     inline PhiStmt* addPhiStmt(NodeID res, NodeID opnd, const ICFGNode* pred)
     {
         PhiStmt *edge = pag->addPhiStmt(res,opnd,pred);
-        setCurrentBBAndValueForPAGEdge(edge);
+        /// If we already added this phi node, then skip this adding
+        if(edge)
+            setCurrentBBAndValueForPAGEdge(edge);
         return edge;
     }
     /// Add SelectStmt

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "svf-lib",
-  "version": "1.0.840",
+  "version": "1.0.841",
   "description": "SVF's npm support",
   "main": "index.js",
   "scripts": {