sverklo 0.2.11 → 0.2.13

package/dist/src/server/tools/diff-heuristics.js

@@ -0,0 +1,213 @@
+// Structural heuristics that scan the actual diff text for specific classes
+// of risk that symbol-level analysis alone will not catch. Kept as a
+// separate module so new heuristics can be added without touching the
+// main review-diff handler, and so each heuristic is unit-testable in
+// isolation.
+//
+// Heuristics are *heuristics* — they trade some false positives for
+// recall on real-world bugs. Each one attaches a short "why" so a human
+// reviewer can quickly dismiss a false flag.
+//
+// Current heuristics:
+//   - unguarded-stream-call: a new call site introduced inside a stream
+//     pipeline (.map / .forEach / .flatMap / .filter / .reduce / etc.)
+//     where the enclosing function has no visible try-catch. One
+//     uncaught RuntimeException on a single element will abort the
+//     entire stream — a real outage risk on production read paths.
+//     Tracked in github.com/sverklo/sverklo/issues/5.
+//
+// Adding a heuristic:
+//   1. Write a pure function that takes a DiffHunk[] and returns
+//      HeuristicFinding[]. No I/O, no git, no filesystem — the caller
+//      is responsible for producing hunks.
+//   2. Register it in ALL_HEURISTICS below.
+//   3. Unit-test it with representative fixtures.
+import { execSync } from "node:child_process";
+// ────────────────────────────────────────────────────────────────────
+// Heuristic 1 — unguarded stream-pipeline call
+// ────────────────────────────────────────────────────────────────────
+// Stream pipeline markers we care about. The list is deliberately
+// multi-language: Java / TS / Kotlin / Scala all share the same shape.
+const STREAM_METHODS = [
+    "map",
+    "forEach",
+    "flatMap",
+    "filter",
+    "reduce",
+    "mapToInt",
+    "mapToLong",
+    "mapToDouble",
+    "peek",
+    "collect",
+];
+// A line is "entering a stream pipeline" if it matches `.<method>(`
+// where <method> is one of the above. We accept optional whitespace.
+const STREAM_ENTRY_RE = new RegExp(`\\.(${STREAM_METHODS.join("|")})\\s*\\(`);
+// A line looks like a call that may throw if it contains `.<name>(`
+// for an identifier-shaped name. This is broad on purpose — most method
+// calls *can* throw, so any introduced call inside a stream pipeline
+// without a try-catch is the pattern we want to flag.
+const ANY_CALL_RE = /\b\w+\s*\(/;
+// A try-catch is "visible" in the hunk if we see a `try` or `catch`
+// token on any context line. This is a conservative proxy for "the
+// enclosing method catches its exceptions" — an AST-based check would
+// be more accurate but would require parsing the entire file per diff.
+const TRY_OR_CATCH_RE = /\b(try|catch)\b/;
+export function findUnguardedStreamCalls(hunks) {
+    const findings = [];
+    for (const hunk of hunks) {
+        // Is there a visible try / catch anywhere in the hunk's context?
+        // If so, skip the whole hunk — the enclosing method probably
+        // catches. False negatives here are fine; we care about loud wins.
+        const hasTryCatch = hunk.lines.some((l) => TRY_OR_CATCH_RE.test(l));
+        if (hasTryCatch)
+            continue;
+        // Walk the hunk line by line. Track whether we've seen a stream
+        // entry on a preceding context/added line, and whether we're still
+        // "inside" it (approximated by nesting depth on the same or next
+        // lines in the hunk).
+        let insideStreamDepth = 0;
+        let streamFileLine = hunk.newStart;
+        let currentNewLine = hunk.newStart;
+        for (const rawLine of hunk.lines) {
+            const prefix = rawLine.charAt(0);
+            const content = rawLine.slice(1);
+            // Track whether we're in a stream block, using a crude brace count
+            // scoped to the hunk. This misses pipelines that span more than the
+            // hunk window — we accept that as a recall tradeoff.
+            if (STREAM_ENTRY_RE.test(content)) {
+                insideStreamDepth = 1;
+                streamFileLine = currentNewLine;
+            }
+            else if (insideStreamDepth > 0) {
+                const opens = (content.match(/\(/g) || []).length;
+                const closes = (content.match(/\)/g) || []).length;
+                insideStreamDepth += opens - closes;
+                if (insideStreamDepth < 0)
+                    insideStreamDepth = 0;
+            }
+            // Only flag on added lines (new risks), not context. Context
+            // lines merely help us track state.
+            if (prefix === "+" && insideStreamDepth > 0 && ANY_CALL_RE.test(content)) {
+                // Skip the stream-entry line itself — we only flag the *body*
+                // calls inside the pipeline, not the pipeline declaration.
+                if (!STREAM_ENTRY_RE.test(content)) {
+                    findings.push({
+                        heuristic: "unguarded-stream-call",
+                        severity: "medium",
+                        file: hunk.filePath,
+                        line: currentNewLine,
+                        snippet: content.trim().slice(0, 120),
+                        message: "New call inside a stream pipeline with no visible try-catch in the hunk. " +
+                            "A single RuntimeException on one element will abort the entire pipeline — " +
+                            "on a production read path this is an outage. Wrap the lambda body in " +
+                            "try-catch or pre-filter elements that could throw.",
+                    });
+                    // Flag once per stream block to avoid spamming — a block with
+                    // ten calls is one finding, not ten.
+                    insideStreamDepth = 0;
+                }
+            }
+            // Advance the running new-file line counter. Context and added
+            // lines both consume new-file line numbers; removed lines do not.
+            if (prefix === "+" || prefix === " ")
+                currentNewLine++;
+        }
+    }
+    return findings;
+}
+// ────────────────────────────────────────────────────────────────────
+// Registry + driver
+// ────────────────────────────────────────────────────────────────────
+export const ALL_HEURISTICS = [
+    findUnguardedStreamCalls,
+];
+export function runAllHeuristics(hunks) {
+    const all = [];
+    for (const fn of ALL_HEURISTICS) {
+        try {
+            all.push(...fn(hunks));
+        }
+        catch {
+            // One broken heuristic must not take down review. Swallow and move on.
+        }
+    }
+    return all;
+}
+// ────────────────────────────────────────────────────────────────────
+// Parser — turn `git diff --unified=N` text into DiffHunk[]
+// ────────────────────────────────────────────────────────────────────
+/**
+ * Parse a unified-diff string (output of `git diff -U5 ref`) into hunks.
+ * Very permissive — anything that doesn't match the expected header is
+ * skipped rather than raising.
+ */
+export function parseUnifiedDiff(diffText) {
+    const hunks = [];
+    const lines = diffText.split("\n");
+    let currentFile = null;
+    let currentHunk = null;
+    for (const line of lines) {
+        // New file header: "diff --git a/foo b/foo"
+        if (line.startsWith("diff --git ")) {
+            if (currentHunk) {
+                hunks.push(currentHunk);
+                currentHunk = null;
+            }
+            currentFile = null;
+            continue;
+        }
+        // "+++ b/path" gives us the new file path
+        if (line.startsWith("+++ ")) {
+            const path = line.slice(4).replace(/^b\//, "").trim();
+            currentFile = path === "/dev/null" ? null : path;
+            continue;
+        }
+        // Hunk header: "@@ -12,5 +34,7 @@ optional-context"
+        if (line.startsWith("@@ ")) {
+            if (currentHunk)
+                hunks.push(currentHunk);
+            const match = line.match(/^@@ -(\d+)(?:,\d+)? \+(\d+)(?:,\d+)? @@/);
+            if (match && currentFile) {
+                currentHunk = {
+                    filePath: currentFile,
+                    oldStart: parseInt(match[1], 10),
+                    newStart: parseInt(match[2], 10),
+                    lines: [],
+                };
+            }
+            else {
+                currentHunk = null;
+            }
+            continue;
+        }
+        // Body lines: "+", "-", or " " prefixed
+        if (currentHunk && (line.startsWith("+") || line.startsWith("-") || line.startsWith(" "))) {
+            // Skip the file-metadata lines "+++" / "---" which we already handled above
+            if (line.startsWith("+++") || line.startsWith("---"))
+                continue;
+            currentHunk.lines.push(line);
+        }
+    }
+    if (currentHunk)
+        hunks.push(currentHunk);
+    return hunks;
+}
+/**
+ * Convenience: pull a unified diff from git and parse it.
+ */
+export function getDiffHunks(rootPath, ref) {
+    try {
+        const out = execSync(`git diff --unified=10 ${ref}`, {
+            cwd: rootPath,
+            encoding: "utf-8",
+            timeout: 8000,
+            maxBuffer: 10 * 1024 * 1024,
+        });
+        return parseUnifiedDiff(out);
+    }
+    catch {
+        return [];
+    }
+}
+//# sourceMappingURL=diff-heuristics.js.map

package/dist/src/server/tools/diff-heuristics.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"diff-heuristics.js","sourceRoot":"","sources":["../../../../src/server/tools/diff-heuristics.ts"],"names":[],"mappings":"AAAA,4EAA4E;AAC5E,qEAAqE;AACrE,sEAAsE;AACtE,sEAAsE;AACtE,aAAa;AACb,EAAE;AACF,oEAAoE;AACpE,wEAAwE;AACxE,6CAA6C;AAC7C,EAAE;AACF,sBAAsB;AACtB,wEAAwE;AACxE,uEAAuE;AACvE,iEAAiE;AACjE,mEAAmE;AACnE,mEAAmE;AACnE,sDAAsD;AACtD,EAAE;AACF,sBAAsB;AACtB,iEAAiE;AACjE,sEAAsE;AACtE,2CAA2C;AAC3C,4CAA4C;AAC5C,kDAAkD;AAElD,OAAO,EAAE,QAAQ,EAAE,MAAM,oBAAoB,CAAC;AAmB9C,uEAAuE;AACvE,+CAA+C;AAC/C,uEAAuE;AAEvE,kEAAkE;AAClE,uEAAuE;AACvE,MAAM,cAAc,GAAG;IACrB,KAAK;IACL,SAAS;IACT,SAAS;IACT,QAAQ;IACR,QAAQ;IACR,UAAU;IACV,WAAW;IACX,aAAa;IACb,MAAM;IACN,SAAS;CACV,CAAC;AAEF,oEAAoE;AACpE,qEAAqE;AACrE,MAAM,eAAe,GAAG,IAAI,MAAM,CAChC,OAAO,cAAc,CAAC,IAAI,CAAC,GAAG,CAAC,UAAU,CAC1C,CAAC;AAEF,oEAAoE;AACpE,wEAAwE;AACxE,qEAAqE;AACrE,sDAAsD;AACtD,MAAM,WAAW,GAAG,YAAY,CAAC;AAEjC,oEAAoE;AACpE,mEAAmE;AACnE,sEAAsE;AACtE,uEAAuE;AACvE,MAAM,eAAe,GAAG,iBAAiB,CAAC;AAE1C,MAAM,UAAU,wBAAwB,CAAC,KAAiB;IACxD,MAAM,QAAQ,GAAuB,EAAE,CAAC;IAExC,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,iEAAiE;QACjE,6DAA6D;QAC7D,mEAAmE;QACnE,MAAM,WAAW,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC;QACpE,IAAI,WAAW;YAAE,SAAS;QAE1B,gEAAgE;QAChE,mEAAmE;QACnE,iEAAiE;QACjE,sBAAsB;QACtB,IAAI,iBAAiB,GAAG,CAAC,CAAC;QAC1B,IAAI,cAAc,GAAG,IAAI,CAAC,QAAQ,CAAC;QACnC,IAAI,cAAc,GAAG,IAAI,CAAC,QAAQ,CAAC;QAEnC,KAAK,MAAM,OAAO,IAAI,IAAI,CAAC,KAAK,EAAE,CAAC;YACjC,MAAM,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;YACjC,MAAM,OAAO,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;YAEjC,mEAAmE;YACnE,oEAAoE;YACpE,qDAAqD;YACrD,IAAI,eAAe,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC;gBAClC,iBAAiB,GAAG,CAAC,CAAC;gBACtB,cAAc,GAAG,cAAc,CAAC;YAClC,CAAC;iBAAM,IAAI,iBAAiB,GAAG,CAAC,EAAE,CAAC;gBACjC,MAAM,KAAK,GAAG,CAAC,OAAO,CAAC,KAAK,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC,MAAM,CAAC;gBAClD,MAAM,MAAM,GAAG,CAAC,OAAO,CAAC,KAAK,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC,MAAM,CAAC;gBACnD,iBAAiB,IAAI,KAAK,GAAG,MAAM,CAAC;gBACpC,IAAI,iBAAiB,GAAG,CAAC;oBAAE,iBAAiB,GAAG,CAAC,CAAC;YACnD,CAAC;YAED,6DAA6D;YAC7D,oCAAoC;YACpC,IAAI,MAAM,KAAK,GAAG,IAAI,iBAAiB,GAAG,CAAC,IAAI,WAAW,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC;gBACzE,8DAA8D;gBAC9D,2DAA2D;gBAC3D,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC;oBACnC,QAAQ,CAAC,IAAI,CAAC;wBACZ,SAAS,EAAE,uBAAuB;wBAClC,QAAQ,EAAE,QAAQ;wBAClB,IAAI,EAAE,IAAI,CAAC,QAAQ;wBACnB,IAAI,EAAE,cAAc;wBACpB,OAAO,EAAE,OAAO,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC;wBACrC,OAAO,EACL,2EAA2E;4BAC3E,4EAA4E;4BAC5E,uEAAuE;4BACvE,oDAAoD;qBACvD,CAAC,CAAC;oBACH,8DAA8D;oBAC9D,qCAAqC;oBACrC,iBAAiB,GAAG,CAAC,CAAC;gBACxB,CAAC;YACH,CAAC;YAED,+DAA+D;YAC/D,kEAAkE;YAClE,IAAI,MAAM,KAAK,GAAG,IAAI,MAAM,KAAK,GAAG;gBAAE,cAAc,EAAE,CAAC;QACzD,CAAC;IACH,CAAC;IAED,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,uEAAuE;AACvE,oBAAoB;AACpB,uEAAuE;AAEvE,MAAM,CAAC,MAAM,cAAc,GAAkD;IAC3E,wBAAwB;CACzB,CAAC;AAEF,MAAM,UAAU,gBAAgB,CAAC,KAAiB;IAChD,MAAM,GAAG,GAAuB,EAAE,CAAC;IACnC,KAAK,MAAM,EAAE,IAAI,cAAc,EAAE,CAAC;QAChC,IAAI,CAAC;YACH,GAAG,CAAC,IAAI,CAAC,GAAG,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC;QACzB,CAAC;QAAC,MAAM,CAAC;YACP,uEAAuE;QACzE,CAAC;IACH,CAAC;IACD,OAAO,GAAG,CAAC;AACb,CAAC;AAED,uEAAuE;AACvE,4DAA4D;AAC5D,uEAAuE;AAEvE;;;;GAIG;AACH,MAAM,UAAU,gBAAgB,CAAC,QAAgB;IAC/C,MAAM,KAAK,GAAe,EAAE,CAAC;IAC7B,MAAM,KAAK,GAAG,QAAQ,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAEnC,IAAI,WAAW,GAAkB,IAAI,CAAC;IACtC,IAAI,WAAW,GAAoB,IAAI,CAAC;IAExC,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,4CAA4C;QAC5C,IAAI,IAAI,CAAC,UAAU,CAAC,aAAa,CAAC,EAAE,CAAC;YACnC,IAAI,WAAW,EAAE,CAAC;gBAChB,KAAK,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;gBACxB,WAAW,GAAG,IAAI,CAAC;YACrB,CAAC;YACD,WAAW,GAAG,IAAI,CAAC;YACnB,SAAS;QACX,CAAC;QAED,0CAA0C;QAC1C,IAAI,IAAI,CAAC,UAAU,CAAC,MAAM,CAAC,EAAE,CAAC;YAC5B,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC;YACtD,WAAW,GAAG,IAAI,KAAK,WAAW,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC;YACjD,SAAS;QACX,CAAC;QAED,oDAAoD;QACpD,IAAI,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,CAAC;YAC3B,IAAI,WAAW;gBAAE,KAAK,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;YACzC,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,yCAAyC,CAAC,CAAC;YACpE,IAAI,KAAK,IAAI,WAAW,EAAE,CAAC;gBACzB,WAAW,GAAG;oBACZ,QAAQ,EAAE,WAAW;oBACrB,QAAQ,EAAE,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC;oBAChC,QAAQ,EAAE,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC;oBAChC,KAAK,EAAE,EAAE;iBACV,CAAC;YACJ,CAAC;iBAAM,CAAC;gBACN,WAAW,GAAG,IAAI,CAAC;YACrB,CAAC;YACD,SAAS;QACX,CAAC;QAED,wCAAwC;QACxC,IAAI,WAAW,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,EAAE,CAAC;YAC1F,4EAA4E;YAC5E,IAAI,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC;gBAAE,SAAS;YAC/D,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC/B,CAAC;IACH,CAAC;IACD,IAAI,WAAW;QAAE,KAAK,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IAEzC,OAAO,KAAK,CAAC;AACf,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,YAAY,CAAC,QAAgB,EAAE,GAAW;IACxD,IAAI,CAAC;QACH,MAAM,GAAG,GAAG,QAAQ,CAAC,yBAAyB,GAAG,EAAE,EAAE;YACnD,GAAG,EAAE,QAAQ;YACb,QAAQ,EAAE,OAAO;YACjB,OAAO,EAAE,IAAI;YACb,SAAS,EAAE,EAAE,GAAG,IAAI,GAAG,IAAI;SAC5B,CAAC,CAAC;QACH,OAAO,gBAAgB,CAAC,GAAG,CAAC,CAAC;IAC/B,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,EAAE,CAAC;IACZ,CAAC;AACH,CAAC"}

package/dist/src/server/tools/diff-heuristics.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/src/server/tools/diff-heuristics.test.js

@@ -0,0 +1,151 @@
+import { describe, it, expect } from "vitest";
+import { findUnguardedStreamCalls, parseUnifiedDiff, runAllHeuristics, } from "./diff-heuristics.js";
+// Regression tests for github.com/sverklo/sverklo/issues/5 — the diff
+// review case that previously missed a class of production risk: a new
+// call site introduced inside a stream pipeline with no enclosing
+// try-catch. The heuristic is a proxy for the formal AST check we
+// eventually want, and these tests lock in its behavior on the shapes
+// we care about most.
+describe("findUnguardedStreamCalls", () => {
+    it("flags a new call added inside a .map() without try-catch", () => {
+        // Realistic-shaped diff hunk: a production read path gains a new
+        // helper call inside its stream pipeline. No try-catch anywhere
+        // in the surrounding context — this is the bug we previously missed.
+        const diffText = [
+            "diff --git a/Service.java b/Service.java",
+            "--- a/Service.java",
+            "+++ b/Service.java",
+            "@@ -10,5 +10,6 @@",
+            " public List<Package> getAll() {",
+            "   return repo.findAll().stream()",
+            "     .map(p -> {",
+            "+      var feat = computeFeatures(p);",
+            "       return toDto(p);",
+            "     })",
+            "     .collect(Collectors.toList());",
+            " }",
+        ].join("\n");
+        const hunks = parseUnifiedDiff(diffText);
+        expect(hunks.length).toBeGreaterThan(0);
+        const findings = findUnguardedStreamCalls(hunks);
+        expect(findings.length).toBe(1);
+        expect(findings[0].heuristic).toBe("unguarded-stream-call");
+        expect(findings[0].file).toBe("Service.java");
+        expect(findings[0].snippet).toContain("computeFeatures");
+    });
+    it("does NOT flag when a try-catch is visible in the hunk context", () => {
+        // Same pattern, but the enclosing method catches its own exceptions.
+        // The heuristic should back off — not perfect, but no false positive.
+        const diffText = [
+            "diff --git a/Service.java b/Service.java",
+            "--- a/Service.java",
+            "+++ b/Service.java",
+            "@@ -10,7 +10,8 @@",
+            " public List<Package> getAll() {",
+            "   try {",
+            "     return repo.findAll().stream()",
+            "       .map(p -> {",
+            "+        var feat = computeFeatures(p);",
+            "         return toDto(p);",
+            "       })",
+            "       .collect(Collectors.toList());",
+            "   } catch (Exception e) { return List.of(); }",
+            " }",
+        ].join("\n");
+        const hunks = parseUnifiedDiff(diffText);
+        const findings = findUnguardedStreamCalls(hunks);
+        expect(findings.length).toBe(0);
+    });
+    it("does not flag added lines outside a stream pipeline", () => {
+        const diffText = [
+            "diff --git a/Util.ts b/Util.ts",
+            "--- a/Util.ts",
+            "+++ b/Util.ts",
+            "@@ -1,5 +1,6 @@",
+            " export function loadConfig() {",
+            "   const raw = readFileSync('config.json');",
+            "+  const parsed = JSON.parse(raw);",
+            "   return raw;",
+            " }",
+        ].join("\n");
+        const hunks = parseUnifiedDiff(diffText);
+        const findings = findUnguardedStreamCalls(hunks);
+        expect(findings.length).toBe(0);
+    });
+    it("flags at most once per stream block", () => {
+        // Ten new calls inside one .map() should produce exactly one
+        // finding, not ten. Noise control.
+        const diffText = [
+            "diff --git a/Batch.ts b/Batch.ts",
+            "--- a/Batch.ts",
+            "+++ b/Batch.ts",
+            "@@ -1,5 +1,14 @@",
+            " function processAll(items: Item[]) {",
+            "   return items.map(it => {",
+            "+    const a = transformA(it);",
+            "+    const b = transformB(it);",
+            "+    const c = transformC(it);",
+            "+    const d = transformD(it);",
+            "     return it;",
+            "   });",
+            " }",
+        ].join("\n");
+        const hunks = parseUnifiedDiff(diffText);
+        const findings = findUnguardedStreamCalls(hunks);
+        expect(findings.length).toBe(1);
+    });
+    it("handles .forEach and .flatMap the same way as .map", () => {
+        const diffText = [
+            "diff --git a/Listener.ts b/Listener.ts",
+            "--- a/Listener.ts",
+            "+++ b/Listener.ts",
+            "@@ -1,4 +1,5 @@",
+            " function broadcast(events: Event[]) {",
+            "   events.forEach(e => {",
+            "+    publishToQueue(e);",
+            "   });",
+            " }",
+        ].join("\n");
+        const hunks = parseUnifiedDiff(diffText);
+        const findings = findUnguardedStreamCalls(hunks);
+        expect(findings.length).toBe(1);
+        expect(findings[0].snippet).toContain("publishToQueue");
+    });
+});
+describe("runAllHeuristics", () => {
+    it("returns empty array for empty hunks", () => {
+        expect(runAllHeuristics([])).toEqual([]);
+    });
+    it("does not throw if a hunk has malformed lines", () => {
+        // Sanity: a heuristic must never take down review even on weird input.
+        expect(() => runAllHeuristics([
+            {
+                filePath: "foo.ts",
+                oldStart: 1,
+                newStart: 1,
+                lines: ["not-a-valid-diff-line", "+ok"],
+            },
+        ])).not.toThrow();
+    });
+});
+describe("parseUnifiedDiff", () => {
+    it("extracts file path and hunk ranges from a standard git diff", () => {
+        const text = [
+            "diff --git a/src/foo.ts b/src/foo.ts",
+            "index abc..def 100644",
+            "--- a/src/foo.ts",
+            "+++ b/src/foo.ts",
+            "@@ -5,3 +5,4 @@",
+            " context",
+            "+added",
+            " context",
+            " context",
+        ].join("\n");
+        const hunks = parseUnifiedDiff(text);
+        expect(hunks.length).toBe(1);
+        expect(hunks[0].filePath).toBe("src/foo.ts");
+        expect(hunks[0].oldStart).toBe(5);
+        expect(hunks[0].newStart).toBe(5);
+    });
+});
+//# sourceMappingURL=diff-heuristics.test.js.map

package/dist/src/server/tools/diff-heuristics.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"diff-heuristics.test.js","sourceRoot":"","sources":["../../../../src/server/tools/diff-heuristics.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EACL,wBAAwB,EACxB,gBAAgB,EAChB,gBAAgB,GACjB,MAAM,sBAAsB,CAAC;AAE9B,sEAAsE;AACtE,uEAAuE;AACvE,kEAAkE;AAClE,kEAAkE;AAClE,sEAAsE;AACtE,sBAAsB;AAEtB,QAAQ,CAAC,0BAA0B,EAAE,GAAG,EAAE;IACxC,EAAE,CAAC,0DAA0D,EAAE,GAAG,EAAE;QAClE,iEAAiE;QACjE,gEAAgE;QAChE,qEAAqE;QACrE,MAAM,QAAQ,GAAG;YACf,0CAA0C;YAC1C,oBAAoB;YACpB,oBAAoB;YACpB,mBAAmB;YACnB,kCAAkC;YAClC,mCAAmC;YACnC,kBAAkB;YAClB,uCAAuC;YACvC,yBAAyB;YACzB,SAAS;YACT,qCAAqC;YACrC,IAAI;SACL,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,MAAM,KAAK,GAAG,gBAAgB,CAAC,QAAQ,CAAC,CAAC;QACzC,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC;QAExC,MAAM,QAAQ,GAAG,wBAAwB,CAAC,KAAK,CAAC,CAAC;QACjD,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAChC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC;QAC5D,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC;QAC9C,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,SAAS,CAAC,iBAAiB,CAAC,CAAC;IAC3D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+DAA+D,EAAE,GAAG,EAAE;QACvE,qEAAqE;QACrE,sEAAsE;QACtE,MAAM,QAAQ,GAAG;YACf,0CAA0C;YAC1C,oBAAoB;YACpB,oBAAoB;YACpB,mBAAmB;YACnB,kCAAkC;YAClC,UAAU;YACV,qCAAqC;YACrC,oBAAoB;YACpB,yCAAyC;YACzC,2BAA2B;YAC3B,WAAW;YACX,uCAAuC;YACvC,gDAAgD;YAChD,IAAI;SACL,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,MAAM,KAAK,GAAG,gBAAgB,CAAC,QAAQ,CAAC,CAAC;QACzC,MAAM,QAAQ,GAAG,wBAAwB,CAAC,KAAK,CAAC,CAAC;QACjD,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qDAAqD,EAAE,GAAG,EAAE;QAC7D,MAAM,QAAQ,GAAG;YACf,gCAAgC;YAChC,eAAe;YACf,eAAe;YACf,iBAAiB;YACjB,iCAAiC;YACjC,6CAA6C;YAC7C,oCAAoC;YACpC,gBAAgB;YAChB,IAAI;SACL,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,MAAM,KAAK,GAAG,gBAAgB,CAAC,QAAQ,CAAC,CAAC;QACzC,MAAM,QAAQ,GAAG,wBAAwB,CAAC,KAAK,CAAC,CAAC;QACjD,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC7C,6DAA6D;QAC7D,mCAAmC;QACnC,MAAM,QAAQ,GAAG;YACf,kCAAkC;YAClC,gBAAgB;YAChB,gBAAgB;YAChB,kBAAkB;YAClB,uCAAuC;YACvC,6BAA6B;YAC7B,gCAAgC;YAChC,gCAAgC;YAChC,gCAAgC;YAChC,gCAAgC;YAChC,iBAAiB;YACjB,QAAQ;YACR,IAAI;SACL,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,MAAM,KAAK,GAAG,gBAAgB,CAAC,QAAQ,CAAC,CAAC;QACzC,MAAM,QAAQ,GAAG,wBAAwB,CAAC,KAAK,CAAC,CAAC;QACjD,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC5D,MAAM,QAAQ,GAAG;YACf,wCAAwC;YACxC,mBAAmB;YACnB,mBAAmB;YACnB,iBAAiB;YACjB,wCAAwC;YACxC,0BAA0B;YAC1B,yBAAyB;YACzB,QAAQ;YACR,IAAI;SACL,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,MAAM,KAAK,GAAG,gBAAgB,CAAC,QAAQ,CAAC,CAAC;QACzC,MAAM,QAAQ,GAAG,wBAAwB,CAAC,KAAK,CAAC,CAAC;QACjD,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAChC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAC;IAC1D,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,kBAAkB,EAAE,GAAG,EAAE;IAChC,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC7C,MAAM,CAAC,gBAAgB,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IAC3C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8CAA8C,EAAE,GAAG,EAAE;QACtD,uEAAuE;QACvE,MAAM,CAAC,GAAG,EAAE,CACV,gBAAgB,CAAC;YACf;gBACE,QAAQ,EAAE,QAAQ;gBAClB,QAAQ,EAAE,CAAC;gBACX,QAAQ,EAAE,CAAC;gBACX,KAAK,EAAE,CAAC,uBAAuB,EAAE,KAAK,CAAC;aACxC;SACF,CAAC,CACH,CAAC,GAAG,CAAC,OAAO,EAAE,CAAC;IAClB,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,kBAAkB,EAAE,GAAG,EAAE;IAChC,EAAE,CAAC,6DAA6D,EAAE,GAAG,EAAE;QACrE,MAAM,IAAI,GAAG;YACX,sCAAsC;YACtC,uBAAuB;YACvB,kBAAkB;YAClB,kBAAkB;YAClB,iBAAiB;YACjB,UAAU;YACV,QAAQ;YACR,UAAU;YACV,UAAU;SACX,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,MAAM,KAAK,GAAG,gBAAgB,CAAC,IAAI,CAAC,CAAC;QACrC,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAC7B,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC;QAC7C,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAClC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IACpC,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/src/server/tools/forget.js

@@ -20,6 +20,9 @@ export function handleForget(indexer, args) {
     }
     indexer.memoryStore.delete(id);
     indexer.memoryEmbeddingStore.delete(id);
+    // Mirror the delete as a tombstone in the JSONL journal so the
+    // journal stays replayable. Issue #7.
+    indexer.memoryJournal.forget(id);
     return `Deleted memory #${id} (${memory.category}): "${memory.content.slice(0, 80)}${memory.content.length > 80 ? "..." : ""}"`;
 }
 //# sourceMappingURL=forget.js.map

package/dist/src/server/tools/forget.js.map

@@ -1 +1 @@
-{"version":3,"file":"forget.js","sourceRoot":"","sources":["../../../../src/server/tools/forget.ts"],"names":[],"mappings":"AAEA,MAAM,CAAC,MAAM,UAAU,GAAG;IACxB,IAAI,EAAE,gBAAgB;IACtB,WAAW,EAAE,wBAAwB;IACrC,WAAW,EAAE;QACX,IAAI,EAAE,QAAiB;QACvB,UAAU,EAAE;YACV,EAAE,EAAE;gBACF,IAAI,EAAE,QAAQ;gBACd,WAAW,EAAE,2CAA2C;aACzD;SACF;QACD,QAAQ,EAAE,CAAC,IAAI,CAAC;KACjB;CACF,CAAC;AAEF,MAAM,UAAU,YAAY,CAC1B,OAAgB,EAChB,IAA6B;IAE7B,MAAM,EAAE,GAAG,IAAI,CAAC,EAAY,CAAC;IAE7B,MAAM,MAAM,GAAG,OAAO,CAAC,WAAW,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IAC/C,IAAI,CAAC,MAAM,EAAE,CAAC;QACZ,OAAO,WAAW,EAAE,aAAa,CAAC;IACpC,CAAC;IAED,OAAO,CAAC,WAAW,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IAC/B,OAAO,CAAC,oBAAoB,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IACxC,OAAO,mBAAmB,EAAE,KAAK,MAAM,CAAC,QAAQ,OAAO,MAAM,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC,GAAG,MAAM,CAAC,OAAO,CAAC,MAAM,GAAG,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,GAAG,CAAC;AAClI,CAAC"}
+{"version":3,"file":"forget.js","sourceRoot":"","sources":["../../../../src/server/tools/forget.ts"],"names":[],"mappings":"AAEA,MAAM,CAAC,MAAM,UAAU,GAAG;IACxB,IAAI,EAAE,gBAAgB;IACtB,WAAW,EAAE,wBAAwB;IACrC,WAAW,EAAE;QACX,IAAI,EAAE,QAAiB;QACvB,UAAU,EAAE;YACV,EAAE,EAAE;gBACF,IAAI,EAAE,QAAQ;gBACd,WAAW,EAAE,2CAA2C;aACzD;SACF;QACD,QAAQ,EAAE,CAAC,IAAI,CAAC;KACjB;CACF,CAAC;AAEF,MAAM,UAAU,YAAY,CAC1B,OAAgB,EAChB,IAA6B;IAE7B,MAAM,EAAE,GAAG,IAAI,CAAC,EAAY,CAAC;IAE7B,MAAM,MAAM,GAAG,OAAO,CAAC,WAAW,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IAC/C,IAAI,CAAC,MAAM,EAAE,CAAC;QACZ,OAAO,WAAW,EAAE,aAAa,CAAC;IACpC,CAAC;IAED,OAAO,CAAC,WAAW,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IAC/B,OAAO,CAAC,oBAAoB,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IACxC,+DAA+D;IAC/D,sCAAsC;IACtC,OAAO,CAAC,aAAa,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IACjC,OAAO,mBAAmB,EAAE,KAAK,MAAM,CAAC,QAAQ,OAAO,MAAM,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC,GAAG,MAAM,CAAC,OAAO,CAAC,MAAM,GAAG,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,GAAG,CAAC;AAClI,CAAC"}

package/dist/src/server/tools/index-status.js

@@ -24,6 +24,22 @@ export function handleIndexStatus(indexer) {
     parts.push(`- ${status.fileCount} files · ${status.chunkCount} symbols · ${symbolRefCount} references`);
     parts.push(`- Languages: ${status.languages.join(", ") || "none"}`);
     parts.push(`- Status: ${status.indexing ? `indexing (${status.progress?.done}/${status.progress?.total})` : "ready"}`);
+    // Embedding provider selection — read from env so users can verify
+    // their SVERKLO_EMBEDDING_PROVIDER setting took effect. Issue #9.
+    const providerEnv = (process.env.SVERKLO_EMBEDDING_PROVIDER || "default").toLowerCase();
+    if (providerEnv !== "default" && providerEnv !== "bundled" && providerEnv !== "onnx") {
+        const extra = [];
+        if (providerEnv === "openai" && process.env.SVERKLO_OPENAI_MODEL) {
+            extra.push(process.env.SVERKLO_OPENAI_MODEL);
+        }
+        if (providerEnv === "ollama" && process.env.SVERKLO_OLLAMA_MODEL) {
+            extra.push(process.env.SVERKLO_OLLAMA_MODEL);
+        }
+        parts.push(`- Embedding provider: ${providerEnv}${extra.length > 0 ? ` (${extra.join(", ")})` : ""}`);
+    }
+    else {
+        parts.push(`- Embedding provider: default (bundled ONNX, 384d)`);
+    }
     // Freshness signal — only meaningful once the index has something to compare
     // against. Skip the disk walk entirely on an empty index to avoid scaring
     // the agent with "everything is dirty" noise during initial bootstrap.

package/dist/src/server/tools/index-status.js.map

@@ -1 +1 @@
-{"version":3,"file":"index-status.js","sourceRoot":"","sources":["../../../../src/server/tools/index-status.ts"],"names":[],"mappings":"AAEA,MAAM,CAAC,MAAM,eAAe,GAAG;IAC7B,IAAI,EAAE,gBAAgB;IACtB,WAAW,EACT,qFAAqF;QACrF,yFAAyF;QACzF,uFAAuF;IACzF,WAAW,EAAE;QACX,IAAI,EAAE,QAAiB;QACvB,UAAU,EAAE,EAAE;KACf;CACF,CAAC;AAEF,MAAM,UAAU,iBAAiB,CAAC,OAAgB;IAChD,MAAM,MAAM,GAAG,OAAO,CAAC,SAAS,EAAE,CAAC;IACnC,MAAM,QAAQ,GAAG,OAAO,CAAC,WAAW,CAAC,KAAK,EAAE,CAAC;IAC7C,MAAM,YAAY,GAAG,OAAO,CAAC,WAAW,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IACrD,MAAM,aAAa,GAAG,OAAO,CAAC,WAAW,CAAC,QAAQ,EAAE,CAAC;IACrD,MAAM,cAAc,GAAG,OAAO,CAAC,cAAc,CAAC,KAAK,EAAE,CAAC;IAEtD,MAAM,KAAK,GAAa,EAAE,CAAC;IAE3B,yBAAyB;IACzB,KAAK,CAAC,IAAI,CAAC,KAAK,MAAM,CAAC,WAAW,EAAE,CAAC,CAAC;IACtC,KAAK,CAAC,IAAI,CAAC,KAAK,MAAM,CAAC,QAAQ,IAAI,CAAC,CAAC;IACrC,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAEf,sBAAsB;IACtB,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IACvB,KAAK,CAAC,IAAI,CAAC,KAAK,MAAM,CAAC,SAAS,YAAY,MAAM,CAAC,UAAU,cAAc,cAAc,aAAa,CAAC,CAAC;IACxG,KAAK,CAAC,IAAI,CAAC,gBAAgB,MAAM,CAAC,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,MAAM,EAAE,CAAC,CAAC;IACpE,KAAK,CAAC,IAAI,CAAC,aAAa,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,aAAa,MAAM,CAAC,QAAQ,EAAE,IAAI,IAAI,MAAM,CAAC,QAAQ,EAAE,KAAK,GAAG,CAAC,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC;IAEvH,6EAA6E;IAC7E,0EAA0E;IAC1E,uEAAuE;IACvE,IAAI,MAAM,CAAC,SAAS,GAAG,CAAC,IAAI,CAAC,MAAM,CAAC,QAAQ,EAAE,CAAC;QAC7C,MAAM,KAAK,GAAG,OAAO,CAAC,YAAY,EAAE,CAAC;QACrC,IAAI,KAAK,CAAC,UAAU,KAAK,IAAI,EAAE,CAAC;YAC9B,KAAK,CAAC,IAAI,CAAC,sBAAsB,SAAS,CAAC,KAAK,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC;QACtE,CAAC;aAAM,CAAC;YACN,KAAK,CAAC,IAAI,CAAC,iEAAiE,CAAC,CAAC;QAChF,CAAC;QAED,MAAM,UAAU,GAAG,KAAK,CAAC,UAAU,CAAC,MAAM,CAAC;QAC3C,MAAM,YAAY,GAAG,KAAK,CAAC,YAAY,CAAC,MAAM,CAAC;QAC/C,IAAI,UAAU,KAAK,CAAC,IAAI,YAAY,KAAK,CAAC,EAAE,CAAC;YAC3C,KAAK,CAAC,IAAI,CAAC,kCAAkC,CAAC,CAAC;QACjD,CAAC;aAAM,CAAC;YACN,MAAM,IAAI,GAAa,EAAE,CAAC;YAC1B,IAAI,UAAU,GAAG,CAAC;gBAAE,IAAI,CAAC,IAAI,CAAC,GAAG,UAAU,QAAQ,CAAC,CAAC;YACrD,IAAI,YAAY,GAAG,CAAC;gBAAE,IAAI,CAAC,IAAI,CAAC,GAAG,YAAY,UAAU,CAAC,CAAC;YAC3D,KAAK,CAAC,IAAI,CAAC,mBAAmB,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,kFAAkF,CAAC,CAAC;YACjI,MAAM,OAAO,GAAG,KAAK,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;YAC7C,IAAI,OAAO,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;gBACvB,KAAK,CAAC,IAAI,CAAC,YAAY,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,UAAU,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,MAAM,UAAU,GAAG,OAAO,CAAC,MAAM,OAAO,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;YAC7H,CAAC;QACH,CAAC;IACH,CAAC;IACD,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAEf,uBAAuB;IACvB,IAAI,QAAQ,GAAG,CAAC,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC5C,KAAK,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QACxB,KAAK,CAAC,IAAI,CAAC,KAAK,QAAQ,qBAAqB,YAAY,CAAC,MAAM,UAAU,QAAQ,GAAG,YAAY,CAAC,MAAM,WAAW,CAAC,CAAC;QACrH,IAAI,aAAa,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAC7B,KAAK,CAAC,IAAI,CAAC,QAAQ,aAAa,CAAC,MAAM,sEAAsE,CAAC,CAAC;QACjH,CAAC;QACD,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACjB,CAAC;IAED,0CAA0C;IAC1C,KAAK,CAAC,IAAI,CAAC,yBAAyB,CAAC,CAAC;IAEtC,uBAAuB;IACvB,MAAM,IAAI,GAAa,EAAE,CAAC;IAE1B,IAAI,MAAM,CAAC,SAAS,KAAK,CAAC,EAAE,CAAC;QAC3B,IAAI,CAAC,IAAI,CAAC,yFAAyF,CAAC,CAAC;IACvG,CAAC;SAAM,CAAC;QACN,IAAI,CAAC,IAAI,CAAC,+EAA+E,CAAC,CAAC;QAC3F,IAAI,CAAC,IAAI,CAAC,iGAAiG,CAAC,CAAC;QAC7G,IAAI,CAAC,IAAI,CAAC,gGAAgG,CAAC,CAAC;QAC5G,IAAI,CAAC,IAAI,CAAC,+FAA+F,CAAC,CAAC;IAC7G,CAAC;IAED,IAAI,QAAQ,KAAK,CAAC,EAAE,CAAC;QACnB,IAAI,CAAC,IAAI,CAAC,4FAA4F,CAAC,CAAC;QACxG,IAAI,CAAC,IAAI,CAAC,yEAAyE,CAAC,CAAC;IACvF,CAAC;SAAM,CAAC;QACN,IAAI,CAAC,IAAI,CAAC,qGAAqG,CAAC,CAAC;QACjH,IAAI,YAAY,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC9B,IAAI,CAAC,IAAI,CAAC,qHAAqH,CAAC,CAAC;QACnI,CAAC;IACH,CAAC;IAED,IAAI,MAAM,CAAC,SAAS,GAAG,EAAE,EAAE,CAAC;QAC1B,IAAI,CAAC,IAAI,CAAC,+GAA+G,CAAC,CAAC;IAC7H,CAAC;IAED,KAAK,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,CAAC;IACpB,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAEf,gCAAgC;IAChC,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC5B,KAAK,CAAC,IAAI,CAAC,6CAA6C,CAAC,CAAC;QAC1D,KAAK,MAAM,CAAC,IAAI,YAAY,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,CAAC;YACzC,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,QAAQ,KAAK,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC;QAC/C,CAAC;QACD,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAC5B,KAAK,CAAC,IAAI,CAAC,aAAa,YAAY,CAAC,MAAM,GAAG,CAAC,2CAA2C,CAAC,CAAC;QAC9F,CAAC;QACD,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACjB,CAAC;IAED,+BAA+B;IAC/B,KAAK,CAAC,IAAI,CAAC,iJAAiJ,CAAC,CAAC;IAE9J,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAC1B,CAAC;AAED,SAAS,SAAS,CAAC,OAAe;IAChC,IAAI,OAAO,GAAG,EAAE;QAAE,OAAO,GAAG,OAAO,GAAG,CAAC;IACvC,IAAI,OAAO,GAAG,IAAI;QAAE,OAAO,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,GAAG,EAAE,CAAC,GAAG,CAAC;IAC1D,IAAI,OAAO,GAAG,KAAK;QAAE,OAAO,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,GAAG,IAAI,CAAC,GAAG,CAAC;IAC7D,OAAO,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,GAAG,KAAK,CAAC,GAAG,CAAC;AAC3C,CAAC"}
+{"version":3,"file":"index-status.js","sourceRoot":"","sources":["../../../../src/server/tools/index-status.ts"],"names":[],"mappings":"AAEA,MAAM,CAAC,MAAM,eAAe,GAAG;IAC7B,IAAI,EAAE,gBAAgB;IACtB,WAAW,EACT,qFAAqF;QACrF,yFAAyF;QACzF,uFAAuF;IACzF,WAAW,EAAE;QACX,IAAI,EAAE,QAAiB;QACvB,UAAU,EAAE,EAAE;KACf;CACF,CAAC;AAEF,MAAM,UAAU,iBAAiB,CAAC,OAAgB;IAChD,MAAM,MAAM,GAAG,OAAO,CAAC,SAAS,EAAE,CAAC;IACnC,MAAM,QAAQ,GAAG,OAAO,CAAC,WAAW,CAAC,KAAK,EAAE,CAAC;IAC7C,MAAM,YAAY,GAAG,OAAO,CAAC,WAAW,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IACrD,MAAM,aAAa,GAAG,OAAO,CAAC,WAAW,CAAC,QAAQ,EAAE,CAAC;IACrD,MAAM,cAAc,GAAG,OAAO,CAAC,cAAc,CAAC,KAAK,EAAE,CAAC;IAEtD,MAAM,KAAK,GAAa,EAAE,CAAC;IAE3B,yBAAyB;IACzB,KAAK,CAAC,IAAI,CAAC,KAAK,MAAM,CAAC,WAAW,EAAE,CAAC,CAAC;IACtC,KAAK,CAAC,IAAI,CAAC,KAAK,MAAM,CAAC,QAAQ,IAAI,CAAC,CAAC;IACrC,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAEf,sBAAsB;IACtB,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IACvB,KAAK,CAAC,IAAI,CAAC,KAAK,MAAM,CAAC,SAAS,YAAY,MAAM,CAAC,UAAU,cAAc,cAAc,aAAa,CAAC,CAAC;IACxG,KAAK,CAAC,IAAI,CAAC,gBAAgB,MAAM,CAAC,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,MAAM,EAAE,CAAC,CAAC;IACpE,KAAK,CAAC,IAAI,CAAC,aAAa,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,aAAa,MAAM,CAAC,QAAQ,EAAE,IAAI,IAAI,MAAM,CAAC,QAAQ,EAAE,KAAK,GAAG,CAAC,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC;IACvH,mEAAmE;IACnE,kEAAkE;IAClE,MAAM,WAAW,GAAG,CAAC,OAAO,CAAC,GAAG,CAAC,0BAA0B,IAAI,SAAS,CAAC,CAAC,WAAW,EAAE,CAAC;IACxF,IAAI,WAAW,KAAK,SAAS,IAAI,WAAW,KAAK,SAAS,IAAI,WAAW,KAAK,MAAM,EAAE,CAAC;QACrF,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,IAAI,WAAW,KAAK,QAAQ,IAAI,OAAO,CAAC,GAAG,CAAC,oBAAoB,EAAE,CAAC;YACjE,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,oBAAoB,CAAC,CAAC;QAC/C,CAAC;QACD,IAAI,WAAW,KAAK,QAAQ,IAAI,OAAO,CAAC,GAAG,CAAC,oBAAoB,EAAE,CAAC;YACjE,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,oBAAoB,CAAC,CAAC;QAC/C,CAAC;QACD,KAAK,CAAC,IAAI,CAAC,yBAAyB,WAAW,GAAG,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,KAAK,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;IACxG,CAAC;SAAM,CAAC;QACN,KAAK,CAAC,IAAI,CAAC,oDAAoD,CAAC,CAAC;IACnE,CAAC;IAED,6EAA6E;IAC7E,0EAA0E;IAC1E,uEAAuE;IACvE,IAAI,MAAM,CAAC,SAAS,GAAG,CAAC,IAAI,CAAC,MAAM,CAAC,QAAQ,EAAE,CAAC;QAC7C,MAAM,KAAK,GAAG,OAAO,CAAC,YAAY,EAAE,CAAC;QACrC,IAAI,KAAK,CAAC,UAAU,KAAK,IAAI,EAAE,CAAC;YAC9B,KAAK,CAAC,IAAI,CAAC,sBAAsB,SAAS,CAAC,KAAK,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC;QACtE,CAAC;aAAM,CAAC;YACN,KAAK,CAAC,IAAI,CAAC,iEAAiE,CAAC,CAAC;QAChF,CAAC;QAED,MAAM,UAAU,GAAG,KAAK,CAAC,UAAU,CAAC,MAAM,CAAC;QAC3C,MAAM,YAAY,GAAG,KAAK,CAAC,YAAY,CAAC,MAAM,CAAC;QAC/C,IAAI,UAAU,KAAK,CAAC,IAAI,YAAY,KAAK,CAAC,EAAE,CAAC;YAC3C,KAAK,CAAC,IAAI,CAAC,kCAAkC,CAAC,CAAC;QACjD,CAAC;aAAM,CAAC;YACN,MAAM,IAAI,GAAa,EAAE,CAAC;YAC1B,IAAI,UAAU,GAAG,CAAC;gBAAE,IAAI,CAAC,IAAI,CAAC,GAAG,UAAU,QAAQ,CAAC,CAAC;YACrD,IAAI,YAAY,GAAG,CAAC;gBAAE,IAAI,CAAC,IAAI,CAAC,GAAG,YAAY,UAAU,CAAC,CAAC;YAC3D,KAAK,CAAC,IAAI,CAAC,mBAAmB,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,kFAAkF,CAAC,CAAC;YACjI,MAAM,OAAO,GAAG,KAAK,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;YAC7C,IAAI,OAAO,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;gBACvB,KAAK,CAAC,IAAI,CAAC,YAAY,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,UAAU,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,MAAM,UAAU,GAAG,OAAO,CAAC,MAAM,OAAO,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;YAC7H,CAAC;QACH,CAAC;IACH,CAAC;IACD,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAEf,uBAAuB;IACvB,IAAI,QAAQ,GAAG,CAAC,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC5C,KAAK,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QACxB,KAAK,CAAC,IAAI,CAAC,KAAK,QAAQ,qBAAqB,YAAY,CAAC,MAAM,UAAU,QAAQ,GAAG,YAAY,CAAC,MAAM,WAAW,CAAC,CAAC;QACrH,IAAI,aAAa,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAC7B,KAAK,CAAC,IAAI,CAAC,QAAQ,aAAa,CAAC,MAAM,sEAAsE,CAAC,CAAC;QACjH,CAAC;QACD,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACjB,CAAC;IAED,0CAA0C;IAC1C,KAAK,CAAC,IAAI,CAAC,yBAAyB,CAAC,CAAC;IAEtC,uBAAuB;IACvB,MAAM,IAAI,GAAa,EAAE,CAAC;IAE1B,IAAI,MAAM,CAAC,SAAS,KAAK,CAAC,EAAE,CAAC;QAC3B,IAAI,CAAC,IAAI,CAAC,yFAAyF,CAAC,CAAC;IACvG,CAAC;SAAM,CAAC;QACN,IAAI,CAAC,IAAI,CAAC,+EAA+E,CAAC,CAAC;QAC3F,IAAI,CAAC,IAAI,CAAC,iGAAiG,CAAC,CAAC;QAC7G,IAAI,CAAC,IAAI,CAAC,gGAAgG,CAAC,CAAC;QAC5G,IAAI,CAAC,IAAI,CAAC,+FAA+F,CAAC,CAAC;IAC7G,CAAC;IAED,IAAI,QAAQ,KAAK,CAAC,EAAE,CAAC;QACnB,IAAI,CAAC,IAAI,CAAC,4FAA4F,CAAC,CAAC;QACxG,IAAI,CAAC,IAAI,CAAC,yEAAyE,CAAC,CAAC;IACvF,CAAC;SAAM,CAAC;QACN,IAAI,CAAC,IAAI,CAAC,qGAAqG,CAAC,CAAC;QACjH,IAAI,YAAY,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC9B,IAAI,CAAC,IAAI,CAAC,qHAAqH,CAAC,CAAC;QACnI,CAAC;IACH,CAAC;IAED,IAAI,MAAM,CAAC,SAAS,GAAG,EAAE,EAAE,CAAC;QAC1B,IAAI,CAAC,IAAI,CAAC,+GAA+G,CAAC,CAAC;IAC7H,CAAC;IAED,KAAK,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,CAAC;IACpB,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAEf,gCAAgC;IAChC,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC5B,KAAK,CAAC,IAAI,CAAC,6CAA6C,CAAC,CAAC;QAC1D,KAAK,MAAM,CAAC,IAAI,YAAY,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,CAAC;YACzC,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,QAAQ,KAAK,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC;QAC/C,CAAC;QACD,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAC5B,KAAK,CAAC,IAAI,CAAC,aAAa,YAAY,CAAC,MAAM,GAAG,CAAC,2CAA2C,CAAC,CAAC;QAC9F,CAAC;QACD,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACjB,CAAC;IAED,+BAA+B;IAC/B,KAAK,CAAC,IAAI,CAAC,iJAAiJ,CAAC,CAAC;IAE9J,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAC1B,CAAC;AAED,SAAS,SAAS,CAAC,OAAe;IAChC,IAAI,OAAO,GAAG,EAAE;QAAE,OAAO,GAAG,OAAO,GAAG,CAAC;IACvC,IAAI,OAAO,GAAG,IAAI;QAAE,OAAO,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,GAAG,EAAE,CAAC,GAAG,CAAC;IAC1D,IAAI,OAAO,GAAG,KAAK;QAAE,OAAO,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,GAAG,IAAI,CAAC,GAAG,CAAC;IAC7D,OAAO,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,GAAG,KAAK,CAAC,GAAG,CAAC;AAC3C,CAAC"}

package/dist/src/server/tools/lookup.js

@@ -1,4 +1,8 @@
 import { formatLookup } from "../../search/token-budget.js";
+// Issue #6: on the first call, sverklo_lookup paid a ~1.6s penalty while
+// warming up prepared statements via fileStore.getAll() to build a
+// pagerank-by-file map. The getByNameWithFile JOIN below returns the
+// same shape in a single indexed query, eliminating the full scan.
 export const lookupTool = {
     name: "sverklo_lookup",
     description: "Look up a specific symbol (function, class, type, variable) by name. Returns its full definition, signature, and location.",
@@ -34,21 +38,16 @@ export function handleLookup(indexer, args) {
     const symbol = args.symbol;
     const type = args.type || "any";
     const tokenBudget = args.token_budget || 1200;
-    let chunks = indexer.chunkStore.getByName(symbol, 20);
+    // Single JOIN'd query — chunks come back pre-sorted by pagerank DESC
+    // and carry the containing file's path, so no full fileStore scan.
+    let chunks = indexer.chunkStore.getByNameWithFile(symbol, 20);
     if (type !== "any") {
         chunks = chunks.filter((c) => c.type === type);
     }
-    // Get file data for PageRank ordering
-    const fileCache = new Map();
-    for (const f of indexer.fileStore.getAll()) {
-        fileCache.set(f.id, f);
-    }
-    // Sort by PageRank of containing file
-    chunks.sort((a, b) => {
-        const fa = fileCache.get(a.file_id);
-        const fb = fileCache.get(b.file_id);
-        return (fb?.pagerank || 0) - (fa?.pagerank || 0);
-    });
-    return formatLookup(chunks, fileCache, tokenBudget);
+    // formatLookup only reads filePath / lang off the file map when the
+    // chunk itself doesn't carry filePath. Since our JOIN provides it,
+    // we can pass an empty map and avoid the scan.
+    const emptyFileMap = new Map();
+    return formatLookup(chunks, emptyFileMap, tokenBudget);
 }
 //# sourceMappingURL=lookup.js.map

package/dist/src/server/tools/lookup.js.map

@@ -1 +1 @@
-{"version":3,"file":"lookup.js","sourceRoot":"","sources":["../../../../src/server/tools/lookup.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,YAAY,EAAE,MAAM,8BAA8B,CAAC;AAG5D,MAAM,CAAC,MAAM,UAAU,GAAG;IACxB,IAAI,EAAE,gBAAgB;IACtB,WAAW,EACT,4HAA4H;IAC9H,WAAW,EAAE;QACX,IAAI,EAAE,QAAiB;QACvB,UAAU,EAAE;YACV,MAAM,EAAE;gBACN,IAAI,EAAE,QAAQ;gBACd,WAAW,EAAE,gDAAgD;aAC9D;YACD,IAAI,EAAE;gBACJ,IAAI,EAAE,QAAQ;gBACd,IAAI,EAAE;oBACJ,UAAU;oBACV,OAAO;oBACP,MAAM;oBACN,WAAW;oBACX,QAAQ;oBACR,UAAU;oBACV,KAAK;iBACN;gBACD,WAAW,EAAE,uBAAuB;aACrC;YACD,YAAY,EAAE;gBACZ,IAAI,EAAE,QAAQ;gBACd,WAAW,EAAE,sCAAsC;aACpD;SACF;QACD,QAAQ,EAAE,CAAC,QAAQ,CAAC;KACrB;CACF,CAAC;AAEF,MAAM,UAAU,YAAY,CAC1B,OAAgB,EAChB,IAA6B;IAE7B,MAAM,MAAM,GAAG,IAAI,CAAC,MAAgB,CAAC;IACrC,MAAM,IAAI,GAAI,IAAI,CAAC,IAA0B,IAAI,KAAK,CAAC;IACvD,MAAM,WAAW,GAAI,IAAI,CAAC,YAAuB,IAAI,IAAI,CAAC;IAE1D,IAAI,MAAM,GAAG,OAAO,CAAC,UAAU,CAAC,SAAS,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;IAEtD,IAAI,IAAI,KAAK,KAAK,EAAE,CAAC;QACnB,MAAM,GAAG,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,IAAI,CAAC,CAAC;IACjD,CAAC;IAED,sCAAsC;IACtC,MAAM,SAAS,GAAG,IAAI,GAAG,EAAsB,CAAC;IAChD,KAAK,MAAM,CAAC,IAAI,OAAO,CAAC,SAAS,CAAC,MAAM,EAAE,EAAE,CAAC;QAC3C,SAAS,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC;IACzB,CAAC;IAED,sCAAsC;IACtC,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE;QACnB,MAAM,EAAE,GAAG,SAAS,CAAC,GAAG,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC;QACpC,MAAM,EAAE,GAAG,SAAS,CAAC,GAAG,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC;QACpC,OAAO,CAAC,EAAE,EAAE,QAAQ,IAAI,CAAC,CAAC,GAAG,CAAC,EAAE,EAAE,QAAQ,IAAI,CAAC,CAAC,CAAC;IACnD,CAAC,CAAC,CAAC;IAEH,OAAO,YAAY,CAAC,MAAM,EAAE,SAAS,EAAE,WAAW,CAAC,CAAC;AACtD,CAAC"}
+{"version":3,"file":"lookup.js","sourceRoot":"","sources":["../../../../src/server/tools/lookup.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,YAAY,EAAE,MAAM,8BAA8B,CAAC;AAG5D,yEAAyE;AACzE,mEAAmE;AACnE,qEAAqE;AACrE,mEAAmE;AAEnE,MAAM,CAAC,MAAM,UAAU,GAAG;IACxB,IAAI,EAAE,gBAAgB;IACtB,WAAW,EACT,4HAA4H;IAC9H,WAAW,EAAE;QACX,IAAI,EAAE,QAAiB;QACvB,UAAU,EAAE;YACV,MAAM,EAAE;gBACN,IAAI,EAAE,QAAQ;gBACd,WAAW,EAAE,gDAAgD;aAC9D;YACD,IAAI,EAAE;gBACJ,IAAI,EAAE,QAAQ;gBACd,IAAI,EAAE;oBACJ,UAAU;oBACV,OAAO;oBACP,MAAM;oBACN,WAAW;oBACX,QAAQ;oBACR,UAAU;oBACV,KAAK;iBACN;gBACD,WAAW,EAAE,uBAAuB;aACrC;YACD,YAAY,EAAE;gBACZ,IAAI,EAAE,QAAQ;gBACd,WAAW,EAAE,sCAAsC;aACpD;SACF;QACD,QAAQ,EAAE,CAAC,QAAQ,CAAC;KACrB;CACF,CAAC;AAEF,MAAM,UAAU,YAAY,CAC1B,OAAgB,EAChB,IAA6B;IAE7B,MAAM,MAAM,GAAG,IAAI,CAAC,MAAgB,CAAC;IACrC,MAAM,IAAI,GAAI,IAAI,CAAC,IAA0B,IAAI,KAAK,CAAC;IACvD,MAAM,WAAW,GAAI,IAAI,CAAC,YAAuB,IAAI,IAAI,CAAC;IAE1D,qEAAqE;IACrE,mEAAmE;IACnE,IAAI,MAAM,GAAG,OAAO,CAAC,UAAU,CAAC,iBAAiB,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;IAE9D,IAAI,IAAI,KAAK,KAAK,EAAE,CAAC;QACnB,MAAM,GAAG,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,IAAI,CAAC,CAAC;IACjD,CAAC;IAED,oEAAoE;IACpE,mEAAmE;IACnE,+CAA+C;IAC/C,MAAM,YAAY,GAAG,IAAI,GAAG,EAAsB,CAAC;IACnD,OAAO,YAAY,CAAC,MAAM,EAAE,YAAY,EAAE,WAAW,CAAC,CAAC;AACzD,CAAC"}

package/dist/src/server/tools/recall.d.ts

@@ -9,6 +9,11 @@ export declare const recallTool: {
                 type: string;
                 description: string;
             };
+            mode: {
+                type: string;
+                enum: string[];
+                description: string;
+            };
             category: {
                 type: string;
                 enum: string[];
@@ -23,7 +28,6 @@ export declare const recallTool: {
                 description: string;
             };
         };
-        required: string[];
     };
 };
 export declare function handleRecall(indexer: Indexer, args: Record<string, unknown>): Promise<string>;

package/dist/src/server/tools/recall.js

@@ -2,15 +2,37 @@ import { embed, cosineSimilarity } from "../../indexer/embedder.js";
 import { checkStaleness } from "../../memory/staleness.js";
 import { track } from "../../telemetry/index.js";
 const RRF_K = 60;
+// Issue #11: core vs archival memory. Core memories are always-on
+// project invariants auto-injected at session start. Archival memories
+// are the searchable long tail. The mode parameter lets callers pick:
+//
+//   - mode=core     → core tier only, returned in priority order
+//   - mode=archival → project + archive tiers, full semantic search
+//   - mode=all      → default, searches everything
+//
+// Core tier is soft-capped at 25 memories — LLM context windows don't
+// appreciate a 500-line system prompt. Exceeding the cap emits a
+// warning in the recall output but does not block writes.
+const CORE_TIER_SOFT_LIMIT = 25;
 export const recallTool = {
     name: "sverklo_recall",
-    description: "Search memories semantically. Finds past decisions, preferences, and patterns relevant to a query.",
+    description: "Search memories semantically. Finds past decisions, preferences, and patterns relevant to a query. " +
+        "Supports two specialized modes: `mode=core` returns only the always-on project invariants (fast, " +
+        "no query needed — use at session start); `mode=archival` searches the full archive with semantic " +
+        "ranking; `mode=all` (default) searches both. Use core for 'what are the project-wide rules I must " +
+        "not violate' and archival for 'what did we decide about X on this codebase'.",
     inputSchema: {
         type: "object",
         properties: {
             query: {
                 type: "string",
-                description: "What to search for in memories",
+                description: "What to search for in memories (optional when mode=core)",
+            },
+            mode: {
+                type: "string",
+                enum: ["core", "archival", "all"],
+                description: "Which memory tier to search. 'core' = always-on invariants only, 'archival' = " +
+                    "searchable long tail, 'all' = both (default).",
             },
             category: {
                 type: "string",
@@ -26,14 +48,52 @@ export const recallTool = {
                 description: "Include stale memories (default: false)",
             },
         },
-        required: ["query"],
     },
 };
 export async function handleRecall(indexer, args) {
-    const query = args.query;
+    const query = args.query || "";
+    const mode = args.mode || "all";
     const category = args.category || "any";
     const limit = args.limit || 10;
     const includeStale = args.include_stale || false;
+    // Mode: core — return the always-on invariants without semantic
+    // ranking. This is the session-start fast path; agents should call
+    // this (or read sverklo://context) at the top of every session.
+    if (mode === "core") {
+        const coreMemories = indexer.memoryStore.getCore(limit);
+        const filtered = category === "any"
+            ? coreMemories
+            : coreMemories.filter((m) => m.category === category);
+        void track("memory.read");
+        if (filtered.length === 0) {
+            return ("No core memories yet. Core memories are always-on project invariants " +
+                "that auto-load each session. Promote an existing memory with " +
+                "`sverklo_promote id:<n> tier:core`, or save a new one with " +
+                "`sverklo_remember ... tier:core`.");
+        }
+        const parts = ["# Core memories (always-on project invariants)", ""];
+        for (const m of filtered) {
+            const staleFlag = m.is_stale ? " [STALE]" : "";
+            parts.push(`- **[${m.category}]**${staleFlag} ${m.content}`);
+        }
+        parts.push("");
+        // Soft-limit warning: too many core memories is an anti-pattern.
+        const totalCore = indexer.memoryStore.getCore(1000).length;
+        if (totalCore > CORE_TIER_SOFT_LIMIT) {
+            parts.push(`⚠️ ${totalCore} core memories — exceeds the soft limit of ${CORE_TIER_SOFT_LIMIT}. ` +
+                "Core memories are injected into every session prompt; too many crowds the context " +
+                "window. Demote the least-critical ones with `sverklo_demote id:<n>`.");
+        }
+        return parts.join("\n");
+    }
+    // Mode: archival | all — full semantic search over the selected
+    // tier(s). If the caller passed mode=archival we exclude core; if
+    // mode=all we include everything.
+    if (!query) {
+        return ("A `query` is required for archival/all recall. Pass `mode:core` if you want " +
+            "to list always-on invariants without a query.");
+    }
+    const excludeTiers = mode === "archival" ? ["core"] : [];
     // Signal A: FTS text search
     const ftsResults = indexer.memoryStore.searchFts(query, 30);
     // Signal B: Vector similarity
@@ -64,6 +124,8 @@ export async function handleRecall(indexer, args) {
             continue;
         if (category !== "any" && memory.category !== category)
             continue;
+        if (excludeTiers.includes(memory.tier))
+            continue;
         // Staleness check (lazy)
         const stale = checkStaleness(memory, indexer.fileStore, indexer.memoryStore);
         if (stale)