svelte-dnd-action 0.9.72 → 0.9.74

package/dist/index.js

@@ -1186,6 +1186,21 @@
   function trs(property) {
     return "".concat(property, " ").concat(TRANSITION_DURATION_SECONDS, "s ease");
   }
+
+  /**
+   * Adds the size transitions after the dragged element's initial styles have been applied.
+   * This normally happens in a timeout to avoid a browser rendering bug, but a synchronous
+   * first morph can happen before that timeout and needs the transitions immediately.
+   * @param {HTMLElement} draggedEl
+   */
+  function ensureMorphSizeTransitions(draggedEl) {
+    var transitionProperties = draggedEl.style.transitionProperty.split(",").map(function (property) {
+      return property.trim();
+    });
+    if (transitionProperties.includes("all")) return;
+    if (!transitionProperties.includes("width")) draggedEl.style.transition += ", ".concat(trs("width"));
+    if (!transitionProperties.includes("height")) draggedEl.style.transition += ", ".concat(trs("height"));
+  }
   /**
    * clones the given element and applies proper styles and transitions to the dragged element
    * @param {HTMLElement} originalElement
@@ -1219,7 +1234,7 @@
     draggedEl.style.transition = "".concat(trs("top"), ", ").concat(trs("left"), ", ").concat(trs("background-color"), ", ").concat(trs("opacity"), ", ").concat(trs("color"), " ");
     // this is a workaround for a strange browser bug that causes the right border to disappear when all the transitions are added at the same time
     window.setTimeout(function () {
-      return draggedEl.style.transition += ", ".concat(trs("width"), ", ").concat(trs("height"));
+      return ensureMorphSizeTransitions(draggedEl);
     }, 0);
     draggedEl.style.zIndex = "9999";
     draggedEl.style.cursor = "grabbing";
@@ -1242,22 +1257,26 @@
    * @param {number} currentMouseY
    */
   function morphDraggedElementToBeLike(draggedEl, copyFromEl, currentMouseX, currentMouseY) {
+    ensureMorphSizeTransitions(draggedEl);
     copyStylesFromTo(copyFromEl, draggedEl);
     var newRect = copyFromEl.getBoundingClientRect();
     var draggedElRect = draggedEl.getBoundingClientRect();
+    var draggedElComputedStyle = window.getComputedStyle(draggedEl);
+    var currentLeft = parseFloat(draggedElComputedStyle.left);
+    var currentTop = parseFloat(draggedElComputedStyle.top);
     var widthChange = newRect.width - draggedElRect.width;
     var heightChange = newRect.height - draggedElRect.height;
     if (widthChange || heightChange) {
       var relativeDistanceOfMousePointerFromDraggedSides = {
-        left: (currentMouseX - draggedElRect.left) / draggedElRect.width,
-        top: (currentMouseY - draggedElRect.top) / draggedElRect.height
+        left: draggedElRect.width ? (currentMouseX - draggedElRect.left) / draggedElRect.width : 0,
+        top: draggedElRect.height ? (currentMouseY - draggedElRect.top) / draggedElRect.height : 0
       };
       if (!getFeatureFlag(FEATURE_FLAG_NAMES.USE_COMPUTED_STYLE_INSTEAD_OF_BOUNDING_RECT)) {
         draggedEl.style.height = "".concat(newRect.height, "px");
         draggedEl.style.width = "".concat(newRect.width, "px");
       }
-      draggedEl.style.left = "".concat(parseFloat(draggedEl.style.left) - relativeDistanceOfMousePointerFromDraggedSides.left * widthChange, "px");
-      draggedEl.style.top = "".concat(parseFloat(draggedEl.style.top) - relativeDistanceOfMousePointerFromDraggedSides.top * heightChange, "px");
+      draggedEl.style.left = "".concat(currentLeft - relativeDistanceOfMousePointerFromDraggedSides.left * widthChange, "px");
+      draggedEl.style.top = "".concat(currentTop - relativeDistanceOfMousePointerFromDraggedSides.top * heightChange, "px");
     }
   }
 
@@ -2916,7 +2935,6 @@
         updateZone();
       },
       destroy: function destroy() {
-        isItemsDragDisabled.set(true);
         zone.destroy();
         node.removeEventListener("consider", consider);
         node.removeEventListener("finalize", finalize);

package/dist/index.mjs

@@ -1180,6 +1180,21 @@ var TRANSITION_DURATION_SECONDS = 0.2;
 function trs(property) {
   return "".concat(property, " ").concat(TRANSITION_DURATION_SECONDS, "s ease");
 }
+
+/**
+ * Adds the size transitions after the dragged element's initial styles have been applied.
+ * This normally happens in a timeout to avoid a browser rendering bug, but a synchronous
+ * first morph can happen before that timeout and needs the transitions immediately.
+ * @param {HTMLElement} draggedEl
+ */
+function ensureMorphSizeTransitions(draggedEl) {
+  var transitionProperties = draggedEl.style.transitionProperty.split(",").map(function (property) {
+    return property.trim();
+  });
+  if (transitionProperties.includes("all")) return;
+  if (!transitionProperties.includes("width")) draggedEl.style.transition += ", ".concat(trs("width"));
+  if (!transitionProperties.includes("height")) draggedEl.style.transition += ", ".concat(trs("height"));
+}
 /**
  * clones the given element and applies proper styles and transitions to the dragged element
  * @param {HTMLElement} originalElement
@@ -1213,7 +1228,7 @@ function createDraggedElementFrom(originalElement, positionCenterOnXY) {
   draggedEl.style.transition = "".concat(trs("top"), ", ").concat(trs("left"), ", ").concat(trs("background-color"), ", ").concat(trs("opacity"), ", ").concat(trs("color"), " ");
   // this is a workaround for a strange browser bug that causes the right border to disappear when all the transitions are added at the same time
   window.setTimeout(function () {
-    return draggedEl.style.transition += ", ".concat(trs("width"), ", ").concat(trs("height"));
+    return ensureMorphSizeTransitions(draggedEl);
   }, 0);
   draggedEl.style.zIndex = "9999";
   draggedEl.style.cursor = "grabbing";
@@ -1236,22 +1251,26 @@ function moveDraggedElementToWasDroppedState(draggedEl) {
  * @param {number} currentMouseY
  */
 function morphDraggedElementToBeLike(draggedEl, copyFromEl, currentMouseX, currentMouseY) {
+  ensureMorphSizeTransitions(draggedEl);
   copyStylesFromTo(copyFromEl, draggedEl);
   var newRect = copyFromEl.getBoundingClientRect();
   var draggedElRect = draggedEl.getBoundingClientRect();
+  var draggedElComputedStyle = window.getComputedStyle(draggedEl);
+  var currentLeft = parseFloat(draggedElComputedStyle.left);
+  var currentTop = parseFloat(draggedElComputedStyle.top);
   var widthChange = newRect.width - draggedElRect.width;
   var heightChange = newRect.height - draggedElRect.height;
   if (widthChange || heightChange) {
     var relativeDistanceOfMousePointerFromDraggedSides = {
-      left: (currentMouseX - draggedElRect.left) / draggedElRect.width,
-      top: (currentMouseY - draggedElRect.top) / draggedElRect.height
+      left: draggedElRect.width ? (currentMouseX - draggedElRect.left) / draggedElRect.width : 0,
+      top: draggedElRect.height ? (currentMouseY - draggedElRect.top) / draggedElRect.height : 0
     };
     if (!getFeatureFlag(FEATURE_FLAG_NAMES.USE_COMPUTED_STYLE_INSTEAD_OF_BOUNDING_RECT)) {
       draggedEl.style.height = "".concat(newRect.height, "px");
       draggedEl.style.width = "".concat(newRect.width, "px");
     }
-    draggedEl.style.left = "".concat(parseFloat(draggedEl.style.left) - relativeDistanceOfMousePointerFromDraggedSides.left * widthChange, "px");
-    draggedEl.style.top = "".concat(parseFloat(draggedEl.style.top) - relativeDistanceOfMousePointerFromDraggedSides.top * heightChange, "px");
+    draggedEl.style.left = "".concat(currentLeft - relativeDistanceOfMousePointerFromDraggedSides.left * widthChange, "px");
+    draggedEl.style.top = "".concat(currentTop - relativeDistanceOfMousePointerFromDraggedSides.top * heightChange, "px");
   }
 }
 
@@ -2910,7 +2929,6 @@ function dragHandleZone(node, options) {
       updateZone();
     },
     destroy: function destroy() {
-      isItemsDragDisabled.set(true);
       zone.destroy();
       node.removeEventListener("consider", consider);
       node.removeEventListener("finalize", finalize);

package/package.json

@@ -1,7 +1,7 @@
 {
     "name": "svelte-dnd-action",
     "description": "*An awesome drag and drop library for Svelte 3 and 4 (not using the browser's built-in dnd, thanks god): Rich animations, nested containers, touch support and more *",
-    "version": "0.9.72",
+    "version": "0.9.74",
     "repository": {
         "type": "git",
         "url": "git+https://github.com/isaacHagoel/svelte-dnd-action.git"

package/src/helpers/styler.js

@@ -13,6 +13,19 @@ const TRANSITION_DURATION_SECONDS = 0.2;
 function trs(property) {
     return `${property} ${TRANSITION_DURATION_SECONDS}s ease`;
 }
+
+/**
+ * Adds the size transitions after the dragged element's initial styles have been applied.
+ * This normally happens in a timeout to avoid a browser rendering bug, but a synchronous
+ * first morph can happen before that timeout and needs the transitions immediately.
+ * @param {HTMLElement} draggedEl
+ */
+function ensureMorphSizeTransitions(draggedEl) {
+    const transitionProperties = draggedEl.style.transitionProperty.split(",").map(property => property.trim());
+    if (transitionProperties.includes("all")) return;
+    if (!transitionProperties.includes("width")) draggedEl.style.transition += `, ${trs("width")}`;
+    if (!transitionProperties.includes("height")) draggedEl.style.transition += `, ${trs("height")}`;
+}
 /**
  * clones the given element and applies proper styles and transitions to the dragged element
  * @param {HTMLElement} originalElement
@@ -45,7 +58,7 @@ export function createDraggedElementFrom(originalElement, positionCenterOnXY) {
     draggedEl.style.width = `${rect.width}px`;
     draggedEl.style.transition = `${trs("top")}, ${trs("left")}, ${trs("background-color")}, ${trs("opacity")}, ${trs("color")} `;
     // this is a workaround for a strange browser bug that causes the right border to disappear when all the transitions are added at the same time
-    window.setTimeout(() => (draggedEl.style.transition += `, ${trs("width")}, ${trs("height")}`), 0);
+    window.setTimeout(() => ensureMorphSizeTransitions(draggedEl), 0);
     draggedEl.style.zIndex = "9999";
     draggedEl.style.cursor = "grabbing";
 
@@ -68,22 +81,26 @@ export function moveDraggedElementToWasDroppedState(draggedEl) {
  * @param {number} currentMouseY
  */
 export function morphDraggedElementToBeLike(draggedEl, copyFromEl, currentMouseX, currentMouseY) {
+    ensureMorphSizeTransitions(draggedEl);
     copyStylesFromTo(copyFromEl, draggedEl);
     const newRect = copyFromEl.getBoundingClientRect();
     const draggedElRect = draggedEl.getBoundingClientRect();
+    const draggedElComputedStyle = window.getComputedStyle(draggedEl);
+    const currentLeft = parseFloat(draggedElComputedStyle.left);
+    const currentTop = parseFloat(draggedElComputedStyle.top);
     const widthChange = newRect.width - draggedElRect.width;
     const heightChange = newRect.height - draggedElRect.height;
     if (widthChange || heightChange) {
         const relativeDistanceOfMousePointerFromDraggedSides = {
-            left: (currentMouseX - draggedElRect.left) / draggedElRect.width,
-            top: (currentMouseY - draggedElRect.top) / draggedElRect.height
+            left: draggedElRect.width ? (currentMouseX - draggedElRect.left) / draggedElRect.width : 0,
+            top: draggedElRect.height ? (currentMouseY - draggedElRect.top) / draggedElRect.height : 0
         };
         if (!getFeatureFlag(FEATURE_FLAG_NAMES.USE_COMPUTED_STYLE_INSTEAD_OF_BOUNDING_RECT)) {
             draggedEl.style.height = `${newRect.height}px`;
             draggedEl.style.width = `${newRect.width}px`;
         }
-        draggedEl.style.left = `${parseFloat(draggedEl.style.left) - relativeDistanceOfMousePointerFromDraggedSides.left * widthChange}px`;
-        draggedEl.style.top = `${parseFloat(draggedEl.style.top) - relativeDistanceOfMousePointerFromDraggedSides.top * heightChange}px`;
+        draggedEl.style.left = `${currentLeft - relativeDistanceOfMousePointerFromDraggedSides.left * widthChange}px`;
+        draggedEl.style.top = `${currentTop - relativeDistanceOfMousePointerFromDraggedSides.top * heightChange}px`;
     }
 }
 

package/src/wrappers/withDragHandles.js

@@ -77,7 +77,6 @@ export function dragHandleZone(node, options) {
             updateZone();
         },
         destroy: () => {
-            isItemsDragDisabled.set(true);
             zone.destroy();
             node.removeEventListener("consider", consider);
             node.removeEventListener("finalize", finalize);