svelte-dnd-action 0.9.65 → 0.9.67

package/dist/index.js

@@ -509,52 +509,91 @@
     var rect = getAbsoluteRect(el);
     return rect.right < 0 || rect.left > document.documentElement.scrollWidth || rect.bottom < 0 || rect.top > document.documentElement.scrollHeight;
   }
+
+  /**
+   * Computes the portion of an element that is actually visible inside its scrollable
+   * ancestor containers. If the element is clipped by any scrollable ancestor (overflow: auto|scroll),
+   * the returned rect is the clipped one. If it is not clipped by any scrollable ancestor but is
+   * partially or fully outside the viewport, the function returns the element's full bounding rect
+   * (i.e. it does NOT clip to the viewport).
+   *
+   * This is useful for distinguishing "hidden because parent scrolls" from
+   * "hidden because off-screen".
+   *
+   * @param {HTMLElement} element - The DOM element to measure.
+   * @returns {{top: number, bottom: number, left: number, right: number, width: number, height: number}}
+   * An object describing the visible rectangle in viewport coordinates.
+   */
   function getVisibleRectRecursive(element) {
+    // original rect of the element (can be off-screen)
     var rect = element.getBoundingClientRect();
+
+    // this will be our "clipped by scroll containers" rect
     var visibleRect = {
       top: rect.top,
       bottom: rect.bottom,
       left: rect.left,
       right: rect.right
     };
+    var wasClippedByScrollY = false;
+    var wasClippedByScrollX = false;
 
-    // Traverse up the DOM hierarchy, checking for scrollable ancestors
+    // walk up and clip ONLY by scrollable ancestors
     var parent = element.parentElement;
     while (parent && parent !== document.body) {
-      var parentRect = parent.getBoundingClientRect();
-
-      // Check if the parent has a scrollable overflow
-      var overflowY = window.getComputedStyle(parent).overflowY;
-      var overflowX = window.getComputedStyle(parent).overflowX;
+      var style = window.getComputedStyle(parent);
+      var overflowY = style.overflowY;
+      var overflowX = style.overflowX;
       var isScrollableY = overflowY === "scroll" || overflowY === "auto";
       var isScrollableX = overflowX === "scroll" || overflowX === "auto";
-
-      // Constrain the visible area to the parent's visible area
-      if (isScrollableY) {
-        visibleRect.top = Math.max(visibleRect.top, parentRect.top);
-        visibleRect.bottom = Math.min(visibleRect.bottom, parentRect.bottom);
-      }
-      if (isScrollableX) {
-        visibleRect.left = Math.max(visibleRect.left, parentRect.left);
-        visibleRect.right = Math.min(visibleRect.right, parentRect.right);
+      if (isScrollableY || isScrollableX) {
+        var parentRect = parent.getBoundingClientRect();
+        if (isScrollableY) {
+          // if we actually shrink, mark it
+          var newTop = Math.max(visibleRect.top, parentRect.top);
+          var newBottom = Math.min(visibleRect.bottom, parentRect.bottom);
+          if (newTop !== visibleRect.top || newBottom !== visibleRect.bottom) {
+            wasClippedByScrollY = true;
+          }
+          visibleRect.top = newTop;
+          visibleRect.bottom = newBottom;
+        }
+        if (isScrollableX) {
+          var newLeft = Math.max(visibleRect.left, parentRect.left);
+          var newRight = Math.min(visibleRect.right, parentRect.right);
+          if (newLeft !== visibleRect.left || newRight !== visibleRect.right) {
+            wasClippedByScrollX = true;
+          }
+          visibleRect.left = newLeft;
+          visibleRect.right = newRight;
+        }
       }
       parent = parent.parentElement;
     }
 
-    // Finally, constrain the visible rect to the viewport
-    visibleRect.top = Math.max(visibleRect.top, 0);
-    visibleRect.bottom = Math.min(visibleRect.bottom, window.innerHeight);
-    visibleRect.left = Math.max(visibleRect.left, 0);
-    visibleRect.right = Math.min(visibleRect.right, window.innerWidth);
+    // CASE 1: element was clipped by a scrollable container
+    // → return the clipped rect (this is your 500px content inside 250px scroller case)
+    if (wasClippedByScrollY || wasClippedByScrollX) {
+      return {
+        top: visibleRect.top,
+        bottom: visibleRect.bottom,
+        left: visibleRect.left,
+        right: visibleRect.right,
+        width: Math.max(0, visibleRect.right - visibleRect.left),
+        height: Math.max(0, visibleRect.bottom - visibleRect.top)
+      };
+    }
 
-    // Return the visible rectangle, ensuring that all values are valid
+    // CASE 2: not clipped by scroll containers
+    // → we want the element’s FULL rect, even if it’s off-screen
+    // i.e. do NOT clip to viewport
     return {
-      top: visibleRect.top,
-      bottom: visibleRect.bottom,
-      left: visibleRect.left,
-      right: visibleRect.right,
-      width: Math.max(0, visibleRect.right - visibleRect.left),
-      height: Math.max(0, visibleRect.bottom - visibleRect.top)
+      top: rect.top,
+      bottom: rect.bottom,
+      left: rect.left,
+      right: rect.right,
+      width: Math.max(0, rect.right - rect.left),
+      height: Math.max(0, rect.bottom - rect.top)
     };
   }
 
@@ -1493,9 +1532,9 @@
       return;
     }
     isDraggedOutsideOfAnyDz = false;
-    // this deals with another race condition. in rare occasions (super rapid operations) the list hasn't updated yet
+    // this deals with another race condition. on some occasions (super rapid operations) the list hasn't updated yet
     items = items.filter(function (item) {
-      return item[ITEM_ID_KEY] !== shadowElData[ITEM_ID_KEY];
+      return item[ITEM_ID_KEY] !== shadowElData[ITEM_ID_KEY] && item[ITEM_ID_KEY] !== SHADOW_PLACEHOLDER_ITEM_ID;
     });
     printDebug(function () {
       return "dragged entered items ".concat(toString(items));

package/dist/index.mjs

@@ -503,52 +503,91 @@ function isElementOffDocument(el) {
   var rect = getAbsoluteRect(el);
   return rect.right < 0 || rect.left > document.documentElement.scrollWidth || rect.bottom < 0 || rect.top > document.documentElement.scrollHeight;
 }
+
+/**
+ * Computes the portion of an element that is actually visible inside its scrollable
+ * ancestor containers. If the element is clipped by any scrollable ancestor (overflow: auto|scroll),
+ * the returned rect is the clipped one. If it is not clipped by any scrollable ancestor but is
+ * partially or fully outside the viewport, the function returns the element's full bounding rect
+ * (i.e. it does NOT clip to the viewport).
+ *
+ * This is useful for distinguishing "hidden because parent scrolls" from
+ * "hidden because off-screen".
+ *
+ * @param {HTMLElement} element - The DOM element to measure.
+ * @returns {{top: number, bottom: number, left: number, right: number, width: number, height: number}}
+ * An object describing the visible rectangle in viewport coordinates.
+ */
 function getVisibleRectRecursive(element) {
+  // original rect of the element (can be off-screen)
   var rect = element.getBoundingClientRect();
+
+  // this will be our "clipped by scroll containers" rect
   var visibleRect = {
     top: rect.top,
     bottom: rect.bottom,
     left: rect.left,
     right: rect.right
   };
+  var wasClippedByScrollY = false;
+  var wasClippedByScrollX = false;
 
-  // Traverse up the DOM hierarchy, checking for scrollable ancestors
+  // walk up and clip ONLY by scrollable ancestors
   var parent = element.parentElement;
   while (parent && parent !== document.body) {
-    var parentRect = parent.getBoundingClientRect();
-
-    // Check if the parent has a scrollable overflow
-    var overflowY = window.getComputedStyle(parent).overflowY;
-    var overflowX = window.getComputedStyle(parent).overflowX;
+    var style = window.getComputedStyle(parent);
+    var overflowY = style.overflowY;
+    var overflowX = style.overflowX;
     var isScrollableY = overflowY === "scroll" || overflowY === "auto";
     var isScrollableX = overflowX === "scroll" || overflowX === "auto";
-
-    // Constrain the visible area to the parent's visible area
-    if (isScrollableY) {
-      visibleRect.top = Math.max(visibleRect.top, parentRect.top);
-      visibleRect.bottom = Math.min(visibleRect.bottom, parentRect.bottom);
-    }
-    if (isScrollableX) {
-      visibleRect.left = Math.max(visibleRect.left, parentRect.left);
-      visibleRect.right = Math.min(visibleRect.right, parentRect.right);
+    if (isScrollableY || isScrollableX) {
+      var parentRect = parent.getBoundingClientRect();
+      if (isScrollableY) {
+        // if we actually shrink, mark it
+        var newTop = Math.max(visibleRect.top, parentRect.top);
+        var newBottom = Math.min(visibleRect.bottom, parentRect.bottom);
+        if (newTop !== visibleRect.top || newBottom !== visibleRect.bottom) {
+          wasClippedByScrollY = true;
+        }
+        visibleRect.top = newTop;
+        visibleRect.bottom = newBottom;
+      }
+      if (isScrollableX) {
+        var newLeft = Math.max(visibleRect.left, parentRect.left);
+        var newRight = Math.min(visibleRect.right, parentRect.right);
+        if (newLeft !== visibleRect.left || newRight !== visibleRect.right) {
+          wasClippedByScrollX = true;
+        }
+        visibleRect.left = newLeft;
+        visibleRect.right = newRight;
+      }
     }
     parent = parent.parentElement;
   }
 
-  // Finally, constrain the visible rect to the viewport
-  visibleRect.top = Math.max(visibleRect.top, 0);
-  visibleRect.bottom = Math.min(visibleRect.bottom, window.innerHeight);
-  visibleRect.left = Math.max(visibleRect.left, 0);
-  visibleRect.right = Math.min(visibleRect.right, window.innerWidth);
+  // CASE 1: element was clipped by a scrollable container
+  // → return the clipped rect (this is your 500px content inside 250px scroller case)
+  if (wasClippedByScrollY || wasClippedByScrollX) {
+    return {
+      top: visibleRect.top,
+      bottom: visibleRect.bottom,
+      left: visibleRect.left,
+      right: visibleRect.right,
+      width: Math.max(0, visibleRect.right - visibleRect.left),
+      height: Math.max(0, visibleRect.bottom - visibleRect.top)
+    };
+  }
 
-  // Return the visible rectangle, ensuring that all values are valid
+  // CASE 2: not clipped by scroll containers
+  // → we want the element’s FULL rect, even if it’s off-screen
+  // i.e. do NOT clip to viewport
   return {
-    top: visibleRect.top,
-    bottom: visibleRect.bottom,
-    left: visibleRect.left,
-    right: visibleRect.right,
-    width: Math.max(0, visibleRect.right - visibleRect.left),
-    height: Math.max(0, visibleRect.bottom - visibleRect.top)
+    top: rect.top,
+    bottom: rect.bottom,
+    left: rect.left,
+    right: rect.right,
+    width: Math.max(0, rect.right - rect.left),
+    height: Math.max(0, rect.bottom - rect.top)
   };
 }
 
@@ -1487,9 +1526,9 @@ function handleDraggedEntered(e) {
     return;
   }
   isDraggedOutsideOfAnyDz = false;
-  // this deals with another race condition. in rare occasions (super rapid operations) the list hasn't updated yet
+  // this deals with another race condition. on some occasions (super rapid operations) the list hasn't updated yet
   items = items.filter(function (item) {
-    return item[ITEM_ID_KEY] !== shadowElData[ITEM_ID_KEY];
+    return item[ITEM_ID_KEY] !== shadowElData[ITEM_ID_KEY] && item[ITEM_ID_KEY] !== SHADOW_PLACEHOLDER_ITEM_ID;
   });
   printDebug(function () {
     return "dragged entered items ".concat(toString(items));

package/package.json

@@ -1,7 +1,7 @@
 {
     "name": "svelte-dnd-action",
     "description": "*An awesome drag and drop library for Svelte 3 and 4 (not using the browser's built-in dnd, thanks god): Rich animations, nested containers, touch support and more *",
-    "version": "0.9.65",
+    "version": "0.9.67",
     "repository": {
         "type": "git",
         "url": "git+https://github.com/isaacHagoel/svelte-dnd-action.git"

package/src/helpers/intersection.js

@@ -158,8 +158,25 @@ export function isElementOffDocument(el) {
     return rect.right < 0 || rect.left > document.documentElement.scrollWidth || rect.bottom < 0 || rect.top > document.documentElement.scrollHeight;
 }
 
+/**
+ * Computes the portion of an element that is actually visible inside its scrollable
+ * ancestor containers. If the element is clipped by any scrollable ancestor (overflow: auto|scroll),
+ * the returned rect is the clipped one. If it is not clipped by any scrollable ancestor but is
+ * partially or fully outside the viewport, the function returns the element's full bounding rect
+ * (i.e. it does NOT clip to the viewport).
+ *
+ * This is useful for distinguishing "hidden because parent scrolls" from
+ * "hidden because off-screen".
+ *
+ * @param {HTMLElement} element - The DOM element to measure.
+ * @returns {{top: number, bottom: number, left: number, right: number, width: number, height: number}}
+ * An object describing the visible rectangle in viewport coordinates.
+ */
 function getVisibleRectRecursive(element) {
-    let rect = element.getBoundingClientRect();
+    // original rect of the element (can be off-screen)
+    const rect = element.getBoundingClientRect();
+
+    // this will be our "clipped by scroll containers" rect
     let visibleRect = {
         top: rect.top,
         bottom: rect.bottom,
@@ -167,43 +184,68 @@ function getVisibleRectRecursive(element) {
         right: rect.right
     };
 
-    // Traverse up the DOM hierarchy, checking for scrollable ancestors
+    let wasClippedByScrollY = false;
+    let wasClippedByScrollX = false;
+
+    // walk up and clip ONLY by scrollable ancestors
     let parent = element.parentElement;
     while (parent && parent !== document.body) {
-        let parentRect = parent.getBoundingClientRect();
-
-        // Check if the parent has a scrollable overflow
-        const overflowY = window.getComputedStyle(parent).overflowY;
-        const overflowX = window.getComputedStyle(parent).overflowX;
+        const style = window.getComputedStyle(parent);
+        const overflowY = style.overflowY;
+        const overflowX = style.overflowX;
         const isScrollableY = overflowY === "scroll" || overflowY === "auto";
         const isScrollableX = overflowX === "scroll" || overflowX === "auto";
 
-        // Constrain the visible area to the parent's visible area
-        if (isScrollableY) {
-            visibleRect.top = Math.max(visibleRect.top, parentRect.top);
-            visibleRect.bottom = Math.min(visibleRect.bottom, parentRect.bottom);
-        }
-        if (isScrollableX) {
-            visibleRect.left = Math.max(visibleRect.left, parentRect.left);
-            visibleRect.right = Math.min(visibleRect.right, parentRect.right);
+        if (isScrollableY || isScrollableX) {
+            const parentRect = parent.getBoundingClientRect();
+
+            if (isScrollableY) {
+                // if we actually shrink, mark it
+                const newTop = Math.max(visibleRect.top, parentRect.top);
+                const newBottom = Math.min(visibleRect.bottom, parentRect.bottom);
+                if (newTop !== visibleRect.top || newBottom !== visibleRect.bottom) {
+                    wasClippedByScrollY = true;
+                }
+                visibleRect.top = newTop;
+                visibleRect.bottom = newBottom;
+            }
+
+            if (isScrollableX) {
+                const newLeft = Math.max(visibleRect.left, parentRect.left);
+                const newRight = Math.min(visibleRect.right, parentRect.right);
+                if (newLeft !== visibleRect.left || newRight !== visibleRect.right) {
+                    wasClippedByScrollX = true;
+                }
+                visibleRect.left = newLeft;
+                visibleRect.right = newRight;
+            }
         }
 
         parent = parent.parentElement;
     }
 
-    // Finally, constrain the visible rect to the viewport
-    visibleRect.top = Math.max(visibleRect.top, 0);
-    visibleRect.bottom = Math.min(visibleRect.bottom, window.innerHeight);
-    visibleRect.left = Math.max(visibleRect.left, 0);
-    visibleRect.right = Math.min(visibleRect.right, window.innerWidth);
+    // CASE 1: element was clipped by a scrollable container
+    // → return the clipped rect (this is your 500px content inside 250px scroller case)
+    if (wasClippedByScrollY || wasClippedByScrollX) {
+        return {
+            top: visibleRect.top,
+            bottom: visibleRect.bottom,
+            left: visibleRect.left,
+            right: visibleRect.right,
+            width: Math.max(0, visibleRect.right - visibleRect.left),
+            height: Math.max(0, visibleRect.bottom - visibleRect.top)
+        };
+    }
 
-    // Return the visible rectangle, ensuring that all values are valid
+    // CASE 2: not clipped by scroll containers
+    // → we want the element’s FULL rect, even if it’s off-screen
+    // i.e. do NOT clip to viewport
     return {
-        top: visibleRect.top,
-        bottom: visibleRect.bottom,
-        left: visibleRect.left,
-        right: visibleRect.right,
-        width: Math.max(0, visibleRect.right - visibleRect.left),
-        height: Math.max(0, visibleRect.bottom - visibleRect.top)
+        top: rect.top,
+        bottom: rect.bottom,
+        left: rect.left,
+        right: rect.right,
+        width: Math.max(0, rect.right - rect.left),
+        height: Math.max(0, rect.bottom - rect.top)
     };
 }

package/src/pointerAction.js

@@ -141,8 +141,8 @@ function handleDraggedEntered(e) {
         return;
     }
     isDraggedOutsideOfAnyDz = false;
-    // this deals with another race condition. in rare occasions (super rapid operations) the list hasn't updated yet
-    items = items.filter(item => item[ITEM_ID_KEY] !== shadowElData[ITEM_ID_KEY]);
+    // this deals with another race condition. on some occasions (super rapid operations) the list hasn't updated yet
+    items = items.filter(item => item[ITEM_ID_KEY] !== shadowElData[ITEM_ID_KEY] && item[ITEM_ID_KEY] !== SHADOW_PLACEHOLDER_ITEM_ID);
     printDebug(() => `dragged entered items ${toString(items)}`);
 
     if (originDropZone !== e.currentTarget) {