svelte-adapter-uws 0.1.0 → 0.1.2

package/README.md

@@ -60,6 +60,8 @@ npm install uNetworking/uWebSockets.js#v20.60.0
 ```
 
 > **Note:** uWebSockets.js is a native C++ addon installed directly from GitHub, not from npm. It may not compile on all platforms. Check the [uWebSockets.js README](https://github.com/uNetworking/uWebSockets.js) if you have issues.
+>
+> **Docker:** Use `node:22-trixie-slim` or another glibc >= 2.38 image. Bookworm-based images and Alpine won't work. See [Deploying with Docker](#deploying-with-docker).
 
 If you plan to use WebSockets during development, also install `ws`:
 
@@ -1119,20 +1121,27 @@ The only difference is how you receive props. The client store API (`on`, `crud`
 uWebSockets.js is a native C++ addon, so your Docker image needs to match the platform it was compiled for. Build inside the container to be safe.
 
 ```dockerfile
-FROM node:20-slim
+FROM node:22-trixie-slim AS build
+
+# git is required - uWebSockets.js is installed from GitHub, not npm
+RUN apt-get update && apt-get install -y --no-install-recommends git && rm -rf /var/lib/apt/lists/*
 
 WORKDIR /app
 
-# Copy package files and install dependencies
 COPY package*.json ./
 RUN npm ci
 
-# Copy source and build
 COPY . .
 RUN npm run build
 
-# Only the build output is needed at runtime
-# (but node_modules must stay for uWebSockets.js native addon)
+# Runtime stage - no git needed
+FROM node:22-trixie-slim
+
+WORKDIR /app
+COPY --from=build /app/build build/
+COPY --from=build /app/node_modules node_modules/
+COPY package.json .
+
 EXPOSE 3000
 CMD ["node", "build"]
 ```
@@ -1150,7 +1159,7 @@ docker run -p 3000:3000 \
   my-app
 ```
 
-> **Tip:** Don't use Alpine (`node:20-alpine`) - uWebSockets.js prebuilt binaries are compiled against glibc, not musl. If you must use Alpine, you'll need to compile from source.
+> **Important:** Use Debian Trixie or Ubuntu 24.04+ based images (glibc >= 2.38). Bookworm-based images (`node:*-slim`, `node:*-bookworm`) ship glibc 2.36 which is too old for uWebSockets.js. Don't use Alpine either - uWebSockets.js binaries are compiled against glibc, not musl.
 
 ---
 
@@ -1395,9 +1404,10 @@ npm install uNetworking/uWebSockets.js#v20.60.0
 sudo apt install build-essential
 ```
 
-**On Docker:** Use a Node.js image that includes build tools:
+**On Docker:** Use a Trixie-based image with git:
 ```dockerfile
-FROM node:20
+FROM node:22-trixie-slim
+RUN apt-get update && apt-get install -y --no-install-recommends git && rm -rf /var/lib/apt/lists/*
 ```
 
 ### "I can't see what's happening with WebSocket messages"

package/files/handler.js

@@ -10,7 +10,7 @@ import { manifest, prerendered, base } from 'MANIFEST';
 import { env } from 'ENV';
 import * as wsModule from 'WS_HANDLER';
 import { parseCookies } from './cookies.js';
-import { mimeLookup, splitCookiesString, parse_as_bytes, parse_origin } from './utils.js';
+import { mimeLookup, parse_as_bytes, parse_origin } from './utils.js';
 
 /* global ENV_PREFIX */
 /* global PRECOMPRESS */
@@ -497,11 +497,13 @@ async function handleSSR(res, method, url, headers, remoteAddress, state, abortS
 			return;
 		}
 		console.error('SSR error:', err);
-		res.cork(() => {
-			res.writeStatus('500 Internal Server Error');
-			res.writeHeader('content-type', 'text/plain');
-			res.end('Internal Server Error');
-		});
+		if (!state.aborted) {
+			res.cork(() => {
+				res.writeStatus('500 Internal Server Error');
+				res.writeHeader('content-type', 'text/plain');
+				res.end('Internal Server Error');
+			});
+		}
 	}
 }
 
@@ -515,15 +517,11 @@ async function handleSSR(res, method, url, headers, remoteAddress, state, abortS
 function writeHeaders(res, response) {
 	res.writeStatus(String(response.status));
 	for (const [key, value] of response.headers) {
-		if (key === 'set-cookie') {
-			for (const cookie of splitCookiesString(
-				/** @type {string} */ (response.headers.get(key))
-			)) {
-				res.writeHeader(key, cookie);
-			}
-		} else {
-			res.writeHeader(key, value);
-		}
+		if (key === 'set-cookie') continue;
+		res.writeHeader(key, value);
+	}
+	for (const cookie of response.headers.getSetCookie()) {
+		res.writeHeader('set-cookie', cookie);
 	}
 }
 
@@ -535,6 +533,7 @@ function writeHeaders(res, response) {
 async function writeResponse(res, response, state) {
 	// No body - write headers + end in a single cork (one syscall)
 	if (!response.body) {
+		if (state.aborted) return;
 		res.cork(() => {
 			writeHeaders(res, response);
 			res.end();
@@ -543,6 +542,7 @@ async function writeResponse(res, response, state) {
 	}
 
 	if (response.body.locked) {
+		if (state.aborted) return;
 		res.cork(() => {
 			res.writeStatus('500 Internal Server Error');
 			res.writeHeader('content-type', 'text/plain');
@@ -576,6 +576,7 @@ async function writeResponse(res, response, state) {
 		}
 
 		// Multi-chunk streaming response - write headers + first two chunks in one cork
+		if (state.aborted) return;
 		res.cork(() => {
 			writeHeaders(res, response);
 			res.write(first.value);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "svelte-adapter-uws",
-  "version": "0.1.0",
+  "version": "0.1.2",
   "description": "SvelteKit adapter for uWebSockets.js - high-performance C++ HTTP server with built-in WebSocket support",
   "author": "Kevin Radziszewski",
   "license": "MIT",