surveysparrow-ionic-plugin 0.0.2 → 0.0.3

package/android/src/main/java/com/surveysparrow/plugins/ionic/SurveySparrowIonicPluginPlugin.java

@@ -21,7 +21,7 @@ public class SurveySparrowIonicPluginPlugin extends Plugin {
     public void loadFullScreenSurvey(PluginCall call) {
         String domain = call.getString("domain");
         String token = call.getString("token");
-        CustomParam[] params = parseParams(call.getArray("params"));
+        CustomParam[] params = parseParams(call.getObject("params"));
         HashMap<String, String> properties = parseProperties(call.getObject("properties"));
 
         implementation.loadFullScreenSurvey(domain, token, params, properties);
@@ -32,28 +32,28 @@ public class SurveySparrowIonicPluginPlugin extends Plugin {
     public void loadFullScreenSurveyWithValidation(PluginCall call) {
         String domain = call.getString("domain");
         String token = call.getString("token");
-        CustomParam[] params = parseParams(call.getArray("params"));
+        CustomParam[] params = parseParams(call.getObject("params"));
         HashMap<String, String> properties = parseProperties(call.getObject("properties"));
 
         implementation.loadFullScreenSurveyWithValidation(domain, token, params, properties);
         call.resolve();
     }
 
-    private CustomParam[] parseParams(JSArray jsParams) {
-        if (jsParams == null || jsParams.length() == 0) {
+    private CustomParam[] parseParams(JSObject jsParams) {
+        if (jsParams == null || jsParams.keys().length == 0) {
             return new CustomParam[0];
         }
-
-        CustomParam[] params = new CustomParam[jsParams.length()];
-
-        for (int i = 0; i < jsParams.length(); i++) {
+    
+        String[] keys = jsParams.keys();
+        CustomParam[] params = new CustomParam[keys.length];
+    
+        for (int i = 0; i < keys.length; i++) {
             try {
-                JSObject paramObj = (JSObject) jsParams.get(i);
-                String key = paramObj.getString("key");
-                String value = paramObj.getString("value");
+                String key = keys[i];
+                String value = jsParams.getString(key);
                 params[i] = new CustomParam(key, value);
             } catch (JSONException e) {
-                throw new RuntimeException("Invalid parameter at index " + i, e);
+                throw new RuntimeException("Invalid parameter for key: " + keys[i], e);
             }
         }
 

package/ios/Sources/SurveySparrowIonicPluginPlugin/SurveySparrowIonicPlugin.swift

@@ -5,7 +5,19 @@ import SwiftUI
 @objc public class SurveySparrowIonicPlugin: NSObject {
     
     @objc public func loadFullScreenSurvey(domain: String, token: String, params: [String: String],  properties: [String: Any]) {
-        FullScreenSurveyView(domain: domain, token: token, params: params, properties: properties)
+        DispatchQueue.main.async {
+            let ssSurveyViewController = SsSurveyViewController()
+            ssSurveyViewController.domain = domain
+            ssSurveyViewController.token = token
+            ssSurveyViewController.params = params
+            ssSurveyViewController.properties = properties
+            ssSurveyViewController.getSurveyLoadedResponse = true
+            ssSurveyViewController.surveyDelegate = SsDelegate()
+            
+            if let topViewController = UIApplication.shared.windows.first?.rootViewController {
+                topViewController.present(ssSurveyViewController, animated: true, completion: nil)
+            }
+        }
     }
     
     @objc public func loadFullScreenSurveyWithValidation(domain: String, token: String, params: [String: String],  properties: [String: Any]) {
@@ -13,30 +25,6 @@ import SwiftUI
     }
 }
 
-struct FullScreenSurveyView: UIViewControllerRepresentable {
-    
-    var domain: String
-    var token: String
-    let params: [String: String]
-    let properties: [String: Any]
-    
-    @State private var isSurveyLoaded: Bool = false
-
-    func makeUIViewController(context: Context) -> SsSurveyViewController{
-        let ssSurveyViewController = SsSurveyViewController()
-        ssSurveyViewController.domain = domain
-        ssSurveyViewController.token = token
-        ssSurveyViewController.params = params
-        ssSurveyViewController.properties = properties
-        ssSurveyViewController.getSurveyLoadedResponse = true
-        ssSurveyViewController.surveyDelegate = SsDelegate()
-        return ssSurveyViewController
-    }
-
-    func updateUIViewController(_ uiViewController: SsSurveyViewController, context: Context) {}
-
-}
-
 struct FullScreenSurveyWithValidation {
     
     let domain: String?

package/ios/Sources/SurveySparrowIonicPluginPlugin/SurveySparrowIonicPluginPlugin.swift

@@ -7,7 +7,8 @@ public class SurveySparrowIonicPluginPlugin: CAPPlugin, CAPBridgedPlugin {
     public let identifier = "SurveySparrowIonicPluginPlugin"
     public let jsName = "SurveySparrowIonicPlugin"
     public let pluginMethods: [CAPPluginMethod] = [
-        CAPPluginMethod(name: "echo", returnType: CAPPluginReturnPromise)
+        CAPPluginMethod(name: "loadFullScreenSurvey", returnType: CAPPluginReturnNone),
+        CAPPluginMethod(name: "loadFullScreenSurveyWithValidation", returnType: CAPPluginReturnNone)
     ]
     
     private let implementation = SurveySparrowIonicPlugin()

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "surveysparrow-ionic-plugin",
-  "version": "0.0.2",
+  "version": "0.0.3",
   "description": "SurveySparrow SDK enables you to collect feedback from your mobile app. Embed the Classic, Chat & NPS surveys in your ionic application seamlessly with few lines of code.",
   "main": "dist/plugin.cjs.js",
   "module": "dist/esm/index.js",