survey-react 1.12.28 → 1.12.29

package/defaultV2.css

@@ -1,5 +1,5 @@
 /*!
- * surveyjs - Survey JavaScript library v1.12.28
+ * surveyjs - Survey JavaScript library v1.12.29
  * Copyright (c) 2015-2025 Devsoft Baltic OÜ  - http://surveyjs.io/
  * License: MIT (http://www.opensource.org/licenses/mit-license.php)
  */

package/defaultV2.min.css

@@ -1,5 +1,5 @@
 /*!
- * surveyjs - Survey JavaScript library v1.12.28
+ * surveyjs - Survey JavaScript library v1.12.29
  * Copyright (c) 2015-2025 Devsoft Baltic OÜ  - http://surveyjs.io/
  * License: MIT (http://www.opensource.org/licenses/mit-license.php)
  */

package/modern.css

@@ -1,5 +1,5 @@
 /*!
- * surveyjs - Survey JavaScript library v1.12.28
+ * surveyjs - Survey JavaScript library v1.12.29
  * Copyright (c) 2015-2025 Devsoft Baltic OÜ  - http://surveyjs.io/
  * License: MIT (http://www.opensource.org/licenses/mit-license.php)
  */

package/modern.min.css

@@ -1,5 +1,5 @@
 /*!
- * surveyjs - Survey JavaScript library v1.12.28
+ * surveyjs - Survey JavaScript library v1.12.29
  * Copyright (c) 2015-2025 Devsoft Baltic OÜ  - http://surveyjs.io/
  * License: MIT (http://www.opensource.org/licenses/mit-license.php)
  */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "survey-react",
-  "version": "1.12.28",
+  "version": "1.12.29",
   "description": "survey.js is a JavaScript Survey Library. It is a modern way to add a survey to your website. It uses JSON for survey metadata and results.",
   "keywords": [
     "Survey",

package/survey.css

@@ -1,5 +1,5 @@
 /*!
- * surveyjs - Survey JavaScript library v1.12.28
+ * surveyjs - Survey JavaScript library v1.12.29
  * Copyright (c) 2015-2025 Devsoft Baltic OÜ  - http://surveyjs.io/
  * License: MIT (http://www.opensource.org/licenses/mit-license.php)
  */

package/survey.min.css

@@ -1,5 +1,5 @@
 /*!
- * surveyjs - Survey JavaScript library v1.12.28
+ * surveyjs - Survey JavaScript library v1.12.29
  * Copyright (c) 2015-2025 Devsoft Baltic OÜ  - http://surveyjs.io/
  * License: MIT (http://www.opensource.org/licenses/mit-license.php)
  */

package/survey.react.d.ts

@@ -4752,6 +4752,7 @@ declare module "packages/survey-core/src/question_baseselect" {
         protected setQuestionComment(newValue: string): void;
         private onUpdateCommentOnAutoOtherMode;
         private setOtherValueInternally;
+        private getValueOnSettingOther;
         clearValue(keepComment?: boolean): void;
         updateCommentFromSurvey(newValue: any): any;
         get renderedValue(): any;

package/survey.react.js

@@ -1,5 +1,5 @@
 /*!
- * surveyjs - Survey JavaScript library v1.12.28
+ * surveyjs - Survey JavaScript library v1.12.29
  * Copyright (c) 2015-2025 Devsoft Baltic OÜ  - http://surveyjs.io/
  * License: MIT (http://www.opensource.org/licenses/mit-license.php)
  */
@@ -45585,8 +45585,6 @@ var survey_SurveyModel = /** @class */ (function (_super) {
     });
     SurveyModel.prototype.updateIsFirstLastPageState = function () {
         var curPage = this.currentPage;
-        this.setPropertyValue("isFirstPage", !!curPage && curPage === this.firstVisiblePage);
-        this.setPropertyValue("isLastPage", !!curPage && curPage === this.lastVisiblePage);
         var fVal = undefined;
         var lVal = undefined;
         var q = this.currentSingleElement;
@@ -45598,6 +45596,8 @@ var survey_SurveyModel = /** @class */ (function (_super) {
                 lVal = index === questions.length - 1;
             }
         }
+        this.setPropertyValue("isFirstPage", !!curPage && curPage === this.firstVisiblePage && (!q || fVal === true));
+        this.setPropertyValue("isLastPage", !!curPage && curPage === this.lastVisiblePage && (!q || lVal === true));
         this.setPropertyValue("isFirstElement", fVal);
         this.setPropertyValue("isLastElement", lVal);
     };
@@ -50380,11 +50380,30 @@ var question_baseselect_QuestionSelectBase = /** @class */ (function (_super) {
             this.isSettingComment = true;
             this.otherValueCore = newValue;
             if (this.isOtherSelected && !this.isRenderedValueSetting) {
-                this.value = this.rendredValueToData(this.renderedValue);
+                this.value = this.getValueOnSettingOther(newValue);
             }
             this.isSettingComment = false;
         }
     };
+    QuestionSelectBase.prototype.getValueOnSettingOther = function (otherValue) {
+        var val = this.rendredValueToData(this.renderedValue);
+        if (this.showCommentArea || this.getStoreOthersAsComment())
+            return val;
+        var item = itemvalue_ItemValue.getItemByValue(this.visibleChoices, otherValue);
+        if (!item || item === this.otherItem)
+            return val;
+        this.otherValueCore = "";
+        if (!Array.isArray(val))
+            return otherValue;
+        var index = val.indexOf(this.otherItem.value);
+        if (index > -1) {
+            val.splice(index, 1);
+        }
+        if (val.indexOf(otherValue) < 0) {
+            val.push(otherValue);
+        }
+        return val;
+    };
     QuestionSelectBase.prototype.clearValue = function (keepComment) {
         _super.prototype.clearValue.call(this, keepComment);
         this.prevOtherValue = undefined;
@@ -63615,10 +63634,10 @@ var question_rating_QuestionRatingModel = /** @class */ (function (_super) {
             return null;
         var value = item.value;
         var description;
-        if (value === this.rateMin) {
+        if (index === 0) {
             description = this.minRateDescription && this.locMinRateDescription;
         }
-        if (value === this.rateMax || index === settings.ratingMaximumRateValueCount) {
+        if (index === (this.rateCount - 1)) {
             description = this.maxRateDescription && this.locMaxRateDescription;
         }
         var newItem = new RatingItemValue(value, item.text, description);
@@ -67065,12 +67084,20 @@ var question_paneldynamic_QuestionPanelDynamicItem = /** @class */ (function ()
             return;
         this.data.setPanelItemData(this, name, helpers_Helpers.getUnbindValue(newValue));
         var questions = this.panel.questions;
-        var triggerName = QuestionPanelDynamicItem.ItemVariableName + "." + name;
         for (var i = 0; i < questions.length; i++) {
             var q = questions[i];
             if (q.getValueName() !== name) {
                 q.checkBindings(name, newValue);
             }
+            var suffix = settings.commentSuffix;
+            if (name.endsWith(suffix)) {
+                name = name.substring(0, name.length - suffix.length);
+                var cQ = this.panel.getQuestionByName(name);
+                if (!!cQ) {
+                    newValue = cQ.value;
+                }
+            }
+            var triggerName = QuestionPanelDynamicItem.ItemVariableName + "." + name;
             q.runTriggers(triggerName, newValue);
         }
     };
@@ -72876,9 +72903,9 @@ Serializer.addClass("currencymask", [
 
 var Version;
 var ReleaseDate;
-Version = "" + "1.12.28";
+Version = "" + "1.12.29";
 settings.version = Version;
-ReleaseDate = "" + "2025-03-18";
+ReleaseDate = "" + "2025-03-24";
 function checkLibraryVersion(ver, libraryName) {
     if (Version != ver) {
         var str = "survey-core has version '" + Version + "' and " + libraryName