supipowers 2.0.1 → 2.1.0

package/src/harness/pr-comment/workflow-summary.ts

@@ -0,0 +1,47 @@
+/**
+ * Fallback writer for `$GITHUB_STEP_SUMMARY`.
+ *
+ * GitHub Actions reads any markdown appended to the file at this env var and renders it
+ * on the workflow run summary page. We use it as a fail-open fallback when posting a PR
+ * comment is impossible (no auth, no `gh` CLI, no PR context).
+ *
+ * Never throws. Returns `{ ok: false }` quietly on IO error so the calling pipeline does
+ * not crash on a runner with an unwritable `$GITHUB_STEP_SUMMARY`.
+ */
+
+import * as fs from "node:fs";
+
+export interface WriteStepSummaryResult {
+  /** True when the body was appended (or no-op because env is unset). */
+  ok: boolean;
+  /** Resolved summary file path when appended. */
+  path?: string;
+  /** When ok=false, a short reason for diagnostics. */
+  reason?: string;
+}
+
+/**
+ * Append `body` to the workflow step summary file. When `$GITHUB_STEP_SUMMARY` is unset
+ * (local dev), this is a successful no-op.
+ */
+export function writeStepSummary(
+  body: string,
+  env: NodeJS.ProcessEnv = process.env,
+): WriteStepSummaryResult {
+  const summaryPath = env.GITHUB_STEP_SUMMARY;
+  if (!summaryPath) {
+    return { ok: true };
+  }
+  try {
+    // The summary file is append-only between steps; we add a leading blank line so the
+    // harness section is separated from anything an earlier step contributed.
+    const payload = body.endsWith("\n") ? `\n${body}` : `\n${body}\n`;
+    fs.appendFileSync(summaryPath, payload);
+    return { ok: true, path: summaryPath };
+  } catch (error) {
+    return {
+      ok: false,
+      reason: error instanceof Error ? error.message : String(error),
+    };
+  }
+}

package/src/harness/project-paths.ts

@@ -52,6 +52,13 @@ export const HARNESS_IMPLEMENT_LOG_FILENAME = "implement-log.jsonl";
 export const HARNESS_PIPELINE_LOG_FILENAME = "pipeline-log.jsonl";
 export const HARNESS_RESEARCH_DIRNAME = "research";
 
+/** Per-session staging directory for the docs stage. */
+export const HARNESS_DOCS_STAGING_DIRNAME = "docs";
+/** Layers subdirectory within the docs staging or repo-docs directory. */
+export const HARNESS_DOCS_LAYERS_DIRNAME = "layers";
+/** Index filename rendered after layer docs promote. */
+export const HARNESS_DOCS_README_FILENAME = "README.md";
+
 /** Tier 1 / Tier 2 output paths in the repo. */
 export const HARNESS_AGENTS_MD_FILENAME = "AGENTS.md";
 export const HARNESS_DOCS_DIRNAME = "docs";
@@ -233,3 +240,91 @@ export function getHarnessGoldenPrinciplesPath(_paths: PlatformPaths, cwd: strin
 export function getHarnessFallowConfigPath(_paths: PlatformPaths, cwd: string): string {
   return path.join(cwd, HARNESS_FALLOW_CONFIG_FILENAME);
 }
+
+// ---------------------------------------------------------------------------
+// Docs stage — staging + repo paths.
+// ---------------------------------------------------------------------------
+/**
+ * Strict whitelist for per-layer doc identifiers.
+ *
+ * Layer ids are user/model-controlled (set in `design-spec.json`) and feed into
+ * `<repo>/docs/layers/<id>.md` plus the per-session staging mirror. Without a strict
+ * boundary an id like `../golden-principles` would let the docs stage overwrite Tier 1
+ * docs (or escape `docs/layers/` entirely). Reject anything that isn't a safe filename
+ * stem: alnum, hyphen, underscore, and (non-leading, non-consecutive) dots.
+ */
+const LAYER_ID_PATTERN = /^[A-Za-z0-9_-][A-Za-z0-9._-]{0,63}$/;
+
+export function isSafeLayerId(layerId: string): boolean {
+  return (
+    typeof layerId === "string" &&
+    LAYER_ID_PATTERN.test(layerId) &&
+    !layerId.includes("..")
+  );
+}
+
+export function assertSafeLayerId(layerId: string): void {
+  if (!isSafeLayerId(layerId)) {
+    throw new Error(
+      `harness: invalid layer id ${JSON.stringify(layerId)} — expected [A-Za-z0-9._-]{1,64} with no path separators, leading dot, or '..'.`,
+    );
+  }
+}
+
+
+/**
+ * Per-session staging dir for the docs stage:
+ * `<projectRoot>/sessions/<sid>/docs/`. Subagents write `layers/<id>.md` here; the stage
+ * renders the index and atomically promotes both staging files to the repo.
+ */
+export function getHarnessDocsStagingDir(
+  paths: PlatformPaths,
+  cwd: string,
+  sessionId: string,
+): string {
+  return path.join(getHarnessSessionDir(paths, cwd, sessionId), HARNESS_DOCS_STAGING_DIRNAME);
+}
+
+/** Per-session staging path for a single layer doc. */
+export function getHarnessDocsStagingLayerPath(
+  paths: PlatformPaths,
+  cwd: string,
+  sessionId: string,
+  layerId: string,
+): string {
+  assertSafeLayerId(layerId);
+  return path.join(
+    getHarnessDocsStagingDir(paths, cwd, sessionId),
+    HARNESS_DOCS_LAYERS_DIRNAME,
+    `${layerId}.md`,
+  );
+}
+
+/** Per-session staging path for the rendered docs index. */
+export function getHarnessDocsStagingReadmePath(
+  paths: PlatformPaths,
+  cwd: string,
+  sessionId: string,
+): string {
+  return path.join(getHarnessDocsStagingDir(paths, cwd, sessionId), HARNESS_DOCS_README_FILENAME);
+}
+
+/** Repo-root path for the rendered docs index: `<repo>/docs/README.md`. */
+export function getHarnessRepoDocsReadmePath(_paths: PlatformPaths, cwd: string): string {
+  return path.join(cwd, HARNESS_DOCS_DIRNAME, HARNESS_DOCS_README_FILENAME);
+}
+
+/** Repo-root path for a single per-layer doc: `<repo>/docs/layers/<id>.md`. */
+export function getHarnessRepoDocsLayerPath(
+  _paths: PlatformPaths,
+  cwd: string,
+  layerId: string,
+): string {
+  assertSafeLayerId(layerId);
+  return path.join(cwd, HARNESS_DOCS_DIRNAME, HARNESS_DOCS_LAYERS_DIRNAME, `${layerId}.md`);
+}
+
+/** Repo-root directory hosting the per-layer docs: `<repo>/docs/layers/`. */
+export function getHarnessRepoDocsLayersDir(_paths: PlatformPaths, cwd: string): string {
+  return path.join(cwd, HARNESS_DOCS_DIRNAME, HARNESS_DOCS_LAYERS_DIRNAME);
+}

package/src/harness/stages/design.ts

@@ -61,6 +61,7 @@ export function defaultCiConfigFromDiscover(discover: HarnessDiscoverArtifact):
     trigger: { mode: "branches", branches: ["dev", "main"] },
     localCommand,
     workflowPath: ".github/workflows/harness-quality.yml",
+    prComment: { enabled: true, mode: "every-push" },
   };
 }
 

package/src/harness/stages/discover.ts

@@ -190,7 +190,6 @@ function detectOmpInfra(cwd: string): HarnessDiscoverArtifact["ompInfra"] {
   const hasSupipowers = existsSync(supipowersDir);
   const skills: string[] = [];
   const reviewAgents: string[] = [];
-  const mcpServers: string[] = [];
   let plansCount = 0;
 
   // Skills are typically in skills/ at the repo root.
@@ -226,20 +225,9 @@ function detectOmpInfra(cwd: string): HarnessDiscoverArtifact["ompInfra"] {
         plansCount = 0;
       }
     }
-    const mcpJson = path.join(supipowersDir, ".mcp.json");
-    if (existsSync(mcpJson)) {
-      try {
-        const parsed = JSON.parse(fs.readFileSync(mcpJson, "utf8")) as {
-          servers?: Record<string, unknown>;
-        };
-        if (parsed.servers) mcpServers.push(...Object.keys(parsed.servers));
-      } catch {
-        // ignore
-      }
-    }
   }
 
-  return { hasSupipowers, skills, reviewAgents, mcpServers, plansCount };
+  return { hasSupipowers, skills, reviewAgents, plansCount };
 }
 
 function detectFrameworks(cwd: string): string[] {