supipowers 1.5.3 → 2.0.0

package/src/commands/ai-review.ts

@@ -1,3 +1,4 @@
+import path from "node:path";
 import { matchesKey, truncateToWidth, wrapTextWithAnsi, type Component, type Focusable } from "@oh-my-pi/pi-tui";
 import type { Platform } from "../platform/types.js";
 import { createWorkflowProgress } from "../platform/progress.js";
@@ -19,6 +20,16 @@ import {
   writeReviewArtifact,
 } from "../storage/review-sessions.js";
 import { accent, bright, muted } from "../platform/tui-colors.js";
+import { resolvePackageManager } from "../workspace/package-manager.js";
+import { resolveRepoRoot } from "../workspace/repo-root.js";
+import {
+  buildWorkspaceTargetOptionLabel,
+  parseTargetArg,
+  selectWorkspaceTarget,
+  type WorkspaceTargetOption,
+} from "../workspace/selector.js";
+import { getProjectStatePath, getProjectTargetStatePath } from "../workspace/state-paths.js";
+import { discoverWorkspaceTargets } from "../workspace/targets.js";
 import type {
   ConfiguredReviewAgent,
   ReviewFinding,
@@ -27,6 +38,7 @@ import type {
   ReviewPostConsolidationAction,
   ReviewScope,
   ReviewSession,
+  WorkspaceTarget,
 } from "../types.js";
 
 modelRegistry.register({
@@ -80,6 +92,123 @@ interface ReviewResultsSummary {
   helpText: string;
 }
 
+interface ParsedAiReviewArgs {
+  requestedTarget: string | null;
+}
+
+interface ReviewTargetChoice {
+  repoRoot: string;
+  target: WorkspaceTarget | null;
+  targets: WorkspaceTarget[];
+}
+
+function parseAiReviewArgs(args?: string): ParsedAiReviewArgs {
+  return {
+    requestedTarget: parseTargetArg(args),
+  };
+}
+
+function buildReviewTargetSummary(target: WorkspaceTarget): string {
+  return `${target.name} (${target.relativeDir})`;
+}
+
+function buildReviewTargetOption(target: WorkspaceTarget): WorkspaceTargetOption {
+  return {
+    target,
+    changed: false,
+    label: target.kind === "root"
+      ? `${buildWorkspaceTargetOptionLabel({ target, changed: false })} — root only`
+      : buildWorkspaceTargetOptionLabel({ target, changed: false }),
+  };
+}
+
+function buildAllReviewTargetLabel(targets: WorkspaceTarget[]): string {
+  const workspaceCount = targets.filter((target) => target.kind === "workspace").length;
+  return workspaceCount === 0
+    ? "All — root target"
+    : `All — root + ${workspaceCount} workspace${workspaceCount === 1 ? "" : "s"}`;
+}
+
+function isMonorepoTargets(targets: WorkspaceTarget[]): boolean {
+  return targets.some((target) => target.kind === "workspace");
+}
+
+async function selectReviewTarget(
+  platform: Platform,
+  ctx: any,
+  requestedTarget: string | null,
+): Promise<ReviewTargetChoice | null> {
+  const repoRoot = await resolveRepoRoot(platform, ctx.cwd);
+  const packageManager = resolvePackageManager(repoRoot);
+  const discoveredTargets = discoverWorkspaceTargets(repoRoot, packageManager.id);
+  const targets = discoveredTargets.length > 0
+    ? discoveredTargets
+    : [{
+        id: "root",
+        name: path.basename(repoRoot) || "root",
+        kind: "root",
+        repoRoot,
+        packageDir: repoRoot,
+        manifestPath: path.join(repoRoot, "package.json"),
+        relativeDir: ".",
+        version: "0.0.0",
+        private: true,
+        packageManager: packageManager.id,
+      } satisfies WorkspaceTarget];
+  const options = targets.map(buildReviewTargetOption);
+
+  if (requestedTarget?.toLowerCase() === "all") {
+    return { repoRoot, target: null, targets };
+  }
+
+  if (requestedTarget) {
+    const selectedTarget = await selectWorkspaceTarget(
+      ctx,
+      options,
+      requestedTarget,
+      {
+        title: "Review target",
+        helpText: "Pick one package to narrow the review, or use --target all to review the root target and every workspace.",
+      },
+    );
+    if (!selectedTarget) {
+      throw new Error(`Review target not found: ${requestedTarget}`);
+    }
+    return { repoRoot, target: selectedTarget, targets };
+  }
+
+  if (!isMonorepoTargets(targets)) {
+    const selectedTarget = await selectWorkspaceTarget(
+      ctx,
+      options,
+      null,
+      {
+        title: "Review target",
+        helpText: "Pick the target to review.",
+      },
+    );
+    return selectedTarget ? { repoRoot, target: selectedTarget, targets } : null;
+  }
+
+  const allLabel = buildAllReviewTargetLabel(targets);
+  const labels = [allLabel, ...options.map((option) => option.label ?? buildWorkspaceTargetOptionLabel(option))];
+  const choice = await ctx.ui.select("Review target", labels, {
+    initialIndex: 0,
+    helpText: "All reviews the root target and every workspace. Choose a single target to narrow the review.",
+  });
+  if (!choice) {
+    return null;
+  }
+  if (choice === allLabel) {
+    return { repoRoot, target: null, targets };
+  }
+
+  const selectedIndex = labels.indexOf(choice) - 1;
+  const selectedTarget = selectedIndex >= 0 ? options[selectedIndex]?.target ?? null : null;
+  return selectedTarget ? { repoRoot, target: selectedTarget, targets } : null;
+}
+
+
 function formatFindingLocation(finding: ReviewFinding): string {
   if (!finding.file) {
     return "unknown location";
@@ -384,8 +513,9 @@ function buildDiscussionPrompt(
   ctx: any,
   session: ReviewSession,
   summary: ReviewResultsSummary,
+  selectedTarget: WorkspaceTarget | null,
 ): string {
-  const sessionDir = buildSavedSessionPath(platform, ctx, session);
+  const sessionDir = buildSavedSessionPath(platform, ctx, session, selectedTarget);
   const artifactLines = [
     `- session: ${sessionDir}/session.json`,
     `- scope: ${sessionDir}/${session.artifacts.scope}`,
@@ -435,8 +565,15 @@ function buildPostConsolidationDetail(action: ReviewPostConsolidationAction): st
   }
 }
 
-function buildSavedSessionPath(platform: Platform, ctx: any, session: ReviewSession): string {
-  return platform.paths.project(ctx.cwd, "reviews", session.id);
+function buildSavedSessionPath(
+  platform: Platform,
+  ctx: any,
+  session: ReviewSession,
+  selectedTarget: WorkspaceTarget | null,
+): string {
+  return selectedTarget
+    ? getProjectTargetStatePath(platform.paths, selectedTarget, "reviews", session.id)
+    : getProjectStatePath(platform.paths, ctx.cwd, "reviews", session.id);
 }
 
 function buildActionLabel(action: ReviewPostConsolidationAction | null): string {
@@ -714,9 +851,14 @@ async function selectMaxIterations(ctx: any, defaultValue = 3): Promise<number |
   return parsed;
 }
 
-function buildCompletionDetail(session: ReviewSession, output: ReviewOutput): string {
+function buildCompletionDetail(
+  session: ReviewSession,
+  output: ReviewOutput,
+  selectedTarget: WorkspaceTarget | null,
+ ): string {
   return [
     `session: ${session.id}`,
+    ...(selectedTarget ? [`target: ${buildReviewTargetSummary(selectedTarget)}`] : []),
     `status: ${output.status}`,
     `findings: ${output.findings.length}`,
     `iterations: ${session.currentIteration}`,
@@ -730,6 +872,7 @@ function writeFindingsReport(
   ctx: any,
   session: ReviewSession,
   output: ReviewOutput,
+  selectedTarget: WorkspaceTarget | null,
   options: { preFixSnapshot?: boolean } = {},
 ): string {
   const artifactPath = deps.writeReviewArtifact(
@@ -738,6 +881,7 @@ function writeFindingsReport(
     session.id,
     FINDINGS_REPORT_FILE,
     buildReviewFindingsMarkdown(output, session, options),
+    selectedTarget,
   );
   session.artifacts.findingsReport = FINDINGS_REPORT_FILE;
   return artifactPath;
@@ -750,13 +894,14 @@ function persistIteration(
   session: ReviewSession,
   iteration: number,
   output: ReviewOutput,
+  selectedTarget: WorkspaceTarget | null,
   extra: Record<string, unknown> = {},
 ): void {
   const relativePath = `${ITERATIONS_DIR}/${iteration}.json`;
   deps.writeReviewArtifact(platform.paths, ctx.cwd, session.id, relativePath, {
     output,
     ...extra,
-  });
+  }, selectedTarget);
   session.iterations.push({
     iteration,
     findings: output.findings.length,
@@ -814,6 +959,7 @@ async function runReviewPass(
     scope,
     agents,
     createAgentSession: platform.createAgentSession.bind(platform),
+    activeTools: platform.getActiveTools(),
     model: resolvedModel.model,
     thinkingLevel: resolvedModel.thinkingLevel,
     onAgentStart: (agent) => progress.startAgent(agent),
@@ -829,13 +975,22 @@ async function runAiReviewSession(
   platform: Platform,
   ctx: any,
   deps: AiReviewCommandDependencies = AI_REVIEW_COMMAND_DEPENDENCIES,
+  args?: string,
 ): Promise<void> {
   if (!ctx.hasUI) {
     ctx.ui.notify("/supi:review requires interactive mode.", "warning");
     return;
   }
 
-  const scope = await deps.selectReviewScope(platform, ctx);
+  const { requestedTarget } = parseAiReviewArgs(args);
+  const selectedReviewTarget = await selectReviewTarget(platform, ctx, requestedTarget);
+  if (!selectedReviewTarget) {
+    return;
+  }
+  const reviewTarget = selectedReviewTarget;
+  const scopeSelection = reviewTarget.target ? { target: reviewTarget.target, targets: reviewTarget.targets } : null;
+
+  const scope = await deps.selectReviewScope(platform, ctx, scopeSelection);
   if (!scope) {
     return;
   }
@@ -846,7 +1001,10 @@ async function runAiReviewSession(
   }
 
   const loadedAgents = level === "multi-agent"
-    ? await deps.loadReviewAgents(platform.paths, ctx.cwd)
+    ? await deps.loadReviewAgents(platform.paths, ctx.cwd, {
+        repoRoot: reviewTarget.repoRoot,
+        workspaceRelativeDir: reviewTarget.target?.kind === "workspace" ? reviewTarget.target.relativeDir : null,
+      })
     : null;
   const agents = loadedAgents?.agents ?? [];
   if (level === "multi-agent" && agents.length === 0) {
@@ -863,8 +1021,8 @@ async function runAiReviewSession(
     scope,
     agents,
   );
-  deps.createReviewSession(platform.paths, ctx.cwd, session);
-  deps.writeReviewArtifact(platform.paths, ctx.cwd, session.id, session.artifacts.scope, scope);
+  deps.createReviewSession(platform.paths, ctx.cwd, session, reviewTarget.target);
+  deps.writeReviewArtifact(platform.paths, ctx.cwd, session.id, session.artifacts.scope, scope, reviewTarget.target);
 
   const progress = createAiReviewProgress(ctx, level, agents);
   progress.completeScope(scope);
@@ -872,14 +1030,20 @@ async function runAiReviewSession(
   function saveSession(status: ReviewSession["status"]): void {
     progress.startSave();
     session.status = status;
-    deps.updateReviewSession(platform.paths, ctx.cwd, session);
+    deps.updateReviewSession(platform.paths, ctx.cwd, session, reviewTarget.target);
     progress.completeSave(status);
   }
 
-
   try {
     const initialRun = await runReviewPass(platform, ctx, deps, scope, level, agents, progress, resolvedModel);
-    deps.writeReviewArtifact(platform.paths, ctx.cwd, session.id, RAW_FINDINGS_FILE, initialRun.rawOutput);
+    deps.writeReviewArtifact(
+      platform.paths,
+      ctx.cwd,
+      session.id,
+      RAW_FINDINGS_FILE,
+      initialRun.rawOutput,
+      reviewTarget.target,
+    );
     session.artifacts.rawFindings = RAW_FINDINGS_FILE;
     for (const agentResult of initialRun.agentResults) {
       deps.writeReviewArtifact(
@@ -888,6 +1052,7 @@ async function runAiReviewSession(
         session.id,
         `${AGENTS_DIR}/${agentResult.agent.name}.json`,
         agentResult,
+        reviewTarget.target,
       );
     }
 
@@ -906,7 +1071,14 @@ async function runAiReviewSession(
       });
       const validatedOutput = preserveBlockedReviewStatus(validation.output, currentOutput.status);
       currentOutput = prepareReviewOutputForFollowUp(validatedOutput, currentOutput.status);
-      deps.writeReviewArtifact(platform.paths, ctx.cwd, session.id, VALIDATED_FINDINGS_FILE, validatedOutput);
+      deps.writeReviewArtifact(
+        platform.paths,
+        ctx.cwd,
+        session.id,
+        VALIDATED_FINDINGS_FILE,
+        validatedOutput,
+        reviewTarget.target,
+      );
       session.artifacts.validatedFindings = VALIDATED_FINDINGS_FILE;
       progress.completeValidate(validatedOutput);
     } else {
@@ -921,7 +1093,14 @@ async function runAiReviewSession(
         deps.consolidateReviewOutputs([currentOutput]),
         currentOutput.status,
       );
-      deps.writeReviewArtifact(platform.paths, ctx.cwd, session.id, CONSOLIDATED_FINDINGS_FILE, currentOutput);
+      deps.writeReviewArtifact(
+        platform.paths,
+        ctx.cwd,
+        session.id,
+        CONSOLIDATED_FINDINGS_FILE,
+        currentOutput,
+        reviewTarget.target,
+      );
       session.artifacts.consolidatedFindings = CONSOLIDATED_FINDINGS_FILE;
       progress.completeConsolidate(currentOutput);
     } else {
@@ -929,13 +1108,28 @@ async function runAiReviewSession(
       progress.skipConsolidate(level === "multi-agent" ? "no findings" : "single-agent");
     }
 
-    persistIteration(deps, platform, ctx, session, 1, currentOutput);
-    let findingsReportPath = writeFindingsReport(deps, platform, ctx, session, currentOutput);
+    persistIteration(deps, platform, ctx, session, 1, currentOutput, reviewTarget.target);
+    let findingsReportPath = writeFindingsReport(
+      deps,
+      platform,
+      ctx,
+      session,
+      currentOutput,
+      reviewTarget.target,
+    );
     let findingsReportIsPreFixSnapshot = false;
 
     async function cancelSession(): Promise<void> {
       if (findingsReportIsPreFixSnapshot) {
-        findingsReportPath = writeFindingsReport(deps, platform, ctx, session, currentOutput, { preFixSnapshot: true });
+        findingsReportPath = writeFindingsReport(
+          deps,
+          platform,
+          ctx,
+          session,
+          currentOutput,
+          reviewTarget.target,
+          { preFixSnapshot: true },
+        );
       }
       saveSession("cancelled");
     }
@@ -963,7 +1157,7 @@ async function runAiReviewSession(
         deps.notifyInfo(
           ctx,
           "AI review documented without fixes",
-          `session: ${session.id} | findings: ${currentOutput.findings.length} | report: ${findingsReportPath}`,
+          `${buildCompletionDetail(session, currentOutput, reviewTarget.target)} | report: ${findingsReportPath}`,
         );
         return;
       }
@@ -975,9 +1169,11 @@ async function runAiReviewSession(
         deps.notifyInfo(
           ctx,
           "AI review saved for discussion",
-          `session: ${session.id} | findings: ${currentOutput.findings.length} | report: ${findingsReportPath}`,
+          `${buildCompletionDetail(session, currentOutput, reviewTarget.target)} | report: ${findingsReportPath}`,
+        );
+        platform.sendUserMessage(
+          buildDiscussionPrompt(platform, ctx, session, reviewResultsSummary, reviewTarget.target),
         );
-        platform.sendUserMessage(buildDiscussionPrompt(platform, ctx, session, reviewResultsSummary));
         return;
       }
 
@@ -1038,8 +1234,24 @@ async function runAiReviewSession(
           }
 
           const delta = compareReviewOutputs(previousOutput, rerunOutput);
-          persistIteration(deps, platform, ctx, session, iteration, rerunOutput, { delta });
-          findingsReportPath = writeFindingsReport(deps, platform, ctx, session, rerunOutput);
+          persistIteration(
+            deps,
+            platform,
+            ctx,
+            session,
+            iteration,
+            rerunOutput,
+            reviewTarget.target,
+            { delta },
+          );
+          findingsReportPath = writeFindingsReport(
+            deps,
+            platform,
+            ctx,
+            session,
+            rerunOutput,
+            reviewTarget.target,
+          );
           findingsReportIsPreFixSnapshot = false;
           progress.completeRerun(iteration, session.maxIterations);
 
@@ -1070,18 +1282,26 @@ async function runAiReviewSession(
     }
 
     if (findingsReportIsPreFixSnapshot) {
-      findingsReportPath = writeFindingsReport(deps, platform, ctx, session, currentOutput, { preFixSnapshot: true });
+      findingsReportPath = writeFindingsReport(
+        deps,
+        platform,
+        ctx,
+        session,
+        currentOutput,
+        reviewTarget.target,
+        { preFixSnapshot: true },
+      );
     }
 
     saveSession(currentOutput.status === "blocked" ? "blocked" : "completed");
     deps.notifyInfo(
       ctx,
       `AI review complete: ${findingsReportIsPreFixSnapshot ? "post-fix verification pending" : currentOutput.status}`,
-      `${buildCompletionDetail(session, currentOutput)} | report: ${findingsReportIsPreFixSnapshot ? `${findingsReportPath} (pre-fix snapshot)` : findingsReportPath}`,
+      `${buildCompletionDetail(session, currentOutput, reviewTarget.target)} | report: ${findingsReportIsPreFixSnapshot ? `${findingsReportPath} (pre-fix snapshot)` : findingsReportPath}`,
     );
   } catch (error) {
     session.status = "blocked";
-    deps.updateReviewSession(platform.paths, ctx.cwd, session);
+    deps.updateReviewSession(platform.paths, ctx.cwd, session, reviewTarget.target);
     progress.failActive((error as Error).message);
     throw error;
   } finally {
@@ -1089,8 +1309,8 @@ async function runAiReviewSession(
   }
 }
 
-export function handleAiReview(platform: Platform, ctx: any): void {
-  void runAiReviewSession(platform, ctx, AI_REVIEW_COMMAND_DEPENDENCIES).catch((error) => {
+export function handleAiReview(platform: Platform, ctx: any, args?: string): void {
+  void runAiReviewSession(platform, ctx, AI_REVIEW_COMMAND_DEPENDENCIES, args).catch((error) => {
     ctx.ui.notify(`AI review failed: ${(error as Error).message}`, "error");
   });
 }
@@ -1099,15 +1319,16 @@ export async function runAiReviewSessionForTest(
   platform: Platform,
   ctx: any,
   deps: AiReviewCommandDependencies,
+  args?: string,
 ): Promise<void> {
-  await runAiReviewSession(platform, ctx, deps);
+  await runAiReviewSession(platform, ctx, deps, args);
 }
 
 export function registerAiReviewCommand(platform: Platform): void {
   platform.registerCommand("supi:review", {
     description: "Run the AI code review pipeline",
-    async handler(_args: string | undefined, ctx: any) {
-      handleAiReview(platform, ctx);
+    async handler(args: string | undefined, ctx: any) {
+      handleAiReview(platform, ctx, args);
     },
   });
 }