superpowers-manager 0.5.2 → 0.6.0

package/README.md

@@ -113,18 +113,20 @@ The [usage reference](https://github.com/j7an/superpowers-manager/blob/main/docs
 The installed package requires Node >=24. Native source, tests, and packaging tooling require Node >=24.12.0. Every other requirement is command-specific and is checked before dispatch. This table is derived from production by `tests/bin/readme-requirements.test.ts`.
 
 <!-- requirements:begin -->
-| Command | git | Python 3 | Codex CLI (default) | Pi CLI (`--harness pi`) |
-|---|---|---|---|---|
-| `pin` | yes | no | no | no |
-| `track-latest` | no | no | no | no |
-| `unpin` | no | no | no | no |
-| `prepare` | yes | only with SUPERPOWERS_VALIDATOR | no | no |
-| `probe` | yes | no | yes | no |
-| `install` | yes | no | yes | yes |
-| `update` | yes | no | yes | yes |
-| `uninstall` | no | no | yes | yes |
+| Command | git | Codex CLI (default) | Pi CLI (`--harness pi`) |
+|---|---|---|---|
+| `pin` | yes | no | no |
+| `track-latest` | no | no | no |
+| `unpin` | no | no | no |
+| `prepare` | yes | no | no |
+| `probe` | yes | yes | no |
+| `install` | yes | yes | yes |
+| `update` | yes | yes | yes |
+| `uninstall` | no | yes | yes |
 <!-- requirements:end -->
 
+Generated Codex manifests preserve upstream JSON number tokens while rejecting non-finite decimal or exponent values.
+
 macOS and Linux are tested. WSL2 is supported for the established Codex path; Pi in WSL2 and native Windows remain untested. The manager runs in-process and does not require Git Bash. The [Pi reference](https://github.com/j7an/superpowers-manager/blob/main/docs/pi.md#runtime-compatibility) explains its runtime qualification and admission checks.
 
 Native test versions qualify integration mechanisms; they are not runtime allowlists, and an untested runtime is not automatically certified as compatible.

package/dist/cli.js

@@ -46,8 +46,8 @@ const IN_PROCESS_HANDLERS = {
 // required because `spw_invoke_adapter` ran validate-adapter-response.py once
 // per adapter call
 // (`git show ad56569a4c161e7b122967442e2b026eeb6395f6:scripts/core/adapter.sh:37-44::--response "$response_file" --result "$result_file" \`);
-// the in-process path has no validator process. It remains CONDITIONAL for
-// `prepare` through commandRequirements(env) below, unchanged from slice 3.4.
+// the in-process path no longer uses that adapter-response validator.
+// No command has a Python requirement in commandRequirements(env).
 // No command requires a POSIX shell any more.
 const SHARED_COMMAND_REQUIREMENTS = {
     pin: ["git"],
@@ -170,13 +170,6 @@ function findTool(name, env, platform) {
     }
     return null;
 }
-// python3 is required by `prepare` only when SUPERPOWERS_VALIDATOR names one:
-// after the port, that optional spawn (runValidator, in src/validator.ts,
-// called from src/commands/prepare.ts) is Python's only remaining consumer
-// on the prepare path. The conditional lives here, in the accessor preflight reads,
-// rather than inside preflight — an accessor that under-reports what
-// preflight enforces is the blind spot slice 2 closed when it made
-// CLI-PREFLIGHT-01 derive its map from production.
 function sharedRequirement(name) {
     return {
         name,
@@ -188,9 +181,6 @@ function sharedRequirement(name) {
 function commandRequirementsFor(env, adapter) {
     const forCommand = (command) => {
         const shared = SHARED_COMMAND_REQUIREMENTS[command].map(sharedRequirement);
-        if (command === "prepare" && env.SUPERPOWERS_VALIDATOR) {
-            shared.push(sharedRequirement("python3"));
-        }
         return [...shared, ...adapter.requirements(command, env)];
     };
     return {
@@ -217,6 +207,8 @@ function commandRequirements(env) {
 // spawned command in-process, so there is no shell to discover.
 function preflightFor(cmd, env, platform, adapter) {
     const errors = [...configurationErrors(cmd, env)];
+    if (errors.length > 0)
+        return { ok: false, errors };
     for (const requirement of commandRequirementsFor(env, adapter)[cmd]) {
         const found = requirement.lookup === "explicit-path-or-path" &&
             requirement.executable.includes(path.sep)
@@ -260,9 +252,12 @@ function usage() {
         "SUPERPOWERS_UPSTREAM_URL, SUPERPOWERS_CODEX, SUPERPOWERS_CACHE_DIR,",
         "SUPERPOWERS_CONFIG_DIR, XDG_CONFIG_HOME,",
         "SUPERPOWERS_PLUGIN_ROOT, SUPERPOWERS_MANIFEST_TEMPLATE,",
-        "SUPERPOWERS_VALIDATOR, SUPERPOWERS_VALIDATOR_EXECUTABLE,",
+        "SUPERPOWERS_VALIDATOR_EXECUTABLE,",
         "SUPERPOWERS_INSTALLED_SEARCH_ROOT, SUPERPOWERS_INSTALL_REFRESH_MODE",
         "",
+        "SUPERPOWERS_VALIDATOR is removed; unset it and use",
+        "SUPERPOWERS_VALIDATOR_EXECUTABLE with an executable validator.",
+        "",
         "Selection state uses SUPERPOWERS_CONFIG_DIR when set; otherwise it uses",
         "$XDG_CONFIG_HOME/superpowers-manager, then $HOME/.config/superpowers-manager.",
     ].join("\n");

package/dist/commands/install.js

@@ -163,9 +163,8 @@ async function gatherInstallStages(ctx, selection, artifact) {
             // is what turns a failed inspection into "error: installed manager
             // fingerprint inspection failed after install."
             // renderInstallVerification's failed-inspection arm
-            // (`src/harnesses/codex/presentation.ts:329::if (inspection.status !== 0 || !inspection.outcome.ok) {`)
-            // exists for this result-bearing path; the lifecycle compatibility
-            // export delegates through the same arm. Returning
+            // (`src/harnesses/codex/presentation.ts:305::if (inspection.status !== 0 || !inspection.outcome.ok) {`)
+            // exists for this result-bearing path. Returning
             // failed() instead reported the adapter's own generic diagnostic and
             // dropped the post-install verification claim -- a mutation had
             // already been issued at stage 3,

package/dist/commands/mutation.js

@@ -3,6 +3,7 @@ import { upstreamCacheRoot } from "../upstream-workspace.js";
 import { SafetyError } from "../safety-error.js";
 import { isAbsolute } from "node:path";
 import { oneLine } from "../cli-arguments.js";
+import { configurationErrors } from "../validator.js";
 export async function withMutation(command, ctx, action) {
     // Selection validation precedes every adapter call and lock creation. A
     // nested mutation receives the already resolved value and cannot observe a
@@ -50,6 +51,12 @@ export async function withMutation(command, ctx, action) {
     return await ctx.coordination.withResources(resources, async () => action(scoped));
 }
 export async function runWithMutation(command, ctx, action) {
+    const errors = configurationErrors(command, ctx.env);
+    if (errors.length > 0) {
+        for (const message of errors)
+            ctx.stderr.write(`error: ${message}\n`);
+        return 1;
+    }
     let actionThrew = false;
     try {
         return await withMutation(command, ctx, async (scoped) => {

package/dist/commands/prepare.js

@@ -7,7 +7,7 @@ import { runGit } from "../git.js";
 import { SafetyError } from "../safety-error.js";
 import { fetchExactCommit, gitSafeSource } from "../upstream.js";
 import { upstreamCacheRoot } from "../upstream-workspace.js";
-import { BOUNDED_EXECUTABLE, UNBOUNDED_LEGACY, launchFailureMessage, resolveValidator, runValidator, displayPath, } from "../validator.js";
+import { BOUNDED_EXECUTABLE, launchFailureMessage, resolveValidator, runValidator, displayPath, } from "../validator.js";
 import { withWorkspace, workspaceRemovalFailure } from "../workspace.js";
 import { replayOutcome } from "./probe.js";
 import { runWithMutation } from "./mutation.js";
@@ -18,18 +18,6 @@ import { runWithMutation } from "./mutation.js";
 function prepareError(message, cause) {
     return new SafetyError("prepare", message, { cause });
 }
-// `[ -f ]` — regular file. `git show ad56569a4c161e7b122967442e2b026eeb6395f6:scripts/prepare:108::[ -f "$additional_validator` uses -f, and
-// tests/baseline/cli-parity.test.js's "CLI-ENV-MANIFEST-TEMPLATE-01 fallback
-// template bytes and non-file rejection" also covers the separately extracted
-// fallback check.
-async function regularFileExists(path) {
-    try {
-        return (await stat(path)).isFile();
-    }
-    catch {
-        return false;
-    }
-}
 // `[ -d ]` — `git show ad56569a4c161e7b122967442e2b026eeb6395f6:scripts/prepare:50::if [ -d`. A regular file named `.git` is what a git
 // worktree or `clone --separate-git-dir` leaves behind; `-e` would take the
 // fetch branch and let git follow its `gitdir:` pointer, where the shell took
@@ -112,7 +100,6 @@ async function gatherPrepare(ctx) {
         throw prepareError("adapter returned an invalid preparation staging leaf");
     }
     const pluginRoot = location.destinationRoot;
-    const additionalValidator = env.SUPERPOWERS_VALIDATOR || "";
     const executableValidator = env.SUPERPOWERS_VALIDATOR_EXECUTABLE || "";
     const tmpParent = dirname(pluginRoot);
     await owned(`cannot create directory: ${tmpParent}`, () => mkdir(tmpParent, { recursive: true }));
@@ -214,37 +201,7 @@ async function gatherPrepare(ctx) {
             return failed(prepared.outcome.result.compatibility.reason);
         }
         let validator = NO_VALIDATOR_OUTPUT;
-        if (additionalValidator.length > 0) {
-            // `git show ad56569a4c161e7b122967442e2b026eeb6395f6:scripts/prepare:108::[ -f "$additional_validator` — `[ -f ]`.
-            if (!(await regularFileExists(additionalValidator))) {
-                return {
-                    kind: "failed",
-                    outcomes,
-                    validator,
-                    message: `additional plugin validator not found: ${additionalValidator}`,
-                };
-            }
-            const ran = await runValidator(["python3", additionalValidator, candidate], UNBOUNDED_LEGACY, env, workspace);
-            if (ran.kind === "launchFailed") {
-                // PARITY, and it must stay a THROW. The legacy path rejects the workspace
-                // callback on a spawn failure; withWorkspace returns the callback error
-                // and the `outcomes` collected above are LOST. That loss is a recorded,
-                // deliberately unassigned defect. Returning a failed outcome here would
-                // replay those outcomes instead -- observably different control flow for
-                // CLI-ENV-VALIDATOR-01, which this PR is not authorized to change.
-                throw prepareError(`cannot execute additional plugin validator: ${additionalValidator}`, ran.cause);
-            }
-            validator = { stdout: ran.stdout.text, stderr: ran.stderr.text };
-            if (ran.kind !== "exited" || ran.code !== 0) {
-                return {
-                    kind: "failed",
-                    outcomes,
-                    validator,
-                    message: "additional plugin validation failed",
-                };
-            }
-        }
-        else if (executableValidator.length > 0) {
+        if (executableValidator.length > 0) {
             const resolution = await resolveValidator(executableValidator);
             const ran = await runValidator([executableValidator, candidate], BOUNDED_EXECUTABLE, env, workspace);
             // The disclosure lands BEFORE any early return, so a launch failure still
@@ -336,10 +293,7 @@ async function performPrepare(argv, ctx) {
     catch (cause) {
         // Hand-written messages, per AGENTS.md's reader-diagnostics rule.
         // Reachable here: prepareError(), from this module's owned() wrappers,
-        // its two manifest-version checks, asResolutionKind, and the
-        // additional-validator branch's own throw on a legacy-validator launch
-        // failure (its cause is the shared runner's (src/validator.ts) captured
-        // spawn error, which oneLine never reads -- it takes .message only);
+        // its two manifest-version checks, and asResolutionKind;
         // readManifest's three hookError messages
         // (`src/harnesses/codex/hooks.ts:113-138::readManifest`), pinned by
         // `tests/unit/harnesses/codex/hooks.test.ts:95::void test("readManifest diagnostics` as carrying no reader vocabulary or
@@ -382,7 +336,7 @@ async function performPrepare(argv, ctx) {
         // only, so it bounds how much of that text lands, not what it may
         // contain.
         //
-        // runAdapter's closing `throw cause` (src/harnesses/codex/adapter.ts) does NOT arrive
+        // runCodexOperation's closing `throw cause` (src/harnesses/codex/adapter.ts) does NOT arrive
         // here -- the call site catches it and converts it to a hand-written
         // message per AGENTS.md's reader-diagnostics rule.
         //
@@ -418,7 +372,7 @@ async function performPrepare(argv, ctx) {
         // completed before cleanup ran, so it is not being reported as unverified
         // -- but something did still go wrong, and AGENTS.md's fail-closed rule
         // extends to it. Mirrors
-        // `src/commands/install.ts:562-570::if (cleanupWarning`.
+        // `src/commands/install.ts:561-570::if (cleanupWarning`.
         ctx.stderr.write(`error: ${cleanupWarning}\n`);
         return 1;
     }

package/dist/commands/probe.js

@@ -7,7 +7,7 @@ export const PROBE_USAGE = "error: usage: superpowers-manager probe [--porcelain
 // response, so adapter messages reached the operator on their declared streams
 // in array order, and a controlled failure printed `error:` plus one `hint:`
 // per hint. DIAG-ADAPTER-01 retains that contract
-// (docs/baseline/protocol-disposition.md); dropping it here would be a
+// (docs/adapter-result-contract.md); dropping it here would be a
 // silent diagnostics regression, not a simplification.
 //
 // Interpolating error.message and each hint is the sanctioned form (AGENTS.md):
@@ -113,14 +113,14 @@ function validControl(value) {
                 candidate.probeEligibility.kind === "blocked" &&
                 candidate.mutationEligibility.kind === "blocked")));
 }
-// `runAdapter` reports a CONTROLLED failure by RETURN VALUE, not by throwing
+// `runCodexOperation` reports a CONTROLLED failure by RETURN VALUE, not by throwing
 // (`src/adapter-result.ts:32-35::export interface AdapterResult`). The shell got
 // fail-closed behaviour for free: spw_invoke_adapter returned 1 and
 // scripts/probe ran under `set -eu`.
 // Omitting the status check here would read a failed inspection as absent
 // evidence and report it as success.
 //
-// It does still THROW for a non-AdapterFailure cause (runAdapter's closing
+// It does still THROW for a non-AdapterFailure cause (runCodexOperation's closing
 // `throw cause`, src/harnesses/codex/adapter.ts). That is caught here rather than in runProbe's
 // outer catch, because the two need different diagnostics -- see spec §3.3a.
 //
@@ -287,8 +287,7 @@ export async function gatherProbe(ctx) {
 export async function runProbe(argv, ctx) {
     // `git show ad56569a4c161e7b122967442e2b026eeb6395f6:scripts/probe:42::porcelain` tested only `[ "${1:-}" = "--porcelain" ]`, so a typo'd
     // flag silently produced human output. Rejecting it is a deliberate
-    // narrowing, recorded as a port-only entry in
-    // tests/migration-inventory/probe.md.
+    // narrowing from the historical shell behavior.
     //
     // This guard is NOT the production path. src/cli.ts's parseArgs rejects the
     // same inputs first, before preflight, with the usage block the CLI's other
@@ -365,10 +364,9 @@ export async function runProbe(argv, ctx) {
         //
         // fetchExactCommit is deliberately NOT in this list, unlike prepare's
         // fetchExactCommit exception, which runPrepare's catch block documents.
-        // Its only callers are `src/upstream-cli.ts:83::await fetchExactCommit` and
-        // gatherPrepare's own call in src/commands/prepare.ts (git grep -n
-        // fetchExactCommit -- src/ is the check that keeps "only" true), so probe
-        // never reaches it and
+        // Its only remaining caller is gatherPrepare's call in
+        // src/commands/prepare.ts (git grep -n fetchExactCommit -- src/ is the
+        // check that keeps "only" true), so probe never reaches it and
         // its splice sites cannot appear on this stream. Do not add it back by
         // symmetry with prepare.
         //
@@ -376,7 +374,7 @@ export async function runProbe(argv, ctx) {
         // all. It (src/provenance.ts) delegates to readGeneratedCommitLenient,
         // which catches every failure and returns "".
         //
-        // A non-AdapterFailure re-thrown by runAdapter's closing `throw cause`
+        // A non-AdapterFailure re-thrown by runCodexOperation's closing `throw cause`
         // (src/harnesses/codex/adapter.ts) does NOT reach here: inspect() catches it and converts
         // it to a hand-written message per AGENTS.md's reader-diagnostics rule -- a
         // rethrown cause is exactly the failure src/harnesses/codex/adapter.ts declined to own, so

package/dist/commands/uninstall.js

@@ -125,7 +125,7 @@ async function gatherUninstall(ctx) {
     catch (cause) {
         // Reachable only for mkdtemp failure, with nothing collected yet: this
         // callback never throws -- every ctx.adapter throw is already caught
-        // inside invoke(), and presenceFlag/verifyUninstalledResources/
+        // inside invoke(), and presenceFlag/
         // reportLegacyState are pure (src/harnesses/codex/lifecycle.ts's header comment) -- so a
         // post-success cleanup failure is handled by onCleanupFailure above and
         // cannot reach here. Wrapping with `outcomes` anyway keeps the class
@@ -163,7 +163,7 @@ async function performUninstall(argv, ctx) {
         // blindly.
         //
         // A cause outside ctx.adapter's AdapterFailure guard
-        // (`src/harnesses/codex/adapter.ts:1081::async function runCodexOperation<T = JsonValue>(`) does NOT
+        // (`src/harnesses/codex/adapter.ts:829::async function runCodexOperation<T = JsonValue>(`) does NOT
         // reach here: invoke() catches it inside gatherUninstall and converts it
         // to a hand-written message carried as UninstallOutcome data, exactly as
         // src/commands/probe.ts's inspect() does for the same cause.

package/dist/effective-selection.js

@@ -34,9 +34,9 @@ export function selectionConfigDir(env) {
 export function selectionStatePath(env) {
     return `${selectionConfigDir(env)}/selection.json`;
 }
-// Composes exactly what `src/selection-state-cli.ts:39::const normalized`
-// composes. The shell wrote a normalized document to a mktemp file and read
-// five fields back with five python3 invocations; in-process this is one call.
+// Normalizes the record returned by readSelectionState directly. The shell
+// wrote a normalized document to a mktemp file and read five fields back with
+// five python3 invocations; in-process this is one call.
 export async function loadSavedSelection(env) {
     return normalizeSaved(await readSelectionState(selectionStatePath(env)));
 }