supercov 4.24.7 → 4.25.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "supercov",
-  "version": "4.24.7",
+  "version": "4.25.0",
   "description": "Coverage, security and code quality for coding agents",
   "keywords": [
     "coverage",
@@ -123,14 +123,14 @@
     "test:windows-tls": "node scripts/windows-tls-test.mjs"
   },
   "optionalDependencies": {
-    "@supercov/cli-darwin-arm64": "4.24.7",
-    "@supercov/cli-darwin-x64": "4.24.7",
-    "@supercov/cli-linux-arm64-gnu": "4.24.7",
-    "@supercov/cli-linux-arm64-musl": "4.24.7",
-    "@supercov/cli-linux-x64-gnu": "4.24.7",
-    "@supercov/cli-linux-x64-musl": "4.24.7",
-    "@supercov/cli-win32-arm64": "4.24.7",
-    "@supercov/cli-win32-x64": "4.24.7"
+    "@supercov/cli-darwin-arm64": "4.25.0",
+    "@supercov/cli-darwin-x64": "4.25.0",
+    "@supercov/cli-linux-arm64-gnu": "4.25.0",
+    "@supercov/cli-linux-arm64-musl": "4.25.0",
+    "@supercov/cli-linux-x64-gnu": "4.25.0",
+    "@supercov/cli-linux-x64-musl": "4.25.0",
+    "@supercov/cli-win32-arm64": "4.25.0",
+    "@supercov/cli-win32-x64": "4.25.0"
   },
   "peerDependencies": {
     "@playwright/test": ">=1.55.0",

package/runtime/javascript/atomic.mjs

@@ -1,6 +1,8 @@
-import { appendFileSync, chmodSync, existsSync, mkdirSync, openSync, closeSync, fsyncSync, renameSync, rmSync, statSync, writeFileSync, } from "node:fs";
+import fs, { appendFileSync, chmodSync, existsSync, mkdirSync, openSync, closeSync, fsyncSync, renameSync, rmSync, statSync, writeFileSync, } from "node:fs";
 import { randomUUID } from "node:crypto";
-import { dirname, resolve } from "node:path";
+import { syncBuiltinESMExports } from "node:module";
+import { threadId } from "node:worker_threads";
+import { dirname, resolve, sep } from "node:path";
 import { Buffer } from "node:buffer";
 
 // In a container Supercov's `docker` launcher mounts the run's directory
@@ -146,3 +148,41 @@ export function appendEvidenceRecord(directory, prefix, payload) {
     append(journal.path, line);
     journal.size += Buffer.byteLength(line);
 }
+
+// Playwright 1.59 writes each file it compiles into its cache in place and
+// reads it back unchecked: a process that read one while another wrote it
+// ran an empty module -- a config of no `default` failed at "Cannot add
+// property metadata, object is not extensible", a test file at "does not
+// provide an export named". The cache a run gives it starts empty and is
+// shared by every Playwright of the run, the containers a sealed suite execs
+// into among them, so every first compile raced; there each file is written
+// whole, or is not there yet and is compiled again. A file written beside the
+// cache's folders, not in one, is never taken for an old entry and removed.
+//
+// Playwright compiles in two threads: the config and CommonJS files in the
+// process's own, ES modules in the thread its loader hooks run in, which has
+// its own `fs` and does not run `--import`. Each calls this. The partial
+// file's name is unique to the write: a process ID repeats across containers
+// and both threads of one process count from zero.
+let cacheWritesWhole = false;
+export function writePlaywrightCacheWhole() {
+    const transformCache = process.env.PWTEST_CACHE_DIR;
+    if (!transformCache || cacheWritesWhole)
+        return;
+    cacheWritesWhole = true;
+    const cacheFolder = resolve(transformCache) + sep;
+    const writeFileSync = fs.writeFileSync;
+    fs.writeFileSync = function (file, ...rest) {
+        if (typeof file !== "string" || !resolve(file).startsWith(cacheFolder))
+            return writeFileSync.call(this, file, ...rest);
+        const partial = resolve(transformCache, `.writing-${process.pid}-${threadId}-${randomUUID()}`);
+        try {
+            writeFileSync.call(this, partial, ...rest);
+            fs.renameSync(partial, file);
+        }
+        finally {
+            fs.rmSync(partial, { force: true });
+        }
+    };
+    syncBuiltinESMExports();
+}

package/runtime/javascript/launchSupervisor.mjs

@@ -628,6 +628,10 @@ function inspectExports(value, depth = 0) {
     exportedValues.add(object);
     if (typeof value === "function")
         patchBuilder(value);
+    // What sits below this depth is never inspected: listing it cost every
+    // process a descriptor read per key of every export's members.
+    if (depth === 2)
+        return;
     for (const key of Reflect.ownKeys(object).slice(0, 200)) {
         if (key === "prototype" || key === "caller" || key === "callee")
             continue;
@@ -719,6 +723,12 @@ function injectChildEnvironment(method, args) {
     // every task aborted with ERR_MODULE_NOT_FOUND. launchSupervisor.js is
     // generated into the same .supercov directory as register.mjs.
     environment.NODE_OPTIONS = appendNodeImport(existingEnvironment?.NODE_OPTIONS ?? process.env.NODE_OPTIONS, new URL("./register.mjs", import.meta.url).href);
+    // The Playwright runner marked its children as not test workers; a process
+    // it forks from its worker entry is one (see register.mjs).
+    if (method === "fork" &&
+        environment.SUPERCOV_PLAYWRIGHT_WORKER !== undefined &&
+        /\/worker\/(?:workerProcessEntry|workerMain)\.js$/.test(String(args[0]).replaceAll("\\", "/")))
+        environment.SUPERCOV_PLAYWRIGHT_WORKER = "1";
     next[index] = { ...options, env: environment };
     if (typeof original === "function")
         next.splice(index + 1, 0, original);