supercov 4.24.7 → 4.24.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "supercov",
-  "version": "4.24.7",
+  "version": "4.24.8",
   "description": "Coverage, security and code quality for coding agents",
   "keywords": [
     "coverage",
@@ -123,14 +123,14 @@
     "test:windows-tls": "node scripts/windows-tls-test.mjs"
   },
   "optionalDependencies": {
-    "@supercov/cli-darwin-arm64": "4.24.7",
-    "@supercov/cli-darwin-x64": "4.24.7",
-    "@supercov/cli-linux-arm64-gnu": "4.24.7",
-    "@supercov/cli-linux-arm64-musl": "4.24.7",
-    "@supercov/cli-linux-x64-gnu": "4.24.7",
-    "@supercov/cli-linux-x64-musl": "4.24.7",
-    "@supercov/cli-win32-arm64": "4.24.7",
-    "@supercov/cli-win32-x64": "4.24.7"
+    "@supercov/cli-darwin-arm64": "4.24.8",
+    "@supercov/cli-darwin-x64": "4.24.8",
+    "@supercov/cli-linux-arm64-gnu": "4.24.8",
+    "@supercov/cli-linux-arm64-musl": "4.24.8",
+    "@supercov/cli-linux-x64-gnu": "4.24.8",
+    "@supercov/cli-linux-x64-musl": "4.24.8",
+    "@supercov/cli-win32-arm64": "4.24.8",
+    "@supercov/cli-win32-x64": "4.24.8"
   },
   "peerDependencies": {
     "@playwright/test": ">=1.55.0",

package/runtime/javascript/atomic.mjs

@@ -1,6 +1,8 @@
-import { appendFileSync, chmodSync, existsSync, mkdirSync, openSync, closeSync, fsyncSync, renameSync, rmSync, statSync, writeFileSync, } from "node:fs";
+import fs, { appendFileSync, chmodSync, existsSync, mkdirSync, openSync, closeSync, fsyncSync, renameSync, rmSync, statSync, writeFileSync, } from "node:fs";
 import { randomUUID } from "node:crypto";
-import { dirname, resolve } from "node:path";
+import { syncBuiltinESMExports } from "node:module";
+import { threadId } from "node:worker_threads";
+import { dirname, resolve, sep } from "node:path";
 import { Buffer } from "node:buffer";
 
 // In a container Supercov's `docker` launcher mounts the run's directory
@@ -146,3 +148,41 @@ export function appendEvidenceRecord(directory, prefix, payload) {
     append(journal.path, line);
     journal.size += Buffer.byteLength(line);
 }
+
+// Playwright 1.59 writes each file it compiles into its cache in place and
+// reads it back unchecked: a process that read one while another wrote it
+// ran an empty module -- a config of no `default` failed at "Cannot add
+// property metadata, object is not extensible", a test file at "does not
+// provide an export named". The cache a run gives it starts empty and is
+// shared by every Playwright of the run, the containers a sealed suite execs
+// into among them, so every first compile raced; there each file is written
+// whole, or is not there yet and is compiled again. A file written beside the
+// cache's folders, not in one, is never taken for an old entry and removed.
+//
+// Playwright compiles in two threads: the config and CommonJS files in the
+// process's own, ES modules in the thread its loader hooks run in, which has
+// its own `fs` and does not run `--import`. Each calls this. The partial
+// file's name is unique to the write: a process ID repeats across containers
+// and both threads of one process count from zero.
+let cacheWritesWhole = false;
+export function writePlaywrightCacheWhole() {
+    const transformCache = process.env.PWTEST_CACHE_DIR;
+    if (!transformCache || cacheWritesWhole)
+        return;
+    cacheWritesWhole = true;
+    const cacheFolder = resolve(transformCache) + sep;
+    const writeFileSync = fs.writeFileSync;
+    fs.writeFileSync = function (file, ...rest) {
+        if (typeof file !== "string" || !resolve(file).startsWith(cacheFolder))
+            return writeFileSync.call(this, file, ...rest);
+        const partial = resolve(transformCache, `.writing-${process.pid}-${threadId}-${randomUUID()}`);
+        try {
+            writeFileSync.call(this, partial, ...rest);
+            fs.renameSync(partial, file);
+        }
+        finally {
+            fs.rmSync(partial, { force: true });
+        }
+    };
+    syncBuiltinESMExports();
+}

package/runtime/javascript/register.mjs

@@ -13,28 +13,10 @@ import { fileURLToPath } from "node:url";
 import { installLaunchSupervisor, wrapImportedCapability } from "./launchSupervisor.mjs";
 import { __supercovBindCapabilityWrapper } from "./capability.mjs";
 import { adaptRunnerEntry, noteSkippedCoverageThresholds } from "./runnerEntry.mjs";
+import { writePlaywrightCacheWhole } from "./atomic.mjs";
 installLaunchSupervisor();
-// Playwright 1.59 writes each file it compiles into its cache in place and
-// reads it back unchecked: a process that read one while another wrote it
-// ran an empty module, and a config of no `default` failed at "Cannot add
-// property metadata, object is not extensible". The cache a run gives it
-// starts empty, so every run compiled; there each file is written whole, or
-// is not there yet and is compiled again. A file written beside the cache's
-// folders, not in one, is never taken for an old entry and removed.
-const transformCache = process.env.PWTEST_CACHE_DIR;
-if (transformCache) {
-    const cacheFolder = resolve(transformCache) + sep;
-    const writeFileSync = fs.writeFileSync;
-    let written = 0;
-    fs.writeFileSync = function (file, ...rest) {
-        if (typeof file !== "string" || !resolve(file).startsWith(cacheFolder))
-            return writeFileSync.call(this, file, ...rest);
-        const partial = resolve(transformCache, `.writing-${process.pid}-${written++}`);
-        writeFileSync.call(this, partial, ...rest);
-        fs.renameSync(partial, file);
-    };
-    syncBuiltinESMExports();
-}
+// Playwright's compile cache, written whole (atomic.mjs says why).
+writePlaywrightCacheWhole();
 // Instrumented sources import the browser-safe capability seam; bind the
 // real supervisor implementation before any user module evaluates.
 __supercovBindCapabilityWrapper(wrapImportedCapability);

package/runtime/javascript/resolve-loader.mjs

@@ -1,6 +1,10 @@
 import { appendFileSync, readFileSync } from "node:fs";
 import { dirname, resolve as resolvePath } from "node:path";
 import { fileURLToPath, pathToFileURL } from "node:url";
+import { writePlaywrightCacheWhole } from "./atomic.mjs";
+// This thread is where Playwright compiles ES modules and writes them into
+// its cache: written whole here too (atomic.mjs says why).
+writePlaywrightCacheWhole();
 const GENERATED_TARGET = "__SUPERCOV_PLAYWRIGHT_MODULE__";
 const TARGET = process.env.SUPERCOV_PLAYWRIGHT_MODULE ??
     (GENERATED_TARGET.startsWith("__") ? "@playwright/test" : GENERATED_TARGET);