sunnah 1.1.2 → 1.1.4

package/bin/index.js

@@ -12,6 +12,10 @@ const pkg = JSON.parse(
   fs.readFileSync(path.join(__dirname, "..", "package.json"), "utf8"),
 );
 
+// ── Windows compatibility ─────────────────────────────────────────────────────
+const isWin = process.platform === "win32";
+const NPM = isWin ? "npm.cmd" : "npm";
+
 // ── Colors ────────────────────────────────────────────────────────────────────
 const c = {
   reset: "\x1b[0m",
@@ -117,7 +121,6 @@ function animateInstall(pkgName) {
     let stageIdx = 0;
     let npmDone = false;
 
-    // Print initial bar on its own line
     process.stdout.write(drawBar(stages[0].label, 0) + "\n");
 
     const tick = () => {
@@ -128,14 +131,12 @@ function animateInstall(pkgName) {
       const step = (stage.end - prevEnd) / 22;
       percent = Math.min(percent + step, stage.end);
 
-      // Overwrite the bar line
       process.stdout.write("\r\x1b[K");
       process.stdout.write(drawBar(stage.label, percent));
 
       if (percent >= stage.end) {
         stageIdx++;
         if (stageIdx >= stages.length) {
-          // All visual stages done — wait for npm
           const poll = setInterval(() => {
             if (npmDone) {
               clearInterval(poll);
@@ -154,26 +155,48 @@ function animateInstall(pkgName) {
 
     setTimeout(tick, stages[0].ms);
 
-    // Actually run npm install -g
-    const proc = spawn("npm", ["install", "-g", pkgName], {
+    // spawn npm.cmd on Windows, npm on Unix
+    const proc = spawn(NPM, ["install", "-g", pkgName], {
       stdio: ["ignore", "pipe", "pipe"],
+      shell: isWin,
+    });
+
+    proc.on("error", () => {
+      // resolve anyway so the UI doesn't hang on spawn failure
+      npmDone = true;
     });
+
     proc.on("close", () => {
       npmDone = true;
     });
   });
 }
 
-// ── Check if a package is already installed globally ─────────────────────────
-function isInstalled(name) {
+// ── Check installed status ONCE at startup, cache forever ───────────────────
+// Calling npm on every render was freezing the terminal. We run one
+// 'npm list -g' at startup, parse the output, and never shell out again.
+function buildInstalledCache() {
+  const cache = new Map();
+  let out = "";
   try {
-    execSync(`npm list -g ${name} --depth=0 2>/dev/null`, { stdio: "ignore" });
-    return true;
-  } catch {
-    return false;
+    out = execSync(`${NPM} list -g --depth=0`, {
+      encoding: "utf8",
+      shell: isWin,
+      timeout: 8000,
+      stdio: ["ignore", "pipe", "ignore"],
+    });
+  } catch (e) {
+    out = e.stdout || "";
   }
+  for (const p of PACKAGES) {
+    cache.set(p.name, out.includes(p.name));
+  }
+  return cache;
 }
 
+let installedCache = new Map();
+const isInstalled = (name) => installedCache.get(name) ?? false;
+
 // ── Render the interactive list ───────────────────────────────────────────────
 const DIV_W = () => Math.min(W() - 2, 70);
 
@@ -315,6 +338,7 @@ async function main() {
 
   // --list
   if (flags.some((f) => f === "--list" || f === "-l")) {
+    installedCache = buildInstalledCache();
     const div = gray("─".repeat(60));
     console.log("");
     console.log(div);
@@ -342,6 +366,13 @@ async function main() {
     process.exit(1);
   }
 
+  // Build installed cache once — never call npm during rendering
+  process.stdout.write(
+    "\n  " + "\x1b[90m" + "Checking installed packages…" + "\x1b[0m",
+  );
+  installedCache = buildInstalledCache();
+  process.stdout.write("\r\x1b[K");
+
   readline.emitKeypressEvents(process.stdin);
   process.stdin.setRawMode(true);
   hideCursor();
@@ -443,6 +474,7 @@ async function main() {
         console.log("");
 
         await animateInstall(p.name);
+        installedCache.set(p.name, true); // update cache
 
         console.log(
           `  ${green("✓")} ${bold(green(p.label))} installed successfully`,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sunnah",
-  "version": "1.1.2",
+  "version": "1.1.4",
   "description": "Interactive CLI installer for Sunnah hadith npm packages",
   "bin": {
     "sunnah": "./bin/index.js"