summrise-agent 1.2.469 → 1.2.471

package/bin/summrise.js

@@ -206,6 +206,34 @@ function apiPost(pathname, body) {
         throw new Error("gateway bad response: " + out.slice(0, 120));
     }
 }
+// ── `sh()` IS `cmd.exe /d /s /c "<string>"`, AND DOUBLE QUOTES DO NOT STOP `%` ──
+//
+// Quoting a value stops cmd from reading `&`, `|`, `>` and `^` as OPERATORS (that is
+// the `psArgv` incident below). It does NOT stop PERCENT EXPANSION: cmd expands
+// `%NAME%` inside a quoted region exactly as it does outside one, so an interpolated
+// PATH that contains a `%` is still a variable reference rather than data. `%` is
+// legal in an NTFS name, and the install/data dirs here are chosen by the operator,
+// so this is reachable rather than theoretical.
+//
+// MEASURED on d1 (2026-09-25) through this exact `spawnSync(cmd, {shell:true})` path;
+// each arrow is the child's own stdout:
+//   `echo [%CMDCMDLINE%]`                 -> [C:\WINDOWS\system32\cmd.exe /d /s /c "echo [%CMDCMDLINE%]"]
+//   `echo ["C:\%ProgramFiles%\Summrise"]` -> ["C:\C:\Program Files\Summrise"]   (rewritten)
+//   shell  `powershell ... "Write-Output '%ProgramFiles%'"` -> C:\Program Files  (value lost)
+//   argv   `powershell ...  Write-Output '%ProgramFiles%'`  -> %ProgramFiles%    (verbatim)
+//
+// AND THE BATCH-FILE ESCAPE IS THE WRONG FIX: cmd's `%%` -> `%` rule belongs to batch
+// FILES. On a `/d /s /c` command line that same measurement prints `[100%%]` for
+// `echo [100%%]` — the doubling is NOT collapsed, so "escaping" a value with `%%`
+// would put a DOUBLED sign into the path, which is worse than the defect. What
+// remains is argv (no cmd in the path at all — `ps()` below hands PowerShell its
+// script directly) or a value that provably cannot contain `%`. A site that keeps a
+// cmd line anyway says which of those it is in a `cmd-% <kind>: <reason>` comment,
+// and test/cli.test.mjs fails any interpolating site that does not.
+//
+// `rmdir`, `taskkill`, `sc`, `schtasks` and `reg` cannot take argv (the first is a
+// cmd BUILTIN — there is no rmdir.exe), so a path handed to one of those must reach
+// cmd as a `%NAME%` reference rather than as text.
 function sh(cmd, opts = {}) {
     return (0, child_process_1.spawnSync)(cmd, { shell: true, stdio: "inherit", ...opts });
 }
@@ -1055,7 +1083,9 @@ function ensureElectron() {
     if (!zip)
         return null;
     fs.mkdirSync(dist, { recursive: true });
-    sh(`powershell -NoProfile -Command "Expand-Archive -Force -Path '${(0, exports.psq)(zip)}' -DestinationPath '${(0, exports.psq)(dist)}'"`);
+    // argv via `ps()`, not a cmd string: BOTH values are paths, and cmd expands `%NAME%`
+    // even inside the double quotes the old form carried (see `sh()`).
+    ps(`Expand-Archive -Force -Path '${(0, exports.psq)(zip)}' -DestinationPath '${(0, exports.psq)(dist)}'`);
     if (!fs.existsSync(path.join(dist, "electron.exe")))
         return null;
     try {
@@ -1736,15 +1766,20 @@ const commands = {
         sh("reg delete HKLM\\SYSTEM\\CurrentControlSet\\Services\\EventLog\\Application\\Cloudflared /f >NUL 2>&1");
         // 4. Stale update-busy marker (a crashed update would lock updates).
         const BUSY = path.join(process.env.ProgramData || "C:\\ProgramData", "SummriseAgent", "update-busy");
-        sh(`powershell -NoProfile -Command "Remove-Item -Force -ErrorAction SilentlyContinue '${(0, exports.psq)(BUSY)}'"`);
+        // `ps()` (argv) rather than `sh()`: BUSY is a PATH under %ProgramData%, and cmd
+        // expands `%NAME%` in a value even when the value is quoted (see `sh()`).
+        ps(`Remove-Item -Force -ErrorAction SilentlyContinue '${(0, exports.psq)(BUSY)}'`);
         // 5. Refresh the BOXED playwright bundle: delete the old tree first so a
         //    removed package/version never leaves stale files behind.
         //    round-163: kill the runner/bridge node processes FIRST — a running
         //    node.exe holds its image file locked, the Remove-Item/Expand-Archive
         //    pair silently skipped it, and the device was left with a playwright
         //    dir WITHOUT node.exe (bridge could never spawn again; observed d1).
-        sh(`powershell -NoProfile -Command "Get-CimInstance Win32_Process | Where-Object { $_.Name -eq 'node.exe' -and $_.CommandLine -like '*${(0, exports.psq)(DIR)}*playwright*' } | ForEach-Object { Stop-Process -Id $_.ProcessId -Force -ErrorAction SilentlyContinue }"`);
-        sh(`powershell -NoProfile -Command "Remove-Item -Recurse -Force -ErrorAction SilentlyContinue '${(0, exports.psq)(PW_DIR)}'"`);
+        // argv (`ps()`), because DIR is the install dir: an operator-chosen PATH, so cmd
+        // could find a `%NAME%` in it — and this script's `|` and `{ }` are only data
+        // because no shell parses the line at all.
+        ps(`Get-CimInstance Win32_Process | Where-Object { $_.Name -eq 'node.exe' -and $_.CommandLine -like '*${(0, exports.psq)(DIR)}*playwright*' } | ForEach-Object { Stop-Process -Id $_.ProcessId -Force -ErrorAction SilentlyContinue }`);
+        ps(`Remove-Item -Recurse -Force -ErrorAction SilentlyContinue '${(0, exports.psq)(PW_DIR)}'`);
         // 6. Legacy install dirs from retired installers (C:\summrise-agent /
         //    D:\summrise-agent). If the registry now points at a DIFFERENT dir and a
         //    legacy dir exists, it is a residue of the old channel — remove it
@@ -1753,6 +1788,9 @@ const commands = {
         for (const legacy of ["C:\\summrise-agent", "D:\\summrise-agent"]) {
             if (legacy !== DIR && fs.existsSync(legacy)) {
                 console.log("setup: removing legacy install dir", legacy);
+                // cmd-% literal: `legacy` is one of the two STRING LITERALS in the array on the
+                // `for` line above, so this value cannot carry a `%` — reviewed, left on the cmd
+                // line (the pin re-reads that array and checks it is literals all the way down).
                 sh(`powershell -NoProfile -Command "Remove-Item -Recurse -Force -ErrorAction SilentlyContinue '${(0, exports.psq)(legacy)}'"`);
             }
         }
@@ -1761,6 +1799,12 @@ const commands = {
         //    the retired orphans. Repair-only (helper checks link existence).
         //    Backslash-escape the .lnk Arguments double quotes for -Command.
         console.log("setup: reconciling desktop shortcut (retired-exe repair)...");
+        // cmd-% residual: THE ONE SITE THIS ROUND DID NOT FIX, and it is not "safe" — both
+        // values are paths (SCRIPTS_DIR, DESK_DIR). It is left because the same line depends
+        // on the cmd-level `\"` escaping above, which is its own defect (cmd does not unescape
+        // `\"`: the quoted region ends at the first `"` and the call works by accident), and
+        // argv-ing this call means deleting that `.replace()` in the same change. Named rather
+        // than silently exempted: the pin allows exactly ONE such site and fails a second.
         sh(`powershell -NoProfile -Command "${deskShortcutRepairPs((0, exports.psq)(SCRIPTS_DIR), (0, exports.psq)(DESK_DIR), "Write-Host").join("; ").replace(/"/g, '\\"')}"`);
         // C1: write the registry single source of truth (InstallDir; DataDir
         // defaults to %ProgramData%\Summrise). Everything else reads it back.
@@ -1825,13 +1869,15 @@ const commands = {
         if (PW_ZIP) {
             const pwDir = PW_DIR;
             fs.mkdirSync(pwDir, { recursive: true });
-            sh(`powershell -NoProfile -Command "Expand-Archive -Force -Path '${(0, exports.psq)(PW_ZIP)}' -DestinationPath '${(0, exports.psq)(COMPONENTS_DIR)}'"`);
+            // argv (`ps()`): PW_ZIP and COMPONENTS_DIR are paths, and cmd expands `%NAME%`
+            // inside quotes (see `sh()`).
+            ps(`Expand-Archive -Force -Path '${(0, exports.psq)(PW_ZIP)}' -DestinationPath '${(0, exports.psq)(COMPONENTS_DIR)}'`);
             // round-163: the whole point of the bundle is node.exe — VERIFY it
             // landed (a silently-missing copy killed the bridge forever on d1).
             // One retry, then fail loudly: a half-staged bundle is worse than none.
             if (!fs.existsSync(path.join(pwDir, "node.exe"))) {
                 console.log("setup: node.exe missing after expand -- retrying once");
-                sh(`powershell -NoProfile -Command "Expand-Archive -Force -Path '${(0, exports.psq)(PW_ZIP)}' -DestinationPath '${(0, exports.psq)(COMPONENTS_DIR)}'"`);
+                ps(`Expand-Archive -Force -Path '${(0, exports.psq)(PW_ZIP)}' -DestinationPath '${(0, exports.psq)(COMPONENTS_DIR)}'`);
             }
             // "node_modules verified" was in the message while only node.exe was checked —
             // and node_modules is where the entry point the agent actually runs lives, so a
@@ -1932,16 +1978,38 @@ const commands = {
                 // filter. `pre` is a PATH (npm's global prefix), so it is DOUBLE-QUOTED for the
                 // cmd layer: unquoted, a prefix like `C:\Program Files\nodejs` was split at its
                 // space and npm installed the CLI somewhere else while reporting success.
+                //
+                // QUOTING IS NOT ENOUGH FOR `pre`, because cmd expands `%NAME%` inside quotes —
+                // so the path does not appear in this command line at all. `%SUMMRISE_NPM_PREFIX%`
+                // does, and the value travels in the environment below. MEASURED on d1, through
+                // npm.cmd ITSELF (the target here is a `.cmd` BATCH shim, and a batch file re-parses
+                // its own arguments, so the /c line was not the only parser to clear):
+                //   `npm config get prefix --prefix "%SUMMRISE_PROBE2%"`          -> C:\%ProgramFiles%\Summrise
+                //   `npm config get prefix --prefix "C:\%ProgramFiles%\Summrise"` -> C:\C:\Program Files\Summrise
+                // The reference is expanded ONCE and what it produced is not re-scanned, so a prefix
+                // literally named `C:\%ProgramFiles%\Summrise` arrives as exactly that, while the raw
+                // interpolation of the same value does not; the quotes still hold an `&` inside one
+                // argument. The pin requires every `%NAME%` on a cmd line to be defined in the same
+                // call's `env`.
+                //
+                // cmd-% version: `${selfVer}` is package.json's own version — a semver, read from
+                // the file the tests read too, so it cannot carry a `%` (and it must be quoted for
+                // the cmd layer regardless, or npm reads an empty spec).
                 const inst = (0, child_process_1.spawnSync)("npm", [
                     "i",
                     "-g",
                     `"summrise-agent@${selfVer}"`,
                     "--prefix",
-                    `"${pre}"`,
+                    `"%SUMMRISE_NPM_PREFIX%"`,
                     "--registry=https://registry.npmjs.org/",
                     "--no-audit",
                     "--no-fund",
-                ], { encoding: "utf8", shell: true, timeout: 300000 });
+                ], {
+                    encoding: "utf8",
+                    shell: true,
+                    timeout: 300000,
+                    env: { ...process.env, SUMMRISE_NPM_PREFIX: pre },
+                });
                 console.log(inst.status === 0
                     ? `setup: ${selfVer} installed globally -- \`summrise status\` works from any shell`
                     : `setup: WARNING -- could not install the CLI globally; run: npm i -g summrise-agent@${selfVer}`);
@@ -1967,13 +2035,16 @@ const commands = {
             // regardless". Worse, the `catch` below could not fire for this — `sh()` RETURNS, it does not
             // throw — so the only thing it ever caught was `writeFileSync`.
             //
-            // ONE CALL, and its status is READ. DOUBLE quotes in the command: a cmd-layer argument, because the
-            // single-quoted version this shipped with reached PowerShell with the quotes included and died on
-            // the device with "unsupported path format" for a path that was perfectly valid.
+            // ONE CALL, and its status is READ. The path is an ARGV ELEMENT now, and that is the fix for
+            // both quoting attempts that came before it: the single-quoted version this shipped with
+            // reached PowerShell with the quotes INCLUDED and died on the device with "unsupported path
+            // format" for a path that was perfectly valid, and the double-quoted version that replaced it
+            // still handed a PATH to cmd — where `%NAME%` expands inside the quotes (see `sh()`). argv
+            // needs no quotes at all: PowerShell receives the path verbatim.
             //
             // A WARNING, NOT FATAL, unlike the agent task: headless installs have no SummriseDesktop, and the
             // registration script itself exits quietly when electron is already alive.
-            const reg302 = sh(`powershell -NoProfile -ExecutionPolicy Bypass -File "${reg}"`, { stdio: "pipe" });
+            const reg302 = (0, child_process_1.spawnSync)("powershell", ["-NoProfile", "-ExecutionPolicy", "Bypass", "-File", reg], { stdio: "pipe" });
             if (reg302 && reg302.status === 0) {
                 console.log("setup: SummriseDesktop registered (logon + a 5-minute watchdog) and started");
             }
@@ -2224,11 +2295,14 @@ const commands = {
         // The register script is WRITTEN here (a machine that never ran setup still gets a working
         // task, from the same builder setup uses) but NOT run: desktop-start.ps1 runs it only when
         // the task is genuinely missing.
-        // ONE STRING, NOT an args array. With `shell: true` Node concatenates the arguments and warns
-        // about it (DEP0190: "the arguments are not escaped, only concatenated") — a warning the
-        // operator saw on the device the first time this command worked. The path is double-quoted,
-        // which is what -File accepts at the cmd layer; nothing here needs an argument list.
-        const r = (0, child_process_1.spawnSync)(`powershell -NoProfile -ExecutionPolicy Bypass -File "${start}"`, { encoding: "utf8", shell: true });
+        // ARGV, NO SHELL — the path is the reason. `shell: true` JOINS an args array into one cmd.exe
+        // line and warns about it (DEP0190: "the arguments are not escaped, only concatenated" — the
+        // warning the operator saw on the device the first time this command worked), and that line is
+        // then re-parsed a second time: `%NAME%` expands even inside the double quotes the old
+        // one-string form carried (see `sh()`), and this path lives under the install dir, which the
+        // operator chooses. Passed as argv, the path reaches PowerShell VERBATIM as one element and
+        // DEP0190 goes with the shell instead of being worked around.
+        const r = (0, child_process_1.spawnSync)("powershell", ["-NoProfile", "-ExecutionPolicy", "Bypass", "-File", start], { encoding: "utf8" });
         const out = String(r.stdout || "").trim();
         if (out.endsWith("already-running")) {
             console.log("desktop: the Summrise shell is ALREADY RUNNING (look for the window, or the tray icon)");
@@ -3123,8 +3197,15 @@ const commands = {
         sh("sc stop Cloudflared 2>NUL");
         sh("sc delete Cloudflared 2>NUL");
         sh("reg delete HKLM\\SYSTEM\\CurrentControlSet\\Services\\EventLog\\Application\\Cloudflared /f 2>NUL");
-        // program dir + registry
-        sh(`rmdir /s /q "${DIR}"`);
+        // program dir + registry.
+        //
+        // NOT `rmdir /s /q "<DIR>"`: `rmdir` is a cmd BUILTIN — there is no rmdir.exe to hand argv
+        // to — so a PATH given to it is text that cmd re-parses, and `%NAME%` expands even inside
+        // those quotes (see `sh()`). DIR is the install dir, i.e. operator-chosen. `ps()` runs the
+        // same deletion (Remove-Item -Recurse -Force, the form the legacy loop below already uses
+        // because it also copes with locked/read-only files) with the path as argv. The VERIFY below
+        // is what decides, which is why silence on failure is acceptable here.
+        ps(`Remove-Item -LiteralPath '${(0, exports.psq)(DIR)}' -Recurse -Force -ErrorAction SilentlyContinue`);
         // Legacy install dirs from retired installers (C:\summrise-agent /
         // D:\summrise-agent) — uninstall must leave NO residue anywhere.
         for (const legacy of ["C:\\summrise-agent", "D:\\summrise-agent"]) {
@@ -3132,6 +3213,9 @@ const commands = {
                 console.log("uninstall: removing legacy install dir", legacy);
                 // PowerShell Remove-Item -Recurse -Force handles locked/read-only
                 // files better than rmdir; retry once after a short wait.
+                //
+                // cmd-% literal: `legacy` is one of the two STRING LITERALS in the array on the `for`
+                // line above, so this value cannot carry a `%` — the pin re-reads that array.
                 sh(`powershell -NoProfile -Command "Remove-Item -LiteralPath '${(0, exports.psq)(legacy)}' -Recurse -Force -ErrorAction SilentlyContinue; Start-Sleep -Milliseconds 500; Remove-Item -LiteralPath '${(0, exports.psq)(legacy)}' -Recurse -Force -ErrorAction SilentlyContinue"`);
                 if (fs.existsSync(legacy)) {
                     console.log("uninstall: WARNING -- legacy dir still present:", legacy);
@@ -3167,8 +3251,10 @@ const commands = {
             console.log("uninstall: program dir + registry removed");
         }
         if (purge) {
-            sh(`rmdir /s /q "${DATA}"`);
-            // A failed rmdir used to print "data dir purged" anyway.
+            // Same as the program dir above: `rmdir` is a builtin, so its path would be text cmd
+            // re-parses (`%NAME%` expands inside quotes), and DATA is a path the operator can remap.
+            ps(`Remove-Item -LiteralPath '${(0, exports.psq)(DATA)}' -Recurse -Force -ErrorAction SilentlyContinue`);
+            // A failed removal used to print "data dir purged" anyway.
             if (fs.existsSync(DATA)) {
                 console.error(`uninstall: FAILED to purge the data dir -- ${DATA} is still present`);
                 process.exitCode = 1;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "summrise-agent",
-  "version": "1.2.469",
+  "version": "1.2.471",
   "description": "Summrise Agent — Windows device MCP server (terminal/SSH/serial) + panel. Self-hosted npm distribution.",
   "//build": "唯一构建路径：在本目录执行 npm run build。它是自包含的：经 npm exec 按需拉取 typescript@5，无需预装任何 node_modules（干净检出可跑；旧脚本引用 ../summrise-desktop-electron/node_modules/.bin/tsc，干净检出必 ENOENT）。必须用 npm exec --package … -- tsc 的形式：npx 会吃掉传给 tsc 的 -p/--outDir 等参数（round-435：npx 写法从未真正跑通过）。先编 electron TS（--noCheck 纯 emit，与 release.yml 一致）同步两处 src/*.js，再编 src/summrise.ts 到 bin/summrise.js 并校验 round-298 标记（弱 oracle，只证某次构建发生，新鲜性由 publish-release.sh 的 tsc 重编 + cmp 门保证）。",
   "bin": {