summit-registration-lite 7.0.6 → 7.0.8

package/dist/components/registration-modal.js

@@ -1487,10 +1487,12 @@ const usePromoCode = ({
   //
   // Note on concurrency: the two call sites (early-auto-apply effect and
   // onTicketSelected's auto-apply branch) operate on disjoint states by design
-  // (the effect requires `!hasTickets`, the branch requires a selected ticket),
-  // so a true concurrent invocation is unreachable in practice. If a future
-  // change makes that overlap possible, gate this body with a ref-tracked
-  // in-flight flag rather than `applyingCode` (which is captured stale here).
+  // (the effect requires `!isApplied`, the branch fires only on a user-driven
+  // ticket selection — by which point isApplied is already true if early
+  // auto-apply ran), so a true concurrent invocation is unreachable in
+  // practice. If a future change makes that overlap possible, gate this body
+  // with a ref-tracked in-flight flag rather than `applyingCode` (which is
+  // captured stale here).
 
   const tryAutoApply = (0,external_react_.useCallback)(async ticket => {
     setIsAutoApplied(true);
@@ -1518,8 +1520,14 @@ const usePromoCode = ({
     }
   }, [discoveredPromoCode, applyPromoCode, onRevalidate, handleValidationError]);
   const onTicketSelected = (0,external_react_.useCallback)(async ticket => {
-    const qualifies = discoveredPromoCode && isCodeValidForTicket(ticket);
-    setSuggestionActive(qualifies);
+    const qualifies = discoveredPromoCode && isCodeValidForTicket(ticket); // Only turn the suggestion on when the current ticket qualifies; don't
+    // turn it off otherwise. With auto-switch-on-Apply, the suggestion is
+    // still useful when the user has a non-qualifying ticket selected
+    // (Apply will switch them to the qualifying one). The status logic
+    // hides the banner whenever a code is applied, so leaving this true
+    // doesn't surface a stale suggestion.
+
+    if (qualifies) setSuggestionActive(true);
     setSuggestionDismissed(false);
     setManualError(null); // Manual (non-discovered) code is applied: re-validate for new ticket
 
@@ -1528,17 +1536,15 @@ const usePromoCode = ({
       return;
     }
 
-    if (!discoveredPromoCode) return; // Discovered code is currently applied
+    if (!discoveredPromoCode) return; // Discovered code is currently applied — re-validate against the new
+    // ticket. The backend rejects if the code doesn't apply, surfacing
+    // INVALID to the user (they can then choose to Remove or pick another
+    // ticket). Previously we silently removed the code on a non-qualifying
+    // pick, which hid the rejection.
 
     if (isDiscoveredCode) {
-      if (!qualifies) {
-        setIsAutoApplied(false);
-        removePromoCode();
-      } else {
-        const valid = await onRevalidate(ticket, 1);
-        if (!valid) setIsAutoApplied(false);
-      }
-
+      const valid = await onRevalidate(ticket, 1);
+      if (!valid) setIsAutoApplied(false);
       return;
     } // No code applied, ticket qualifies, auto-apply configured, single code only
 
@@ -1546,19 +1552,20 @@ const usePromoCode = ({
     if (!isApplied && qualifies && discoveredPromoCode.auto_apply && !userRemovedAutoApply && discoveredPromoCodes.length === 1) {
       await tryAutoApply(ticket);
     }
-  }, [discoveredPromoCode, isApplied, isDiscoveredCode, userRemovedAutoApply, discoveredPromoCodes, isCodeValidForTicket, removePromoCode, onRevalidate, tryAutoApply]); // Early auto-apply: when no tickets are available and a single auto_apply code
-  // was discovered, apply it so the API returns WithPromoCode ticket types.
-  // On failure, mark as removed to prevent re-fire loops.
+  }, [discoveredPromoCode, isApplied, isDiscoveredCode, userRemovedAutoApply, discoveredPromoCodes, isCodeValidForTicket, onRevalidate, tryAutoApply]); // Early auto-apply on load (per SDS: silently apply a discovered single
+  // auto_apply code when no code is currently applied). Wait on
+  // ticketDataLoaded only to avoid racing the initial fetch. On failure,
+  // mark as removed to prevent re-fire loops.
 
   (0,external_react_.useEffect)(() => {
     if (userRemovedAutoApply || isApplied) return;
-    if (!ticketDataLoaded || hasTickets) return;
+    if (!ticketDataLoaded) return;
     if (!discoveredPromoCode?.auto_apply) return;
     if (discoveredPromoCodes.length !== 1) return;
     tryAutoApply(null).then(success => {
       if (!success) setUserRemovedAutoApply(true);
     });
-  }, [userRemovedAutoApply, ticketDataLoaded, hasTickets, discoveredPromoCode, discoveredPromoCodes, isApplied, tryAutoApply]);
+  }, [userRemovedAutoApply, ticketDataLoaded, discoveredPromoCode, discoveredPromoCodes, isApplied, tryAutoApply]);
   const onApply = (0,external_react_.useCallback)(async (code, ticket, quantity) => {
     setManualError(null);
     setApplyingCode(true);
@@ -1597,11 +1604,20 @@ const usePromoCode = ({
       status,
       isReady,
       validationError,
+      // True while applyPromoCode is in flight (covers the window where
+      // promoCode is set but the refreshed ticketTypes haven't landed
+      // yet). Callers should defer ticket-list-driven side effects
+      // until this clears to avoid acting on a stale list.
+      applyingCode,
       // Applied code origin
       isDiscoveredCode,
       isAutoApplied,
       // Discovery / suggestion
       suggestedCode,
+      // Predicate the caller can use to find a ticket the discovered
+      // promo applies to (auto-selection after auto-apply, ticket
+      // switching on Apply).
+      isCodeValidForTicket,
       // Quantity caps from the active discovered code
       maxQuantityFromPromo,
       perAccountLimit
@@ -2892,6 +2908,7 @@ const PromoCodeInput = ({
   promoCode,
   suggestedCode,
   isAutoApplied,
+  isCurrentTicketQualifying,
   onApply,
   onRemove,
   onInputChange,
@@ -2924,12 +2941,16 @@ const PromoCodeInput = ({
         return undefined;
 
       case constants.PROMO_STATUS.SUGGESTED:
-        return external_i18n_react_default().translate('promo_code.suggestion_label');
+        // The suggestion banner stays visible across non-qualifying ticket
+        // picks (so the "Apply will switch you" affordance persists). Swap
+        // the copy so it stays accurate: tell the user the code applies to
+        // a different ticket and that Apply will switch them.
+        return isCurrentTicketQualifying ? external_i18n_react_default().translate('promo_code.suggestion_label') : external_i18n_react_default().translate('promo_code.suggestion_label_switch');
 
       default:
         return undefined;
     }
-  }, [promoStatus, isAutoApplied]);
+  }, [promoStatus, isAutoApplied, isCurrentTicketQualifying]);
   const canApply = !isLocked && !!inputValue;
 
   const handleInputChange = value => {
@@ -3130,9 +3151,19 @@ const TicketTypeComponent = ({
     // When promo code changes, the API returns updated ticket types with/without discount.
     // Sync the selected ticket with the refreshed data.
     if (!ticket) {
-      // Auto-select if only one ticket type available after promo code applied
-      if (promoCode && originalTicketTypes.length === 1) {
-        handleTicketChange(originalTicketTypes[0]);
+      // Auto-select after a promo code is applied. Defer while applyingCode is
+      // true: the reducer sets promoCode synchronously before the refreshed
+      // ticketTypes land, so acting now would auto-select from a stale list.
+      // Once apply settles, prefer the first ticket the discovered code applies
+      // to (so per-ticket validation succeeds); fall back to the only ticket
+      // when there's a single option.
+      // Scan allowedTicketTypes (date-filtered) so we never auto-select
+      // a ticket the user couldn't have picked themselves from the dropdown.
+      if (promoCode && !promoState.applyingCode && allowedTicketTypes.length > 0) {
+        const isValid = promoState.isCodeValidForTicket;
+        const qualifying = isValid && allowedTicketTypes.find(isValid);
+        const toSelect = qualifying || (allowedTicketTypes.length === 1 ? allowedTicketTypes[0] : null);
+        if (toSelect) handleTicketChange(toSelect);
       }
 
       return;
@@ -3149,7 +3180,7 @@ const TicketTypeComponent = ({
       setTicket(null);
       setQuantity(minQuantity);
     }
-  }, [promoCode, originalTicketTypes]);
+  }, [promoCode, promoState.applyingCode, allowedTicketTypes, originalTicketTypes]);
   const showTicketSelector = allowedTicketTypes.length > 0;
   const isPrePaidReservation = (0,external_react_.useMemo)(() => reservation ? (0,utils/* isPrePaidOrder */.xm)(reservation) : false, [reservation]); // check if reassignment is allowed by both promo code AND ticket type
 
@@ -3200,7 +3231,24 @@ const TicketTypeComponent = ({
   const decrementQuantity = () => setQuantity(quantity - 1);
 
   const handleApplyPromoCode = async code => {
-    await promoActions.onApply(code, ticket, quantity);
+    // If the user applies the suggested/discovered code while a
+    // non-qualifying ticket is selected, deselect first. The qualifying
+    // ticket may not yet be in originalTicketTypes (it's revealed by the
+    // code-filtered refetch inside applyPromoCode). After apply resolves,
+    // the post-apply effect picks the qualifying ticket from the
+    // refreshed list. Manual non-discovered codes still validate against
+    // the current ticket — backend decides.
+    const isDiscovered = code === promoState.suggestedCode;
+    const isValid = promoState.isCodeValidForTicket;
+    let targetTicket = ticket;
+
+    if (isDiscovered && isValid && ticket && !isValid(ticket)) {
+      setTicket(null);
+      setQuantity(minQuantity);
+      targetTicket = null;
+    }
+
+    await promoActions.onApply(code, targetTicket, quantity);
   };
 
   return /*#__PURE__*/external_react_default().createElement("div", {
@@ -3310,6 +3358,7 @@ const TicketTypeComponent = ({
     promoCode: promoCode,
     suggestedCode: promoState.suggestedCode,
     isAutoApplied: promoState.isAutoApplied,
+    isCurrentTicketQualifying: promoState.isCodeValidForTicket(ticket),
     onInputChange: promoActions.onInputChange,
     onApply: handleApplyPromoCode,
     onRemove: promoActions.onRemove,
@@ -3915,14 +3964,18 @@ const RegistrationFormContent = _ref => {
   } = promo; // Error rendered in the promo notice slot — form-level warning layered on top
   // of the hook's own validation error (API rejection or status-derived).
 
-  const ticketStepError = unappliedCodeWarning ?? promoState.validationError; // Clear the unapplied-code warning once the condition that would have raised it
-  // no longer holds (input cleared, code applied, or a suggestion is showing).
+  const ticketStepError = unappliedCodeWarning ?? promoState.validationError; // Clear the unapplied-code warning once it's no longer the right message to show.
+  // The hook's own validationError takes precedence: if the user actually clicked
+  // Apply and the backend rejected, surfacing "you didn't apply" would mask the
+  // specific rejection reason. Depending on validationError (rather than on
+  // applyPromoCode's brief Redux promoCode=truthy window) keeps the cleanup
+  // robust against refactors of the apply action's sequencing.
 
   (0,external_react_.useEffect)(() => {
-    if (!formValues?.promoCode || promoCode || promoState.status === constants.PROMO_STATUS.SUGGESTED) {
+    if (!formValues?.promoCode || promoCode || promoState.status === constants.PROMO_STATUS.SUGGESTED || promoState.validationError) {
       setUnappliedCodeWarning(null);
     }
-  }, [formValues?.promoCode, promoCode, promoState.status]);
+  }, [formValues?.promoCode, promoCode, promoState.status, promoState.validationError]);
   const [ref, {
     height
   }] = (0,external_react_use_namespaceObject.useMeasure)();
@@ -5161,7 +5214,7 @@ module.exports = require("sweetalert2");
 /***/ ((module) => {
 
 "use strict";
-module.exports = JSON.parse('{"purchase_complete_step":{"title":" Your order is complete","initial_order_complete_1st_paragraph_label":"A ticket has been assigned to {attendee}. To complete {adv} additional ticket details, please click the \\"{button}\\" button.","initial_order_complete_button":"Finish Now","order_complete_1st_paragraph_label":"You may visit the \\"My Orders/Tickets\\" tab in the top right-hand corner of the navigation bar to\\n assign/reassign tickets or to complete any required ticket details.","order_complete_button":"View My Orders/Tickets","access_event_button":"Access Event Now","initial_order_footer_label":"If you wish to transfer your assigned ticket, close this window and visit the \\"My Orders/Tickets\\" tab in the top navigation bar. ","footer_assistance_text":"For further assistance, please email <a href=\\"mailto:{supportEmail}\\">{supportEmail}</a>","event_will_start_text":"The event will start on {date} at {time} {time_zone_label}"},"ticket_type":{"ticket_quantity_tooltip":"Only one ticket type can be selected per order. To purchase multiple ticket types, please place a separate registration order for each ticket type.","no_tickets_available":"There are no tickets currently available for purchase. If you have a promo code, enter it below to check for eligible tickets.","max_per_order_one":"This ticket type is limited to 1 per order.","max_per_order_other":"This ticket type is limited to {limit} per order."},"promo_code":{"promo_code_tooltip":"Only one promo code can be used per order; the code will be applied to all tickets in this order. If you\'d like to use multiple promo codes, please place a separate registration order for each promo code.","default_label":"Do you have a promo code?","auto_applied_label":"Following promo code was automatically applied:","applied_label":"Applied promo code:","applying_label":"Applying promo code...","suggestion_label":"You qualify for the following promo code:","per_account_limit_one":"Promo code limits {limit} ticket per account.","per_account_limit_other":"Promo code limits {limit} tickets per account.","non_transferable":"This ticket will be automatically assigned to you and cannot be reassigned.","unapplied_code_warning":"You entered a promo code but it hasn\'t been applied. Make sure to click the \'Apply\' button or remove it before continuing.","invalid_code":"Promo code entered is not valid.","validation_error":"An error occurred while validating the promo code."}}');
+module.exports = JSON.parse('{"purchase_complete_step":{"title":" Your order is complete","initial_order_complete_1st_paragraph_label":"A ticket has been assigned to {attendee}. To complete {adv} additional ticket details, please click the \\"{button}\\" button.","initial_order_complete_button":"Finish Now","order_complete_1st_paragraph_label":"You may visit the \\"My Orders/Tickets\\" tab in the top right-hand corner of the navigation bar to\\n assign/reassign tickets or to complete any required ticket details.","order_complete_button":"View My Orders/Tickets","access_event_button":"Access Event Now","initial_order_footer_label":"If you wish to transfer your assigned ticket, close this window and visit the \\"My Orders/Tickets\\" tab in the top navigation bar. ","footer_assistance_text":"For further assistance, please email <a href=\\"mailto:{supportEmail}\\">{supportEmail}</a>","event_will_start_text":"The event will start on {date} at {time} {time_zone_label}"},"ticket_type":{"ticket_quantity_tooltip":"Only one ticket type can be selected per order. To purchase multiple ticket types, please place a separate registration order for each ticket type.","no_tickets_available":"There are no tickets currently available for purchase. If you have a promo code, enter it below to check for eligible tickets.","max_per_order_one":"This ticket type is limited to 1 per order.","max_per_order_other":"This ticket type is limited to {limit} per order."},"promo_code":{"promo_code_tooltip":"Only one promo code can be used per order; the code will be applied to all tickets in this order. If you\'d like to use multiple promo codes, please place a separate registration order for each promo code.","default_label":"Do you have a promo code?","auto_applied_label":"Following promo code was automatically applied:","applied_label":"Applied promo code:","applying_label":"Applying promo code...","suggestion_label":"You qualify for the following promo code:","suggestion_label_switch":"Following promo code applies to a different ticket. Apply to switch.","per_account_limit_one":"Promo code limits {limit} ticket per account.","per_account_limit_other":"Promo code limits {limit} tickets per account.","non_transferable":"This ticket will be automatically assigned to you and cannot be reassigned.","unapplied_code_warning":"You entered a promo code but it hasn\'t been applied. Make sure to click the \'Apply\' button or remove it before continuing.","invalid_code":"Promo code entered is not valid.","validation_error":"An error occurred while validating the promo code."}}');
 
 /***/ })