substrate-ai 0.2.25 → 0.2.26

package/dist/cli/index.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-import { DatabaseWrapper, SUBSTRATE_OWNED_SETTINGS_KEYS, VALID_PHASES, buildPipelineStatusOutput, createContextCompiler, createDispatcher, createImplementationOrchestrator, createPackLoader, createPhaseOrchestrator, createStopAfterGate, findPackageRoot, formatOutput, formatPhaseCompletionSummary, formatPipelineStatusHuman, formatPipelineSummary, formatTokenTelemetry, getAllDescendantPids, getAutoHealthData, getSubstrateDefaultSettings, registerHealthCommand, registerRunCommand, resolveBmadMethodSrcPath, resolveBmadMethodVersion, resolveMainRepoRoot, runAnalysisPhase, runMigrations, runPlanningPhase, runSolutioningPhase, validateStopAfterFromConflict } from "../run-CKvf6LgL.js";
+import { DatabaseWrapper, SUBSTRATE_OWNED_SETTINGS_KEYS, VALID_PHASES, buildPipelineStatusOutput, createContextCompiler, createDispatcher, createImplementationOrchestrator, createPackLoader, createPhaseOrchestrator, createStopAfterGate, findPackageRoot, formatOutput, formatPhaseCompletionSummary, formatPipelineStatusHuman, formatPipelineSummary, formatTokenTelemetry, getAllDescendantPids, getAutoHealthData, getSubstrateDefaultSettings, registerHealthCommand, registerRunCommand, resolveBmadMethodSrcPath, resolveBmadMethodVersion, resolveMainRepoRoot, runAnalysisPhase, runMigrations, runPlanningPhase, runSolutioningPhase, validateStopAfterFromConflict } from "../run-CEtHPG4I.js";
 import { createLogger, deepMask } from "../logger-D2fS2ccL.js";
 import { AdapterRegistry, ConfigError, ConfigIncompatibleFormatError } from "../errors-CswS7Mzg.js";
 import { CURRENT_CONFIG_FORMAT_VERSION, CURRENT_TASK_GRAPH_VERSION, PartialSubstrateConfigSchema, SUPPORTED_CONFIG_FORMAT_VERSIONS, SubstrateConfigSchema, defaultConfigMigrator } from "../version-manager-impl-CZ6KF1Ds.js";
@@ -2842,7 +2842,7 @@ async function runSupervisorAction(options, deps = {}) {
 								const expDb = expDbWrapper.db;
 								const { runRunAction: runPipeline } = await import(
 									/* @vite-ignore */
-									"../run-bigUnNya.js"
+									"../run-BXKRGSeL.js"
 );
 								const runStoryFn = async (opts) => {
 									const exitCode = await runPipeline({

package/dist/index.d.ts

@@ -172,6 +172,44 @@ interface StoryEscalationEvent {
   /** Issues list from the final review (may be empty) */
   issues: EscalationIssue[];
 }
+/**
+ * Emitted when a dev-story agent reported COMPLETE but git diff shows no
+ * file changes in the working tree (phantom completion — Story 24-1).
+ */
+interface StoryZeroDiffEscalationEvent {
+  type: 'story:zero-diff-escalation';
+  /** ISO-8601 timestamp generated at emit time */
+  ts: string;
+  /** Story key (e.g., "10-1") */
+  storyKey: string;
+  /** Always "zero-diff-on-complete" */
+  reason: string;
+}
+/**
+ * Emitted when the build verification command exits with a non-zero code
+ * or times out, before code-review is dispatched (Story 24-2).
+ */
+interface StoryBuildVerificationFailedEvent {
+  type: 'story:build-verification-failed';
+  /** ISO-8601 timestamp generated at emit time */
+  ts: string;
+  /** Story key (e.g., "24-2") */
+  storyKey: string;
+  /** Exit code from the build command (-1 for timeout) */
+  exitCode: number;
+  /** Combined stdout+stderr output, truncated to 2000 chars */
+  output: string;
+}
+/**
+ * Emitted when the build verification command exits with code 0 (Story 24-2).
+ */
+interface StoryBuildVerificationPassedEvent {
+  type: 'story:build-verification-passed';
+  /** ISO-8601 timestamp generated at emit time */
+  ts: string;
+  /** Story key (e.g., "24-2") */
+  storyKey: string;
+}
 /**
  * Emitted for non-fatal warnings during pipeline execution
  * (e.g., token ceiling truncation, partial batch failures).
@@ -432,7 +470,7 @@ interface SupervisorExperimentErrorEvent {
  * }
  * ```
  */
-type PipelineEvent = PipelineStartEvent | PipelineCompleteEvent | StoryPhaseEvent | StoryDoneEvent | StoryEscalationEvent | StoryWarnEvent | StoryLogEvent | PipelineHeartbeatEvent | StoryStallEvent | SupervisorPollEvent | SupervisorKillEvent | SupervisorRestartEvent | SupervisorAbortEvent | SupervisorSummaryEvent | SupervisorAnalysisCompleteEvent | SupervisorAnalysisErrorEvent | SupervisorExperimentStartEvent | SupervisorExperimentSkipEvent | SupervisorExperimentRecommendationsEvent | SupervisorExperimentCompleteEvent | SupervisorExperimentErrorEvent; //#endregion
+type PipelineEvent = PipelineStartEvent | PipelineCompleteEvent | StoryPhaseEvent | StoryDoneEvent | StoryEscalationEvent | StoryWarnEvent | StoryLogEvent | PipelineHeartbeatEvent | StoryStallEvent | StoryZeroDiffEscalationEvent | StoryBuildVerificationFailedEvent | StoryBuildVerificationPassedEvent | SupervisorPollEvent | SupervisorKillEvent | SupervisorRestartEvent | SupervisorAbortEvent | SupervisorSummaryEvent | SupervisorAnalysisCompleteEvent | SupervisorAnalysisErrorEvent | SupervisorExperimentStartEvent | SupervisorExperimentSkipEvent | SupervisorExperimentRecommendationsEvent | SupervisorExperimentCompleteEvent | SupervisorExperimentErrorEvent; //#endregion
 //#region src/core/errors.d.ts
 
 /**
@@ -1018,6 +1056,11 @@ interface OrchestratorEvents {
     storyKey: string;
     msg: string;
   };
+  /** Zero-diff detection gate: dev-story reported COMPLETE but git diff is empty (Story 24-1) */
+  'orchestrator:zero-diff-escalation': {
+    storyKey: string;
+    reason: string;
+  };
   /** Implementation orchestrator has finished all stories */
   'orchestrator:complete': {
     totalStories: number;
@@ -1067,6 +1110,17 @@ interface OrchestratorEvents {
       affected_items: string[];
     }>;
   };
+  /** Build verification command failed with non-zero exit or timeout */
+  'story:build-verification-failed': {
+    storyKey: string;
+    exitCode: number;
+    /** Build output (stdout+stderr), truncated to 2000 chars */
+    output: string;
+  };
+  /** Build verification command exited with code 0 */
+  'story:build-verification-passed': {
+    storyKey: string;
+  };
 }
 
 //#endregion

package/dist/{run-bigUnNya.js → run-BXKRGSeL.js}

@@ -1,4 +1,4 @@
-import { registerRunCommand, runRunAction } from "./run-CKvf6LgL.js";
+import { registerRunCommand, runRunAction } from "./run-CEtHPG4I.js";
 import "./logger-D2fS2ccL.js";
 import "./helpers-DljGJnFF.js";
 import "./decisions-Dq4cAA2L.js";

package/dist/{run-CKvf6LgL.js → run-CEtHPG4I.js}

@@ -677,7 +677,9 @@ const PackManifestSchema = z.object({
 	prompts: z.record(z.string(), z.string()),
 	constraints: z.record(z.string(), z.string()),
 	templates: z.record(z.string(), z.string()),
-	conflictGroups: z.record(z.string(), z.string()).optional()
+	conflictGroups: z.record(z.string(), z.string()).optional(),
+	verifyCommand: z.union([z.string(), z.literal(false)]).optional(),
+	verifyTimeoutMs: z.number().optional()
 });
 const ConstraintSeveritySchema = z.enum([
 	"required",
@@ -2212,6 +2214,69 @@ const PIPELINE_EVENT_METADATA = [
 				description: "Error message."
 			}
 		]
+	},
+	{
+		type: "story:zero-diff-escalation",
+		description: "Dev-story reported COMPLETE but git diff shows no file changes (phantom completion).",
+		when: "After dev-story succeeds with zero file changes in working tree.",
+		fields: [
+			{
+				name: "ts",
+				type: "string",
+				description: "Timestamp."
+			},
+			{
+				name: "storyKey",
+				type: "string",
+				description: "Story key."
+			},
+			{
+				name: "reason",
+				type: "string",
+				description: "Always \"zero-diff-on-complete\"."
+			}
+		]
+	},
+	{
+		type: "story:build-verification-failed",
+		description: "Build verification command (default: npm run build) exited with non-zero code or timed out.",
+		when: "After dev-story and zero-diff check pass, but before code-review is dispatched.",
+		fields: [
+			{
+				name: "ts",
+				type: "string",
+				description: "Timestamp."
+			},
+			{
+				name: "storyKey",
+				type: "string",
+				description: "Story key."
+			},
+			{
+				name: "exitCode",
+				type: "number",
+				description: "Exit code from the build command (-1 for timeout)."
+			},
+			{
+				name: "output",
+				type: "string",
+				description: "Combined stdout+stderr from the build command (truncated to 2000 chars)."
+			}
+		]
+	},
+	{
+		type: "story:build-verification-passed",
+		description: "Build verification command exited with code 0 — compilation clean.",
+		when: "After dev-story completes and build verification command succeeds.",
+		fields: [{
+			name: "ts",
+			type: "string",
+			description: "Timestamp."
+		}, {
+			name: "storyKey",
+			type: "string",
+			description: "Story key."
+		}]
 	}
 ];
 /**
@@ -3472,6 +3537,114 @@ var DispatcherImpl = class {
 		}
 	}
 };
+/** Default command for the build verification gate */
+const DEFAULT_VERIFY_COMMAND = "npm run build";
+/** Default timeout in milliseconds for the build verification gate */
+const DEFAULT_VERIFY_TIMEOUT_MS = 6e4;
+/**
+* Run the build verification gate synchronously.
+*
+* Executes the configured verifyCommand (default: "npm run build") in the
+* project root directory, capturing stdout and stderr. On success (exit 0)
+* returns { status: 'passed' }. On failure or timeout, returns a structured
+* result with status, exitCode, output, and reason.
+*
+* AC4/5: reads verifyCommand from options (or defaults to 'npm run build').
+* AC6: if verifyCommand is empty string or false, returns { status: 'skipped' }.
+* AC8: timeout is configurable via verifyTimeoutMs (default 60 s).
+*/
+function runBuildVerification(options) {
+	const { verifyCommand, verifyTimeoutMs, projectRoot } = options;
+	const cmd = verifyCommand === void 0 ? DEFAULT_VERIFY_COMMAND : verifyCommand;
+	if (!cmd) return { status: "skipped" };
+	const timeoutMs = verifyTimeoutMs ?? DEFAULT_VERIFY_TIMEOUT_MS;
+	try {
+		const stdout = execSync(cmd, {
+			cwd: projectRoot,
+			timeout: timeoutMs,
+			encoding: "utf-8"
+		});
+		return {
+			status: "passed",
+			exitCode: 0,
+			output: typeof stdout === "string" ? stdout : ""
+		};
+	} catch (err) {
+		if (err != null && typeof err === "object") {
+			const e = err;
+			const isTimeout = e.killed === true;
+			const exitCode = typeof e.status === "number" ? e.status : 1;
+			const rawStdout = e.stdout;
+			const rawStderr = e.stderr;
+			const stdoutStr = typeof rawStdout === "string" ? rawStdout : Buffer.isBuffer(rawStdout) ? rawStdout.toString("utf-8") : "";
+			const stderrStr = typeof rawStderr === "string" ? rawStderr : Buffer.isBuffer(rawStderr) ? rawStderr.toString("utf-8") : "";
+			const combinedOutput = [stdoutStr, stderrStr].filter((s) => s.length > 0).join("\n");
+			if (isTimeout) return {
+				status: "timeout",
+				exitCode: -1,
+				output: combinedOutput,
+				reason: "build-verification-timeout"
+			};
+			return {
+				status: "failed",
+				exitCode,
+				output: combinedOutput,
+				reason: "build-verification-failed"
+			};
+		}
+		return {
+			status: "failed",
+			exitCode: 1,
+			output: String(err),
+			reason: "build-verification-failed"
+		};
+	}
+}
+/**
+* Check git working tree for modified files using `git diff --name-only HEAD`
+* (unstaged + staged changes to tracked files) and `git diff --cached --name-only`
+* (staged new files not yet in HEAD). Returns a deduplicated array of file paths.
+*
+* Returns an empty array when:
+* - No files have been modified or staged
+* - Git commands fail (e.g., not in a git repo, git not installed)
+*
+* Used by the zero-diff detection gate (Story 24-1) to catch phantom completions
+* where a dev-story agent reported COMPLETE but made no actual file changes.
+*
+* @param workingDir - Directory to run git commands in (defaults to process.cwd())
+* @returns Array of changed file paths; empty when nothing changed
+*/
+function checkGitDiffFiles(workingDir = process.cwd()) {
+	const results = new Set();
+	try {
+		const unstaged = execSync("git diff --name-only HEAD", {
+			cwd: workingDir,
+			encoding: "utf-8",
+			timeout: 5e3,
+			stdio: [
+				"ignore",
+				"pipe",
+				"pipe"
+			]
+		});
+		unstaged.split("\n").map((l) => l.trim()).filter((l) => l.length > 0).forEach((f) => results.add(f));
+	} catch {}
+	try {
+		const staged = execSync("git diff --cached --name-only", {
+			cwd: workingDir,
+			encoding: "utf-8",
+			timeout: 5e3,
+			stdio: [
+				"ignore",
+				"pipe",
+				"pipe"
+			]
+		});
+		staged.split("\n").map((l) => l.trim()).filter((l) => l.length > 0).forEach((f) => results.add(f));
+	} catch {}
+	return Array.from(results);
+}
 /**
 * Create a new Dispatcher instance.
 *
@@ -7027,6 +7200,7 @@ function createImplementationOrchestrator(deps) {
 		persistState();
 		let devFilesModified = [];
 		const batchFileGroups = [];
+		let devStoryWasSuccess = false;
 		try {
 			let storyContentForAnalysis = "";
 			try {
@@ -7135,6 +7309,7 @@ function createImplementationOrchestrator(deps) {
 						batchIndex: batch.batchIndex,
 						error: batchResult.error
 					}, "Batch dev-story reported failure — continuing with partial files");
+					else devStoryWasSuccess = true;
 					eventBus.emit("orchestrator:story-phase-complete", {
 						storyKey,
 						phase: "IN_DEV",
@@ -7163,7 +7338,8 @@ function createImplementationOrchestrator(deps) {
 					result: devResult
 				});
 				persistState();
-				if (devResult.result === "failed") logger$20.warn("Dev-story reported failure, proceeding to code review", {
+				if (devResult.result === "success") devStoryWasSuccess = true;
+				else logger$20.warn("Dev-story reported failure, proceeding to code review", {
 					storyKey,
 					error: devResult.error,
 					filesModified: devFilesModified.length
@@ -7187,7 +7363,70 @@ function createImplementationOrchestrator(deps) {
 			persistState();
 			return;
 		}
+		if (devStoryWasSuccess) {
+			const changedFiles = checkGitDiffFiles(projectRoot ?? process.cwd());
+			if (changedFiles.length === 0) {
+				logger$20.warn({ storyKey }, "Zero-diff detected after COMPLETE dev-story — no file changes in git working tree");
+				eventBus.emit("orchestrator:zero-diff-escalation", {
+					storyKey,
+					reason: "zero-diff-on-complete"
+				});
+				endPhase(storyKey, "dev-story");
+				updateStory(storyKey, {
+					phase: "ESCALATED",
+					error: "zero-diff-on-complete",
+					completedAt: new Date().toISOString()
+				});
+				writeStoryMetricsBestEffort(storyKey, "escalated", 0);
+				emitEscalation({
+					storyKey,
+					lastVerdict: "zero-diff-on-complete",
+					reviewCycles: 0,
+					issues: ["dev-story completed with COMPLETE verdict but no file changes detected in git diff"]
+				});
+				persistState();
+				return;
+			}
+		}
 		endPhase(storyKey, "dev-story");
+		{
+			const buildVerifyResult = runBuildVerification({
+				verifyCommand: pack.manifest.verifyCommand,
+				verifyTimeoutMs: pack.manifest.verifyTimeoutMs,
+				projectRoot: projectRoot ?? process.cwd()
+			});
+			if (buildVerifyResult.status === "passed") {
+				eventBus.emit("story:build-verification-passed", { storyKey });
+				logger$20.info({ storyKey }, "Build verification passed");
+			} else if (buildVerifyResult.status === "failed" || buildVerifyResult.status === "timeout") {
+				const truncatedOutput = (buildVerifyResult.output ?? "").slice(0, 2e3);
+				const reason = buildVerifyResult.reason ?? "build-verification-failed";
+				eventBus.emit("story:build-verification-failed", {
+					storyKey,
+					exitCode: buildVerifyResult.exitCode ?? 1,
+					output: truncatedOutput
+				});
+				logger$20.warn({
+					storyKey,
+					reason,
+					exitCode: buildVerifyResult.exitCode
+				}, "Build verification failed — escalating story");
+				updateStory(storyKey, {
+					phase: "ESCALATED",
+					error: reason,
+					completedAt: new Date().toISOString()
+				});
+				writeStoryMetricsBestEffort(storyKey, "escalated", 0);
+				emitEscalation({
+					storyKey,
+					lastVerdict: reason,
+					reviewCycles: 0,
+					issues: [truncatedOutput]
+				});
+				persistState();
+				return;
+			}
+		}
 		let reviewCycles = 0;
 		let keepReviewing = true;
 		let timeoutRetried = false;
@@ -12267,6 +12506,30 @@ async function runRunAction(options) {
 					child_active: payload.childActive
 				});
 			});
+			eventBus.on("orchestrator:zero-diff-escalation", (payload) => {
+				ndjsonEmitter.emit({
+					type: "story:zero-diff-escalation",
+					ts: new Date().toISOString(),
+					storyKey: payload.storyKey,
+					reason: payload.reason
+				});
+			});
+			eventBus.on("story:build-verification-passed", (payload) => {
+				ndjsonEmitter.emit({
+					type: "story:build-verification-passed",
+					ts: new Date().toISOString(),
+					storyKey: payload.storyKey
+				});
+			});
+			eventBus.on("story:build-verification-failed", (payload) => {
+				ndjsonEmitter.emit({
+					type: "story:build-verification-failed",
+					ts: new Date().toISOString(),
+					storyKey: payload.storyKey,
+					exitCode: payload.exitCode,
+					output: payload.output
+				});
+			});
 		}
 		const orchestrator = createImplementationOrchestrator({
 			db,
@@ -12721,4 +12984,4 @@ function registerRunCommand(program, _version = "0.0.0", projectRoot = process.c
 
 //#endregion
 export { DatabaseWrapper, SUBSTRATE_OWNED_SETTINGS_KEYS, VALID_PHASES, buildPipelineStatusOutput, createContextCompiler, createDispatcher, createImplementationOrchestrator, createPackLoader, createPhaseOrchestrator, createStopAfterGate, findPackageRoot, formatOutput, formatPhaseCompletionSummary, formatPipelineStatusHuman, formatPipelineSummary, formatTokenTelemetry, getAllDescendantPids, getAutoHealthData, getSubstrateDefaultSettings, registerHealthCommand, registerRunCommand, resolveBmadMethodSrcPath, resolveBmadMethodVersion, resolveMainRepoRoot, runAnalysisPhase, runMigrations, runPlanningPhase, runRunAction, runSolutioningPhase, validateStopAfterFromConflict };
-//# sourceMappingURL=run-CKvf6LgL.js.map
+//# sourceMappingURL=run-CEtHPG4I.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "substrate-ai",
-  "version": "0.2.25",
+  "version": "0.2.26",
   "description": "Substrate — multi-agent orchestration daemon for AI coding agents",
   "type": "module",
   "license": "MIT",