substrate-ai 0.19.33 → 0.19.35

package/dist/cli/index.js

@@ -1,10 +1,10 @@
 #!/usr/bin/env node
-import { FileStateStore, RunManifest, SUBSTRATE_OWNED_SETTINGS_KEYS, SupervisorLock, VALID_PHASES, WorkGraphRepository, buildPipelineStatusOutput, createDatabaseAdapter, createStateStore, findPackageRoot, formatOutput, formatPipelineStatusHuman, formatPipelineSummary, formatTokenTelemetry, getAllDescendantPids, getAutoHealthData, getSubstrateDefaultSettings, inspectProcessTree, parseDbTimestampAsUtc, registerHealthCommand, resolveBmadMethodSrcPath, resolveBmadMethodVersion, resolveMainRepoRoot, resolveRunManifest } from "../health-q4LAKfYz.js";
+import { FileStateStore, RunManifest, SUBSTRATE_OWNED_SETTINGS_KEYS, SupervisorLock, VALID_PHASES, WorkGraphRepository, buildPipelineStatusOutput, createDatabaseAdapter, createStateStore, findPackageRoot, formatOutput, formatPipelineStatusHuman, formatPipelineSummary, formatTokenTelemetry, getAllDescendantPids, getAutoHealthData, getSubstrateDefaultSettings, inspectProcessTree, parseDbTimestampAsUtc, registerHealthCommand, resolveBmadMethodSrcPath, resolveBmadMethodVersion, resolveMainRepoRoot, resolveRunManifest } from "../health-Ckl2VOPW.js";
 import { createLogger } from "../logger-KeHncl-f.js";
 import { createEventBus } from "../helpers-CElYrONe.js";
 import { AdapterRegistry, BudgetConfigSchema, CURRENT_CONFIG_FORMAT_VERSION, CURRENT_TASK_GRAPH_VERSION, ConfigError, CostTrackerConfigSchema, DEFAULT_CONFIG, DoltClient, DoltNotInstalled, GlobalSettingsSchema, IngestionServer, MonitorDatabaseImpl, OPERATIONAL_FINDING, PartialGlobalSettingsSchema, PartialProviderConfigSchema, ProvidersSchema, RoutingRecommender, STORY_METRICS, TelemetryConfigSchema, addTokenUsage, aggregateTokenUsageForRun, checkDoltInstalled, compareRunMetrics, createAmendmentRun, createConfigSystem, createDecision, createDoltClient, createPipelineRun, getActiveDecisions, getAllCostEntriesFiltered, getBaselineRunMetrics, getDecisionsByCategory, getDecisionsByPhaseForRun, getLatestCompletedRun, getLatestRun, getPipelineRunById, getPlanningCostTotal, getRetryableEscalations, getRunMetrics, getRunningPipelineRuns, getSessionCostSummary, getSessionCostSummaryFiltered, getStoryMetricsForRun, getTokenUsageSummary, incrementRunRestarts, initSchema, initializeDolt, listRunMetrics, loadParentRunDecisions, supersedeDecision, tagRunAsBaseline, updatePipelineRun } from "../dist-6ETBV23_.js";
 import "../adapter-registry-DXLMTmfD.js";
-import { AdapterTelemetryPersistence, AppError, DoltRepoMapMetaRepository, DoltSymbolRepository, ERR_REPO_MAP_STORAGE_WRITE, EpicIngester, GitClient, GrammarLoader, RepoMapInjector, RepoMapModule, RepoMapQueryEngine, RepoMapStorage, SymbolParser, createContextCompiler, createDispatcher, createEventEmitter, createImplementationOrchestrator, createPackLoader, createPhaseOrchestrator, createStopAfterGate, createTelemetryAdvisor, formatPhaseCompletionSummary, getFactoryRunSummaries, getScenarioResultsForRun, getTwinRunsForRun, listGraphRuns, registerExportCommand, registerFactoryCommand, registerRunCommand, registerScenariosCommand, resolveStoryKeys, runAnalysisPhase, runPlanningPhase, runSolutioningPhase, validateStopAfterFromConflict } from "../run-nz9xWO1t.js";
+import { AdapterTelemetryPersistence, AppError, DoltRepoMapMetaRepository, DoltSymbolRepository, ERR_REPO_MAP_STORAGE_WRITE, EpicIngester, GitClient, GrammarLoader, RepoMapInjector, RepoMapModule, RepoMapQueryEngine, RepoMapStorage, SymbolParser, createContextCompiler, createDispatcher, createEventEmitter, createImplementationOrchestrator, createPackLoader, createPhaseOrchestrator, createStopAfterGate, createTelemetryAdvisor, formatPhaseCompletionSummary, getFactoryRunSummaries, getScenarioResultsForRun, getTwinRunsForRun, listGraphRuns, registerExportCommand, registerFactoryCommand, registerRunCommand, registerScenariosCommand, resolveStoryKeys, runAnalysisPhase, runPlanningPhase, runSolutioningPhase, validateStopAfterFromConflict } from "../run-BG1vEtOA.js";
 import "../errors-QZ2_FzOB.js";
 import "../routing-CcBOCuC9.js";
 import "../decisions-C0pz9Clx.js";
@@ -3307,7 +3307,7 @@ async function runStatusAction(options) {
 			logger$12.debug({ err }, "Work graph query failed, continuing without work graph data");
 		}
 		if (run === void 0) {
-			const { inspectProcessTree: inspectProcessTree$1 } = await import("../health-BMz_Vxme.js");
+			const { inspectProcessTree: inspectProcessTree$1 } = await import("../health-B28gVggH.js");
 			const substrateDirPath = join(projectRoot, ".substrate");
 			const processInfo = inspectProcessTree$1({
 				projectRoot,
@@ -4833,7 +4833,7 @@ async function runSupervisorAction(options, deps = {}) {
 								await initSchema(expAdapter);
 								const { runRunAction: runPipeline } = await import(
 									/* @vite-ignore */
-									"../run-Cv8E1iib.js"
+									"../run-DgayZ4Aq.js"
 );
 								const runStoryFn = async (opts) => {
 									const exitCode = await runPipeline({

package/dist/{health-BMz_Vxme.js → health-B28gVggH.js}

@@ -1,4 +1,4 @@
-import { DEFAULT_STALL_THRESHOLD_SECONDS, getAllDescendantPids, getAutoHealthData, inspectProcessTree, isOrchestratorProcessLine, registerHealthCommand, runHealthAction } from "./health-q4LAKfYz.js";
+import { DEFAULT_STALL_THRESHOLD_SECONDS, getAllDescendantPids, getAutoHealthData, inspectProcessTree, isOrchestratorProcessLine, registerHealthCommand, runHealthAction } from "./health-Ckl2VOPW.js";
 import "./logger-KeHncl-f.js";
 import "./dist-6ETBV23_.js";
 import "./decisions-C0pz9Clx.js";

package/dist/{health-q4LAKfYz.js → health-Ckl2VOPW.js}

@@ -2715,7 +2715,7 @@ function createSdlcEventBridge(opts) {
 		const { finalOutcome } = data;
 		if (finalOutcome.status === "SUCCESS") sdlcBus.emit("orchestrator:story-complete", {
 			storyKey,
-			reviewCycles: devStoryRetries
+			reviewCycles: devStoryRetries + 1
 		});
 	};
 	const onGoalGateUnsatisfied = (data) => {
@@ -4253,4 +4253,4 @@ function registerHealthCommand(program, _version = "0.0.0", projectRoot = proces
 
 //#endregion
 export { BMAD_BASELINE_TOKENS_FULL, DEFAULT_STALL_THRESHOLD_SECONDS, DoltMergeConflict, FileStateStore, FindingsInjector, RunManifest, STOP_AFTER_VALID_PHASES, STORY_KEY_PATTERN$1 as STORY_KEY_PATTERN, SUBSTRATE_OWNED_SETTINGS_KEYS, SupervisorLock, VALID_PHASES, WorkGraphRepository, __commonJS, __require, __toESM, applyConfigToGraph, buildPipelineStatusOutput, createDatabaseAdapter$1 as createDatabaseAdapter, createGraphOrchestrator, createSdlcCodeReviewHandler, createSdlcCreateStoryHandler, createSdlcDevStoryHandler, createSdlcPhaseHandler, createStateStore, detectCycles, extractTargetFilesFromStoryContent, findPackageRoot, formatOutput, formatPipelineStatusHuman, formatPipelineSummary, formatTokenTelemetry, getAllDescendantPids, getAutoHealthData, getSubstrateDefaultSettings, inspectProcessTree, isOrchestratorProcessLine, parseDbTimestampAsUtc, registerHealthCommand, resolveBmadMethodSrcPath, resolveBmadMethodVersion, resolveGraphPath, resolveMainRepoRoot, resolveRunManifest, runHealthAction, validateStoryKey };
-//# sourceMappingURL=health-q4LAKfYz.js.map
+//# sourceMappingURL=health-Ckl2VOPW.js.map

package/dist/{run-nz9xWO1t.js → run-BG1vEtOA.js}

@@ -1,4 +1,4 @@
-import { BMAD_BASELINE_TOKENS_FULL, DoltMergeConflict, FileStateStore, FindingsInjector, RunManifest, STOP_AFTER_VALID_PHASES, STORY_KEY_PATTERN, VALID_PHASES, WorkGraphRepository, __commonJS, __require, __toESM, applyConfigToGraph, buildPipelineStatusOutput, createDatabaseAdapter, createGraphOrchestrator, createSdlcCodeReviewHandler, createSdlcCreateStoryHandler, createSdlcDevStoryHandler, createSdlcPhaseHandler, detectCycles, extractTargetFilesFromStoryContent, formatOutput, formatPipelineSummary, formatTokenTelemetry, inspectProcessTree, parseDbTimestampAsUtc, resolveGraphPath, resolveMainRepoRoot, validateStoryKey } from "./health-q4LAKfYz.js";
+import { BMAD_BASELINE_TOKENS_FULL, DoltMergeConflict, FileStateStore, FindingsInjector, RunManifest, STOP_AFTER_VALID_PHASES, STORY_KEY_PATTERN, VALID_PHASES, WorkGraphRepository, __commonJS, __require, __toESM, applyConfigToGraph, buildPipelineStatusOutput, createDatabaseAdapter, createGraphOrchestrator, createSdlcCodeReviewHandler, createSdlcCreateStoryHandler, createSdlcDevStoryHandler, createSdlcPhaseHandler, detectCycles, extractTargetFilesFromStoryContent, formatOutput, formatPipelineSummary, formatTokenTelemetry, inspectProcessTree, parseDbTimestampAsUtc, resolveGraphPath, resolveMainRepoRoot, validateStoryKey } from "./health-Ckl2VOPW.js";
 import { createLogger } from "./logger-KeHncl-f.js";
 import { TypedEventBusImpl, createEventBus, createTuiApp, isTuiCapable, printNonTtyWarning, sleep } from "./helpers-CElYrONe.js";
 import { ADVISORY_NOTES, Categorizer, ConsumerAnalyzer, DEFAULT_GLOBAL_SETTINGS, DispatcherImpl, DoltClient, ESCALATION_DIAGNOSIS, EXPERIMENT_RESULT, EfficiencyScorer, IngestionServer, LogTurnAnalyzer, OPERATIONAL_FINDING, Recommender, RoutingRecommender, RoutingResolver, RoutingTelemetry, RoutingTokenAccumulator, RoutingTuner, STORY_METRICS, STORY_OUTCOME, SubstrateConfigSchema, TEST_EXPANSION_FINDING, TEST_PLAN, TelemetryNormalizer, TelemetryPipeline, TurnAnalyzer, addTokenUsage, aggregateTokenUsageForRun, aggregateTokenUsageForStory, callLLM, createConfigSystem, createDatabaseAdapter$1, createDecision, createPipelineRun, createRequirement, detectInterfaceChanges, getArtifactByTypeForRun, getArtifactsByRun, getDecisionsByCategory, getDecisionsByPhase, getDecisionsByPhaseForRun, getLatestRun, getPipelineRunById, getRunMetrics, getRunningPipelineRuns, getStoryMetricsForRun, getTokenUsageSummary, initSchema, listRequirements, loadModelRoutingConfig, registerArtifact, updatePipelineRun, updatePipelineRunConfig, upsertDecision, writeRunMetrics, writeStoryMetrics } from "./dist-6ETBV23_.js";
@@ -7372,6 +7372,191 @@ function extractFilesInScope(storyContent) {
 	].join("\n");
 }
 
+//#endregion
+//#region src/modules/compiled-workflows/scope-guardrail.ts
+/**
+* ScopeGuardrail — utility for detecting out-of-scope file modifications in code review.
+*
+* Parses the expected file set from a story spec and compares it against the
+* actual files modified by the dev agent. Returns a pre-computed scope analysis
+* markdown string that can be injected into the code-review prompt so the LLM
+* reviewer does not need to re-parse the spec sections manually.
+*
+* Architecture constraints:
+* - Pure utility: no imports from packages/sdlc/, packages/core/, or persistence layer
+* - Takes plain strings in, returns plain strings out
+* - Test-file exemption patterns must match countTestMetrics() in code-review.ts
+*/
+/**
+* File extensions that qualify a token as a "path-like" string in task bullets.
+* Any token containing `/` and one of these extensions is treated as a file path.
+*/
+const RECOGNIZED_EXTENSIONS = [
+	".ts",
+	".js",
+	".tsx",
+	".jsx",
+	".md",
+	".json",
+	".yaml",
+	".yml",
+	".py",
+	".go",
+	".java",
+	".rb",
+	".rs",
+	".sh",
+	".css",
+	".scss",
+	".html"
+];
+/**
+* Section headings that explicitly list expected file paths.
+*/
+const FILE_PATH_SECTION_PATTERNS = [
+	/^#{1,4}\s*(file paths to create|files? to create)/i,
+	/^#{1,4}\s*(file paths to modify|files? to modify)/i,
+	/^#{1,4}\s*(key file paths?)/i
+];
+/**
+* The heading that marks the start of tasks/subtasks section.
+*/
+const TASKS_SECTION_PATTERN = /^#{1,4}\s*(tasks?\s*\/?\s*subtasks?|tasks?)/i;
+/**
+* Returns true if the given file path is a test file.
+* Patterns must be consistent with countTestMetrics() in code-review.ts,
+* which checks for `.test.`, `.spec.`, and `__tests__`. We also add `__mocks__/`.
+*/
+function isTestFile(filePath) {
+	return filePath.includes(".test.") || filePath.includes(".spec.") || filePath.includes("__tests__/") || filePath.includes("__tests__\\") || filePath.includes("/__tests__") || filePath.includes("\\__tests__") || filePath.includes("__mocks__/") || filePath.includes("__mocks__\\") || filePath.includes("/__mocks__") || filePath.includes("\\__mocks__");
+}
+var ScopeGuardrail = class ScopeGuardrail {
+	/**
+	* Extract expected file paths from a story spec's raw text content.
+	*
+	* Scans for paths under sections:
+	*  - "### File Paths to Create" / "### Files to Create"
+	*  - "### File Paths to Modify" / "### Files to Modify"
+	*  - "### Key File Paths"
+	*  - Path-like tokens in "### Tasks / Subtasks" bullets
+	*
+	* A "path-like" token is any token containing `/` and a recognized extension.
+	* Backtick wrappers and leading `- ` list markers are stripped.
+	*
+	* @param storyContent - Raw story spec markdown text
+	* @returns Set of file path strings extracted from the spec
+	*/
+	static parseExpectedFiles(storyContent) {
+		const paths = new Set();
+		const lines = storyContent.split("\n");
+		let mode = "none";
+		for (const rawLine of lines) {
+			const line = rawLine.trimEnd();
+			if (/^#{1,4}\s/.test(line)) {
+				mode = "none";
+				for (const pattern of FILE_PATH_SECTION_PATTERNS) if (pattern.test(line)) {
+					mode = "file-list";
+					break;
+				}
+				if (mode === "none" && TASKS_SECTION_PATTERN.test(line)) mode = "tasks";
+				continue;
+			}
+			if (mode === "file-list") {
+				const extracted = extractPathsFromLine(line);
+				for (const p of extracted) paths.add(p);
+			} else if (mode === "tasks") {
+				const extracted = extractPathLikeTokens(line);
+				for (const p of extracted) paths.add(p);
+			}
+		}
+		return paths;
+	}
+	/**
+	* Build a pre-computed scope analysis markdown string for injection into
+	* the code-review prompt context.
+	*
+	* Returns empty string if no out-of-scope violations are detected (so the
+	* assemblePrompt optional-section drop behavior applies automatically).
+	*
+	* @param storyContent - Raw story spec markdown text
+	* @param filesModified - List of file paths from the git diff
+	* @returns Markdown string listing expected/actual/delta file sets,
+	*          or empty string if no violations found
+	*/
+	static buildAnalysis(storyContent, filesModified) {
+		const expectedFiles = ScopeGuardrail.parseExpectedFiles(storyContent);
+		const nonTestFiles = filesModified.filter((f$1) => !isTestFile(f$1));
+		const outOfScope = nonTestFiles.filter((f$1) => !expectedFiles.has(f$1));
+		if (outOfScope.length === 0) return "";
+		const expectedList = expectedFiles.size > 0 ? Array.from(expectedFiles).map((f$1) => `  - ${f$1}`).join("\n") : "  (none specified)";
+		const actualList = nonTestFiles.length > 0 ? nonTestFiles.map((f$1) => `  - ${f$1}`).join("\n") : "  (none)";
+		const deltaList = outOfScope.map((f$1) => `  - ${f$1}`).join("\n");
+		return [
+			"## Pre-Computed Scope Analysis",
+			"",
+			"Expected files (from spec):",
+			expectedList,
+			"",
+			"Actual files (from diff):",
+			actualList,
+			"",
+			"Out-of-scope files (excluding tests):",
+			deltaList,
+			"",
+			"Note: Test files (*.test.ts, *.spec.ts, __tests__/, __mocks__/) are excluded from scope checking."
+		].join("\n");
+	}
+};
+/**
+* Extract all path-like strings from a line (for file-list sections).
+* Handles both backtick-wrapped paths and plain paths.
+* Strips leading `- ` list markers.
+*/
+function extractPathsFromLine(line) {
+	const paths = [];
+	const trimmed = line.trim().replace(/^[-*]\s+/, "");
+	if (!trimmed) return paths;
+	const backtickMatches = trimmed.matchAll(/`([^`]+)`/g);
+	for (const match$1 of backtickMatches) {
+		const candidate = match$1[1].trim();
+		if (isFilePath(candidate)) paths.push(candidate);
+	}
+	if (paths.length > 0) return paths;
+	const noSpaces = trimmed.split(/\s/)[0];
+	if (noSpaces && isFilePath(noSpaces)) paths.push(noSpaces);
+	return paths;
+}
+/**
+* Extract path-like tokens from a line (for tasks/subtasks sections).
+* A path-like token contains `/` and a recognized extension.
+*/
+function extractPathLikeTokens(line) {
+	const paths = [];
+	const backtickMatches = line.matchAll(/`([^`]+)`/g);
+	for (const match$1 of backtickMatches) {
+		const candidate = match$1[1].trim();
+		if (isFilePath(candidate)) paths.push(candidate);
+	}
+	const withoutBackticks = line.replace(/`[^`]+`/g, " ");
+	const tokens = withoutBackticks.split(/\s+/);
+	for (const token of tokens) {
+		const clean = token.replace(/[,;:()\[\]{}'"]+$/g, "").replace(/^[,;:()\[\]{}'"]+/g, "");
+		if (clean && isFilePath(clean)) paths.push(clean);
+	}
+	return paths;
+}
+/**
+* Returns true if the candidate string looks like a file path:
+* - Contains at least one `/`
+* - Has a recognized file extension
+* - Does not contain spaces
+*/
+function isFilePath(candidate) {
+	if (!candidate.includes("/")) return false;
+	if (/\s/.test(candidate)) return false;
+	return RECOGNIZED_EXTENSIONS.some((ext$1) => candidate.endsWith(ext$1));
+}
+
 //#endregion
 //#region src/modules/compiled-workflows/code-review.ts
 const logger$14 = createLogger("compiled-workflows:code-review");
@@ -7568,6 +7753,8 @@ async function runCodeReview(deps, params) {
 	} catch {}
 	const testMetricsContent = await countTestMetrics(filesModified, cwd);
 	if (testMetricsContent) logger$14.debug({ storyKey }, "Injecting verified test-count metrics into code-review context");
+	const scopeAnalysisContent = storyContent && filesModified ? ScopeGuardrail.buildAnalysis(storyContent, filesModified) : "";
+	if (scopeAnalysisContent) logger$14.debug({ storyKey }, "Scope analysis detected out-of-scope files");
 	const buildStatusPrefix = buildPassed === true ? "BUILD STATUS: PASSED — code compiles and passes build verification. Focus on logic correctness, style, and acceptance criteria rather than compilation errors.\n\n" : "";
 	const sections = [
 		{
@@ -7585,6 +7772,11 @@ async function runCodeReview(deps, params) {
 			content: testMetricsContent,
 			priority: "important"
 		},
+		{
+			name: "scope_analysis",
+			content: scopeAnalysisContent,
+			priority: "optional"
+		},
 		{
 			name: "previous_findings",
 			content: previousFindingsContent,
@@ -9478,20 +9670,21 @@ function verifyContracts(declarations, projectRoot) {
 	const mismatches = [];
 	for (const exp of exports$1) {
 		if (!exp.filePath) continue;
-		const absPath = join$1(projectRoot, exp.filePath);
+		const cleanPath = exp.filePath.replace(/`/g, "");
+		const absPath = join$1(projectRoot, cleanPath);
 		if (!existsSync(absPath)) {
 			const importers = imports.filter((i) => i.contractName === exp.contractName);
 			if (importers.length > 0) for (const imp of importers) mismatches.push({
 				exporter: exp.storyKey,
 				importer: imp.storyKey,
 				contractName: exp.contractName,
-				mismatchDescription: `Exported file not found: ${exp.filePath}`
+				mismatchDescription: `Exported file not found: ${cleanPath}`
 			});
 			else mismatches.push({
 				exporter: exp.storyKey,
 				importer: null,
 				contractName: exp.contractName,
-				mismatchDescription: `Exported file not found: ${exp.filePath}`
+				mismatchDescription: `Exported file not found: ${cleanPath}`
 			});
 		}
 	}
@@ -12914,6 +13107,16 @@ function createImplementationOrchestrator(deps) {
 						modifiedInterfaces: icResult.modifiedInterfaces,
 						potentiallyAffectedTests: icResult.potentiallyAffectedTests
 					});
+					if (config.pipelineRunId !== void 0) createDecision(db, {
+						pipeline_run_id: config.pipelineRunId,
+						phase: "implementation",
+						category: "INTERFACE_WARNING",
+						key: `${storyKey}:${config.pipelineRunId}`,
+						value: JSON.stringify({
+							modifiedInterfaces: icResult.modifiedInterfaces,
+							potentiallyAffectedTests: icResult.potentiallyAffectedTests
+						})
+					}).catch(() => {});
 				}
 			}
 		} catch {}
@@ -13197,11 +13400,12 @@ function createImplementationOrchestrator(deps) {
 					phase: "COMPLETE",
 					completedAt: new Date().toISOString()
 				});
-				await writeStoryMetricsBestEffort(storyKey, verdict, reviewCycles + 1);
-				await writeStoryOutcomeBestEffort(storyKey, "complete", reviewCycles + 1);
+				const completedReviewCycles = reviewCycles + 1;
+				await writeStoryMetricsBestEffort(storyKey, verdict, completedReviewCycles);
+				await writeStoryOutcomeBestEffort(storyKey, "complete", completedReviewCycles);
 				eventBus.emit("orchestrator:story-complete", {
 					storyKey,
-					reviewCycles
+					reviewCycles: completedReviewCycles
 				});
 				await persistState();
 				if (verdict === "LGTM_WITH_NOTES" && reviewResult.notes && config.pipelineRunId) try {
@@ -18134,6 +18338,7 @@ async function runResearchPhase(deps, params) {
 
 //#endregion
 //#region src/modules/telemetry/mesh-reporter.ts
+const logger$2 = createLogger("mesh-reporter");
 /** Lazy-loaded substrate version (avoids module-load-time side effects that break test mocking). */
 let _cachedVersion;
 function getSubstrateVersion() {
@@ -18147,7 +18352,68 @@ function getSubstrateVersion() {
 	}
 	return _cachedVersion;
 }
-const logger$2 = createLogger("mesh-reporter");
+async function loadVerificationResults(runId, runsDir) {
+	const results = {};
+	try {
+		const manifest = RunManifest.open(runId, runsDir);
+		const data = await manifest.read();
+		if (data?.per_story_state) for (const [storyKey, state] of Object.entries(data.per_story_state)) {
+			const vr = state["verification_result"];
+			if (vr) results[storyKey] = {
+				status: vr.status ?? "pass",
+				checks: (vr.checks ?? []).map((c) => ({
+					checkName: c.checkName,
+					status: c.status,
+					...c.details !== void 0 && { details: c.details },
+					...c.duration_ms !== void 0 && { durationMs: c.duration_ms }
+				}))
+			};
+		}
+	} catch {
+		logger$2.debug({ runId }, "Could not read RunManifest for verification results — skipping");
+	}
+	return results;
+}
+async function loadEfficiencyScores(adapter, storyKeys) {
+	const scores = {};
+	if (storyKeys.length === 0) return scores;
+	try {
+		for (const key of storyKeys) {
+			const rows = await adapter.query("SELECT composite_score FROM efficiency_scores WHERE story_key = ? ORDER BY timestamp DESC LIMIT 1", [key]);
+			if (rows.length > 0 && rows[0] !== void 0) scores[key] = rows[0].composite_score;
+		}
+	} catch {
+		logger$2.debug("Could not query efficiency_scores table — skipping");
+	}
+	return scores;
+}
+async function loadContractVerification(adapter, runId) {
+	try {
+		const rows = await adapter.query(`SELECT key, value FROM decisions WHERE pipeline_run_id = ? AND category = 'interface-contract'`, [runId]);
+		if (rows.length === 0) return void 0;
+		const mismatches = [];
+		let verified = 0;
+		for (const row of rows) try {
+			const parsed = JSON.parse(row.value);
+			if (parsed.verdict === "fail" && parsed.contractName && parsed.mismatchDescription) mismatches.push({
+				exporter: parsed.exporter ?? row.key,
+				importer: parsed.importer ?? null,
+				contractName: parsed.contractName,
+				mismatchDescription: parsed.mismatchDescription
+			});
+			else verified++;
+		} catch {}
+		return {
+			verified,
+			mismatches: mismatches.length,
+			verdict: mismatches.length > 0 ? "fail" : "pass",
+			...mismatches.length > 0 && { details: mismatches }
+		};
+	} catch {
+		logger$2.debug("Could not query contract verification decisions — skipping");
+		return void 0;
+	}
+}
 async function buildRunReport(adapter, runId, opts) {
 	const runMetrics = await getRunMetrics(adapter, runId);
 	if (!runMetrics) {
@@ -18155,11 +18421,46 @@ async function buildRunReport(adapter, runId, opts) {
 		return null;
 	}
 	const storyMetrics = await getStoryMetricsForRun(adapter, runId);
+	const storyKeys = storyMetrics.map((s$1) => s$1.story_key);
+	const dbDir = opts.projectRoot ? join$1(opts.projectRoot, ".substrate") : ".substrate";
+	const runsDir = join$1(dbDir, "runs");
+	const verificationResults = await loadVerificationResults(runId, runsDir);
+	const efficiencyScores = await loadEfficiencyScores(adapter, storyKeys);
+	const contractVerification = await loadContractVerification(adapter, runId);
+	const warnings = [];
+	try {
+		const warnRows = await adapter.query(`SELECT key, value FROM decisions WHERE pipeline_run_id = ? AND category = 'INTERFACE_WARNING'`, [runId]);
+		for (const row of warnRows) try {
+			const parsed = JSON.parse(row.value);
+			const storyKey = row.key.split(":")[0] ?? "unknown";
+			const ifaces = parsed.modifiedInterfaces?.join(", ") ?? "";
+			warnings.push(`${storyKey}: modified interfaces [${ifaces}]`);
+		} catch {}
+	} catch {
+		logger$2.debug("Could not query INTERFACE_WARNING decisions — skipping");
+	}
+	const testExpansions = {};
+	try {
+		const expRows = await adapter.query(`SELECT key, value FROM decisions WHERE pipeline_run_id = ? AND category = 'TEST_EXPANSION_FINDING'`, [runId]);
+		for (const row of expRows) try {
+			const parsed = JSON.parse(row.value);
+			const storyKey = row.key.split(":")[0] ?? "unknown";
+			testExpansions[storyKey] = {
+				priority: parsed.expansion_priority ?? "unknown",
+				gapCount: parsed.coverage_gaps?.length ?? 0
+			};
+		} catch {}
+	} catch {
+		logger$2.debug("Could not query TEST_EXPANSION_FINDING decisions — skipping");
+	}
+	for (const [storyKey, exp] of Object.entries(testExpansions)) if (exp.gapCount > 0) warnings.push(`${storyKey}: test expansion found ${exp.gapCount} coverage gap(s), priority=${exp.priority}`);
 	const stories = storyMetrics.map((s$1) => {
 		let phaseDurations;
 		if (s$1.phase_durations_json) try {
 			phaseDurations = JSON.parse(s$1.phase_durations_json);
 		} catch {}
+		const vr = verificationResults[s$1.story_key];
+		const qualityScore = efficiencyScores[s$1.story_key];
 		return {
 			storyKey: s$1.story_key,
 			result: s$1.result,
@@ -18169,9 +18470,16 @@ async function buildRunReport(adapter, runId, opts) {
 			costUsd: s$1.cost_usd,
 			reviewCycles: s$1.review_cycles,
 			dispatches: s$1.dispatches,
-			...phaseDurations !== void 0 && { phaseDurations }
+			...phaseDurations !== void 0 && { phaseDurations },
+			...vr !== void 0 && {
+				verificationStatus: vr.status,
+				verificationChecks: vr.checks
+			},
+			...qualityScore !== void 0 && { qualityScore }
 		};
 	});
+	const storyScores = stories.map((s$1) => s$1.qualityScore).filter((s$1) => s$1 !== void 0);
+	const avgEfficiencyScore = storyScores.length > 0 ? Math.round(storyScores.reduce((a, b) => a + b, 0) / storyScores.length) : void 0;
 	const rawStatus = runMetrics.status.toLowerCase();
 	const status = rawStatus === "completed" ? "completed" : rawStatus === "failed" ? "failed" : "partial";
 	const projectId = opts.projectId ?? (opts.projectRoot ? basename$1(opts.projectRoot) : "unknown");
@@ -18193,6 +18501,9 @@ async function buildRunReport(adapter, runId, opts) {
 		totalDispatches: runMetrics.total_dispatches,
 		restarts: runMetrics.restarts,
 		stories,
+		...contractVerification !== void 0 && { contractVerification },
+		...warnings.length > 0 && { warnings },
+		...avgEfficiencyScore !== void 0 && { efficiencyScore: avgEfficiencyScore },
 		agentBackend: opts.agentBackend ?? "claude-code",
 		engineType: opts.engineType ?? "linear",
 		concurrency: opts.concurrency ?? runMetrics.concurrency_setting
@@ -42266,6 +42577,13 @@ async function runFullPipeline(options) {
 						runId
 					});
 					process.stdout.write(summary + "\n");
+					if (fpMeshUrl !== void 0) await reportToMesh(adapter, runId, fpMeshUrl, {
+						projectId: fpMeshProjectId,
+						projectRoot,
+						agentBackend: agentId ?? "claude-code",
+						engineType: fpEngineType ?? "linear",
+						concurrency
+					});
 					return 0;
 				}
 			}
@@ -42375,4 +42693,4 @@ function registerRunCommand(program, _version = "0.0.0", projectRoot = process.c
 
 //#endregion
 export { AdapterTelemetryPersistence, AppError, DoltRepoMapMetaRepository, DoltSymbolRepository, ERR_REPO_MAP_STORAGE_WRITE, EpicIngester, GitClient, GrammarLoader, RepoMapInjector, RepoMapModule, RepoMapQueryEngine, RepoMapStorage, SymbolParser, createContextCompiler, createDispatcher, createEventEmitter, createImplementationOrchestrator, createPackLoader, createPhaseOrchestrator, createStopAfterGate, createTelemetryAdvisor, formatPhaseCompletionSummary, getFactoryRunSummaries, getScenarioResultsForRun, getTwinRunsForRun, listGraphRuns, normalizeGraphSummaryToStatus, registerExportCommand, registerFactoryCommand, registerRunCommand, registerScenariosCommand, resolveMaxReviewCycles, resolveStoryKeys, runAnalysisPhase, runPlanningPhase, runRunAction, runSolutioningPhase, validateStopAfterFromConflict, wireNdjsonEmitter };
-//# sourceMappingURL=run-nz9xWO1t.js.map
+//# sourceMappingURL=run-BG1vEtOA.js.map

package/dist/{run-Cv8E1iib.js → run-DgayZ4Aq.js}

@@ -1,8 +1,8 @@
-import "./health-q4LAKfYz.js";
+import "./health-Ckl2VOPW.js";
 import "./logger-KeHncl-f.js";
 import "./helpers-CElYrONe.js";
 import "./dist-6ETBV23_.js";
-import { normalizeGraphSummaryToStatus, registerRunCommand, resolveMaxReviewCycles, runRunAction, wireNdjsonEmitter } from "./run-nz9xWO1t.js";
+import { normalizeGraphSummaryToStatus, registerRunCommand, resolveMaxReviewCycles, runRunAction, wireNdjsonEmitter } from "./run-BG1vEtOA.js";
 import "./routing-CcBOCuC9.js";
 import "./decisions-C0pz9Clx.js";
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "substrate-ai",
-  "version": "0.19.33",
+  "version": "0.19.35",
   "description": "Substrate — multi-agent orchestration daemon for AI coding agents",
   "type": "module",
   "license": "MIT",

package/packs/bmad/prompts/code-review.md

@@ -19,6 +19,9 @@
 ### Prior Run Findings
 {{prior_findings}}
 
+<!-- scope_analysis -->
+{{scope_analysis}}
+
 ---
 
 ## Mission
@@ -39,12 +42,13 @@ Adversarial code review. Find what's wrong. Validate story claims against actual
 
 3. **Build AC Checklist** — For each acceptance criterion (AC1, AC2, ...) in the story, determine: `met` (code implements it), `not_met` (code does not implement it), or `partial` (partially implemented). Cite the specific file and function as evidence.
 
-4. **Execute adversarial review** across 5 dimensions:
+4. **Execute adversarial review** across 6 dimensions:
    - **AC Validation** — Is each acceptance criterion implemented?
    - **AC-to-Test Traceability** — For each AC, identify the specific test file and test function that validates it. If an AC has no corresponding test evidence, flag it as a major issue: "AC{N} has no test evidence". A test "covers" an AC if it directly exercises the behavior described in the criterion — tangential tests do not count.
    - **Task Audit** — Tasks marked `[x]` that aren't done are BLOCKER issues
    - **Code Quality** — Security, error handling, edge cases, maintainability
    - **Test Quality** — Real assertions, not placeholders or skipped tests
+   - **Scope Compliance** — Compare files in the git diff against the expected file set from the story spec's "Key File Paths", "File Paths to Create", "File Paths to Modify", and "Tasks / Subtasks" sections. Any non-test file created or modified that does not appear in that expected set should be recorded as a `scope-creep` finding with `category: scope-creep` and `severity: minor`. **Test files (paths containing `.test.ts`, `.spec.ts`, `__tests__/`, or `__mocks__/`) are always exempt from scope checking — do not flag them, regardless of whether they appear in the story spec.** If a pre-computed scope analysis is provided in the `scope_analysis` section above, use it as ground truth — do not re-parse the story spec manually. **ADVISORY ONLY: Scope-creep findings are informational. If the only issues found are `scope-creep` entries, the verdict must be SHIP_IT or LGTM_WITH_NOTES — scope-creep findings do not independently trigger NEEDS_MINOR_FIXES or NEEDS_MAJOR_REWORK.**
 
 5. **Severity classification:**
    - **blocker** — Task `[x]` but not implemented; security vulnerability; data loss risk
@@ -85,6 +89,10 @@ issue_list:
     description: "Variable name `d` should be more descriptive"
     file: "src/modules/foo/foo.ts"
     line: 15
+  - severity: minor
+    category: scope-creep
+    description: "File src/modules/foo/extra.ts was created but not listed in the story spec's expected file set"
+    file: "src/modules/foo/extra.ts"
 ac_checklist:
   - ac_id: AC1
     status: met