stylelint-order 5.0.0 → 6.0.0

package/README.md

@@ -64,6 +64,7 @@ All these configs have `properties-order` configured  with logical properties gr
 * [`stylelint-config-hudochenkov/order`](https://github.com/hudochenkov/stylelint-config-hudochenkov/blob/master/order.js)
 * [`stylelint-config-recess-order`](https://github.com/stormwarning/stylelint-config-recess-order)
 * [`stylelint-config-property-sort-order-smacss`](https://github.com/cahamilton/stylelint-config-property-sort-order-smacss)
+* [`stylelint-config-clean-order`](https://github.com/kutsan/stylelint-config-clean-order)
 
 ## Thanks
 

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "stylelint-order",
-	"version": "5.0.0",
+	"version": "6.0.0",
 	"description": "A collection of order related linting rules for Stylelint.",
 	"keywords": [
 		"stylelint-plugin",
@@ -21,35 +21,31 @@
 	],
 	"main": "index.js",
 	"dependencies": {
-		"postcss": "^8.3.11",
-		"postcss-sorting": "^7.0.1"
+		"postcss": "^8.4.20",
+		"postcss-sorting": "^8.0.0"
 	},
 	"peerDependencies": {
 		"stylelint": "^14.0.0"
 	},
 	"devDependencies": {
-		"@stylelint/postcss-css-in-js": "^0.37.2",
-		"eslint": "^7.27.0",
-		"eslint-config-hudochenkov": "^8.0.0",
-		"eslint-config-prettier": "^8.3.0",
-		"eslint-plugin-import": "^2.25.2",
-		"eslint-plugin-jest": "^24.3.6",
-		"eslint-plugin-unicorn": "^33.0.1",
-		"husky": "^7.0.2",
-		"jest": "^27.2.5",
-		"jest-preset-stylelint": "^4.1.1",
-		"jest-watch-typeahead": "^1.0.0",
-		"lint-staged": "^11.2.3",
-		"postcss-html": "^0.36.0",
-		"postcss-less": "^5.0.0",
-		"prettier": "~2.4.1",
+		"eslint": "^8.31.0",
+		"eslint-config-hudochenkov": "^9.0.0",
+		"eslint-config-prettier": "^8.6.0",
+		"husky": "^8.0.3",
+		"jest": "^29.3.1",
+		"jest-preset-stylelint": "^6.0.0",
+		"jest-watch-typeahead": "^2.2.1",
+		"lint-staged": "^13.1.0",
+		"postcss-html": "^1.5.0",
+		"postcss-less": "^6.0.0",
+		"postcss-styled-syntax": "^0.1.0",
+		"prettier": "~2.8.1",
 		"prettier-config-hudochenkov": "^0.3.0",
-		"stylelint": "^14.0.0"
+		"stylelint": "^14.16.1"
 	},
 	"scripts": {
-		"pretest": "eslint . --max-warnings=0 && prettier '**/*.js' --check",
+		"lint": "eslint . --max-warnings=0 && prettier '**/*.js' --check",
 		"test": "jest",
-		"jest": "jest",
 		"watch": "jest --watch",
 		"coverage": "jest --coverage",
 		"fix": "eslint . --fix --max-warnings=0 && prettier '**/*.js' --write",

package/rules/order/README.md

@@ -18,16 +18,16 @@ type PrimaryOption = Array<Keyword | AtRule | Rule>;
 type Keyword = "custom-properties" | "dollar-variables" | "at-variables" | "declarations" | "rules" | "at-rules" | "less-mixins";
 
 type AtRule = {
-	type: 'at-rule',
-	name?: string,
-	parameter?: string | RegExp,
-	hasBlock?: boolean
+	type: 'at-rule';
+	name?: string;
+	parameter?: string | RegExp;
+	hasBlock?: boolean;
 };
 
 type Rule = {
-	type: 'rule',
-	selector?: string | RegExp,
-	name?: string
+	type: 'rule';
+	selector?: string | RegExp;
+	name?: string;
 };
 ```
 
@@ -178,7 +178,7 @@ Matches all rules with selector matching pattern:
 
 ```ts
 type SecondaryOptions = {
-	unspecified?: "top" | "bottom" | "ignore",
+	unspecified?: "top" | "bottom" | "ignore";
 };
 ```
 

package/rules/order/checkNode.js

@@ -82,7 +82,7 @@ module.exports = function checkNode({
 
 		allNodes.push(nodeData);
 
-		let previousNodeData = allNodes[allNodes.length - 2];
+		let previousNodeData = allNodes[allNodes.length - 2]; // eslint-disable-line unicorn/prefer-at -- Need to support older Node.js
 
 		// Skip first node
 		if (!previousNodeData) {

package/rules/properties-alphabetical-order/checkNode.js

@@ -36,7 +36,7 @@ module.exports = function checkNode(node, result, ruleName, messages) {
 			node: child,
 		};
 
-		let previousPropData = allPropData[allPropData.length - 1];
+		let previousPropData = allPropData[allPropData.length - 1]; // eslint-disable-line unicorn/prefer-at -- Need to support older Node.js
 
 		allPropData.push(propData);
 

package/rules/properties-order/README.md

@@ -19,7 +19,7 @@ This rule ignores variables (`$sass`, `@less`, `--custom-property`).
 * Optional secondary options
 	* [`unspecified`](#unspecified)
 	* [`emptyLineBeforeUnspecified`](#emptyLineBeforeUnspecified)
-	* [`emptyLineMinimumPropertyThreshold`](#emptylineminimumpropertythreshold)
+	* [`emptyLineMinimumPropertyThreshold`](#emptyLineMinimumPropertyThreshold)
 * [Autofixing caveats](#autofixing-caveats)
 
 ## Options
@@ -28,11 +28,11 @@ This rule ignores variables (`$sass`, `@less`, `--custom-property`).
 type PrimaryOption = Array<string | Group>;
 
 type Group = {
-	properties: Array<string>,
-	emptyLineBefore?: 'always' | 'never' | 'threshold',
-	noEmptyLineBetween?: boolean,
-	groupName?: string
-	order?: 'flexible,
+	properties: Array<string>;
+	emptyLineBefore?: 'always' | 'never' | 'threshold';
+	noEmptyLineBetween?: boolean;
+	groupName?: string;
+	order?: 'flexible';
 };
 ```
 
@@ -47,7 +47,7 @@ Array of unprefixed property names or group objects. Within an order array, you
 
 		If `emptyLineBefore` specified, regardless of it's value, the first property in a rule would be forced to not have an empty line before it.
 
-		For `threshold`, refer to the [`emptyLineMinimumPropertyThreshold` documentation](#emptylineminimumpropertythreshold-number).
+		For `threshold`, refer to the [`emptyLineMinimumPropertyThreshold` documentation](#emptyLineMinimumPropertyThreshold).
 
 		If this option is not working as expected, make sure you don't have `declaration-empty-line-before` configured in a conflicting way in your Stylelint config or config you're extending (e. g. [`stylelint-config-standard`](https://github.com/stylelint/stylelint-config-standard)).
 
@@ -507,9 +507,9 @@ a {
 
 ```ts
 type SecondaryOptions = {
-	unspecified?: "top" | "bottom" | "bottomAlphabetical" | "ignore",
-	emptyLineBeforeUnspecified?: "always" | "never" | "threshold",
-	emptyLineMinimumPropertyThreshold?: number,
+	unspecified?: "top" | "bottom" | "bottomAlphabetical" | "ignore";
+	emptyLineBeforeUnspecified?: "always" | "never" | "threshold";
+	emptyLineMinimumPropertyThreshold?: number;
 };
 ```
 
@@ -688,7 +688,7 @@ Default behavior does not enforce the presence of an empty line before an unspec
 If `"always"`, the unspecified group must be separated from other properties by an empty newline.
 If `"never"`, the unspecified group must have no empty lines separating it from other properties.
 
-For `"threshold"`, see the [`emptyLineMinimumPropertyThreshold` documentation](#emptylineminimumpropertythreshold-number) for more information.
+For `"threshold"`, see the [`emptyLineMinimumPropertyThreshold` documentation](#emptyLineMinimumPropertyThreshold) for more information.
 
 If `emptyLineBeforeUnspecified` specified, regardless of it's value, if the first property in a rule is target of this option, that property would be forced to not have an empty line before it.
 

package/utils/__tests__/vendor.test.js

@@ -3,13 +3,13 @@ let vendor = require('../vendor');
 const VALUE = '-1px -1px 1px rgba(0, 0, 0, 0.2) inset';
 
 it('returns prefix', () => {
-	expect(vendor.prefix('-moz-color')).toEqual('-moz-');
-	expect(vendor.prefix('color')).toEqual('');
-	expect(vendor.prefix(VALUE)).toEqual('');
+	expect(vendor.prefix('-moz-color')).toBe('-moz-');
+	expect(vendor.prefix('color')).toBe('');
+	expect(vendor.prefix(VALUE)).toBe('');
 });
 
 it('returns unprefixed version', () => {
-	expect(vendor.unprefixed('-moz-color')).toEqual('color');
-	expect(vendor.unprefixed('color')).toEqual('color');
+	expect(vendor.unprefixed('-moz-color')).toBe('color');
+	expect(vendor.unprefixed('color')).toBe('color');
 	expect(vendor.unprefixed(VALUE)).toEqual(VALUE);
 });

package/utils/getContainingNode.js

@@ -1,12 +1,6 @@
 module.exports = function getContainingNode(node) {
-	// For styled-components declarations are children of Root node
-	if (
-		node.type !== 'rule' &&
-		node.type !== 'atrule' &&
-		node.parent.document &&
-		node.parent.document.nodes &&
-		node.parent.document.nodes.some((item) => item.type === 'root')
-	) {
+	// For styled-components: declarations are children of Root node
+	if (node.type !== 'rule' && node.type !== 'atrule' && node.parent.type === 'root') {
 		return node.parent;
 	}