stream-chat-react-native-core 9.5.1-beta.6 → 9.5.1-beta.8

package/src/components/Notifications/__tests__/notificationFilters.test.ts

@@ -0,0 +1,50 @@
+import type { Notification } from 'stream-chat';
+
+import { excludeCanceledUploadNotifications } from '../notificationFilters';
+
+const buildNotification = (overrides: Partial<Notification> = {}): Notification =>
+  ({
+    createdAt: 0,
+    id: 'n1',
+    message: 'Error uploading attachment',
+    origin: { emitter: 'AttachmentManager' },
+    type: 'api:attachment:upload:failed',
+    ...overrides,
+  }) as Notification;
+
+const canceledError = (name: 'AbortError' | 'CanceledError') => {
+  const error = new Error('canceled');
+  error.name = name;
+  return error;
+};
+
+// A filter returns `true` to KEEP a notification, `false` to hide it.
+describe('excludeCanceledUploadNotifications', () => {
+  it.each(['AbortError', 'CanceledError'] as const)(
+    'hides an upload-failed notification aborted with %s',
+    (name) => {
+      const notification = buildNotification({ originalError: canceledError(name) });
+
+      expect(excludeCanceledUploadNotifications(notification)).toBe(false);
+    },
+  );
+
+  it('keeps a genuine upload failure', () => {
+    const notification = buildNotification({ originalError: new Error('Network Error') });
+
+    expect(excludeCanceledUploadNotifications(notification)).toBe(true);
+  });
+
+  it('keeps an upload-failed notification with no original error', () => {
+    expect(excludeCanceledUploadNotifications(buildNotification())).toBe(true);
+  });
+
+  it('keeps a cancellation error reported on a different notification type', () => {
+    const notification = buildNotification({
+      originalError: canceledError('CanceledError'),
+      type: 'api:message:send:failed',
+    });
+
+    expect(excludeCanceledUploadNotifications(notification)).toBe(true);
+  });
+});

package/src/components/Notifications/index.ts

@@ -2,4 +2,5 @@ export * from './Notification';
 export * from './NotificationList';
 export * from './NotificationTargetContext';
 export * from './hooks';
+export * from './notificationFilters';
 export * from './notificationTarget';

package/src/components/Notifications/notificationFilters.ts

@@ -0,0 +1,26 @@
+import type { Notification } from 'stream-chat';
+
+import type { NotificationListFilter } from './NotificationList';
+
+const ATTACHMENT_UPLOAD_FAILED_TYPE = 'api:attachment:upload:failed';
+
+/**
+ * A cancelled upload surfaces as an `api:attachment:upload:failed` notification
+ * whose original error is an `AbortError` (fetch) or `CanceledError` (axios).
+ * This is what happens when the user removes an attachment before its upload
+ * has finished - the inflight request is aborted, not genuinely failed.
+ */
+const isCanceledAttachmentUpload = (notification: Notification) =>
+  notification.type === ATTACHMENT_UPLOAD_FAILED_TYPE &&
+  (notification.originalError?.name === 'CanceledError' ||
+    notification.originalError?.name === 'AbortError');
+
+/**
+ * Notification list filter that keeps every notification except the spurious
+ * "upload failed" one produced when a user removes an attachment mid-upload
+ * (a filter returns `true` to keep a notification). Genuine upload failures
+ * (network, server) are kept because their error is neither aborted nor
+ * cancelled.
+ */
+export const excludeCanceledUploadNotifications: NotificationListFilter = (notification) =>
+  !isCanceledAttachmentUpload(notification);

package/src/version.json

@@ -1,3 +1,3 @@
 {
-  "version": "9.5.1-beta.6"
+  "version": "9.5.1-beta.8"
 }