stream-chat-react-native-core 5.5.1-beta.1 → 5.6.0-beta.0

package/src/__tests__/offline-feature.test.js

@@ -14,6 +14,7 @@ import { queryChannelsApi } from '../mock-builders/api/queryChannels';
 import { useMockedApis } from '../mock-builders/api/useMockedApis';
 import dispatchChannelTruncatedEvent from '../mock-builders/event/channelTruncated';
 import dispatchChannelUpdatedEvent from '../mock-builders/event/channelUpdated';
+import dispatchConnectionChangedEvent from '../mock-builders/event/connectionChanged';
 import dispatchMemberAddedEvent from '../mock-builders/event/memberAdded';
 import dispatchMemberRemovedEvent from '../mock-builders/event/memberRemoved';
 import dispatchMemberUpdatedEvent from '../mock-builders/event/memberUpdated';
@@ -206,7 +207,6 @@ describe('Offline support is enabled', () => {
 
     const channelQueriesRows = BetterSqlite.selectFromTable('channelQueries');
     const cidsInDB = JSON.parse(channelQueriesRows[0].cids);
-
     const filterSortQueryInDB = channelQueriesRows[0].id;
     const actualFilterSortQueryInDB = convertFilterSortToQuery({ filters, sort });
 
@@ -285,8 +285,10 @@ describe('Offline support is enabled', () => {
 
   it('should store filter-sort query and cids on ChannelList in channelQueries table', async () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
-
     const { getByTestId, queryAllByA11yRole } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
+    // await waiter();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
 
     expectCIDsOnUIToBeInDB(queryAllByA11yRole);
@@ -296,6 +298,7 @@ describe('Offline support is enabled', () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
 
     const { getByTestId, queryAllByA11yRole } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
 
     expectAllChannelsWithStateToBeInDB(queryAllByA11yRole);
@@ -305,6 +308,7 @@ describe('Offline support is enabled', () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
 
     const { getByTestId } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
     const newMessage = generateMessage({
       cid: channels[0].channel.cid,
@@ -322,6 +326,7 @@ describe('Offline support is enabled', () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
 
     const { getByTestId, queryAllByA11yRole } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
 
     const newChannel = createChannel();
@@ -343,6 +348,7 @@ describe('Offline support is enabled', () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
 
     const { getByTestId } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
 
     const updatedMessage = { ...channels[0].messages[0] };
@@ -361,6 +367,7 @@ describe('Offline support is enabled', () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
 
     const { getByTestId, queryAllByA11yRole } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
     const removedChannel = channels[getRandomInt(0, channels.length - 1)].channel;
     act(() => dispatchNotificationRemovedFromChannel(chatClient, removedChannel));
@@ -387,6 +394,7 @@ describe('Offline support is enabled', () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
 
     const { getByTestId, queryAllByA11yRole } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
 
     const newChannel = createChannel();
@@ -416,6 +424,7 @@ describe('Offline support is enabled', () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
 
     const { getByTestId, queryAllByA11yRole } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
 
     const channelToTruncate = channels[getRandomInt(0, channels.length - 1)].channel;
@@ -440,6 +449,7 @@ describe('Offline support is enabled', () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
 
     const { getByTestId } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
 
     const targetChannel = channels[getRandomInt(0, channels.length - 1)];
@@ -481,6 +491,7 @@ describe('Offline support is enabled', () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
 
     const { getByTestId } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
 
     const targetChannel = channels[getRandomInt(0, channels.length - 1)];
@@ -528,6 +539,7 @@ describe('Offline support is enabled', () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
 
     const { getByTestId } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
 
     const targetChannel = channels[getRandomInt(0, channels.length - 1)];
@@ -561,6 +573,7 @@ describe('Offline support is enabled', () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
 
     const { getByTestId } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
 
     const targetChannel = channels[getRandomInt(0, channels.length - 1)];
@@ -579,6 +592,7 @@ describe('Offline support is enabled', () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
 
     const { getByTestId } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
 
     const targetChannel = channels[getRandomInt(0, channels.length - 1)];
@@ -597,6 +611,7 @@ describe('Offline support is enabled', () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
 
     const { getByTestId } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
 
     const targetChannel = channels[getRandomInt(0, channels.length - 1)];
@@ -620,6 +635,7 @@ describe('Offline support is enabled', () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
 
     const { getByTestId } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
 
     const targetChannel = channels[getRandomInt(0, channels.length - 1)];
@@ -640,6 +656,7 @@ describe('Offline support is enabled', () => {
     useMockedApis(chatClient, [queryChannelsApi(channels)]);
 
     const { getByTestId } = renderComponent();
+    act(() => dispatchConnectionChangedEvent(chatClient));
     await waitFor(() => expect(getByTestId('channel-list')).toBeTruthy());
     const targetChannel = channels[getRandomInt(0, channels.length - 1)];
     const targetMember = targetChannel.members[getRandomInt(0, targetChannel.members.length - 1)];

package/src/__tests__/optimistic-update.test.js

@@ -0,0 +1,368 @@
+/* eslint-disable no-underscore-dangle */
+import React, { useContext, useEffect, useState } from 'react';
+import { View } from 'react-native';
+
+import { act, cleanup, render, waitFor } from '@testing-library/react-native';
+
+import { v4 as uuidv4 } from 'uuid';
+
+import { Channel } from '../components/Channel/Channel';
+import { Chat } from '../components/Chat/Chat';
+import { MessagesContext } from '../contexts';
+import { deleteMessageApi } from '../mock-builders/api/deleteMessage';
+import { deleteReactionApi } from '../mock-builders/api/deleteReaction';
+import { erroredDeleteApi, erroredPostApi } from '../mock-builders/api/error';
+import { getOrCreateChannelApi } from '../mock-builders/api/getOrCreateChannel';
+import { sendReactionApi } from '../mock-builders/api/sendReaction';
+import { useMockedApis } from '../mock-builders/api/useMockedApis';
+import dispatchConnectionChangedEvent from '../mock-builders/event/connectionChanged';
+import { generateChannelResponse } from '../mock-builders/generator/channel';
+import { generateMember } from '../mock-builders/generator/member';
+import { generateMessage } from '../mock-builders/generator/message';
+import { generateReaction } from '../mock-builders/generator/reaction';
+import { generateUser } from '../mock-builders/generator/user';
+import { getTestClientWithUser } from '../mock-builders/mock';
+import { upsertChannels } from '../store/apis';
+import { QuickSqliteClient } from '../store/QuickSqliteClient';
+import { BetterSqlite } from '../test-utils/BetterSqlite';
+
+describe('Optimistic Updates', () => {
+  let chatClient;
+
+  const getRandomInt = (lower, upper) => Math.floor(lower + Math.random() * (upper - lower + 1));
+  const createChannel = () => {
+    const allUsers = Array(20).fill(1).map(generateUser);
+    const allMessages = [];
+    const allMembers = [];
+    const allReactions = [];
+    const allReads = [];
+    const id = uuidv4();
+    const cid = `messaging:${id}`;
+    const begin = getRandomInt(0, allUsers.length - 2); // begin shouldn't be the end of users.length
+    const end = getRandomInt(begin + 1, allUsers.length - 1);
+    const usersForMembers = allUsers.slice(begin, end);
+    const members = usersForMembers.map((user) =>
+      generateMember({
+        cid,
+        user,
+      }),
+    );
+    const messages = Array(10)
+      .fill(1)
+      .map(() => {
+        const id = uuidv4();
+        const user = usersForMembers[getRandomInt(0, usersForMembers.length - 1)];
+
+        const begin = getRandomInt(0, usersForMembers.length - 2); // begin shouldn't be the end of users.length
+        const end = getRandomInt(begin + 1, usersForMembers.length - 1);
+
+        const usersForReactions = usersForMembers.slice(begin, end);
+        const reactions = usersForReactions.map((user) =>
+          generateReaction({
+            message_id: id,
+            user,
+          }),
+        );
+        allReactions.push(...reactions);
+        return generateMessage({
+          cid,
+          id,
+          latest_reactions: reactions,
+          user,
+          userId: user.id,
+        });
+      });
+
+    const reads = members.map((member) => ({
+      last_read: new Date(new Date().setDate(new Date().getDate() - getRandomInt(0, 20))),
+      unread_messages: getRandomInt(0, messages.length),
+      user: member.user,
+    }));
+
+    allMessages.push(...messages);
+    allMembers.push(...members);
+    allReads.push(...reads);
+
+    return generateChannelResponse({
+      cid,
+      id,
+      members,
+      messages,
+    });
+  };
+
+  beforeEach(async () => {
+    jest.clearAllMocks();
+
+    chatClient = await getTestClientWithUser({ id: 'dan' });
+    const channelResponse = createChannel();
+    useMockedApis(chatClient, [getOrCreateChannelApi(channelResponse)]);
+    channel = chatClient.channel('messaging', channelResponse.id);
+    await channel.watch();
+
+    channel.cid = channelResponse.channel.cid;
+    channel.id = channelResponse.channel.id;
+
+    // Populate the DB with channel
+    QuickSqliteClient.initializeDatabase();
+    upsertChannels({
+      channels: [channelResponse],
+      isLatestMessagesSet: true,
+    });
+  });
+
+  afterEach(() => {
+    BetterSqlite.dropAllTables();
+    cleanup();
+  });
+
+  let channel;
+  // This component is used for performing effects in a component that consumes ChannelContext,
+  // i.e. making use of the callbacks & values provided by the Channel component.
+  // the effect is called every time channelContext changes
+  const CallbackEffectWithContext = ({ callback, children, context }) => {
+    const ctx = useContext(context);
+    const [ready, setReady] = useState(false);
+    useEffect(() => {
+      const call = async () => {
+        await callback(ctx);
+        setReady(true);
+      };
+
+      call();
+    }, []);
+
+    if (!ready) return null;
+
+    return children;
+  };
+
+  describe('delete message', () => {
+    it('pending task should exist if deleteMessage request fails', async () => {
+      const message = generateMessage();
+
+      const { getByTestId } = render(
+        <Chat client={chatClient} enableOfflineSupport>
+          <Channel channel={channel} initialValue={message.text}>
+            <CallbackEffectWithContext
+              callback={async ({ deleteMessage }) => {
+                useMockedApis(chatClient, [erroredPostApi()]);
+                try {
+                  await deleteMessage(message);
+                } catch (e) {
+                  // do nothing
+                }
+              }}
+              context={MessagesContext}
+            >
+              <View testID='children' />
+            </CallbackEffectWithContext>
+          </Channel>
+        </Chat>,
+      );
+      await waitFor(() => expect(getByTestId('children')).toBeTruthy());
+      await waitFor(() => {
+        const pendingTasksRows = BetterSqlite.selectFromTable('pendingTasks');
+        const pendingTaskType = pendingTasksRows?.[0]?.type;
+        const pendingTaskPayload = JSON.parse(pendingTasksRows?.[0]?.payload || '{}');
+        expect(pendingTaskType).toBe('delete-message');
+        expect(pendingTaskPayload[0]).toBe(message.id);
+      });
+    });
+
+    it('pending task should be cleared if deleteMessage request is succesful', async () => {
+      const message = generateMessage();
+      const { getByTestId } = render(
+        <Chat client={chatClient} enableOfflineSupport>
+          <Channel channel={channel} initialValue={message.text}>
+            <CallbackEffectWithContext
+              callback={({ deleteMessage }) => {
+                useMockedApis(chatClient, [deleteMessageApi(message)]);
+                deleteMessage(message);
+              }}
+              context={MessagesContext}
+            >
+              <View testID='children' />
+            </CallbackEffectWithContext>
+          </Channel>
+        </Chat>,
+      );
+      await waitFor(() => expect(getByTestId('children')).toBeTruthy());
+      await waitFor(() => {
+        const pendingTasksRows = BetterSqlite.selectFromTable('pendingTasks');
+        expect(pendingTasksRows.length).toBe(0);
+      });
+    });
+  });
+
+  describe('send reaction', () => {
+    it('pending task should exist if sendReaction request fails', async () => {
+      const reaction = generateReaction();
+      const targetMessage = channel.state.messages[0];
+
+      const { getByTestId } = render(
+        <Chat client={chatClient} enableOfflineSupport>
+          <Channel channel={channel}>
+            <CallbackEffectWithContext
+              callback={async ({ sendReaction }) => {
+                useMockedApis(chatClient, [erroredPostApi()]);
+                try {
+                  await sendReaction(reaction.type, targetMessage.id);
+                } catch (e) {
+                  // do nothing
+                }
+              }}
+              context={MessagesContext}
+            >
+              <View testID='children' />
+            </CallbackEffectWithContext>
+          </Channel>
+        </Chat>,
+      );
+      await waitFor(() => expect(getByTestId('children')).toBeTruthy());
+      await waitFor(() => {
+        const pendingTasksRows = BetterSqlite.selectFromTable('pendingTasks');
+        const pendingTaskType = pendingTasksRows?.[0]?.type;
+        const pendingTaskPayload = JSON.parse(pendingTasksRows?.[0]?.payload || '{}');
+        expect(pendingTaskType).toBe('send-reaction');
+        expect(pendingTaskPayload[0]).toBe(targetMessage.id);
+      });
+    });
+
+    it('pending task should be cleared if sendReaction request is succesful', async () => {
+      const reaction = generateReaction();
+      const targetMessage = channel.state.messages[0];
+
+      const { getByTestId } = render(
+        <Chat client={chatClient} enableOfflineSupport>
+          <Channel channel={channel}>
+            <CallbackEffectWithContext
+              callback={({ sendReaction }) => {
+                useMockedApis(chatClient, [sendReactionApi(targetMessage, reaction)]);
+                sendReaction(reaction.type, targetMessage.id);
+              }}
+              context={MessagesContext}
+            >
+              <View testID='children' />
+            </CallbackEffectWithContext>
+          </Channel>
+        </Chat>,
+      );
+      await waitFor(() => expect(getByTestId('children')).toBeTruthy());
+      await waitFor(() => {
+        const pendingTasksRows = BetterSqlite.selectFromTable('pendingTasks');
+        expect(pendingTasksRows.length).toBe(0);
+      });
+    });
+  });
+
+  describe('delete reaction', () => {
+    it('pending task should exist if deleteReaction request fails', async () => {
+      const reaction = generateReaction();
+      const targetMessage = channel.state.messages[0];
+
+      const { getByTestId } = render(
+        <Chat client={chatClient} enableOfflineSupport>
+          <Channel channel={channel}>
+            <CallbackEffectWithContext
+              callback={async ({ deleteReaction }) => {
+                useMockedApis(chatClient, [erroredPostApi()]);
+                try {
+                  await deleteReaction(reaction.type, targetMessage.id);
+                } catch (e) {
+                  // do nothing
+                }
+              }}
+              context={MessagesContext}
+            >
+              <View testID='children' />
+            </CallbackEffectWithContext>
+          </Channel>
+        </Chat>,
+      );
+      await waitFor(() => expect(getByTestId('children')).toBeTruthy());
+      await waitFor(() => {
+        const pendingTasksRows = BetterSqlite.selectFromTable('pendingTasks');
+        const pendingTaskType = pendingTasksRows?.[0]?.type;
+        const pendingTaskPayload = JSON.parse(pendingTasksRows?.[0]?.payload || '{}');
+        expect(pendingTaskType).toBe('delete-reaction');
+        expect(pendingTaskPayload[0]).toBe(targetMessage.id);
+      });
+    });
+
+    it('pending task should be cleared if deleteReaction request is succesful', async () => {
+      const reaction = generateReaction();
+      const targetMessage = channel.state.messages[0];
+
+      const { getByTestId } = render(
+        <Chat client={chatClient} enableOfflineSupport>
+          <Channel channel={channel}>
+            <CallbackEffectWithContext
+              callback={async ({ deleteReaction }) => {
+                useMockedApis(chatClient, [deleteReactionApi(targetMessage, reaction)]);
+                await deleteReaction(reaction.type, targetMessage.id);
+              }}
+              context={MessagesContext}
+            >
+              <View testID='children' />
+            </CallbackEffectWithContext>
+          </Channel>
+        </Chat>,
+      );
+      await waitFor(() => expect(getByTestId('children')).toBeTruthy());
+
+      await waitFor(() => {
+        const pendingTasksRows = BetterSqlite.selectFromTable('pendingTasks');
+        expect(pendingTasksRows.length).toBe(0);
+      });
+    });
+  });
+
+  it('pending task should be executed after connection is recovered', async () => {
+    const message = channel.state.messages[0];
+    const reaction = generateReaction();
+
+    const { getByTestId } = render(
+      <Chat client={chatClient} enableOfflineSupport>
+        <Channel channel={channel} initialValue={message.text}>
+          <CallbackEffectWithContext
+            callback={async ({ deleteMessage, sendReaction }) => {
+              useMockedApis(chatClient, [erroredDeleteApi()]);
+              try {
+                await deleteMessage(reaction);
+              } catch (e) {
+                // do nothing
+              }
+
+              useMockedApis(chatClient, [erroredPostApi()]);
+              try {
+                await sendReaction(reaction.type, message.id);
+              } catch (e) {
+                // do nothing
+              }
+            }}
+            context={MessagesContext}
+          >
+            <View testID='children' />
+          </CallbackEffectWithContext>
+        </Channel>
+      </Chat>,
+    );
+    await waitFor(() => expect(getByTestId('children')).toBeTruthy());
+
+    await waitFor(() => {
+      const pendingTasksRows = BetterSqlite.selectFromTable('pendingTasks');
+      expect(pendingTasksRows.length).toBe(2);
+    });
+
+    chatClient.deleteMessage = jest.fn();
+    channel.sendReaction = jest.fn();
+
+    act(() => dispatchConnectionChangedEvent(chatClient, true));
+
+    await waitFor(() => {
+      expect(chatClient.deleteMessage).toHaveBeenCalled();
+      expect(channel.sendReaction).toHaveBeenCalled();
+    });
+  });
+});

package/src/components/Attachment/GalleryImage.tsx

@@ -4,7 +4,7 @@ import { Image, ImageProps } from 'react-native';
 import { ChatContextValue, useChatContext } from '../../contexts/chatContext/ChatContext';
 
 import type { DefaultStreamChatGenerics } from '../../types/types';
-import { getUrlWithoutParams, makeImageCompatibleUrl } from '../../utils/utils';
+import { getUrlWithoutParams, isLocalUrl, makeImageCompatibleUrl } from '../../utils/utils';
 
 export type GalleryImageWithContextProps<
   StreamChatGenerics extends DefaultStreamChatGenerics = DefaultStreamChatGenerics,
@@ -13,8 +13,20 @@ export type GalleryImageWithContextProps<
 export const GalleryImageWithContext: React.FC<GalleryImageWithContextProps> = (props) => {
   const { ImageComponent = Image, uri, ...rest } = props;
 
+  if (!isLocalUrl(uri)) {
+    return (
+      <ImageComponent
+        {...rest}
+        accessibilityLabel='Gallery Image'
+        source={{
+          uri: makeImageCompatibleUrl(uri),
+        }}
+      />
+    );
+  }
+
   return (
-    <ImageComponent
+    <Image
       {...rest}
       accessibilityLabel='Gallery Image'
       source={{