stimeo-ui 0.5.0 → 0.6.0

package/dist/inspector/cli.d.ts

@@ -227,9 +227,11 @@ interface DocumentCondition {
  * A single accessibility requirement on a controller's markup (Inspector
  * stage 3). At least one of {@link attrs} must be present on the
  * {@link target} element; when {@link values} is given, the present
- * attribute's value must be one of them. {@link or} widens the requirement
- * with alternative attribute/value groups — the requirement is satisfied when
- * *any* group is (e.g. `role="status"` **or** `aria-live`).
+ * attribute's value must be one of them, and when it is not, the value must be
+ * non-empty — ARIA derives no name from `aria-label=""`, so an empty value
+ * leaves the requirement unmet. {@link or} widens the requirement with
+ * alternative attribute/value groups — the requirement is satisfied when *any*
+ * group is (e.g. `role="status"` **or** `aria-live`).
  */
 interface A11yRequirement {
     /**
@@ -597,6 +599,15 @@ interface ConditionalTargetRule {
     readonly whenPresent: string;
     /** Targets that become required once {@link whenPresent} appears. */
     readonly require: readonly string[];
+    /**
+     * Require each {@link require} entry to sit **inside** the `whenPresent`
+     * element rather than anywhere in the scope.
+     *
+     * A `<template>` is cloned at runtime, so a part declared outside it never
+     * reaches the clone. Without this the presence check passes on markup the
+     * controller then refuses to build from.
+     */
+    readonly requireInside?: boolean;
     /** Human-readable fix suggestion shown by the CLI (stage 4). */
     readonly suggestion: string;
 }
@@ -616,6 +627,8 @@ interface ValueConstraint {
     readonly finite?: boolean;
     /** Require a decoded number strictly greater than this bound. */
     readonly greaterThan?: number;
+    /** Require a decoded number with no fractional part. */
+    readonly integer?: boolean;
     /** Human-readable fix suggestion shown by the CLI (stage 4). */
     readonly suggestion: string;
 }

package/dist/inspector/cli.js

@@ -967,6 +967,12 @@ var DIAGNOSTIC_CODES = [
 ];
 
 // src/inspector/check.ts
+function isInside(node, ancestor) {
+  for (let current = node.parent; current; current = current.parent) {
+    if (current === ancestor) return true;
+  }
+  return false;
+}
 function checkSource(source, manifest) {
   const diagnostics = [];
   const tree = parseHtml(neutralizeErb(source), erbElements(source));
@@ -1364,13 +1370,16 @@ function checkSource(source, manifest) {
     const present = presence.get(node)?.get(identifier) ?? /* @__PURE__ */ new Set();
     for (const rule of controller.conditionalTargets) {
       if (!present.has(rule.whenPresent)) continue;
-      const missing = rule.require.filter((target) => !present.has(target));
+      const nodesOf = (target) => targetNodes.get(node)?.get(identifier)?.get(target) ?? [];
+      const owners = nodesOf(rule.whenPresent);
+      const satisfied = (target) => rule.requireInside ? nodesOf(target).some((el) => owners.some((owner) => isInside(el, owner))) : present.has(target);
+      const missing = rule.require.filter((target) => !satisfied(target));
       if (missing.length === 0) continue;
       report(
         node,
         "missing-conditional-target",
         complete ? "error" : "warning",
-        `"${identifier}" has a "${rule.whenPresent}" target, which also requires ${list(missing)}.`,
+        rule.requireInside ? `"${identifier}" requires ${list(missing)} inside its "${rule.whenPresent}".` : `"${identifier}" has a "${rule.whenPresent}" target, which also requires ${list(missing)}.`,
         node,
         complete ? rule.suggestion : UNRESOLVED_TARGET_HINT
       );
@@ -1388,7 +1397,7 @@ function checkSource(source, manifest) {
         if (!hasReadableMarkup(el)) continue;
         if (!contentHolds(node, identifier, el, req.whenContains)) continue;
         if (!elementHolds(el, req.whenElement)) continue;
-        checkA11y(report, el, identifier, req, severity);
+        checkA11y(report, el, identifier, req, severity, isDynamicValue);
       }
     }
   }
@@ -1682,6 +1691,7 @@ function valueSatisfiesConstraint(raw, constraint) {
   if (Number.isNaN(value)) return false;
   if (constraint.finite && !Number.isFinite(value)) return false;
   if (constraint.greaterThan !== void 0 && !(value > constraint.greaterThan)) return false;
+  if (constraint.integer && !Number.isInteger(value)) return false;
   return true;
 }
 function decodeNumericValue(raw) {
@@ -1692,6 +1702,7 @@ function describeValueConstraint(constraint) {
   if (constraint.greaterThan !== void 0) {
     parts.push(`greater than ${constraint.greaterThan}`);
   }
+  if (constraint.integer) parts.push("with no fractional part");
   return parts.join(" ");
 }
 var UNRESOLVED_TARGET_HINT = "Part of this scope is rendered by a helper or a non-literal data: hash, so the target may exist at runtime.";
@@ -1699,7 +1710,7 @@ var UNRESOLVED_HOST_HINT = "An enclosing helper's data: option is not a literal
 function hasReadableMarkup(el) {
   return el.origin === "markup";
 }
-function checkA11y(report, el, identifier, req, severity) {
+function checkA11y(report, el, identifier, req, severity, isDynamicValue) {
   const groups = [
     { attrs: req.attrs, values: req.values },
     ...req.or ?? []
@@ -1719,9 +1730,14 @@ function checkA11y(report, el, identifier, req, severity) {
   }
   const invalid = [];
   let anyPresent = false;
+  let blank;
   for (const [name, allowed] of allowedByAttr) {
     const attr = el.attrs.find((a) => a.name === name);
     if (!attr) continue;
+    if (allowed.anyValue && attr.value.trim() === "" && !isDynamicValue(attr)) {
+      blank ??= attr;
+      continue;
+    }
     anyPresent = true;
     if (!allowed.anyValue && !allowed.values.has(attr.value.trim())) {
       invalid.push({ attr, values: [...allowed.values] });
@@ -1733,8 +1749,8 @@ function checkA11y(report, el, identifier, req, severity) {
       el,
       "missing-aria",
       severity,
-      `"${identifier}" ${verb} ${describeAttrs([...allowedByAttr.keys()])} on its ${where}.`,
-      el,
+      blank ? `${blank.name} is empty on the ${where} of "${identifier}", which ${verb} a value there.` : `"${identifier}" ${verb} ${describeAttrs([...allowedByAttr.keys()])} on its ${where}.`,
+      blank ?? el,
       req.suggestion
     );
     return;