stated-protocol 5.2.1 → 5.3.1

package/src/rating.test.ts

@@ -1,6 +1,7 @@
 import { describe, it } from 'node:test';
 import assert from 'node:assert';
 import { parseRating, buildRating } from './protocol';
+import { isRatingValue } from './types';
 
 const randomUnicodeString = () =>
   Array.from({ length: 20 }, () => String.fromCharCode(Math.floor(Math.random() * 65536)))
@@ -13,7 +14,10 @@ describe('Rating building', () => {
       { length: 4 },
       randomUnicodeString
     );
-    const rating = Math.ceil(Math.random() * 5);
+    const rating = Math.floor(Math.random() * 5) + 1;
+    if (!isRatingValue(rating)) {
+      throw new Error(`Generated invalid rating: ${rating}`);
+    }
     const ratingContent = buildRating({ subjectName, subjectReference, rating, comment, quality });
     const parsedRating = parseRating(ratingContent);
     assert.strictEqual(parsedRating.subjectName, subjectName);

package/src/signature.ts

@@ -150,9 +150,9 @@ export const verifySignedStatement = async (signedStatement: string): Promise<bo
  * @returns Base64 string
  */
 function bytesToBase64(bytes: Uint8Array): string {
-  // Use btoa if available (browser), otherwise use Buffer (Node.js)
   if (typeof btoa !== 'undefined') {
-    return btoa(String.fromCharCode(...Array.from(bytes)));
+    const binaryString = Array.from(bytes, byte => String.fromCharCode(byte)).join('');
+    return btoa(binaryString);
   } else {
     return Buffer.from(bytes).toString('base64');
   }

package/src/types.ts

@@ -55,7 +55,8 @@ export type StatementTypeValue =
   | 'dispute_statement_content'
   | 'dispute_statement_authenticity'
   | 'rating'
-  | 'sign_pdf';
+  | 'sign_pdf'
+  | 'observation';
 
 export type Statement = {
   domain: string;
@@ -152,7 +153,7 @@ export type ResponseContent = {
   response: string;
 };
 
-export type PDFSigning = {};
+export type PDFSigning = Record<string, never>;
 
 export type RatingSubjectTypeValue =
   | 'Organisation'
@@ -181,3 +182,9 @@ export type Bounty = {
   judge: string;
   judgePay?: string;
 };
+
+export type Observation = {
+  subject: string;
+  property: string;
+  value: string;
+};

package/src/utils.test.ts

@@ -9,7 +9,7 @@ import {
   generateStatementHash,
   validateStatementHash,
   generateStatementsFile,
-  parseStatementsFile,
+  splitStatements,
   generateStatementFilename,
   generateAttachmentFilename,
 } from './utils';
@@ -118,22 +118,17 @@ describe('Statement Utils', () => {
       assert.ok(statementsFile.includes('\n\n'));
     });
 
-    it('should parse statements file', () => {
+    it('should split statements file', () => {
       const statementsFile = generateStatementsFile([statement1, statement2]);
-      const parsed = parseStatementsFile(statementsFile);
+      const parsed = splitStatements(statementsFile);
       assert.strictEqual(parsed.length, 2);
       assert.strictEqual(parsed[0], statement1);
       assert.strictEqual(parsed[1], statement2);
     });
 
-    it('should throw error for invalid statement in file', () => {
-      const invalidFile = 'Invalid statement\n\nAnother invalid statement';
-      assert.throws(() => parseStatementsFile(invalidFile));
-    });
-
-    it('should filter empty statements', () => {
+    it('should filter empty statements when splitting', () => {
       const fileWithEmpty = statement1 + '\n\n\n\n' + statement2;
-      const parsed = parseStatementsFile(fileWithEmpty);
+      const parsed = splitStatements(fileWithEmpty);
       assert.strictEqual(parsed.length, 2);
     });
   });

package/src/utils.ts

@@ -1,7 +1,6 @@
 import { peopleCountBuckets } from './constants';
 
 import { sha256, verify } from './hash';
-import { parseStatement } from './protocol';
 
 export const generateFileHash = (fileContent: Buffer | string): string => {
   return sha256(fileContent);
@@ -42,7 +41,7 @@ export const generateStatementsFile = (statements: string[]): string => {
   return statements.join('\n\n');
 };
 
-export const parseStatementsFile = (statementsFileContent: string): string[] => {
+export const splitStatements = (statementsFileContent: string): string[] => {
   const statementParts = statementsFileContent.split(/\n\nStated protocol version: /);
   const statements: string[] = [];
 
@@ -57,14 +56,7 @@ export const parseStatementsFile = (statementsFileContent: string): string[] =>
 
     statement = statement.replace(/\n+$/, '\n');
 
-    try {
-      parseStatement({ statement });
-      statements.push(statement);
-    } catch (error) {
-      throw new Error(
-        `Invalid statement at index ${i}: ${error instanceof Error ? error.message : String(error)}`
-      );
-    }
+    statements.push(statement);
   }
 
   return statements;