start-vibing 2.0.32 → 2.0.34

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "start-vibing",
-	"version": "2.0.32",
+	"version": "2.0.34",
 	"description": "Setup Claude Code agents, skills, and hooks in your project. Smart copy that preserves your custom domains and configurations.",
 	"type": "module",
 	"bin": {

package/template/.claude/hooks/stop-validator.ts

@@ -1225,7 +1225,7 @@ WORKFLOW
 		// continue: true tells Claude to KEEP WORKING after receiving this block
 		const result: HookResult = { continue: true, decision: 'block', reason: blockReason.trim() };
 		console.log(JSON.stringify(result));
-		process.exit(2);
+		process.exit(0); // Must be 0 for JSON to be processed - exit 2 ignores JSON!
 	}
 
 	// All validations passed

package/template/.claude/skills/codebase-knowledge/domains/claude-system.md

@@ -2,9 +2,9 @@
 
 ## Last Update
 
-- **Date:** 2026-01-03
-- **Commit:** d429772
-- **Session:** Universal hook runner with multi-runtime fallback support
+- **Date:** 2026-01-06
+- **Commit:** 77e2263
+- **Session:** Fixed stop hook exit code from 2 to 0 for proper JSON processing
 
 ## Files
 
@@ -86,14 +86,45 @@
 
 | Hash    | Date       | Description                                                           |
 | ------- | ---------- | --------------------------------------------------------------------- |
+| 77e2263 | 2026-01-06 | fix: stop hook exit code from 2 to 0 for JSON processing              |
 | d429772 | 2026-01-03 | feat(agents): restructure agent system with 82 specialized sub-agents |
 | 70ca50f | 2026-01-02 | feat(start-vibing): auto-install Claude Code and self-update          |
 | 5c74c95 | 2026-01-02 | feat: add specialized agents and progressive disclosure to skills     |
 | b5c483b | 2026-01-02 | docs: add agents/skills comparison research with industry benchmarks  |
-| 0f2c1ff | 2026-01-02 | fix: block ALL changes on main branch, not just protected files       |
 
 ## Problems & Solutions
 
+### 2026-01-06 - Stop Hook Exit Code Fix
+
+**Problem:**
+When stop hook blocked task completion, Claude was just stopping instead of continuing to fix the issues. The message "Stop hook prevented continuation" appeared but Claude didn't take action.
+
+**Root Cause:**
+Stop hook was using `process.exit(2)` which causes Claude Code to **ignore the JSON output**. The `decision: "block"` with `reason` was being sent correctly, but exit code 2 made Claude ignore it and only show stderr.
+
+**Solution:**
+Changed exit code from 2 to 0 in `stop-validator.ts`:
+
+```typescript
+// Before: process.exit(2);
+process.exit(0); // Must be 0 for JSON to be processed!
+```
+
+**Key Insight:**
+- Exit code 0: JSON stdout is processed (decision, reason fields work)
+- Exit code 2: JSON stdout is IGNORED, only stderr shown
+
+**Files Modified:**
+- `.claude/hooks/stop-validator.ts` - Changed exit(2) to exit(0) on line 1228
+- `.claude/skills/hook-development/SKILL.md` - Updated documentation with correct exit code guidance
+
+**Prevention:**
+- Always use exit(0) for Stop hooks that want Claude to continue
+- Use `decision: "block"` in JSON to block, not exit code 2
+- Exit code 2 is only for PreToolUse hooks (blocks specific tool call)
+
+---
+
 ### 2026-01-03 - Universal Hook Runner with Multi-Runtime Fallback
 
 **Problem:**

package/template/.claude/skills/hook-development/SKILL.md

@@ -107,10 +107,12 @@ Event-specific fields:
 
 | Code | Meaning | Behavior |
 |------|---------|----------|
-| 0 | Success | stdout appears in transcript |
-| 2 | Blocking error | stderr feeds back to Claude for action |
+| 0 | Success | JSON stdout is processed (decision, reason, continue fields) |
+| 2 | Blocking error | JSON stdout is IGNORED, only stderr shown to Claude |
 | Other | Non-blocking error | Hook failed, but doesn't block |
 
+**IMPORTANT for Stop Hooks:** To make Claude CONTINUE working after a block, use exit(0) with `decision: "block"` in JSON. Exit code 2 ignores JSON, so Claude just stops instead of fixing issues.
+
 ---
 
 ## Environment Variables
@@ -164,13 +166,20 @@ const cmd = `cat ${filePath}`;   // WRONG - injection risk
 ### Error Handling
 
 ```typescript
-// For blocking errors - use exit code 2
+// For Stop hooks - use JSON with decision: "block" + exit(0)
+// This makes Claude CONTINUE working to fix the issues
 if (validationFailed) {
-  process.stderr.write(errorMessage);
-  process.exit(2); // Blocks and shows to Claude
+  console.log(JSON.stringify({ decision: 'block', reason: errorMessage }));
+  process.exit(0); // Must be 0 for JSON to be processed!
+}
+
+// For PreToolUse hooks - exit(2) blocks the specific tool operation
+if (dangerousOperation) {
+  process.stderr.write('BLOCKED: Dangerous operation');
+  process.exit(2); // Blocks this tool call only
 }
 
-// For non-blocking errors
+// For non-blocking warnings
 if (warningCondition) {
   console.error('Warning:', message);
   process.exit(1); // Logs but doesn't block
@@ -199,20 +208,24 @@ async function main(): Promise<void> {
   const error = validateSomething();
 
   if (error) {
-    // Block with actionable message
-    const message = `
+    // Block and make Claude CONTINUE working to fix the issue
+    // IMPORTANT: Use exit(0) so JSON is processed. exit(2) ignores JSON!
+    const result: HookResult = {
+      decision: 'block',
+      reason: `
 ERROR: ${error.type}
 
 ${error.message}
 
 REQUIRED ACTION:
   Task(subagent_type="${error.agent}", prompt="${error.prompt}")
-`;
-    process.stderr.write(message);
-    process.exit(2); // Blocking
+`
+    };
+    console.log(JSON.stringify(result));
+    process.exit(0); // Must be 0 for JSON to be processed!
   }
 
-  // Success
+  // Success - allow task completion
   const result: HookResult = { decision: 'approve', reason: 'All checks passed' };
   console.log(JSON.stringify(result));
   process.exit(0);
@@ -289,8 +302,12 @@ const validations = [
 
 const firstError = validations.find(v => v !== null);
 if (firstError) {
-  process.stderr.write(formatError(firstError));
-  process.exit(2);
+  // Use JSON with decision: "block" + exit(0) so Claude CONTINUES fixing
+  console.log(JSON.stringify({
+    decision: 'block',
+    reason: formatError(firstError)
+  }));
+  process.exit(0); // NOT exit(2) - that ignores JSON!
 }
 ```