start-vibing 2.0.28 → 2.0.30

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "start-vibing",
-	"version": "2.0.28",
+	"version": "2.0.30",
 	"description": "Setup Claude Code agents, skills, and hooks in your project. Smart copy that preserves your custom domains and configurations.",
 	"type": "module",
 	"bin": {

package/template/.claude/hooks/stop-validator.ts

@@ -1037,62 +1037,65 @@ async function readStdinWithTimeout(timeoutMs: number): Promise<string> {
 }
 
 /**
- * Run validations in priority order and return the FIRST error found.
- * This ensures Claude fixes one issue at a time in the correct sequence.
+ * Collect ALL validation errors in priority order.
+ * Returns array of all errors found, empty if all passed.
  */
-function runValidationsInOrder(
+function collectAllErrors(
 	currentBranch: string,
 	modifiedFiles: string[],
 	sourceFiles: string[],
 	isMainBranch: boolean,
-	isCleanTree: boolean
-): ValidationError | null {
-	// PRIORITY ORDER - most critical first, one at a time
-	// Each validation returns early on first error
+	_isCleanTree: boolean
+): ValidationError[] {
+	const errors: ValidationError[] = [];
 
 	// 1. Branch validation - can't complete on feature branch
 	const branchError = validateBranch(currentBranch, modifiedFiles);
-	if (branchError) return branchError;
+	if (branchError) errors.push(branchError);
 
 	// 2. Git tree - must be clean (only check if on main)
 	if (isMainBranch) {
 		const treeError = validateGitTree(modifiedFiles);
-		if (treeError) return treeError;
+		if (treeError) errors.push(treeError);
 	}
 
 	// 3. CLAUDE.md must exist
 	const claudeMdExistsError = validateClaudeMdExists();
-	if (claudeMdExistsError) return claudeMdExistsError;
+	if (claudeMdExistsError) {
+		errors.push(claudeMdExistsError);
+		// If CLAUDE.md doesn't exist, skip other CLAUDE.md validations
+		return errors;
+	}
 
 	// 4. Check if template merge is needed
 	const templateMergeError = validateClaudeMdTemplateMerge();
-	if (templateMergeError) return templateMergeError;
+	if (templateMergeError) errors.push(templateMergeError);
 
 	// 5. CLAUDE.md size - must be under 40k
 	const sizeError = validateClaudeMdSize();
-	if (sizeError) return sizeError;
+	if (sizeError) errors.push(sizeError);
 
 	// 6. CLAUDE.md structure - must have required sections
 	const structureError = validateClaudeMdStructure();
-	if (structureError) return structureError;
+	if (structureError) errors.push(structureError);
 
 	// 7. Last Change must not be stacked
 	const lastChangeError = validateClaudeMdLastChange();
-	if (lastChangeError) return lastChangeError;
+	if (lastChangeError) errors.push(lastChangeError);
 
 	// 8. CLAUDE.md must be updated if files changed
 	const updatedError = validateClaudeMdUpdated(modifiedFiles);
-	if (updatedError) return updatedError;
+	if (updatedError) errors.push(updatedError);
 
 	// 9. Source files must be documented
 	const docError = validateDocumentation(sourceFiles);
-	if (docError) return docError;
+	if (docError) errors.push(docError);
 
 	// 10. Domain documentation must be complete
 	const domainDocError = validateDomainDocumentation(modifiedFiles);
-	if (domainDocError) return domainDocError;
+	if (domainDocError) errors.push(domainDocError);
 
-	return null; // All validations passed
+	return errors;
 }
 
 async function main(): Promise<void> {
@@ -1130,8 +1133,8 @@ async function main(): Promise<void> {
 
 	console.error(`[stop-validator] Branch: ${currentBranch}, Modified: ${modifiedFiles.length}`);
 
-	// Run validations in order - get FIRST error only
-	const error = runValidationsInOrder(
+	// Collect ALL errors to show summary
+	const allErrors = collectAllErrors(
 		currentBranch,
 		modifiedFiles,
 		sourceFiles,
@@ -1140,54 +1143,80 @@ async function main(): Promise<void> {
 	);
 
 	// ============================================================================
-	// OUTPUT RESULTS - ONE ERROR AT A TIME
+	// OUTPUT RESULTS - SHOW ALL ERRORS, DETAIL FIRST ONE
 	// ============================================================================
 
-	if (error) {
-		const subagentInfo = ERROR_TO_SUBAGENT[error.type] || {
+	if (allErrors.length > 0) {
+		const firstError = allErrors[0];
+		const subagentInfo = ERROR_TO_SUBAGENT[firstError.type] || {
 			agent: 'general-purpose',
 			prompt: 'Fix the validation error',
 		};
 
-		const blockReason = `
-================================================================================
-STOP VALIDATOR - BLOCKED (1 issue to fix)
-================================================================================
-
-**MANDATORY**: After fixing this issue, you MUST attempt to complete the task
-again so this hook can re-validate. DO NOT consider the task done until the
-stop hook returns "ALL CHECKS PASSED". Keep fixing issues one by one until
-all validations pass.
+		// Build summary of ALL errors
+		let errorSummary = '';
+		for (let i = 0; i < allErrors.length; i++) {
+			const err = allErrors[i];
+			const status = i === 0 ? '→ FIXING NOW' : '  (pending)';
+			errorSummary += `  ${i + 1}. [${err.type}] ${status}\n`;
+		}
 
+		// Build pending errors note (if more than 1)
+		let pendingNote = '';
+		if (allErrors.length > 1) {
+			pendingNote = `
 --------------------------------------------------------------------------------
+REMAINING ISSUES (${allErrors.length - 1} more after this one)
+--------------------------------------------------------------------------------
+
+After fixing the first issue, run the validator again to see details for the next:
+
+  Bash(command="npx tsx .claude/hooks/stop-validator.ts", description="Run validator to see next issue")
+
+`;
+		}
 
-ERROR: ${error.type}
+		const blockReason = `
+================================================================================
+STOP VALIDATOR - BLOCKED (${allErrors.length} issue${allErrors.length > 1 ? 's' : ''} found)
+================================================================================
 
-${error.message}
+**FIRST**: Create a TODO LIST to track fixing all ${allErrors.length} issues:
 
-${error.action}
+  TodoWrite(todos=[
+${allErrors.map((e, i) => `    { content: "Fix ${e.type}", status: "${i === 0 ? 'in_progress' : 'pending'}", activeForm: "Fixing ${e.type}" }`).join(',\n')}
+  ])
 
 --------------------------------------------------------------------------------
-STEP 1: Fix the issue using this subagent
+ALL ISSUES FOUND (in priority order)
 --------------------------------------------------------------------------------
 
-  Task(subagent_type="${subagentInfo.agent}", prompt="${subagentInfo.prompt}")
-
+${errorSummary}
 --------------------------------------------------------------------------------
-STEP 2: After fixing, run the validator MANUALLY to verify
+ISSUE #1 DETAILS (fix this first)
 --------------------------------------------------------------------------------
 
-  Bash(command="npx tsx .claude/hooks/stop-validator.ts", description="Run stop validator manually")
+ERROR: ${firstError.type}
 
-This will show if the fix worked or if there are more issues to resolve.
-DO NOT try to complete the task until the validator returns "ALL CHECKS PASSED".
+${firstError.message}
 
+${firstError.action}
+
+--------------------------------------------------------------------------------
+FIX USING THIS SUBAGENT
+--------------------------------------------------------------------------------
+
+  Task(subagent_type="${subagentInfo.agent}", prompt="${subagentInfo.prompt}")
+${pendingNote}
 --------------------------------------------------------------------------------
-STEP 3: Repeat Steps 1-2 until ALL CHECKS PASSED
+WORKFLOW
 --------------------------------------------------------------------------------
 
-Only after seeing "ALL CHECKS PASSED" from the manual validator run,
-you may proceed to complete the task.
+1. Create the TODO list above
+2. Fix issue #1 using the subagent
+3. Run: npx tsx .claude/hooks/stop-validator.ts
+4. If more issues, repeat for each one
+5. Only complete task when "ALL CHECKS PASSED"
 ================================================================================
 `;
 

package/template/.claude/hooks/user-prompt-submit.ts

@@ -31,10 +31,23 @@ const STRICT_WORKFLOW = `
 │ 6. DOCUMENT     → Document ALL modified files (MANDATORY)      │
 │ 7. UPDATE       → Update CLAUDE.md with session changes        │
 │ 8. QUALITY      → typecheck + lint + test (Husky enforced)     │
-│ 9. FINISH       → PR + merge to main (clean tree required)     │
+│ 9. VALIDATE     → RUN: npx tsx .claude/hooks/stop-validator.ts │
+│ 10. FINISH      → Only after "ALL CHECKS PASSED"               │
 └─────────────────────────────────────────────────────────────────┘
 
-⚠️  STOP HOOK ACTIVE - Task completion will be BLOCKED if:
+╔═════════════════════════════════════════════════════════════════╗
+║  ⚠️  MANDATORY: RUN STOP VALIDATOR BEFORE COMPLETING ANY TASK   ║
+╠═════════════════════════════════════════════════════════════════╣
+║                                                                 ║
+║  COMMAND: npx tsx .claude/hooks/stop-validator.ts               ║
+║                                                                 ║
+║  YOU MUST run this command manually BEFORE saying "task done".  ║
+║  Fix ALL issues one by one. Run validator again after EACH fix.║
+║  Only complete task when output shows "ALL CHECKS PASSED".      ║
+║                                                                 ║
+╚═════════════════════════════════════════════════════════════════╝
+
+⚠️  STOP HOOK BLOCKS task completion if:
     - NOT on main branch (PR must be merged first)
     - Git tree NOT clean (all changes must be committed)
     - CLAUDE.md NOT updated (must reflect session changes)