start-vibing 1.1.3 → 1.1.4

package/template/.claude/skills/final-check/SKILL.md

@@ -1,72 +1,284 @@
 ---
 name: final-check
-description: Final validation before commits. HAS VETO POWER. Activates when user says 'commit', 'ready to commit', 'finalize', 'done', or when workflow is near completion. Blocks if any validation fails.
+description: Final validation before task completion. Verifies all skills were consulted, documentation updated, tests pass. HAS VETO POWER - blocks incomplete tasks.
 allowed-tools: Read, Grep, Glob, Bash
 ---
 
-# Final Check
+# Final Check - Final Validation System
 
 ## VETO POWER
 
-This skill CAN and MUST block incomplete tasks.
+> **WARNING:** This skill HAS VETO POWER.
+> If rule violated, MUST:
+>
+> 1. STOP and list violations
+> 2. REQUIRE fix before approving
+> 3. Re-validate after fixes
 
-## When to Use
+---
+
+## Purpose
+
+This skill is the LAST check before task completion:
+
+- **Validates** all CLAUDE.md rules
+- **Verifies** all skills were consulted
+- **Confirms** documentation was updated
+- **Ensures** nothing was forgotten
+- **Blocks** incomplete tasks
+
+---
 
-- Before any commit
-- When user says task is "done"
-- After all other agents completed
+## Mega Validation Checklist
 
-## Mega Checklist
+### 1. CODEBASE-KNOWLEDGE
 
-### 1. Codebase Knowledge
-- [ ] Domain consulted before implementing?
-- [ ] Domain updated after implementing?
+- [ ] Affected domain consulted BEFORE implementing?
+- [ ] Domain file UPDATED after implementing?
 - [ ] Commit hash added?
+- [ ] Connections verified?
 
-### 2. Docs Tracker
-- [ ] Documentation updated?
-- [ ] Changelog entry added?
+### 2. DOCS-TRACKER
 
-### 3. Test Coverage
-- [ ] New files have tests?
-- [ ] All tests pass?
+- [ ] Changes detected via git diff?
+- [ ] New documentation created (if needed)?
+- [ ] Existing documentation updated?
+- [ ] Changelog updated?
+
+### 3. TEST-COVERAGE
+
+- [ ] New files have test or exemption?
+- [ ] New tRPC routes have unit test?
+- [ ] New pages have E2E spec?
+- [ ] E2E uses `auth.helper.ts` correctly?
 - [ ] No `.skip()` added?
+- [ ] All tests pass?
+
+### 4. UI-UX-AUDIT
 
-### 4. Security Scan
-- [ ] User ID from session?
-- [ ] No sensitive data to frontend?
-- [ ] Zod validation on routes?
+- [ ] Competitors researched (if UI)?
+- [ ] Accessibility validated?
+- [ ] Responsiveness tested?
+- [ ] Skeleton created (if new component)?
+- [ ] Zero horizontal overflow?
+
+### 5. SECURITY-SCAN
+
+- [ ] User ID always from session?
+- [ ] Sensitive data not sent to frontend?
+- [ ] Zod validation on all routes?
+- [ ] OWASP Top 10 verified?
+- [ ] No pending VETO?
+
+### 6. QUALITY-GATE
 
-### 5. Quality Gate
 - [ ] `bun run typecheck` passes?
 - [ ] `bun run lint` passes?
 - [ ] `bun run test` passes?
+- [ ] `bun run test:e2e` passes?
 - [ ] `bun run build` passes?
 
-### 6. UI/UX (if applicable)
-- [ ] Competitors researched?
-- [ ] Accessibility validated?
-- [ ] All viewports tested?
+---
 
-## Quick Validation
+## Checklist by Task Type
 
-```bash
-bun run typecheck && bun run lint && bun run test && bun run build
+### New Feature
+
+```markdown
+### Before Implementation
+
+- [ ] Consulted codebase-knowledge domain?
+- [ ] Researched competitors (if UI)?
+
+### During Implementation
+
+- [ ] Followed code patterns?
+- [ ] Created skeleton for components?
+- [ ] Validated inputs with Zod?
+- [ ] User ID always from session?
+
+### After Implementation
+
+- [ ] Created unit tests?
+- [ ] Created E2E tests?
+- [ ] Updated codebase-knowledge?
+- [ ] Updated docs/flows (if applicable)?
+- [ ] Ran full quality-gate?
+- [ ] Security-scan approved?
+```
+
+### Bug Fix
+
+```markdown
+### Before
+
+- [ ] Consulted affected domain?
+- [ ] Identified root cause?
+
+### During
+
+- [ ] Fix is minimal and focused?
+- [ ] Doesn't introduce regression?
+
+### After
+
+- [ ] Test covering the bug?
+- [ ] Updated domain with commit?
+- [ ] Quality-gate passes?
+```
+
+### Refactor
+
+```markdown
+### Before
+
+- [ ] Consulted affected domains?
+- [ ] Mapped all dependencies?
+
+### During
+
+- [ ] Maintained existing behavior?
+- [ ] Didn't break tests?
+
+### After
+
+- [ ] All tests pass?
+- [ ] Updated affected domains?
+- [ ] Quality-gate passes?
+```
+
+---
+
+## Validation Flow
+
+```
+TASK COMPLETE? (developer thinks done)
+        ↓
+1. VERIFY CODEBASE-KNOWLEDGE → Consulted? Updated?
+        ↓
+2. VERIFY DOCS-TRACKER → Docs updated? Changelog?
+        ↓
+3. VERIFY TEST-COVERAGE → All files have tests? Pass?
+        ↓
+4. VERIFY UI-UX-AUDIT (if UI) → Research? Accessibility?
+        ↓
+5. VERIFY SECURITY-SCAN → No VETO? OWASP OK?
+        ↓
+6. VERIFY QUALITY-GATE → All checks pass?
+        ↓
+    ┌─────────┴─────────┐
+    ↓                   ↓
+VIOLATION           ALL OK
+→ VETO              → APPROVED
+→ LIST ISSUES       → CAN COMMIT
 ```
 
-## Output
+---
+
+## Output Format
+
+### Approved
+
+```markdown
+## FINAL CHECK - APPROVED
+
+### Task Summary
+
+- **Type:** Feature
+- **Domain:** [domain]
+- **Files:** X modified
+
+### Verifications
+
+- [x] Codebase-Knowledge: Consulted and updated
+- [x] Docs-Tracker: Changelog updated
+- [x] Test-Coverage: Unit 3/3, E2E 2/2 pass
+- [x] UI-UX-Audit: Competitors researched, accessible
+- [x] Security-Scan: No vulnerabilities
+- [x] Quality-Gate: All checks pass
+
+**STATUS: APPROVED** - Ready to commit
+```
 
-**APPROVED:** All checks pass → ready to commit
-**VETOED:** Violations found → fix before commit
+### Vetoed
+
+```markdown
+## FINAL CHECK - VETOED
+
+### Task Summary
+
+- **Type:** Feature
+- **Domain:** [domain]
+
+### Violations Found
+
+#### ❌ Codebase-Knowledge
+
+- **Violation:** Domain NOT updated after implementation
+- **Action:** Update domain file with commit hash
+
+#### ❌ Test-Coverage
+
+- **Violation:** New file without test
+- **File:** `components/NewComponent.tsx`
+- **Action:** Create E2E spec
+
+**STATUS: VETOED** - 2 violations. Fix before commit.
+
+### Next Steps
+
+1. Update domain file
+2. Create test for new component
+3. Re-run final-check
+```
+
+---
 
 ## VETO Rules
 
-### Immediate VETO
-- Security vulnerability found
-- Tests failing
-- Build failing
-- Domain not updated
+### IMMEDIATE VETO
+
+1. Security-scan found critical vulnerability
+2. Quality-gate doesn't pass
+3. Tests failing
+4. Codebase-knowledge not updated
+
+### VETO BEFORE MERGE
+
+1. Docs not updated
+2. Skeleton missing (if new component)
+3. Changelog not updated
+
+### WARNING (No veto)
+
+1. Coverage below ideal (but critical tests exist)
+2. Optional docs missing
+
+---
+
+## Quick Command
+
+```bash
+# Run full validation
+bun run typecheck && bun run lint && bun run test && bun run test:e2e && bun run build
+
+# If all pass, manually verify:
+# - codebase-knowledge updated?
+# - docs updated?
+# - skeleton created?
+```
+
+---
+
+## Critical Rules
+
+1. **HAS VETO POWER** - Last barrier before commit
+2. **VERIFIES EVERYTHING** - All skills, all rules
+3. **NO EXCUSES** - Rule is rule
+4. **DOCUMENTS VIOLATIONS** - For learning
+
+---
+
+## Version
 
-### VETO Before Merge
-- Docs not updated
-- Changelog missing
+- **v2.0.0** - Generic template

package/template/.claude/skills/quality-gate/SKILL.md

@@ -1,71 +1,278 @@
 ---
 name: quality-gate
-description: Runs code quality checks (typecheck, lint, tests, build). Activates when user says 'check quality', 'run tests', 'typecheck', 'lint', 'build', or before any commit to validate code passes all gates.
+description: Automates quality checks (typecheck, lint, tests, build) and blocks commits that don't pass. Use before any commit to validate code quality.
 allowed-tools: Bash, Read, Grep
 ---
 
-# Quality Gate
+# Quality Gate - Quality Verification System
 
-## When to Use
+## Purpose
 
-- Before committing changes
-- After implementation
-- When user asks to "check", "validate", or "run tests"
+This skill automates quality checks:
 
-## Commands (Run in Order)
+- **Typecheck** - TypeScript errors
+- **Lint** - Code patterns (ESLint)
+- **Build** - Build verification
+- **Tests** - Unit and E2E tests
+- **Blocks** commits that don't pass
+
+---
+
+## Commands
+
+### 1. TypeScript Check
 
 ```bash
-# 1. TypeScript
 bun run typecheck
+# or
+bunx tsc --noEmit
+```
+
+### 2. ESLint Check
 
-# 2. ESLint
+```bash
 bun run lint
+# or
+bunx eslint . --ext .ts,.tsx
+```
+
+### 3. Build Check
+
+```bash
+bun run build
+```
 
-# 3. Unit Tests
+### 4. Unit Tests
+
+```bash
 bun run test
+# or
+bunx vitest run
+```
 
-# 4. E2E Tests
-bun run test:e2e
+### 5. E2E Tests
 
-# 5. Build
-bun run build
+```bash
+bun run test:e2e
+# or
+bunx playwright test
 ```
 
-### All at Once
+### 6. All Checks (RECOMMENDED)
 
 ```bash
 bun run typecheck && bun run lint && bun run test && bun run test:e2e && bun run build
 ```
 
+---
+
 ## Execution Flow
 
 ```
-TYPECHECK → LINT → TESTS → E2E → BUILD
-     ↓ fail    ↓ fail   ↓ fail  ↓ fail  ↓ fail
-   STOP      STOP      STOP    STOP    STOP
+1. TYPECHECK → If fail: STOP and list errors
+        ↓
+2. LINT → If fail: STOP and list errors
+        ↓
+3. UNIT TESTS → If fail: STOP and list failures
+        ↓
+4. E2E TESTS → If fail: STOP and list failures
+        ↓
+5. BUILD → If fail: STOP and list errors
+        ↓
+RESULT: ✅ APPROVED or ❌ REJECTED
+```
+
+---
+
+## Common TypeScript Errors
+
+### Type 'X' is not assignable to type 'Y'
+
+```typescript
+// ERROR
+const value: string = 123;
+
+// FIX
+const value: number = 123;
+```
+
+### Object is possibly 'undefined'
+
+```typescript
+// ERROR
+const name = user.name.toUpperCase();
+
+// FIX
+const name = user?.name?.toUpperCase() ?? '';
 ```
 
-## Common Fixes
+### Property 'X' does not exist on type 'Y'
 
-### TypeScript: Object possibly undefined
 ```typescript
-// Fix: use optional chaining
-const name = user?.name ?? '';
+// ERROR
+const age = user.age; // age doesn't exist
+
+// FIX
+interface User {
+	name: string;
+	age?: number;
+}
 ```
 
-### ESLint: no-explicit-any
+---
+
+## Common ESLint Errors
+
+### @typescript-eslint/no-explicit-any
+
 ```typescript
-// Fix: use unknown
+// ERROR
+function parse(data: any) {}
+
+// FIX
 function parse(data: unknown) {}
 ```
 
-## Output
+### @typescript-eslint/no-unused-vars
+
+```typescript
+// ERROR
+const unused = 'value';
+
+// FIX - remove or prefix with _
+const _unused = 'value';
+```
+
+### react-hooks/exhaustive-deps
+
+```typescript
+// ERROR
+useEffect(() => {
+	fetchData(userId);
+}, []); // missing userId
+
+// FIX
+useEffect(() => {
+	fetchData(userId);
+}, [userId]);
+```
+
+---
+
+## Output Format
+
+### Approved
+
+```markdown
+## QUALITY GATE - APPROVED
+
+### Checks Executed
+
+| Check      | Status        | Time  |
+| ---------- | ------------- | ----- |
+| TypeScript | ✅ Pass       | 3.2s  |
+| ESLint     | ✅ Pass       | 5.1s  |
+| Unit Tests | ✅ 42/42 Pass | 8.3s  |
+| E2E Tests  | ✅ 15/15 Pass | 45.2s |
+| Build      | ✅ Pass       | 32.1s |
+
+**STATUS: APPROVED** - Ready to commit
+```
+
+### Rejected
+
+```markdown
+## QUALITY GATE - REJECTED
+
+### Checks Executed
+
+| Check      | Status      |
+| ---------- | ----------- |
+| TypeScript | ❌ 3 errors |
+
+### TypeScript Errors
+
+#### Error 1: server/routers/example.ts:45
+```
+
+Type 'string | undefined' is not assignable to type 'string'.
+
+````
+
+**Suggested fix:**
+```typescript
+const name: string = input.name ?? "";
+````
+
+**STATUS: REJECTED** - Fix 3 errors before commit
+
+````
+
+---
+
+## Quick Checks
+
+### Fast Check (typecheck + lint only)
+```bash
+bun run typecheck && bun run lint
+````
+
+### Full Check (everything)
+
+```bash
+bun run typecheck && bun run lint && bun run test && bun run test:e2e && bun run build
+```
+
+### Modified Files Only
+
+```bash
+git diff --name-only | grep -E "\.(ts|tsx)$" | xargs bunx eslint
+```
+
+---
 
-**APPROVED:** All checks pass → ready to commit
-**REJECTED:** Fix errors before proceeding
+## Pre-Commit Checklist
+
+- [ ] `bun run typecheck` passes?
+- [ ] `bun run lint` passes?
+- [ ] `bun run test` passes?
+- [ ] `bun run test:e2e` passes?
+- [ ] `bun run build` passes?
+- [ ] No `any` in code?
+- [ ] No unused variables?
+- [ ] No debug console.log?
+
+---
+
+## Scripts (package.json)
+
+```json
+{
+	"scripts": {
+		"typecheck": "tsc --noEmit",
+		"lint": "eslint . --ext .ts,.tsx",
+		"lint:fix": "eslint . --ext .ts,.tsx --fix",
+		"test": "vitest run",
+		"test:watch": "vitest",
+		"test:e2e": "playwright test",
+		"test:e2e:ui": "playwright test --ui",
+		"test:all": "bun run typecheck && bun run lint && bun run test && bun run test:e2e",
+		"build": "next build"
+	}
+}
+```
+
+---
+
+## Critical Rules
+
+1. **NEVER commit with errors** - All checks must pass
+2. **RUN IN ORDER** - typecheck → lint → test → e2e → build
+3. **FIX IMMEDIATELY** - Errors cannot accumulate
+4. **DON'T USE --force** - Solve problems, don't ignore
+
+---
 
-## Rules
+## Version
 
-1. **Never commit with errors**
-2. **Run in order** - stop at first failure
-3. **Don't use --force** - solve problems properly
+- **v2.0.0** - Generic template