start-vibing 1.1.2 → 1.1.3

package/template/.claude/hooks/stop-validation.py

@@ -1,155 +0,0 @@
-#!/usr/bin/env python3
-"""
-Stop Hook - Workflow Validation Before Stopping
-
-This hook validates that the workflow was properly executed before
-allowing Claude to stop. If validation fails, Claude is forced to continue.
-
-Exit codes:
-- 0: Allow stop (or output JSON to block)
-"""
-
-import json
-import sys
-import os
-from pathlib import Path
-
-PROJECT_DIR = os.environ.get('CLAUDE_PROJECT_DIR', os.getcwd())
-WORKFLOW_STATE_PATH = Path(PROJECT_DIR) / '.claude' / 'workflow-state.json'
-
-
-def load_workflow_state():
-    """Load current workflow state"""
-    if not WORKFLOW_STATE_PATH.exists():
-        return None
-    try:
-        with open(WORKFLOW_STATE_PATH) as f:
-            return json.load(f)
-    except (json.JSONDecodeError, IOError):
-        return None
-
-
-def validate_workflow(state: dict) -> tuple[bool, list[str]]:
-    """Validate workflow completion"""
-    issues = []
-
-    if not state or not state.get('currentTask'):
-        # No task, allow stop
-        return True, []
-
-    task = state['currentTask']
-    task_type = task.get('type', 'feature')
-    agents = task.get('agents', {})
-    modified_files = task.get('modifiedFiles', [])
-
-    # Skip validation for research/config tasks
-    if task_type in ['research', 'config']:
-        return True, []
-
-    # Check required agents executed
-    required_agents = {
-        'feature': ['orchestrator', 'analyzer', 'research', 'tester', 'securityAuditor', 'qualityChecker', 'finalValidator', 'domainUpdater'],
-        'fix': ['analyzer', 'research', 'tester', 'securityAuditor', 'qualityChecker', 'finalValidator', 'domainUpdater'],
-        'refactor': ['analyzer', 'tester', 'qualityChecker', 'finalValidator', 'domainUpdater'],
-    }
-
-    for agent in required_agents.get(task_type, []):
-        agent_status = agents.get(agent, {})
-        if not agent_status.get('executed'):
-            issues.append(f"Agent '{agent}' has not executed")
-        elif agent_status.get('result') == 'vetoed':
-            issues.append(f"Agent '{agent}' VETOED - must resolve before stopping")
-
-    # Check if files were modified without tests
-    if modified_files and task_type in ['feature', 'fix']:
-        tests_created = task.get('testsCreated', [])
-        # Exclude: tests, specs, docs, markdown, and .claude config files
-        source_files = [m for m in modified_files if not any(
-            p in m['path'].lower() for p in ['test', 'spec', '.md', 'docs/', '.claude/']
-        )]
-
-        if source_files and not tests_created:
-            issues.append(f"Modified {len(source_files)} source file(s) but no tests created")
-
-    # Check documentation (skip for .claude config files)
-    if modified_files and task_type == 'feature':
-        non_config_files = [m for m in modified_files if '.claude/' not in m['path']]
-        if non_config_files:
-            docs_updated = task.get('docsUpdated', [])
-            if not docs_updated:
-                issues.append("No documentation updated for feature")
-
-    # Check quality gates
-    quality = task.get('qualityGates', {})
-    for gate in ['typecheck', 'lint', 'build']:
-        gate_result = quality.get(gate, {})
-        if gate_result and not gate_result.get('passed'):
-            issues.append(f"Quality gate '{gate}' failed")
-
-    # Check security audit
-    security = task.get('securityAudit', {})
-    if security.get('result') == 'vetoed':
-        issues.append("Security audit VETOED - must resolve vulnerabilities")
-
-    # Check final validation
-    final = task.get('finalValidation', {})
-    if final.get('executed') and not final.get('readyToCommit'):
-        issues.append("Final validation not approved for commit")
-
-    # Check domain-updater (critical for knowledge retention)
-    domain_updater = agents.get('domainUpdater', {})
-    if modified_files and not domain_updater.get('executed'):
-        issues.append("Domain updater has not run - domains must be updated with session learnings")
-
-    # Check commit-manager (critical for persisting changes - FINAL step)
-    commit_manager = agents.get('commitManager', {})
-    if domain_updater.get('executed') and not commit_manager.get('executed'):
-        issues.append("Commit-manager has not run - changes must be committed before session ends")
-
-    return len(issues) == 0, issues
-
-
-def main():
-    # Read hook input
-    try:
-        hook_input = json.load(sys.stdin)
-    except json.JSONDecodeError:
-        sys.exit(0)
-
-    # Load state
-    state = load_workflow_state()
-
-    # Validate
-    is_valid, issues = validate_workflow(state)
-
-    if is_valid:
-        # Allow stop
-        sys.exit(0)
-    else:
-        # Block stop and force continuation
-        output = {
-            "decision": "block",
-            "reason": f"""WORKFLOW INCOMPLETE - Cannot stop yet.
-
-Issues found:
-{chr(10).join(f'  ❌ {issue}' for issue in issues)}
-
-You must complete these steps before stopping:
-1. Execute all required agents
-2. Resolve any VETOs
-3. Create tests for modified files
-4. Update documentation
-5. Pass all quality gates
-6. Get final validation approval
-7. Run domain-updater to update domains with session learnings
-8. Run commit-manager to commit changes (FINAL step)
-
-Resume the workflow to address these issues."""
-        }
-
-        print(json.dumps(output))
-        sys.exit(0)
-
-
-if __name__ == '__main__':
-    main()

package/template/.claude/hooks/validate-commit.py

@@ -1,200 +0,0 @@
-#!/usr/bin/env python3
-"""
-Husky Pre-Commit Hook - Workflow Validation
-
-This script is called by Husky before allowing a commit.
-It validates that:
-1. The workflow was properly executed
-2. All modified files were approved
-3. Tests were created for source files
-4. Documentation was updated
-5. Quality gates passed
-6. Final validation approved
-
-Exit codes:
-- 0: Allow commit
-- 1: Block commit with error message
-"""
-
-import json
-import sys
-import os
-import subprocess
-from pathlib import Path
-
-PROJECT_DIR = os.environ.get('CLAUDE_PROJECT_DIR', os.getcwd())
-WORKFLOW_STATE_PATH = Path(PROJECT_DIR) / '.claude' / 'workflow-state.json'
-
-
-def get_staged_files():
-    """Get list of staged files"""
-    try:
-        result = subprocess.run(
-            ['git', 'diff', '--cached', '--name-only'],
-            capture_output=True,
-            text=True,
-            check=True
-        )
-        return [f.strip() for f in result.stdout.strip().split('\n') if f.strip()]
-    except subprocess.CalledProcessError:
-        return []
-
-
-def load_workflow_state():
-    """Load current workflow state"""
-    if not WORKFLOW_STATE_PATH.exists():
-        return None
-    try:
-        with open(WORKFLOW_STATE_PATH) as f:
-            return json.load(f)
-    except (json.JSONDecodeError, IOError):
-        return None
-
-
-def validate_commit(state: dict, staged_files: list) -> tuple[bool, list[str]]:
-    """Validate that commit is allowed"""
-    errors = []
-
-    # Skip validation if no staged files
-    if not staged_files:
-        return True, []
-
-    # Skip if only workflow state files
-    non_workflow_files = [f for f in staged_files if '.claude/' not in f]
-    if not non_workflow_files:
-        return True, []
-
-    # Check workflow state exists
-    if not state:
-        errors.append("No workflow-state.json found - did you use the agent workflow?")
-        errors.append("Run the orchestrator agent to start a task before committing.")
-        return False, errors
-
-    task = state.get('currentTask')
-    if not task:
-        errors.append("No active task in workflow state")
-        errors.append("The agent workflow was not properly started")
-        return False, errors
-
-    # Check all staged files were in workflow
-    modified_in_workflow = [m['path'] for m in task.get('modifiedFiles', [])]
-    approved_files = task.get('approvedFiles', [])
-
-    for staged in staged_files:
-        # Skip workflow files
-        if '.claude/' in staged or staged.endswith('.md'):
-            continue
-
-        # Check if file was tracked
-        if staged not in modified_in_workflow:
-            # Check if matches approved pattern
-            matched = False
-            for approved in approved_files:
-                if approved.endswith('*') and staged.startswith(approved[:-1]):
-                    matched = True
-                    break
-                if staged.endswith(approved) or staged == approved:
-                    matched = True
-                    break
-
-            if not matched:
-                errors.append(f"File '{staged}' was not tracked in workflow")
-                errors.append("  This file was modified outside the agent workflow")
-
-    # Check agents executed
-    agents = task.get('agents', {})
-    task_type = task.get('type', 'feature')
-
-    # Required agents by task type
-    required = {
-        'feature': ['analyzer', 'tester', 'securityAuditor', 'qualityChecker', 'finalValidator'],
-        'fix': ['analyzer', 'tester', 'qualityChecker', 'finalValidator'],
-        'refactor': ['analyzer', 'qualityChecker', 'finalValidator'],
-        'config': ['qualityChecker'],
-    }
-
-    for agent in required.get(task_type, []):
-        agent_status = agents.get(agent, {})
-        if not agent_status.get('executed'):
-            errors.append(f"Required agent '{agent}' was not executed")
-        elif agent_status.get('result') == 'vetoed':
-            errors.append(f"Agent '{agent}' VETOED this task - resolve before committing")
-
-    # Check tests
-    if task_type in ['feature', 'fix']:
-        source_files = [f for f in staged_files if not any(
-            p in f.lower() for p in ['test', 'spec', '.md', 'docs/', '.json']
-        )]
-        tests_created = task.get('testsCreated', [])
-
-        if source_files and not tests_created:
-            errors.append(f"Modified {len(source_files)} source file(s) but no tests were created")
-            errors.append("  Run the tester agent to create tests")
-
-    # Check quality gates
-    quality = task.get('qualityGates', {})
-    for gate in ['typecheck', 'lint']:
-        gate_result = quality.get(gate, {})
-        if gate_result.get('passed') is False:
-            errors.append(f"Quality gate '{gate}' failed")
-
-    # Check security audit
-    security = task.get('securityAudit', {})
-    if security.get('result') == 'vetoed':
-        errors.append("Security audit VETOED - vulnerabilities must be fixed")
-
-    # Check final validation
-    final = task.get('finalValidation', {})
-    if not final.get('readyToCommit'):
-        if not final.get('executed'):
-            errors.append("Final validation was not executed")
-            errors.append("  Run the final-validator agent before committing")
-        else:
-            errors.append("Final validation did not approve commit")
-            violations = final.get('violations', [])
-            for v in violations[:5]:  # Show first 5
-                errors.append(f"  - {v}")
-
-    return len(errors) == 0, errors
-
-
-def main():
-    print("🔍 Validating workflow compliance...\n")
-
-    # Get staged files
-    staged_files = get_staged_files()
-
-    if not staged_files:
-        print("✅ No files staged for commit")
-        sys.exit(0)
-
-    # Load state
-    state = load_workflow_state()
-
-    # Validate
-    is_valid, errors = validate_commit(state, staged_files)
-
-    if is_valid:
-        print("✅ Workflow validation passed")
-        print(f"   {len(staged_files)} file(s) ready to commit")
-        sys.exit(0)
-    else:
-        print("❌ COMMIT BLOCKED - Workflow validation failed\n")
-        print("Errors found:")
-        for error in errors:
-            print(f"  {error}")
-
-        print("\n" + "=" * 50)
-        print("How to fix:")
-        print("1. Run the complete agent workflow (orchestrator → ... → final-validator)")
-        print("2. Ensure all agents executed and approved")
-        print("3. Create tests for new/modified code")
-        print("4. Pass all quality gates")
-        print("5. Get final validation approval")
-        print("=" * 50)
-
-        sys.exit(1)
-
-
-if __name__ == '__main__':
-    main()