start-command 0.30.0 → 0.30.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # start-command
 
+## 0.30.1
+
+### Patch Changes
+
+- 1a040d6: Use `docker stop` for detached Docker `--stop` control so containers follow Docker's graceful stop lifecycle instead of receiving a raw `SIGINT`.
+
 ## 0.30.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "start-command",
-  "version": "0.30.0",
+  "version": "0.30.1",
   "description": "Gamification of coding, execute any command with ability to auto-report issues on GitHub",
   "main": "src/bin/cli.js",
   "exports": {

package/src/lib/args-parser.js

@@ -30,7 +30,7 @@
  * --list                           List all tracked command executions
  * --upload-log <uuid-or-session>    Upload the stored log for a tracked execution
  * --output-format <format>         Output format for status/list (links-notation, json, text)
- * --stop <uuid-or-session-name>     Send CTRL+C/SIGINT to a detached execution
+ * --stop <uuid-or-session-name>     Ask a detached execution to stop gracefully
  * --terminate <uuid-or-session-name> Terminate a detached execution immediately
  * --cleanup                        Clean up stale "executing" records (processes that crashed or were killed)
  * --cleanup-dry-run                Show stale records that would be cleaned up (without actually cleaning)

package/src/lib/execution-control.js

@@ -197,9 +197,9 @@ function getControlCommand(record, action) {
       case 'docker':
         return {
           command: 'docker',
-          args: ['kill', '--signal=SIGINT', sessionName],
-          method: 'SIGINT',
-          message: `Sent SIGINT to detached docker container: ${sessionName}`,
+          args: ['stop', sessionName],
+          method: 'DOCKER_STOP',
+          message: `Requested graceful stop for detached docker container: ${sessionName}`,
         };
       default:
         return {

package/src/lib/usage.js

@@ -27,7 +27,7 @@ Options:
   --status <id>         Show status of execution by UUID or session name (--output-format: links-notation|json|text)
   --list                List all tracked executions (--output-format: links-notation|json|text)
   --upload-log <id>     Upload the stored log for an execution UUID or session name
-  --stop <id>           Send CTRL+C/SIGINT to a detached isolated execution
+  --stop <id>           Ask a detached isolated execution to stop gracefully
   --terminate <id>      Terminate a detached isolated execution immediately
   --cleanup             Clean up stale "executing" records (crashed/killed processes)
   --cleanup-dry-run     Show stale records that would be cleaned up (without cleaning)

package/test/execution-control.js

@@ -136,6 +136,46 @@ describe('execution control', () => {
     });
   });
 
+  it('should stop a detached docker container with docker stop', () => {
+    const store = createStore();
+    store.save(
+      createDetachedRecord({
+        uuid: 'docker-control-uuid',
+        options: {
+          isolated: 'docker',
+          isolationMode: 'detached',
+          sessionName: 'docker-session',
+          containerId: 'abc123',
+        },
+      })
+    );
+    const runner = createRunner({
+      'docker inspect -f {{.Id}} {{.State.Pid}} docker-session': {
+        success: true,
+        stdout: 'abcdef 0\n',
+        stderr: '',
+        status: 0,
+        error: null,
+      },
+    });
+
+    const result = controlExecution(
+      store,
+      'docker-control-uuid',
+      ControlAction.STOP,
+      runner
+    );
+
+    assert.strictEqual(result.success, true);
+    assert.match(result.output, /action stop/);
+    assert.match(result.output, /method DOCKER_STOP/);
+    assert.match(result.output, /containerId abcdef/);
+    assert.deepStrictEqual(runner.calls[0], {
+      command: 'docker',
+      args: ['stop', 'docker-session'],
+    });
+  });
+
   it('should send docker terminate through docker kill', () => {
     const store = createStore();
     store.save(