start-command 0.29.0 → 0.29.1

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # start-command
 
+## 0.29.1
+
+### Patch Changes
+
+- Fix detached docker `--status`/`--list` reporting a terminal status (`executed`) with the `-1` sentinel while the container is still running (or not visible yet on a slow Docker-in-Docker host). `isDetachedSessionAlive()` now treats a failed `docker inspect` as "unknown" (returns `null`) instead of "stopped", so a session whose container has not appeared yet stays `executing` rather than being marked finished. When a container has genuinely stopped, `enrichDetachedStatus()` resolves the real exit code from the `Exit Code:` log footer and then `docker inspect .State.ExitCode`, only falling back to `-1` when no real code can be obtained.
+
+  Fix `--status` for detached executions resurrecting a completed (killed) record. `enrichDetachedStatus()` no longer flips an already-`executed` record back to `executing` (and nulls its exit code) just because `screen -ls`/`tmux`/`docker` still lists a same-named session — a lingering shell can outlive a SIGKILLed command (e.g. OOM, exit 137). The recorded exit code and the `Exit Code:` log footer that `start` itself writes are now treated as authoritative; the record only flips to `executing` when there is no recorded exit code and no terminal footer in the log.
+
 ## 0.29.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "start-command",
-  "version": "0.29.0",
+  "version": "0.29.1",
   "description": "Gamification of coding, execute any command with ability to auto-report issues on GitHub",
   "main": "src/bin/cli.js",
   "exports": {

package/src/lib/status-formatter.js

@@ -7,7 +7,7 @@
  * - Text: Human-readable text format
  */
 
-const { execSync } = require('child_process');
+const { execSync, spawnSync } = require('child_process');
 const fs = require('fs');
 const {
   escapeForLinksNotation,
@@ -15,6 +15,58 @@ const {
 } = require('./output-blocks');
 const { collectProcessIds } = require('./execution-control');
 
+/**
+ * Inspect the live state of a detached docker container by name.
+ *
+ * Distinguishes three outcomes that matter for status reporting:
+ * - the container exists and is running,
+ * - the container exists but has stopped (with a real exit code), and
+ * - the container cannot be inspected at all.
+ *
+ * The last case is crucial on slow Docker-in-Docker hosts (issue #136): right
+ * after `docker run -d` returns, `docker inspect <name>` can transiently fail
+ * because the container is not visible yet. A failed inspect must NOT be read
+ * as "stopped"; it means "unknown", so callers can keep the session running
+ * instead of fabricating a terminal `-1` result.
+ *
+ * @param {string} sessionName - Container name
+ * @returns {{running: boolean, exitCode: number|null}|null} State, or null when
+ *   the container cannot be inspected (not found yet, removed, or docker error)
+ */
+function inspectDockerState(sessionName) {
+  const result = spawnSync(
+    'docker',
+    ['inspect', '-f', '{{.State.Running}} {{.State.ExitCode}}', sessionName],
+    { encoding: 'utf8', stdio: ['pipe', 'pipe', 'pipe'] }
+  );
+  if (result.error || result.status !== 0 || !result.stdout) {
+    return null;
+  }
+  const [runningRaw, exitRaw] = result.stdout.trim().split(/\s+/);
+  const exitCode = Number.parseInt(exitRaw, 10);
+  return {
+    running: runningRaw === 'true',
+    exitCode: Number.isFinite(exitCode) ? exitCode : null,
+  };
+}
+
+/**
+ * Best-effort terminal exit code reported by the isolation backend itself
+ * (currently docker via `docker inspect .State.ExitCode`). Returns null when
+ * the backend cannot provide a real code, so callers never surface the `-1`
+ * sentinel for a session whose real exit code is simply not available yet.
+ * @param {Object} record - Execution record
+ * @returns {number|null}
+ */
+function readBackendExitCode(record) {
+  const opts = record.options || {};
+  if (opts.isolated !== 'docker' || !opts.sessionName) {
+    return null;
+  }
+  const state = inspectDockerState(opts.sessionName);
+  return state && !state.running ? state.exitCode : null;
+}
+
 /**
  * Check if a detached isolation session is still running
  * @param {Object} record - Execution record
@@ -46,11 +98,11 @@ function isDetachedSessionAlive(record) {
         return true;
       }
       case 'docker': {
-        const output = execSync(
-          `docker inspect -f "{{.State.Running}}" ${sessionName}`,
-          { encoding: 'utf8', stdio: ['pipe', 'pipe', 'pipe'] }
-        );
-        return output.trim() === 'true';
+        // A failed inspect means the container is not visible yet (still being
+        // created on a slow DinD host) or already removed — not "stopped".
+        // Return null (unknown) so the session is not falsely marked finished.
+        const state = inspectDockerState(sessionName);
+        return state === null ? null : state.running;
       }
       case 'ssh': {
         // For SSH, check if the PID is still running on remote would require
@@ -100,24 +152,62 @@ function readExitCodeFromLog(logPath) {
  */
 function enrichDetachedStatus(record) {
   const alive = isDetachedSessionAlive(record);
+  const footerExit = readExitCodeFromLog(record.logPath);
+
+  // Create a shallow copy to avoid mutating the original
+  const cloneRecord = () => {
+    const enriched = Object.create(Object.getPrototypeOf(record));
+    Object.assign(enriched, record);
+    return enriched;
+  };
+
   if (alive === null) {
+    // Liveness is unknown: the backend could not be probed (e.g. a detached
+    // docker container that is not visible yet on a slow Docker-in-Docker host,
+    // or one that has already been removed). Honor a terminal `Exit Code:`
+    // footer if the command wrote one; otherwise leave the record untouched
+    // (still executing) rather than fabricating a `-1` terminal result that
+    // orchestrators misread as a finished/failed run (issue #136).
+    const isDetached =
+      record.options && record.options.isolationMode === 'detached';
+    if (isDetached && record.status === 'executing' && footerExit !== null) {
+      const enriched = cloneRecord();
+      enriched.status = 'executed';
+      enriched.exitCode = footerExit;
+      if (!enriched.endTime) {
+        enriched.endTime = new Date().toISOString();
+      }
+      return enriched;
+    }
     return record;
   }
 
-  // Create a shallow copy to avoid mutating the original
-  const enriched = Object.create(Object.getPrototypeOf(record));
-  Object.assign(enriched, record);
+  const enriched = cloneRecord();
 
   if (alive && enriched.status === 'executed') {
-    // Session still running but record says executed - correct it
-    enriched.status = 'executing';
-    enriched.exitCode = null;
-    enriched.endTime = null;
+    // A live `screen -ls` (or `tmux`/`docker`) session does NOT mean the command
+    // is still running: a lingering shell can outlive a killed command (e.g. the
+    // OOM killer sends SIGKILL, exit 137, but the login shell stays up for a
+    // window after `start` already wrote the terminal footer). The footer/recorded
+    // exit code is authoritative. Only flip back to 'executing' when there is NO
+    // recorded terminal exit code AND no `Exit Code:` footer in the log.
+    const hasRecordedExit =
+      enriched.exitCode !== null && enriched.exitCode !== undefined;
+    if (!hasRecordedExit && footerExit === null) {
+      // Session still running and no terminal record - correct it
+      enriched.status = 'executing';
+      enriched.exitCode = null;
+      enriched.endTime = null;
+    }
+    // Otherwise keep the recorded/footer exit code - the command has finished.
   } else if (!alive && enriched.status === 'executing') {
-    // Session ended but record says executing - correct it
+    // Session ended but record says executing - correct it. Resolve a real exit
+    // code: prefer the log footer, then the backend's own record (e.g.
+    // `docker inspect .State.ExitCode`), and only fall back to the `-1` sentinel
+    // as a last resort when no real code can be obtained (issue #136).
     enriched.status = 'executed';
     if (enriched.exitCode === null || enriched.exitCode === undefined) {
-      enriched.exitCode = readExitCodeFromLog(enriched.logPath) ?? -1;
+      enriched.exitCode = footerExit ?? readBackendExitCode(enriched) ?? -1;
     }
     if (!enriched.endTime) {
       enriched.endTime = new Date().toISOString();

package/test/session-name-status.js

@@ -306,6 +306,249 @@ describe('Issue #101: Detached status enrichment', () => {
         expect(enriched.endTime).not.toBeNull();
       }
     });
+
+    // Issue #134: a lingering screen session must NOT resurrect a completed
+    // (killed, exit 137) record back to 'executing' / null exit code.
+    describe('Issue #134: completed record with a lingering live session', () => {
+      const screenAvailable = (() => {
+        const probe = spawnSync('screen', ['-v'], { encoding: 'utf8' });
+        return probe.status === 0 || /Screen version/.test(probe.stdout || '');
+      })();
+
+      let sessionName;
+      let logPath;
+
+      beforeEach(() => {
+        if (!screenAvailable) {
+          return;
+        }
+        sessionName = `enrich-134-${process.pid}-${Date.now()}`;
+        logPath = path.join(TEST_APP_FOLDER, `${sessionName}.log`);
+        if (!fs.existsSync(TEST_APP_FOLDER)) {
+          fs.mkdirSync(TEST_APP_FOLDER, { recursive: true });
+        }
+        // Footer exactly as `start` writes it for a SIGKILLed command.
+        fs.writeFileSync(
+          logPath,
+          `Killed\n\n${'='.repeat(50)}\nFinished: 2026-06-14 19:10:49.822\nExit Code: 137\n`
+        );
+        // A shell that outlives the (already-finished) command.
+        spawnSync('screen', ['-dmS', sessionName, 'sh', '-c', 'sleep 30'], {
+          encoding: 'utf8',
+        });
+      });
+
+      afterEach(() => {
+        if (!screenAvailable) {
+          return;
+        }
+        spawnSync('screen', ['-S', sessionName, '-X', 'quit'], {
+          stdio: 'ignore',
+        });
+        if (logPath && fs.existsSync(logPath)) {
+          fs.unlinkSync(logPath);
+        }
+      });
+
+      it('keeps the recorded exit code when the session is still listed', () => {
+        if (!screenAvailable) {
+          return;
+        }
+        const record = new ExecutionRecord({
+          command: 'sleep 60',
+          logPath,
+          options: {
+            sessionName,
+            isolated: 'screen',
+            isolationMode: 'detached',
+          },
+        });
+        record.complete(137);
+
+        // Sanity: the session must actually be alive for this test to be meaningful.
+        expect(isDetachedSessionAlive(record)).toBe(true);
+
+        const enriched = enrichDetachedStatus(record);
+        expect(enriched.status).toBe('executed');
+        expect(enriched.exitCode).toBe(137);
+        expect(enriched.endTime).not.toBeNull();
+      });
+
+      it('honors the log footer exit code even without a recorded exit code', () => {
+        if (!screenAvailable) {
+          return;
+        }
+        const record = new ExecutionRecord({
+          command: 'sleep 60',
+          logPath,
+          options: {
+            sessionName,
+            isolated: 'screen',
+            isolationMode: 'detached',
+          },
+        });
+        // Record was never reconciled: status 'executed' but exitCode still null.
+        record.status = 'executed';
+        record.exitCode = null;
+        record.endTime = null;
+
+        expect(isDetachedSessionAlive(record)).toBe(true);
+
+        const enriched = enrichDetachedStatus(record);
+        // Footer says 137, so it must stay finished, not flip to executing.
+        expect(enriched.status).toBe('executed');
+      });
+
+      it('flips to executing only when there is no terminal record at all', () => {
+        if (!screenAvailable) {
+          return;
+        }
+        // Log with NO Exit Code footer and no recorded exit code.
+        fs.writeFileSync(logPath, 'still running, no footer yet\n');
+        const record = new ExecutionRecord({
+          command: 'sleep 60',
+          logPath,
+          options: {
+            sessionName,
+            isolated: 'screen',
+            isolationMode: 'detached',
+          },
+        });
+        record.status = 'executed';
+        record.exitCode = null;
+        record.endTime = null;
+
+        expect(isDetachedSessionAlive(record)).toBe(true);
+
+        const enriched = enrichDetachedStatus(record);
+        expect(enriched.status).toBe('executing');
+        expect(enriched.exitCode).toBeNull();
+        expect(enriched.endTime).toBeNull();
+      });
+    });
+  });
+});
+
+// Issue #136: a detached docker session must not be reported with a terminal
+// status (`executed`) and the `-1` sentinel while its container is still
+// running (or not visible yet on a slow Docker-in-Docker host).
+describe('Issue #136: detached docker session liveness', () => {
+  // Use the repo's own probe: `docker` may be installed yet unable to run Linux
+  // images (e.g. Windows runners in Windows-containers mode, where `alpine`
+  // never starts). In that case `docker inspect` fails and liveness is `null`
+  // (unknown) rather than `false`, which would break the stopped-container
+  // assertions below.
+  const { canRunLinuxDockerImages } = require('../src/lib/isolation');
+  const dockerAvailable = canRunLinuxDockerImages();
+
+  // Whether the container actually exists (was created) per `docker inspect`.
+  function dockerContainerExists(name) {
+    const probe = spawnSync('docker', ['inspect', name], { stdio: 'ignore' });
+    return probe.status === 0;
+  }
+
+  function makeDockerRecord(sessionName, extra = {}) {
+    return new ExecutionRecord({
+      command: 'sleep 120; echo done',
+      options: {
+        sessionName,
+        isolated: 'docker',
+        isolationMode: 'detached',
+      },
+      ...extra,
+    });
+  }
+
+  function dockerRm(name) {
+    spawnSync('docker', ['rm', '-f', name], { stdio: 'ignore' });
+  }
+
+  it('reports unknown (null) — not false — when the container is not visible yet', () => {
+    if (!dockerAvailable) {
+      return;
+    }
+    const record = makeDockerRecord('issue136-container-does-not-exist-yet');
+    expect(isDetachedSessionAlive(record)).toBeNull();
+  });
+
+  it('keeps the record executing while the container is not visible yet', () => {
+    if (!dockerAvailable) {
+      return;
+    }
+    const record = makeDockerRecord('issue136-container-not-visible');
+    // Defaults to executing with a null exit code.
+    const enriched = enrichDetachedStatus(record);
+    expect(enriched.status).toBe('executing');
+    expect(enriched.exitCode).toBeNull();
+    expect(enriched.endTime).toBeNull();
+  });
+
+  it('keeps a running container executing', () => {
+    if (!dockerAvailable) {
+      return;
+    }
+    const name = `issue136-running-${process.pid}`;
+    dockerRm(name);
+    const started = spawnSync('docker', [
+      'run',
+      '-d',
+      '--name',
+      name,
+      'alpine',
+      'sh',
+      '-c',
+      'sleep 30',
+    ]);
+    if (started.status !== 0) {
+      dockerRm(name);
+      return;
+    }
+    try {
+      const record = makeDockerRecord(name);
+      expect(isDetachedSessionAlive(record)).toBe(true);
+      const enriched = enrichDetachedStatus(record);
+      expect(enriched.status).toBe('executing');
+      expect(enriched.exitCode).toBeNull();
+    } finally {
+      dockerRm(name);
+    }
+  });
+
+  it('resolves a stopped container to its real exit code, never the -1 sentinel', () => {
+    if (!dockerAvailable) {
+      return;
+    }
+    const name = `issue136-stopped-${process.pid}`;
+    dockerRm(name);
+    const ran = spawnSync('docker', [
+      'run',
+      '--name',
+      name,
+      'alpine',
+      'sh',
+      '-c',
+      'exit 1',
+    ]);
+    // `docker run` exits with the container's code (1 here); treat spawn errors
+    // (no daemon) or a container that never materialized (e.g. the Linux image
+    // could not be pulled) as a skip — there is nothing stopped to inspect.
+    if (ran.error || !dockerContainerExists(name)) {
+      dockerRm(name);
+      return;
+    }
+    try {
+      // No log footer: force exit-code resolution through `docker inspect`.
+      const record = makeDockerRecord(name, {
+        logPath: '/nonexistent-issue136.log',
+      });
+      expect(isDetachedSessionAlive(record)).toBe(false);
+      const enriched = enrichDetachedStatus(record);
+      expect(enriched.status).toBe('executed');
+      expect(enriched.exitCode).toBe(1);
+      expect(enriched.endTime).not.toBeNull();
+    } finally {
+      dockerRm(name);
+    }
   });
 });